From unknown Tue Jun 24 20:50:58 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#27844 <27844@debbugs.gnu.org> To: bug#27844 <27844@debbugs.gnu.org> Subject: Status: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name Reply-To: bug#27844 <27844@debbugs.gnu.org> Date: Wed, 25 Jun 2025 03:50:58 +0000 retitle 27844 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file= name reassign 27844 emacs submitter 27844 Tino Calancha severity 27844 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 26 23:27:21 2017 Received: (at submit) by debbugs.gnu.org; 27 Jul 2017 03:27:21 +0000 Received: from localhost ([127.0.0.1]:57827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daZSK-0002xc-NO for submit@debbugs.gnu.org; Wed, 26 Jul 2017 23:27:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57533) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daZSI-0002xL-VY for submit@debbugs.gnu.org; Wed, 26 Jul 2017 23:27:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daZSB-0006RW-UU for submit@debbugs.gnu.org; Wed, 26 Jul 2017 23:27:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57322) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1daZSB-0006RL-RJ for submit@debbugs.gnu.org; Wed, 26 Jul 2017 23:27:11 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48504) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daZSA-0003nT-Cf for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 23:27:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daZS9-0006QY-63 for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 23:27:10 -0400 Received: from mail-pf0-x235.google.com ([2607:f8b0:400e:c00::235]:33195) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1daZS9-0006QD-04 for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 23:27:09 -0400 Received: by mail-pf0-x235.google.com with SMTP id d67so10329149pfc.0 for ; Wed, 26 Jul 2017 20:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=RIPmb75OlHG2F5e33ltdfymE25R/yYijbqOknsJlZAo=; b=Q1JdkkkRXhxylupIOCCsok5kdGFN9Onp7h16xLBnZdIQhBqI4HiHr2UMq5f7aFJ7q7 v8iiKy6HO5J3h1HJWWBGtVlhYR5i3X5vUgJKT4DhxE6PuW93T29K3WTfMbeEzrNS7oD5 di6pH0lDB8HWKGPsiiDEVpiQOj1eA0i9DMpTxSVlpTGKgPJcjH4bqmZ3lal3+4k2QTRr 7+7GfFm1WgfKJPGvB1ziUAJE+dNhex6PUx45O/A+k1d6hsLm0++/HVGmkI+2Vimgfu7R 6To0cmLKU8EKovdzoYOcyCEFfhtDTqQ+/DJ1C9hH0VSNzA4ExJvquyJz19Wsji/vKmnf EjXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=RIPmb75OlHG2F5e33ltdfymE25R/yYijbqOknsJlZAo=; b=dSIZ4jtjMjOVSKdL6qMwOBTpMLxmV1xsVvMeZwLoV8DodgvpQDEFGh9p7y0vSVils5 YQbIF/gJDfAdpWCtLDApvr3fSlS4LOOI6bsTZ7eq1aoMhRVnYKFVI7edt5U+KUSxb+4C HvGvpVAXidTzHLdJLr8Q5VOJbMjiWxYvX9jpDRQsgeXl+2rYot0W4kOQXuwiuDpATzIH JL5luMFxCsJ5S3R62R4An3z4GQS/Hwm34z+9CqhD4UeJA6ykwg3kXLB9cVCpAHRAx21X KSyGXXQbhosfvfKjntzTZh9Mnul/FMG9R6AK2nUCDbLTzZzr1Ga9h60jEwKA6sVPJ3tO hPnQ== X-Gm-Message-State: AIVw11180/gSG0MAMd3RKsA6IS1fTVWIY90b5vPXfpmWk3on4ou8Jv8t K6Yaso0liaQuNQDi X-Received: by 10.98.23.69 with SMTP id 66mr2789904pfx.305.1501126027685; Wed, 26 Jul 2017 20:27:07 -0700 (PDT) Received: from calancha-pc ([240f:6e:fb29:1:9ee6:2511:da80:1c7e]) by smtp.gmail.com with ESMTPSA id k185sm32711547pgc.31.2017.07.26.20.27.06 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Jul 2017 20:27:07 -0700 (PDT) From: Tino Calancha To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name Date: Thu, 27 Jul 2017 12:27:05 +0900 Message-ID: <878tjasgom.fsf@calancha-pc> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Dired with eshell-ls doesn't handle wildcards in file names. emacs -Q -l em-ls -eval "(customize-set-variable 'eshell-ls-use-in-dired t)" I) M-: (dired source-directory) RET C-x d lisp/*.el RET II) ;; Following works but it shows full file name, instead of the ;; more common relative file name. C-x d lisp/simple.el RET --8<-----------------------------cut here---------------start------------->8--- commit 8826109f3b619b59b7d68afa55e446e0c487ca76 Author: Tino Calancha Date: Thu Jul 27 12:21:15 2017 +0900 Dired w/ eshell-ls: Handle shell wildcards in file name * lisp/eshell/em-ls.el (eshell-ls--insert-directory): Use eshell-extended-glob (Bug#27844). * test/lisp/dired-tests.el (dired-test-bug27844): Add test. diff --git a/lisp/eshell/em-ls.el b/lisp/eshell/em-ls.el index 79799db30b..48f3874bf7 100644 --- a/lisp/eshell/em-ls.el +++ b/lisp/eshell/em-ls.el @@ -241,6 +241,8 @@ dired-flag ;;; Functions: +(declare-function eshell-extended-glob "em-glob" (glob)) + (defun eshell-ls--insert-directory (orig-fun file switches &optional wildcard full-directory-p) "Insert directory listing for FILE, formatted according to SWITCHES. @@ -273,11 +275,18 @@ eshell-ls--insert-directory (set 'font-lock-buffers (delq (current-buffer) (symbol-value 'font-lock-buffers))))) + (require 'em-glob) (let ((insert-func 'insert) (error-func 'insert) (flush-func 'ignore) + (target ; Expand the shell wildcards if any. + (if (and (atom file) + (string-match "[[?*]" file) + (not (file-exists-p file))) + (mapcar #'file-relative-name (eshell-extended-glob file)) + (file-relative-name file))) eshell-ls-dired-initial-args) - (eshell-do-ls (append switches (list file))))))))) + (eshell-do-ls (append switches (list target))))))))) (defsubst eshell/ls (&rest args) "An alias version of `eshell-do-ls'." diff --git a/test/lisp/dired-tests.el b/test/lisp/dired-tests.el index 601d65768b..16086b97a9 100644 --- a/test/lisp/dired-tests.el +++ b/test/lisp/dired-tests.el @@ -188,5 +188,24 @@ (customize-set-variable 'eshell-ls-use-in-dired orig) (and (buffer-live-p buf) (kill-buffer))))) + +(ert-deftest dired-test-bug27844 () + "Test for http://debbugs.gnu.org/27844 ." + (require 'em-ls) + (let ((orig eshell-ls-use-in-dired) + (dired-use-ls-dired 'unspecified) + buf insert-directory-program) + (unwind-protect + (progn + (customize-set-variable 'eshell-ls-use-in-dired t) + (setq buf (dired (expand-file-name "lisp/*.el" source-directory))) + (dired-toggle-marks) + (should (cdr (dired-get-marked-files))) + (kill-buffer buf) + (setq buf (dired (expand-file-name "lisp/subr.el" source-directory))) + (should (looking-at "subr\\.el"))) + (customize-set-variable 'eshell-ls-use-in-dired orig) + (and (buffer-live-p buf) (kill-buffer))))) + (provide 'dired-tests) ;; dired-tests.el ends here --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-07-26 Repository revision: e1e8d2e229f48b3cee765f7cf27ae04ee4401d85 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 27 05:23:24 2017 Received: (at 27844) by debbugs.gnu.org; 27 Jul 2017 09:23:24 +0000 Received: from localhost ([127.0.0.1]:57901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daf0t-0002uH-V1 for submit@debbugs.gnu.org; Thu, 27 Jul 2017 05:23:24 -0400 Received: from mail-pf0-f176.google.com ([209.85.192.176]:34766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daf0s-0002u2-KI for 27844@debbugs.gnu.org; Thu, 27 Jul 2017 05:23:23 -0400 Received: by mail-pf0-f176.google.com with SMTP id q85so81491418pfq.1 for <27844@debbugs.gnu.org>; Thu, 27 Jul 2017 02:23:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=wxpNF5JtOkAdxS84TT3I1iaKQ0OwX4b1lzlgE+RduUM=; b=P6dqDrq5h3eDYMViwXbJnJrK15sCji6GhzvYdNXFBYGXdxdyeHAyNKqHfaPNkChqFR ox6VReoZbjaKe2fIeuCXlXihb7Ksil4GPb4GfZFXAtY6V47NEU97eMDrYsJuxGDke0Pe 6boHPU2OnlYBtdubyRyCpWKWWoG7i95s9qP0cMQgCtOknduOhRw3H11aL/kQEtf2gwK0 /Nn36TiStwehT56gGYKAmkSbWxvp+v9ootLUeHBjuoUtlwyTKToKPbEdNW1TxrCaQYMh +C8Q9seLBfbt5VpCwKr9Y/TAlAdId9RcspKt70SzlwiWvN697B1zCcIuEKBGzD5x7OnN 5wyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=wxpNF5JtOkAdxS84TT3I1iaKQ0OwX4b1lzlgE+RduUM=; b=gTkmeWhsPHeYxeM+yx9Bv2nXwJtn7XQwCsiyZkILkv8BjDSpB2bQZEeaS6vA1EKqn+ xCUaWoeyjgDizqLA9DOTwcW8z/tPhGZIGy1s0ymgjki4BUNwtbQ7jtuYSDjH6dXOiDFt Ci8RqQPUyf/nN0FaxbJUax29BtmVz8EIWmMST4qKCYUFlwGIVtdeZigwIhYSvX3ngqzB 0CZQsg7PpvmEd1TCBi1TmAyWvQeWVRLbqxa3nbSnNZm6m0SbUfDEu0pfNhVKu0cIBlMP PAQ3QNSeAu8l8g4sqYti1kY2SHeCuwRdmRDLUosrqQCuYetewWaBO6vBRMNJdGli530G fTmQ== X-Gm-Message-State: AIVw112V+QG1I8ns709890me0kT/UxRsQQZALL6J/lTOq2nDdL3BOBxO mcFeEw7ePO/eiKhb X-Received: by 10.84.128.4 with SMTP id 4mr92939pla.184.1501147396017; Thu, 27 Jul 2017 02:23:16 -0700 (PDT) Received: from calancha-pc ([240f:6e:fb29:1:9ee6:2511:da80:1c7e]) by smtp.gmail.com with ESMTPSA id y22sm34897695pfi.159.2017.07.27.02.23.13 for <27844@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Jul 2017 02:23:15 -0700 (PDT) From: Tino Calancha To: 27844@debbugs.gnu.org Subject: Re: bug#27844: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name References: <878tjasgom.fsf@calancha-pc> Date: Thu, 27 Jul 2017 18:23:08 +0900 In-Reply-To: <878tjasgom.fsf@calancha-pc> (Tino Calancha's message of "Thu, 27 Jul 2017 12:27:05 +0900") Message-ID: <87h8xyutc3.fsf@calancha-pc> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 27844 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Tino Calancha writes: > Dired with eshell-ls doesn't handle wildcards in file names. > > ;;; Functions: > > +(declare-function eshell-extended-glob "em-glob" (glob)) > + > (defun eshell-ls--insert-directory > (orig-fun file switches &optional wildcard full-directory-p) > "Insert directory listing for FILE, formatted according to SWITCHES. > @@ -273,11 +275,18 @@ eshell-ls--insert-directory > (set 'font-lock-buffers > (delq (current-buffer) > (symbol-value 'font-lock-buffers))))) > + (require 'em-glob) > (let ((insert-func 'insert) > (error-func 'insert) > (flush-func 'ignore) > + (target ; Expand the shell wildcards if any. > + (if (and (atom file) > + (string-match "[[?*]" file) > + (not (file-exists-p file))) > + (mapcar #'file-relative-name (eshell-extended-glob file)) > + (file-relative-name file))) > eshell-ls-dired-initial-args) `eshell-extended-glob' returns a list of matches on success, otherwise it returns FILE; if no match i think we should signal an error. --8<-----------------------------cut here---------------start------------->8--- commit 22f4516a6081c57363790694a11e5f9fe3f84c70 Author: Tino Calancha Date: Thu Jul 27 18:08:17 2017 +0900 Dired w/ eshell-ls: Handle shell wildcards in file name * lisp/eshell/em-ls.el (eshell-ls--insert-directory): Use eshell-extended-glob (Bug#27844). * test/lisp/dired-tests.el (dired-test-bug27844): Add test. diff --git a/lisp/eshell/em-ls.el b/lisp/eshell/em-ls.el index 79799db30b..2e0b16db75 100644 --- a/lisp/eshell/em-ls.el +++ b/lisp/eshell/em-ls.el @@ -241,6 +241,8 @@ dired-flag ;;; Functions: +(declare-function eshell-extended-glob "em-glob" (glob)) + (defun eshell-ls--insert-directory (orig-fun file switches &optional wildcard full-directory-p) "Insert directory listing for FILE, formatted according to SWITCHES. @@ -273,11 +275,21 @@ eshell-ls--insert-directory (set 'font-lock-buffers (delq (current-buffer) (symbol-value 'font-lock-buffers))))) + (require 'em-glob) (let ((insert-func 'insert) (error-func 'insert) (flush-func 'ignore) + (target ; Expand the shell wildcards if any. + (if (and (atom file) + (string-match "[[?*]" file) + (not (file-exists-p file))) + (let ((matches (eshell-extended-glob file))) + (if (consp matches) + (mapcar #'file-relative-name matches) + (user-error (format "%s: No files matching wildcard" file)))) + (file-relative-name file))) eshell-ls-dired-initial-args) - (eshell-do-ls (append switches (list file))))))))) + (eshell-do-ls (append switches (list target))))))))) (defsubst eshell/ls (&rest args) "An alias version of `eshell-do-ls'." --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-07-27 Repository revision: 28faa94f1c423091bb34c2776eabe9ae83e5b4fc From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 29 05:05:21 2017 Received: (at 27844) by debbugs.gnu.org; 29 Jul 2017 09:05:21 +0000 Received: from localhost ([127.0.0.1]:60575 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbNgW-0000qq-P0 for submit@debbugs.gnu.org; Sat, 29 Jul 2017 05:05:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44213) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbNgV-0000qd-7T for 27844@debbugs.gnu.org; Sat, 29 Jul 2017 05:05:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbNgO-0000Od-OW for 27844@debbugs.gnu.org; Sat, 29 Jul 2017 05:05:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55498) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbNgO-0000OV-Lr; Sat, 29 Jul 2017 05:05:12 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4219 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dbNgN-0000dV-RV; Sat, 29 Jul 2017 05:05:12 -0400 Date: Sat, 29 Jul 2017 12:05:03 +0300 Message-Id: <83k22r396o.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: <878tjasgom.fsf@calancha-pc> (message from Tino Calancha on Thu, 27 Jul 2017 12:27:05 +0900) Subject: Re: bug#27844: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name References: <878tjasgom.fsf@calancha-pc> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27844 Cc: 27844@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Date: Thu, 27 Jul 2017 12:27:05 +0900 > > > Dired with eshell-ls doesn't handle wildcards in file names. > emacs -Q -l em-ls -eval "(customize-set-variable 'eshell-ls-use-in-dired t)" > > I) > M-: (dired source-directory) RET > C-x d lisp/*.el RET > > II) > ;; Following works but it shows full file name, instead of the > ;; more common relative file name. > C-x d lisp/simple.el RET > > --8<-----------------------------cut here---------------start------------->8--- > commit 8826109f3b619b59b7d68afa55e446e0c487ca76 > Author: Tino Calancha > Date: Thu Jul 27 12:21:15 2017 +0900 > > Dired w/ eshell-ls: Handle shell wildcards in file name > > * lisp/eshell/em-ls.el (eshell-ls--insert-directory): > Use eshell-extended-glob (Bug#27844). > * test/lisp/dired-tests.el (dired-test-bug27844): Add test. LGTM, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 29 05:07:11 2017 Received: (at 27844) by debbugs.gnu.org; 29 Jul 2017 09:07:11 +0000 Received: from localhost ([127.0.0.1]:60579 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbNiJ-0000tZ-4f for submit@debbugs.gnu.org; Sat, 29 Jul 2017 05:07:11 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbNiH-0000tM-RU for 27844@debbugs.gnu.org; Sat, 29 Jul 2017 05:07:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbNi9-00021O-LB for 27844@debbugs.gnu.org; Sat, 29 Jul 2017 05:07:04 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55596) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbNi9-00021H-Hl; Sat, 29 Jul 2017 05:07:01 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4222 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dbNi8-0002Pn-OD; Sat, 29 Jul 2017 05:07:01 -0400 Date: Sat, 29 Jul 2017 12:06:52 +0300 Message-Id: <83inib393n.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: <87h8xyutc3.fsf@calancha-pc> (message from Tino Calancha on Thu, 27 Jul 2017 18:23:08 +0900) Subject: Re: bug#27844: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name References: <878tjasgom.fsf@calancha-pc> <87h8xyutc3.fsf@calancha-pc> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27844 Cc: 27844@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Date: Thu, 27 Jul 2017 18:23:08 +0900 > > `eshell-extended-glob' returns a list of matches on success, otherwise > it returns FILE; if no match i think we should signal an error. Whether this should be an error or just FILE is a matter of personal preferences, I think. Some shells behave this way, others the other way. So either we should leave your original patch as it was, or introduce a defcustom to produce an error if the user so wants. WDYT? From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 31 23:00:52 2017 Received: (at 27844) by debbugs.gnu.org; 1 Aug 2017 03:00:52 +0000 Received: from localhost ([127.0.0.1]:35955 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcNQS-0005sa-C6 for submit@debbugs.gnu.org; Mon, 31 Jul 2017 23:00:52 -0400 Received: from mail-pf0-f173.google.com ([209.85.192.173]:33104) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcNQQ-0005sN-V7 for 27844@debbugs.gnu.org; Mon, 31 Jul 2017 23:00:51 -0400 Received: by mail-pf0-f173.google.com with SMTP id d67so2121634pfc.0 for <27844@debbugs.gnu.org>; Mon, 31 Jul 2017 20:00:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=ikWjAy3DCJDIfmUL6s3HFuTZCODxSdsqgnZ04ByN1VM=; b=QUiAr6ZDJ6aPv2m8s9TF/HShpG1YWBZx8sDh3HTkV9pYuT0eqcsXrgCRL5b+f1dcpt HnrFGg1U4gFbVwsDQEQRsp/1DlZXG+IvQgJWQnFkxIDL/+0gQyl05X3wp4k9UW6qDa6k Zrk0SqaFI4QP/DYiEnQFi7VbjKrs5uXt9+l9meEAWKHRCiAANrHoMvTDi02DbNBIIem/ U8IiEtI9g6e8Qr4dJGn8VG4TFY4HPxi17x+C62Se4TNKWe9m46qy7PpbASoZbDBvpzJ0 mNC0SqHCBFVMU8TlqQflkI+w/wGuq34brW1hTZc1U13y3Xb5eG0jkHLoqNZgux0mp2Ti oZtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=ikWjAy3DCJDIfmUL6s3HFuTZCODxSdsqgnZ04ByN1VM=; b=oDZkk/IZewKhsyD4AMGwim5jomGrLXw7b5Z3A/gLD5wmcoIMERwcPjWR77GY9wbyzW PsYDJLOn/bOhCU2OrDw55A9OqYs/s3aBDb7c3yxzBY/4KBtdbqgpm3IVhDn2Z6zuOcbx 7KtcTdqFeyyg3UopFurtS5n42Oo96fzohK0B+ulrmvX8PX7yyZrp5r6Vp7rWWxFSixik 1zNIeuKeW6vLXttplpjuL/kjYZQtrSQ/NWXtkLDgUJflI66EfJqOqB0xF1A9mdf4rRoc SuY0SMGgEOj9NnCcJNQ6fHsYBIPjxtk+6nqJoUIQ/TNbIvPmm00AJI0KGnjsZZHuE11B ddBg== X-Gm-Message-State: AIVw1101GaoGZBXIjq72V5bWyQJrFJTIjofpcCV8JgCLLiQhlVq6q8Te 5o7YN8w518ejP5Oz X-Received: by 10.98.89.22 with SMTP id n22mr17706191pfb.326.1501556444352; Mon, 31 Jul 2017 20:00:44 -0700 (PDT) Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id d127sm51273132pfa.171.2017.07.31.20.00.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 31 Jul 2017 20:00:43 -0700 (PDT) From: Tino Calancha To: Eli Zaretskii Subject: Re: bug#27844: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name References: <878tjasgom.fsf@calancha-pc> <87h8xyutc3.fsf@calancha-pc> <83inib393n.fsf@gnu.org> Date: Tue, 01 Aug 2017 12:00:39 +0900 In-Reply-To: <83inib393n.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Jul 2017 12:06:52 +0300") Message-ID: <87lgn4j8ko.fsf@calancha-pc> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 27844 Cc: 27844@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Eli Zaretskii writes: >> From: Tino Calancha >> Date: Thu, 27 Jul 2017 18:23:08 +0900 >> >> `eshell-extended-glob' returns a list of matches on success, otherwise >> it returns FILE; if no match i think we should signal an error. > > Whether this should be an error or just FILE is a matter of personal > preferences, I think. Some shells behave this way, others the other > way. So either we should leave your original patch as it was, or > introduce a defcustom to produce an error if the user so wants. Indeed such defcustom already does exist: eshell-error-if-no-glob (default to nil). You can see at the end of `eshell-extended-glob': (if eshell-error-if-no-glob (error "No matches found: %s" glob) glob) John designed this package very well. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 01 09:40:22 2017 Received: (at 27844) by debbugs.gnu.org; 1 Aug 2017 13:40:22 +0000 Received: from localhost ([127.0.0.1]:36265 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcXPK-0005ly-7n for submit@debbugs.gnu.org; Tue, 01 Aug 2017 09:40:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36645) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcXPG-0005lh-8R for 27844@debbugs.gnu.org; Tue, 01 Aug 2017 09:40:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcXP7-0006mi-Qc for 27844@debbugs.gnu.org; Tue, 01 Aug 2017 09:40:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55330) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcXP7-0006mK-ND; Tue, 01 Aug 2017 09:40:09 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4660 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dcXP6-0003mO-OG; Tue, 01 Aug 2017 09:40:09 -0400 Date: Tue, 01 Aug 2017 16:40:02 +0300 Message-Id: <8360e71k5p.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: <87lgn4j8ko.fsf@calancha-pc> (message from Tino Calancha on Tue, 01 Aug 2017 12:00:39 +0900) Subject: Re: bug#27844: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name References: <878tjasgom.fsf@calancha-pc> <87h8xyutc3.fsf@calancha-pc> <83inib393n.fsf@gnu.org> <87lgn4j8ko.fsf@calancha-pc> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27844 Cc: 27844@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Cc: 27844@debbugs.gnu.org > Date: Tue, 01 Aug 2017 12:00:39 +0900 > > Eli Zaretskii writes: > > >> From: Tino Calancha > >> Date: Thu, 27 Jul 2017 18:23:08 +0900 > >> > >> `eshell-extended-glob' returns a list of matches on success, otherwise > >> it returns FILE; if no match i think we should signal an error. > > > > Whether this should be an error or just FILE is a matter of personal > > preferences, I think. Some shells behave this way, others the other > > way. So either we should leave your original patch as it was, or > > introduce a defcustom to produce an error if the user so wants. > Indeed such defcustom already does exist: eshell-error-if-no-glob > (default to nil). > You can see at the end of `eshell-extended-glob': > (if eshell-error-if-no-glob > (error "No matches found: %s" glob) > glob) I'm confused: I wasn't commenting on what eshell-extended-glob does, I was commenting about your code: + (let ((matches (eshell-extended-glob file))) + (if (consp matches) + (mapcar #'file-relative-name matches) + (user-error (format "%s: No files matching wildcard" file)))) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ If eshell-extended-glob already signals an error when it's TRT, why do you need to signal an error if Eshell doesn't? What am I missing? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 01 10:06:12 2017 Received: (at 27844) by debbugs.gnu.org; 1 Aug 2017 14:06:12 +0000 Received: from localhost ([127.0.0.1]:37039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcXoK-0006Xt-2B for submit@debbugs.gnu.org; Tue, 01 Aug 2017 10:06:12 -0400 Received: from mail-pg0-f66.google.com ([74.125.83.66]:36950) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcXoI-0006Xb-Ah for 27844@debbugs.gnu.org; Tue, 01 Aug 2017 10:06:10 -0400 Received: by mail-pg0-f66.google.com with SMTP id 83so2859164pgb.4 for <27844@debbugs.gnu.org>; Tue, 01 Aug 2017 07:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=uNe1Gq6bvSZIrKr23J1P5uNLQF9LazUJgBsB4AnehLs=; b=vEJ3ADLkiPEoBq8UsAE3+OG6vwr3gw6L3QTVmCt90IIf++8BGSdz2xT1kCttIjcH2C mLe5uxMsbjrXKKIym/vMoNULjXUPnkYXWXI9NZk8PqTHubkSpTF44nJvQG5xdX7wfZ75 RZXTptS+jRAdkwmUSiEEQAR7tLQicDpl36n6AdlPV8OR22MQ+3IUvb3dkHgvbi8JL9OE sTveiov8DJlTiK/zJv5Hd0Y1SweRZfYHik6Q+oYU8a0Kwtrjtv6Ix4+5lCqH8m3BTi/c olb+uWlEVQ/jiWl3zYdlhgFUEPYiACbKeNpTYe9F6NOFHP9bGwASEV2BS8NEyYqGt0GW yjzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=uNe1Gq6bvSZIrKr23J1P5uNLQF9LazUJgBsB4AnehLs=; b=B1VK4Tlzs+7WGe+DgdzJNlMPz5kftm7k8u1rOFTZQWVDFCp5rOhLyCQF69QvCwOk4q 02byfthFyl/EqxU8dkhle2PEHHfsEdt69Ye9xIjmFRdTVbuVK7A3xl/N2qS99RaaWA5D RZWiAFnAAupopvKKzVLozHLYdqAo0H+0V1wtrPYILTm0FCAhlbM6PO0M8dKikgzLKQRb 31sLLSfMiF2rodUcDcrtkHg07b1k3qvlMK7Xe3zQelRA9LzKS7H6CrShcL3kJhsuSeZX DMq0tjKdJ8Shg4cWg14yX9NL47XZn8oUECmqGAfbMvyBBOMD3QxzLIyJkQyMUFmCliS8 NNUw== X-Gm-Message-State: AIVw110EsvcP7XTT1KM36SvHbAC7sDy/ppthEnVjZEpT8LW+janG9yrN +n5Ei2tqiuTOlA== X-Received: by 10.84.217.74 with SMTP id e10mr7728524plj.410.1501596364559; Tue, 01 Aug 2017 07:06:04 -0700 (PDT) Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id f87sm54341610pfe.108.2017.08.01.07.06.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Aug 2017 07:06:03 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Tue, 1 Aug 2017 23:06:01 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#27844: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name In-Reply-To: <8360e71k5p.fsf@gnu.org> Message-ID: References: <878tjasgom.fsf@calancha-pc> <87h8xyutc3.fsf@calancha-pc> <83inib393n.fsf@gnu.org> <87lgn4j8ko.fsf@calancha-pc> <8360e71k5p.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 27844 Cc: 27844@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Tue, 1 Aug 2017, Eli Zaretskii wrote: > I'm confused: I wasn't commenting on what eshell-extended-glob does, I > was commenting about your code: > > + (let ((matches (eshell-extended-glob file))) > + (if (consp matches) > + (mapcar #'file-relative-name matches) > + (user-error (format "%s: No files matching wildcard" file)))) > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > If eshell-extended-glob already signals an error when it's TRT, why do > you need to signal an error if Eshell doesn't? What am I missing? I prefer to throw an error because looks familiar compared with what i see when using GNU/ls. If i try: C-x d ~/emacs-master/lisp/*.Z RET I) with GNU/ls or with ls-lisp: i get an error and i read in the echo area: Reading directory: No such file or directory, ~/emacs-master/lisp/*Z II) with eshell-ls: I actualy get a Dired buffer with an entry (the directory itself). I rather prefer if II) behaves as I) regardless on 'eshell-error-if-no-glob', that means, my second patch with the user-error. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 01 11:37:57 2017 Received: (at 27844) by debbugs.gnu.org; 1 Aug 2017 15:37:57 +0000 Received: from localhost ([127.0.0.1]:37103 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcZF7-00024A-1o for submit@debbugs.gnu.org; Tue, 01 Aug 2017 11:37:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56755) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcZF5-00023y-Er for 27844@debbugs.gnu.org; Tue, 01 Aug 2017 11:37:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcZEx-0002Ob-4z for 27844@debbugs.gnu.org; Tue, 01 Aug 2017 11:37:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58170) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcZEx-0002OV-1I; Tue, 01 Aug 2017 11:37:47 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4853 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dcZEv-0001YM-1s; Tue, 01 Aug 2017 11:37:46 -0400 Date: Tue, 01 Aug 2017 18:37:37 +0300 Message-Id: <83wp6nz4ce.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Tue, 1 Aug 2017 23:06:01 +0900 (JST)) Subject: Re: bug#27844: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name References: <878tjasgom.fsf@calancha-pc> <87h8xyutc3.fsf@calancha-pc> <83inib393n.fsf@gnu.org> <87lgn4j8ko.fsf@calancha-pc> <8360e71k5p.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27844 Cc: 27844@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Date: Tue, 1 Aug 2017 23:06:01 +0900 (JST) > cc: Tino Calancha , 27844@debbugs.gnu.org > > > If eshell-extended-glob already signals an error when it's TRT, why do > > you need to signal an error if Eshell doesn't? What am I missing? > I prefer to throw an error because looks familiar compared with > what i see when using GNU/ls. > If i try: > C-x d ~/emacs-master/lisp/*.Z RET > > I) with GNU/ls or with ls-lisp: > i get an error and i read in the echo area: > Reading directory: No such file or directory, ~/emacs-master/lisp/*Z > > II) with eshell-ls: > I actualy get a Dired buffer with an entry (the directory itself). > > I rather prefer if II) behaves as I) regardless on > 'eshell-error-if-no-glob', that means, my second patch with the > user-error. So we are back to the same issue: this is IMO a user preference, and you are accustomed to one of the possible behaviors. And since you want the behavior to be independent on an already existing user option, I'm not sure how to proceed. Maybe you could start by explaining why you don't want eshell-error-if-no-glob to control this? From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 01 12:04:33 2017 Received: (at 27844) by debbugs.gnu.org; 1 Aug 2017 16:04:34 +0000 Received: from localhost ([127.0.0.1]:37144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcZer-0004Xt-M6 for submit@debbugs.gnu.org; Tue, 01 Aug 2017 12:04:33 -0400 Received: from mail-pg0-f52.google.com ([74.125.83.52]:36646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcZeo-0004Xf-O9 for 27844@debbugs.gnu.org; Tue, 01 Aug 2017 12:04:31 -0400 Received: by mail-pg0-f52.google.com with SMTP id v77so4021442pgb.3 for <27844@debbugs.gnu.org>; Tue, 01 Aug 2017 09:04:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=BRbCuWFJb7qhIIjVYr8ZAOiKFWfpWAbLDhhwoThrb4g=; b=AwbiD8tFmJPzASfWROeuFpB6E75P5rQMaEbnbBRS4r9rigSnt2z+wUocda90cLGpDe QkG+20ppOd5AKDeqsVqfXkRIOvIK8y6YeWXt2Ja5A5JSHj4SM2w9wTewqe5+w0JfikuP eJrnfNquA9PchXqt9xSNGT0/4tZAMTDyVsJ/LsiO+oGrHBhaC3vBnJbpVldC+PAbV/ng Y1BDjO7XDTuymojPjFfN8J7gNExJVhtz1qRd159feJ0938llfAA5xm8U9oYKjuRAvcca XqL92M2TE7+qBuXhOydD6wo48m7+A050mT2R4T5qJjra0dhlQHlzPkFgiUKhMzs+bXlP iwyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=BRbCuWFJb7qhIIjVYr8ZAOiKFWfpWAbLDhhwoThrb4g=; b=SohkGg9mV7cdtEXBSXDhIjAy/o3zxVqurdx2WBTIRq0cX32rOncvNaGvrRYN+bci8Z 7+8hnJHwrFQi2jEWRA9uiR5c6OZo4Kra23yFczr1bHmEiKMSNmStQFoa+xpnvT6vig0v qNmGk1m2Arz4Ct6dpKX4imVEzuXdfjijLAbHFSa1AYzhElKOSKLYXsHqTcovJ1KZyGKW CQJhuWmYrfwTE0d7GO2zvk6HFqMrAGlbYLFUx4TebzluazTgIDOlZ1JIuLKlmXV7T2DN qiRFa98rGhIzAOUq5IxVnLX6K8PZCbiCPAvPclJ/p2OCRI6r8gs7x7NuE+ZPtshOzGXm b5YA== X-Gm-Message-State: AIVw113c4CYbp6Z4VC0pH2jIUerpncamEA1zM2F286BoPZKlNXDt5PaL 1l44vBZfmgYrPA== X-Received: by 10.84.128.14 with SMTP id 14mr21726442pla.285.1501603464495; Tue, 01 Aug 2017 09:04:24 -0700 (PDT) Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id e131sm24710966pfc.93.2017.08.01.09.04.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 01 Aug 2017 09:04:23 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Wed, 2 Aug 2017 01:04:20 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#27844: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name In-Reply-To: <83wp6nz4ce.fsf@gnu.org> Message-ID: References: <878tjasgom.fsf@calancha-pc> <87h8xyutc3.fsf@calancha-pc> <83inib393n.fsf@gnu.org> <87lgn4j8ko.fsf@calancha-pc> <8360e71k5p.fsf@gnu.org> <83wp6nz4ce.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 27844 Cc: 27844@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Tue, 1 Aug 2017, Eli Zaretskii wrote: >> From: Tino Calancha >> Date: Tue, 1 Aug 2017 23:06:01 +0900 (JST) >> cc: Tino Calancha , 27844@debbugs.gnu.org >> >>> If eshell-extended-glob already signals an error when it's TRT, why do >>> you need to signal an error if Eshell doesn't? What am I missing? >> I prefer to throw an error because looks familiar compared with >> what i see when using GNU/ls. >> If i try: >> C-x d ~/emacs-master/lisp/*.Z RET >> >> I) with GNU/ls or with ls-lisp: >> i get an error and i read in the echo area: >> Reading directory: No such file or directory, ~/emacs-master/lisp/*Z >> >> II) with eshell-ls: >> I actualy get a Dired buffer with an entry (the directory itself). >> >> I rather prefer if II) behaves as I) regardless on >> 'eshell-error-if-no-glob', that means, my second patch with the >> user-error. > > So we are back to the same issue: this is IMO a user preference, and > you are accustomed to one of the possible behaviors. And since you > want the behavior to be independent on an already existing user > option, I'm not sure how to proceed. Maybe you could start by > explaining why you don't want eshell-error-if-no-glob to control this? 1) I am imaging one user in a system without an external 'ls' installed. 2) This hypothetical user wants to use Dired; after searching the web, find s?he could do it via eshell. 3) I assume this user is not interested in the eshell internals: just want to have Dired running without complications. That means 'eshell-error-if-no-glob' keeps its default, nil. For this guy is more informative to get an error after s?he dired ~/emacs/lisp/*.Z saying that nothing matched the wildcard. Getting the Dired buffer with the listing of '~/emacs/lisp' is confuse and requires some time to understand the situation. Furthermore, s?he could do the same operation in another machine, one with an external "ls" installed, and observe a different result. I like the idea that Dired behaves uniformsly regardless on if we are using an external 'ls' or an elisp emulation of it. That said, i am OK with showing the Dired buffer ie, let eshell-error-if-no-glob to decide the situation, if you like more. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 01 14:44:28 2017 Received: (at 27844) by debbugs.gnu.org; 1 Aug 2017 18:44:28 +0000 Received: from localhost ([127.0.0.1]:37251 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcc9a-0008BT-PX for submit@debbugs.gnu.org; Tue, 01 Aug 2017 14:44:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:56048) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcc9Z-0008BI-RH for 27844@debbugs.gnu.org; Tue, 01 Aug 2017 14:44:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcc9M-0005nE-Qx for 27844@debbugs.gnu.org; Tue, 01 Aug 2017 14:44:17 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33487) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcc9M-0005n7-N5; Tue, 01 Aug 2017 14:44:12 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4961 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dcc9J-0002Me-Sp; Tue, 01 Aug 2017 14:44:12 -0400 Date: Tue, 01 Aug 2017 21:43:41 +0300 Message-Id: <83tw1ryvqa.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Wed, 2 Aug 2017 01:04:20 +0900 (JST)) Subject: Re: bug#27844: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name References: <878tjasgom.fsf@calancha-pc> <87h8xyutc3.fsf@calancha-pc> <83inib393n.fsf@gnu.org> <87lgn4j8ko.fsf@calancha-pc> <8360e71k5p.fsf@gnu.org> <83wp6nz4ce.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27844 Cc: 27844@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Date: Wed, 2 Aug 2017 01:04:20 +0900 (JST) > cc: Tino Calancha , 27844@debbugs.gnu.org > > 1) I am imaging one user in a system without an external 'ls' installed. > > 2) This hypothetical user wants to use Dired; after searching the web, > find s?he could do it via eshell. > > 3) I assume this user is not interested in the eshell internals: just want > to have Dired running without complications. That means > 'eshell-error-if-no-glob' keeps its default, nil. How about binding eshell-error-if-no-glob to non-nil when eshell/ls is called from Dired, then? > I like the idea that Dired behaves uniformsly regardless on if we are > using an external 'ls' or an elisp emulation of it. That's an unreachable ideal, because there are too many versions of 'ls' out there. GNU 'ls' is just one of them. And sometimes the error comes from the shell which expands wildcards, not from 'ls' itself. From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 02 04:49:59 2017 Received: (at 27844) by debbugs.gnu.org; 2 Aug 2017 08:49:59 +0000 Received: from localhost ([127.0.0.1]:37652 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcpLp-0003uf-J7 for submit@debbugs.gnu.org; Wed, 02 Aug 2017 04:49:57 -0400 Received: from mail-io0-f177.google.com ([209.85.223.177]:37272) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcpLn-0003uP-K9 for 27844@debbugs.gnu.org; Wed, 02 Aug 2017 04:49:56 -0400 Received: by mail-io0-f177.google.com with SMTP id c74so17772018iod.4 for <27844@debbugs.gnu.org>; Wed, 02 Aug 2017 01:49:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=D6VL/nHR01ntgnuAoF6QZPBcf8hQkyZQLYDn+9+MsNI=; b=Hs3CCBafpnNorN6QTrmSl3aSIUqsamGDBqE9OHM1piWhH9sI86g4FxG0J1niXbU0qR mUU2p8KdFbjoWqB9AbaXDTQVhdW5zmnH+nsMU535NY+TGKogu/9X87GEt62BcjeIuAdS qsHipnMiazI/E1LG0D5Iw0wlUDc7s9jNk2L1SzWGrW4iSn4XCx+8dfNAhb/TfAkiEYIM Buth2f4OdEBpK3t2UJdSqRlrvP3HI/v6elFa8iwWgxEyfxVa6+bUDPhjpdAya+2kW9gg 7/u/TpT8wZ8mS8GKULyYLRdo0TJcn38TvogVMGiASW0F3V2DrvLSeNFdZfZYX3SHdyIa f9ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=D6VL/nHR01ntgnuAoF6QZPBcf8hQkyZQLYDn+9+MsNI=; b=CIBazJcwewU9IN62JbhqtCTMj2PQvff23JEglc32+qOMti7qh/Ue0gA4Kc8k9DNqev eqoqzDlOu0NAh5ei16N5Ag584uw4CmIJy/zjqshMqNjxd4i5MxjCDut8GvZfB0KQ11l4 UNR2BcvKNNmt1emtqsdKcLC9crMHhc6slp08IMQlryc8frhckVcVbsCVf8Xs3ExwiSst bgyiBoYqDO45JFSQ2w+5a5Fw1Dql8+i5VD4JCEt7JU69NtVgIXTgLkSTCRHSndLrdJth NT7ysE1yvI5/YrBVINgyHm2fymvn4Mgn8iPuJuFlOuc6zU/w+fUkJ17tSWG82CdneHY5 X9mQ== X-Gm-Message-State: AIVw111Ypxfi5eDrSW+iRTzuUdvkkv0YfBzkIw5jd2wy59FLqnyx3Cca LCIq0AVqjSd3/w== X-Received: by 10.107.12.70 with SMTP id w67mr28663144ioi.298.1501663789589; Wed, 02 Aug 2017 01:49:49 -0700 (PDT) Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id d201sm1748621itb.0.2017.08.02.01.49.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 02 Aug 2017 01:49:48 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Wed, 2 Aug 2017 17:49:45 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#27844: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name In-Reply-To: <83tw1ryvqa.fsf@gnu.org> Message-ID: References: <878tjasgom.fsf@calancha-pc> <87h8xyutc3.fsf@calancha-pc> <83inib393n.fsf@gnu.org> <87lgn4j8ko.fsf@calancha-pc> <8360e71k5p.fsf@gnu.org> <83wp6nz4ce.fsf@gnu.org> <83tw1ryvqa.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 27844 Cc: 27844@debbugs.gnu.org, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On Tue, 1 Aug 2017, Eli Zaretskii wrote: >> From: Tino Calancha >> Date: Wed, 2 Aug 2017 01:04:20 +0900 (JST) >> cc: Tino Calancha , 27844@debbugs.gnu.org >> >> 1) I am imaging one user in a system without an external 'ls' installed. >> >> 2) This hypothetical user wants to use Dired; after searching the web, >> find s?he could do it via eshell. >> >> 3) I assume this user is not interested in the eshell internals: just want >> to have Dired running without complications. That means >> 'eshell-error-if-no-glob' keeps its default, nil. > > How about binding eshell-error-if-no-glob to non-nil when eshell/ls is > called from Dired, then? It sounds good. Updated patch: --8<-----------------------------cut here---------------start------------->8--- commit 4654a88f53450e680a10e63a010ffbcbeedfef3e Author: Tino Calancha Date: Wed Aug 2 17:46:50 2017 +0900 Dired w/ eshell-ls: Handle shell wildcards in file name * lisp/eshell/em-ls.el (eshell-ls--insert-directory): Use eshell-extended-glob (Bug#27844). * test/lisp/dired-tests.el (dired-test-bug27844): Add test. diff --git a/lisp/eshell/em-ls.el b/lisp/eshell/em-ls.el index 39f03ffb79..38e38132bf 100644 --- a/lisp/eshell/em-ls.el +++ b/lisp/eshell/em-ls.el @@ -243,6 +243,9 @@ dired-flag ;;; Functions: +(declare-function eshell-extended-glob "em-glob" (glob)) +(defvar eshell-error-if-no-glob) + (defun eshell-ls--insert-directory (orig-fun file switches &optional wildcard full-directory-p) "Insert directory listing for FILE, formatted according to SWITCHES. @@ -275,14 +278,22 @@ eshell-ls--insert-directory (set 'font-lock-buffers (delq (current-buffer) (symbol-value 'font-lock-buffers))))) - (let ((insert-func 'insert) - (error-func 'insert) - (flush-func 'ignore) - (switches - (append eshell-ls-dired-initial-args - (and (or (consp dired-directory) wildcard) (list "-d")) - switches))) - (eshell-do-ls (nconc switches (list file))))))))) + (require 'em-glob) + (let* ((insert-func 'insert) + (error-func 'insert) + (flush-func 'ignore) + (eshell-error-if-no-glob t) + (target ; Expand the shell wildcards if any. + (if (and (atom file) + (string-match "[[?*]" file) + (not (file-exists-p file))) + (mapcar #'file-relative-name (eshell-extended-glob file)) + (file-relative-name file))) + (switches + (append eshell-ls-dired-initial-args + (and (or (consp dired-directory) wildcard) (list "-d")) + switches))) + (eshell-do-ls (nconc switches (list target))))))))) (declare-function eshell-extended-glob "em-glob" (glob)) diff --git a/test/lisp/eshell/em-ls-tests.el b/test/lisp/eshell/em-ls-tests.el index 71a555d1ea..8e7b91d979 100644 --- a/test/lisp/eshell/em-ls-tests.el +++ b/test/lisp/eshell/em-ls-tests.el @@ -75,6 +75,24 @@ (customize-set-variable 'eshell-ls-use-in-dired orig) (and (buffer-live-p buf) (kill-buffer))))) +(ert-deftest em-ls-test-bug27844 () + "Test for http://debbugs.gnu.org/27844 ." + (let ((orig eshell-ls-use-in-dired) + (dired-use-ls-dired 'unspecified) + buf insert-directory-program) + (unwind-protect + (progn + (customize-set-variable 'eshell-ls-use-in-dired t) + (setq buf (dired (expand-file-name "lisp/*.el" source-directory))) + (dired-toggle-marks) + (should (cdr (dired-get-marked-files))) + (kill-buffer buf) + (setq buf (dired (expand-file-name "lisp/subr.el" source-directory))) + (should (looking-at "subr\\.el"))) + (customize-set-variable 'eshell-ls-use-in-dired orig) + (and (buffer-live-p buf) (kill-buffer))))) + + (provide 'em-ls-test) ;;; em-ls-tests.el ends here --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-08-02 built Repository revision: e82c4f56e6f9a6bce4098698b17fa45dcc5bbd25 From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 04 09:16:45 2017 Received: (at 27844) by debbugs.gnu.org; 4 Aug 2017 13:16:45 +0000 Received: from localhost ([127.0.0.1]:41018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddcT7-0000Gn-5y for submit@debbugs.gnu.org; Fri, 04 Aug 2017 09:16:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddcT5-0000GY-EU for 27844@debbugs.gnu.org; Fri, 04 Aug 2017 09:16:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddcRr-00050I-GV for 27844@debbugs.gnu.org; Fri, 04 Aug 2017 09:16:38 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48239) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddcRr-000500-BT; Fri, 04 Aug 2017 09:15:27 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4513 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ddcRq-0002be-Kl; Fri, 04 Aug 2017 09:15:27 -0400 Date: Fri, 04 Aug 2017 16:15:16 +0300 Message-Id: <83zibfwk2j.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: (message from Tino Calancha on Wed, 2 Aug 2017 17:49:45 +0900 (JST)) Subject: Re: bug#27844: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name References: <878tjasgom.fsf@calancha-pc> <87h8xyutc3.fsf@calancha-pc> <83inib393n.fsf@gnu.org> <87lgn4j8ko.fsf@calancha-pc> <8360e71k5p.fsf@gnu.org> <83wp6nz4ce.fsf@gnu.org> <83tw1ryvqa.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27844 Cc: 27844@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Date: Wed, 2 Aug 2017 17:49:45 +0900 (JST) > cc: Tino Calancha , 27844@debbugs.gnu.org > > > How about binding eshell-error-if-no-glob to non-nil when eshell/ls is > > called from Dired, then? > It sounds good. > Updated patch: Fine with me, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 06 00:30:17 2017 Received: (at 27844-done) by debbugs.gnu.org; 6 Aug 2017 04:30:17 +0000 Received: from localhost ([127.0.0.1]:43999 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deDCj-0008PB-DB for submit@debbugs.gnu.org; Sun, 06 Aug 2017 00:30:17 -0400 Received: from mail-pg0-f53.google.com ([74.125.83.53]:38687) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deDCh-0008Oy-3P for 27844-done@debbugs.gnu.org; Sun, 06 Aug 2017 00:30:16 -0400 Received: by mail-pg0-f53.google.com with SMTP id l64so21929183pge.5 for <27844-done@debbugs.gnu.org>; Sat, 05 Aug 2017 21:30:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=EkBQeStUgMXRaC5IYwboZFkWxNcAXH6F+6WcDN3JLoU=; b=KXICY/F488vy1Hcve8hnfEoXZXKZjyvsCNWj8zSh+BqvTb5ex86k5NwrorM3jRVbk1 qETDLnLTyr1J8pTbgmVjS1uUTSx9CiZFwUZ5S1VxrwjKHgAwJzSk2LVOSog2waVJulLt H5gM/7DyGNGhRT5cFp9GmyXm8cKhWGH292BHk4oT1+SvQwbCtkRz7sxkm9UwCs53uplO FuuNv/IMI8QTQ2js9ZQAVg6K/0B1W7TdkSewhRzTWO6j9wbpxSLl2nr4bgmCaymFdMVF tAYQOahDxC8RhQp9is5uP8jPaEezKmJ2nOb7/rox7rM634CNHjM+TlwXmkaKQE3BziN5 iocg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=EkBQeStUgMXRaC5IYwboZFkWxNcAXH6F+6WcDN3JLoU=; b=E4vt4QQpSqepSFYJLR3ZtHUrha2tq+W9Jr5s4n9Ni56codW/iGtBl/T7XthSp8J0Yv tfC4r0YYvS82oZ2hLMiCCEQK+dTx135zG3Wv0CFD4pEhEBHXq1ZISV1oqaOiz+7LlECS Y9TdEXooZ7mAvynwpT3d+QNvPjRQOAAgQFS8WRheIU6SBXEPev/Rw7jhRfiLUxAjLs9k Xi2NcZowbJx2C6EuYeBcG8kFhAkxJHsg4P6/IxFWEYwSDQK28++33zruLM8mZDHpIs/Z 8oz6srlv7ff/ixemmLTgp2oHICZlxW19vl0oO1iwqoFxMc2F5paN5YSyH6nP/DE1oqad AMWw== X-Gm-Message-State: AIVw110rOmpf5O0fHJ3cbvmr09Hq9Saa4bjj4kFmcDmBGR8SnAPb7eLb pAWK/8isrG3pJay/ X-Received: by 10.98.245.147 with SMTP id b19mr7483145pfm.286.1501993808824; Sat, 05 Aug 2017 21:30:08 -0700 (PDT) Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id r87sm10005124pfb.112.2017.08.05.21.30.07 for <27844-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 05 Aug 2017 21:30:08 -0700 (PDT) From: Tino Calancha To: 27844-done@debbugs.gnu.org Subject: Re: bug#27844: 26.0.50; Dired w/ eshell-ls doesn't support wildcards in file name References: <878tjasgom.fsf@calancha-pc> <83k22r396o.fsf@gnu.org> Date: Sun, 06 Aug 2017 13:30:06 +0900 In-Reply-To: <83k22r396o.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Jul 2017 12:05:03 +0300") Message-ID: <87h8xlmi7l.fsf@calancha-pc> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 27844-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii writes: >> Dired w/ eshell-ls: Handle shell wildcards in file name >> >> * lisp/eshell/em-ls.el (eshell-ls--insert-directory): >> Use eshell-extended-glob (Bug#27844). >> * test/lisp/dired-tests.el (dired-test-bug27844): Add test. > > LGTM, thanks. Pushed fix into master branch as commit c0df64db08b58cdac37cb38c16f2ba2f097fae92 (Dired w/ eshell-ls: Handle shell wildcards in file name) From unknown Tue Jun 24 20:50:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 03 Sep 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator