Subject: Re: bug#27843: 26.0.50; Dired w/ eshell insert subdirs content when dir-or-list is a cons

From: Eli Zaretskii <[email-masked]>
Date: Sat, 29 Jul 2017 12:04:17 +0300

> From: Tino Calancha <[email-masked]>
> Date: Thu, 27 Jul 2017 12:19:08 +0900
> 
> emacs -r -Q -l ls-lisp -eval "(setq ls-lisp-use-insert-directory-program t)"
> ;; Following form must lists just 2 entries in Dired:
> M-: (dired (list source-directory "README" "lisp")) RET
> 
> ;; In fact, it inserts the full content of subdir "lisp".
> 
> --8<-----------------------------cut here---------------start------------->8---
> commit 6216ea9470feabf22333988f02203334fcfd2e26
> Author: Tino Calancha <[email-masked]>
> Date:   Thu Jul 27 12:09:00 2017 +0900
> 
>     Dired w/ eshell: Don't insert subdirs content if dir-or-list is a cons
>     
>     * lisp/eshell/em-ls.el (eshell-ls--insert-directory):
>     Append '("-d") into 'eshell-ls-dired-initial-args'
>     when 'dired-directory' is a cons (Bug#27843).
>     * test/lisp/dired-tests.el (dired-test-bug27843): Add test.

This LGTM, but please rephrase the log summary line to be positive,
not negative.

Thanks.