From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 26 23:19:28 2017 Received: (at submit) by debbugs.gnu.org; 27 Jul 2017 03:19:28 +0000 Received: from localhost ([127.0.0.1]:57822 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daZKh-0002lv-QE for submit@debbugs.gnu.org; Wed, 26 Jul 2017 23:19:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53633) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daZKf-0002li-Pp for submit@debbugs.gnu.org; Wed, 26 Jul 2017 23:19:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daZKZ-0000mY-7t for submit@debbugs.gnu.org; Wed, 26 Jul 2017 23:19:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:43172) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1daZKZ-0000mK-4o for submit@debbugs.gnu.org; Wed, 26 Jul 2017 23:19:19 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44576) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daZKX-0001rM-MU for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 23:19:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daZKW-0000jX-BG for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 23:19:17 -0400 Received: from mail-pg0-x22e.google.com ([2607:f8b0:400e:c05::22e]:36665) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1daZKW-0000gt-5o for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 23:19:16 -0400 Received: by mail-pg0-x22e.google.com with SMTP id 125so92138251pgi.3 for ; Wed, 26 Jul 2017 20:19:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=Z2t6x2Ma0LloV57Aivb8d8GC4T5D85km0qBNS61Eu14=; b=HzzjlgB62g+lY/J9dQ1o3UKT2lcffSM5JzW2tNsScdEEr1an6ehvhOVotQp9SyuFj+ GpQ7KCnIVgzGiJtjT46VHrrrSek+R5lHKHs1t7BEkO2X//Mw6xGB1VGELVCKb0ruKNxB FvB/DZNNjfZtXcfJkjS/2nfoG0+qJvmtfGBhdkxCjImMRTNT2WGvUn2KQiucqs1aTabf fEAZQuTqhx530SboML98IXbIoaJlYnuYLG9optNWVfxJhH+APCjKBxV8aHef8lfcRftz sakkJeOy8ZHHJviBbBzzQxUxq2TsTeLO1NAnpdXhc/eWC+0/EW6DQgC1WcmoDCeJA1zN 1Ngw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=Z2t6x2Ma0LloV57Aivb8d8GC4T5D85km0qBNS61Eu14=; b=gy7x+ZDNbO9TmIfQCPeMvfh0Hh1iQP8pBiTgfMkv50ZQSGkJZhESxzgfYlQ91MsUJZ F5bobfAGnRYfgtB7WSG2YkFYc7fmoVVAuQTsfYLUX39z0uHEtV4sd8kkox0qPLnLbZQ3 XnDKU/DeXgT7ghIJguzHVtXqb9vvRLRiYpktGxnlSzTmvhY1Wj9EPDsAsja8KqzVL4Te yiW+sTrnPyPM0W1GtvTbxuZC0qqHBljEV106CvuxboTeMb22hhFMc+kuKhWtF/V/xhhS eNUD3rYkQcvuhq0wzfhBAukErrYngcxLQGVyFX97Ns80MyNIAyumGBWWjdmo0oJiKWKb nDRA== X-Gm-Message-State: AIVw112pzkOq416IY8u8QxIEj/srTLXEvdHFljCZYivCwbqlWu1RKnqt PoLsTZXDWJhsrGJA X-Received: by 10.84.248.13 with SMTP id p13mr2951437pll.312.1501125552895; Wed, 26 Jul 2017 20:19:12 -0700 (PDT) Received: from calancha-pc ([240f:6e:fb29:1:9ee6:2511:da80:1c7e]) by smtp.gmail.com with ESMTPSA id e24sm13035749pfk.180.2017.07.26.20.19.11 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Jul 2017 20:19:12 -0700 (PDT) From: Tino Calancha To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Dired w/ eshell insert subdirs content when dir-or-list is a cons Date: Thu, 27 Jul 2017 12:19:08 +0900 Message-ID: <87bmo6sh1v.fsf@calancha-pc> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) emacs -r -Q -l ls-lisp -eval "(setq ls-lisp-use-insert-directory-program t)" ;; Following form must lists just 2 entries in Dired: M-: (dired (list source-directory "README" "lisp")) RET ;; In fact, it inserts the full content of subdir "lisp". --8<-----------------------------cut here---------------start------------->8--- commit 6216ea9470feabf22333988f02203334fcfd2e26 Author: Tino Calancha Date: Thu Jul 27 12:09:00 2017 +0900 Dired w/ eshell: Don't insert subdirs content if dir-or-list is a cons * lisp/eshell/em-ls.el (eshell-ls--insert-directory): Append '("-d") into 'eshell-ls-dired-initial-args' when 'dired-directory' is a cons (Bug#27843). * test/lisp/dired-tests.el (dired-test-bug27843): Add test. diff --git a/lisp/eshell/em-ls.el b/lisp/eshell/em-ls.el index 79799db30b..367ec69489 100644 --- a/lisp/eshell/em-ls.el +++ b/lisp/eshell/em-ls.el @@ -276,8 +276,10 @@ eshell-ls--insert-directory (let ((insert-func 'insert) (error-func 'insert) (flush-func 'ignore) - eshell-ls-dired-initial-args) - (eshell-do-ls (append switches (list file))))))))) + (switches (append eshell-ls-dired-initial-args + (and (consp dired-directory) (list "-d")) + switches))) + (eshell-do-ls (nconc switches (list file))))))))) (defsubst eshell/ls (&rest args) "An alias version of `eshell-do-ls'." diff --git a/test/lisp/dired-tests.el b/test/lisp/dired-tests.el index 601d65768b..63b1e45e1f 100644 --- a/test/lisp/dired-tests.el +++ b/test/lisp/dired-tests.el @@ -188,5 +188,20 @@ (customize-set-variable 'eshell-ls-use-in-dired orig) (and (buffer-live-p buf) (kill-buffer))))) +(ert-deftest dired-test-bug27843 () + "Test for http://debbugs.gnu.org/27843 ." + (require 'em-ls) + (let ((orig eshell-ls-use-in-dired) + (dired-use-ls-dired 'unspecified) + buf insert-directory-program) + (unwind-protect + (progn + (customize-set-variable 'eshell-ls-use-in-dired t) + (setq buf (dired (list source-directory "lisp"))) + (dired-toggle-marks) + (should-not (cdr (dired-get-marked-files)))) + (customize-set-variable 'eshell-ls-use-in-dired orig) + (and (buffer-live-p buf) (kill-buffer))))) + (provide 'dired-tests) ;; dired-tests.el ends here --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-07-26 Repository revision: e1e8d2e229f48b3cee765f7cf27ae04ee4401d85 From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 27 05:27:04 2017 Received: (at 27843) by debbugs.gnu.org; 27 Jul 2017 09:27:04 +0000 Received: from localhost ([127.0.0.1]:57908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daf4S-0002zr-KE for submit@debbugs.gnu.org; Thu, 27 Jul 2017 05:27:04 -0400 Received: from mail-pg0-f53.google.com ([74.125.83.53]:36203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daf4Q-0002zL-Ke for 27843@debbugs.gnu.org; Thu, 27 Jul 2017 05:27:02 -0400 Received: by mail-pg0-f53.google.com with SMTP id 125so95752963pgi.3 for <27843@debbugs.gnu.org>; Thu, 27 Jul 2017 02:27:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=c4N1Od0nC6ZJM1Aeqzt2ghS66DNESzTHKCvOjdSA80k=; b=daWJ1w1V0vT7ML1wK8VV02s/3CKdGFMGzjES6ePHxE95s3QX8jyvcvT7mQyU0RrbGl EjM6BpWGE2wAlklqD5fZYn7rozAwrF7ZIPXn/3bfy1vLezzqJd6lAvlBVMCM6ljSgyIq 85+yPBGl29R4kz00hnzyJEGrP5mV17F1Q2A7ocbdzIr6UImA8Wc6znbgT7KauMG1S60s WS7dMjfLJ93DfFL7cG0dGolZFe9JDcH/ULW2xyFnjScnxjLAKZUcP/fmfSj8akJkdpme ANDDrxvwkFqCqR/hufT02lzpH8JjtbSq5X9plc1GuTnGZpjqylGNvpo+xXNm934OmD7f S8DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=c4N1Od0nC6ZJM1Aeqzt2ghS66DNESzTHKCvOjdSA80k=; b=rB6iQ7SdU8HCqnrCkGShc/4xphAlh9Lhi7DcFQodaqfnx+oQUi1pVoTRl7eHDRdLYT PQUBeqn4Jny25DZEY2hw7CwVASFK7fY2toxCWtF1d8+nKS51oNC2VawAMepUgZYs444z /+djryIk0VWosD983xsNl0117xLHcoqw7+UifJwnedOzErCXa/MYB7fVLifZEuqYohxD 9Bo9lX3dIaUdzax8OQYoxaU4A3KWNPsxk7CTzKTA6Jm8OA3ARFHdv48biEbS8wKZwp8K FH2cRrmYvDzVWkx80F/SDSetANeKL6tAT0mxn1n+FDVImA07YFjL+SDNealbxBjlhySm RUlQ== X-Gm-Message-State: AIVw110CtEhCaKbgVGgexhb+QwxJpAEKX13+ZQ9Dvi9H+k+iyy6YFDOS ny0BeFjtTOV6Ak1C X-Received: by 10.98.80.89 with SMTP id e86mr3458565pfb.195.1501147616704; Thu, 27 Jul 2017 02:26:56 -0700 (PDT) Received: from calancha-pc ([240f:6e:fb29:1:9ee6:2511:da80:1c7e]) by smtp.gmail.com with ESMTPSA id f74sm20398140pfk.131.2017.07.27.02.26.55 for <27843@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Jul 2017 02:26:56 -0700 (PDT) From: Tino Calancha To: 27843@debbugs.gnu.org Subject: Re: bug#27843: 26.0.50; Dired w/ eshell insert subdirs content when dir-or-list is a cons References: <87bmo6sh1v.fsf@calancha-pc> Date: Thu, 27 Jul 2017 18:26:53 +0900 In-Reply-To: <87bmo6sh1v.fsf@calancha-pc> (Tino Calancha's message of "Thu, 27 Jul 2017 12:19:08 +0900") Message-ID: <87eft2ut5u.fsf@calancha-pc> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 27843 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Tino Calancha writes: > @@ -276,8 +276,10 @@ eshell-ls--insert-directory > (let ((insert-func 'insert) > (error-func 'insert) > (flush-func 'ignore) > - eshell-ls-dired-initial-args) > - (eshell-do-ls (append switches (list file))))))))) > + (switches (append eshell-ls-dired-initial-args > + (and (consp dired-directory) (list "-d")) > + switches))) > + (eshell-do-ls (nconc switches (list file))))))))) Not just when dired-directory is a cons, _also_ if WILDCARD is non-nil we must just list the directory entry. --8<-----------------------------cut here---------------start------------->8--- commit 2fd058081bac06744ee38acdd209a3fce4405131 Author: Tino Calancha Date: Thu Jul 27 18:12:46 2017 +0900 Dired w/ eshell: Don't insert subdirs content if dir-or-list is a cons * lisp/eshell/em-ls.el (eshell-ls--insert-directory): Append '("-d") into 'eshell-ls-dired-initial-args' when 'dired-directory' is a cons (Bug#27843). * test/lisp/dired-tests.el (dired-test-bug27843): Add test. diff --git a/lisp/eshell/em-ls.el b/lisp/eshell/em-ls.el index 79799db30b..5926969b09 100644 --- a/lisp/eshell/em-ls.el +++ b/lisp/eshell/em-ls.el @@ -276,8 +276,10 @@ eshell-ls--insert-directory (let ((insert-func 'insert) (error-func 'insert) (flush-func 'ignore) - eshell-ls-dired-initial-args) - (eshell-do-ls (append switches (list file))))))))) + (switches (append eshell-ls-dired-initial-args + (and (or (consp dired-directory) wildcard) (list "-d")) + switches))) + (eshell-do-ls (nconc switches (list file))))))))) (defsubst eshell/ls (&rest args) "An alias version of `eshell-do-ls'." --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-07-26 Repository revision: 28faa94f1c423091bb34c2776eabe9ae83e5b4fc From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 29 05:04:37 2017 Received: (at 27843) by debbugs.gnu.org; 29 Jul 2017 09:04:37 +0000 Received: from localhost ([127.0.0.1]:60571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbNfp-0000pS-GY for submit@debbugs.gnu.org; Sat, 29 Jul 2017 05:04:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbNfn-0000pF-TD for 27843@debbugs.gnu.org; Sat, 29 Jul 2017 05:04:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbNff-0008Ay-Ol for 27843@debbugs.gnu.org; Sat, 29 Jul 2017 05:04:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55474) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbNff-0008Af-Ly; Sat, 29 Jul 2017 05:04:27 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4218 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dbNfe-00005v-6o; Sat, 29 Jul 2017 05:04:26 -0400 Date: Sat, 29 Jul 2017 12:04:17 +0300 Message-Id: <83lgn7397y.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: <87bmo6sh1v.fsf@calancha-pc> (message from Tino Calancha on Thu, 27 Jul 2017 12:19:08 +0900) Subject: Re: bug#27843: 26.0.50; Dired w/ eshell insert subdirs content when dir-or-list is a cons References: <87bmo6sh1v.fsf@calancha-pc> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27843 Cc: 27843@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Date: Thu, 27 Jul 2017 12:19:08 +0900 > > emacs -r -Q -l ls-lisp -eval "(setq ls-lisp-use-insert-directory-program t)" > ;; Following form must lists just 2 entries in Dired: > M-: (dired (list source-directory "README" "lisp")) RET > > ;; In fact, it inserts the full content of subdir "lisp". > > --8<-----------------------------cut here---------------start------------->8--- > commit 6216ea9470feabf22333988f02203334fcfd2e26 > Author: Tino Calancha > Date: Thu Jul 27 12:09:00 2017 +0900 > > Dired w/ eshell: Don't insert subdirs content if dir-or-list is a cons > > * lisp/eshell/em-ls.el (eshell-ls--insert-directory): > Append '("-d") into 'eshell-ls-dired-initial-args' > when 'dired-directory' is a cons (Bug#27843). > * test/lisp/dired-tests.el (dired-test-bug27843): Add test. This LGTM, but please rephrase the log summary line to be positive, not negative. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 29 05:07:56 2017 Received: (at 27843) by debbugs.gnu.org; 29 Jul 2017 09:07:56 +0000 Received: from localhost ([127.0.0.1]:60582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbNj1-0000uU-CH for submit@debbugs.gnu.org; Sat, 29 Jul 2017 05:07:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbNiz-0000uI-Na for 27843@debbugs.gnu.org; Sat, 29 Jul 2017 05:07:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbNir-0002fe-5i for 27843@debbugs.gnu.org; Sat, 29 Jul 2017 05:07:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55625) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbNir-0002fa-2f; Sat, 29 Jul 2017 05:07:45 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4223 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dbNiq-00039l-Al; Sat, 29 Jul 2017 05:07:44 -0400 Date: Sat, 29 Jul 2017 12:07:35 +0300 Message-Id: <83h8xv392g.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: <87eft2ut5u.fsf@calancha-pc> (message from Tino Calancha on Thu, 27 Jul 2017 18:26:53 +0900) Subject: Re: bug#27843: 26.0.50; Dired w/ eshell insert subdirs content when dir-or-list is a cons References: <87bmo6sh1v.fsf@calancha-pc> <87eft2ut5u.fsf@calancha-pc> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27843 Cc: 27843@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Date: Thu, 27 Jul 2017 18:26:53 +0900 > > Tino Calancha writes: > > > @@ -276,8 +276,10 @@ eshell-ls--insert-directory > > (let ((insert-func 'insert) > > (error-func 'insert) > > (flush-func 'ignore) > > - eshell-ls-dired-initial-args) > > - (eshell-do-ls (append switches (list file))))))))) > > + (switches (append eshell-ls-dired-initial-args > > + (and (consp dired-directory) (list "-d")) > > + switches))) > > + (eshell-do-ls (nconc switches (list file))))))))) > Not just when dired-directory is a cons, _also_ if WILDCARD is non-nil > we must just list the directory entry. OK, thanks. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 01 10:34:45 2017 Received: (at 27843-done) by debbugs.gnu.org; 1 Aug 2017 14:34:45 +0000 Received: from localhost ([127.0.0.1]:37055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcYFw-0007BU-S0 for submit@debbugs.gnu.org; Tue, 01 Aug 2017 10:34:45 -0400 Received: from mail-pf0-f179.google.com ([209.85.192.179]:35028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcYFu-0007BH-Qj for 27843-done@debbugs.gnu.org; Tue, 01 Aug 2017 10:34:43 -0400 Received: by mail-pf0-f179.google.com with SMTP id t86so8555615pfe.2 for <27843-done@debbugs.gnu.org>; Tue, 01 Aug 2017 07:34:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=/20NV+9FUaX/0QcezDwGLEUm8D4y+L2VDnDZ9ZutS00=; b=kz8lWnzl0E3IZyWjOP+qs2ifKKmLoXYGBh8wii3H0HQoa8Sx7pUwCLX5i4PmwTz/Kf moYVzXPn1d0DJhyTs10o8/WcaYvc4GYQhEpbQo49P8a7agWNYOhsUdyrZ2KmsRPRdZu3 H1sOz0PjDF1qU7MI3+93IAqnOSreDndor3hDD+EqzcXR3fmtT7DSlWvhHAJQYj+nskMf QNtEdMRkYdVmhAg7cwVxtKudtcre3RBIlBifwlgAHXoq2/X58frRbArbTIL3/9HkurKL NTQ/NcUkYBc0t4SJNaEjBRR8Mn7n7XX9rGg9vpxUkeTdV/Ct8fHCMVlK7bFxGgb72fgq OnRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=/20NV+9FUaX/0QcezDwGLEUm8D4y+L2VDnDZ9ZutS00=; b=akQ4C0a1LVJovsBm7g5yRK94UrC7Cc8wchHuFnRupy+L9xJ7EojNjRyEt7F3cTWKEc dN9nyXRy5ADOHP+5/xc73/FueLefZREqT0W17O9bN9MmrCzeuflhiKGH8CUqfmm+ktry DpVj6SuAfo6r7LHIqzrA4k8+4EooHthyTDm0jhxdYelFEuA+5rTE7Pzloc1u6zQNlfRH Yzss+B2WLxSVmEBfRVazv90BS5avy8aVxF8BqqpIxPI77zgCTZN4+WArGlXQibVoaeb1 vYQbN11gCacNDd3A8kh/oHZU3bWc18MD+QbjRNE7TSgK4SblwrfSI18dDSKF53BsPZrE xh8Q== X-Gm-Message-State: AIVw111fvYZJUWpWcN5c2fGEnSlvJXZXYppZm+tmckpILQ7YcjEYcx2L BTv+BXyLQVu+jpn+ X-Received: by 10.84.218.66 with SMTP id f2mr21039521plm.206.1501598076516; Tue, 01 Aug 2017 07:34:36 -0700 (PDT) Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id u184sm51842214pfb.37.2017.08.01.07.34.35 for <27843-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 Aug 2017 07:34:36 -0700 (PDT) From: Tino Calancha To: 27843-done@debbugs.gnu.org Subject: Re: bug#27843: 26.0.50; Dired w/ eshell insert subdirs content when dir-or-list is a cons References: <87bmo6sh1v.fsf@calancha-pc> <83lgn7397y.fsf@gnu.org> Date: Tue, 01 Aug 2017 23:34:29 +0900 In-Reply-To: <83lgn7397y.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 29 Jul 2017 12:04:17 +0300") Message-ID: <87y3r38ih6.fsf@calancha-pc> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 27843-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Eli Zaretskii writes: >> Dired w/ eshell: Don't insert subdirs content if dir-or-list is a cons >> >> * lisp/eshell/em-ls.el (eshell-ls--insert-directory): >> Append '("-d") into 'eshell-ls-dired-initial-args' >> when 'dired-directory' is a cons (Bug#27843). >> * test/lisp/dired-tests.el (dired-test-bug27843): Add test. > > This LGTM, but please rephrase the log summary line to be positive, > not negative. Rephrased log summary as "Insert subdir content if dir-or-list is a string w/o wildcards" and pushed to master as commit f3ad15933a0d104b099d640d5c43fce99ece0003 From unknown Tue Jun 24 14:00:21 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 30 Aug 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator