GNU bug report logs - #27841
25.2; Patch for completion-table-with-predicate

Previous Next

Full log

Message #13 received at 27841 <at> debbugs.gnu.org (full text, mbox):

From: Ryan Thompson <rct <at> thompsonclan.org>
To: npostavs <at> users.sourceforge.net
Cc: 27841 <at> debbugs.gnu.org
Subject: Re: bug#27841: 25.2; Patch for completion-table-with-predicate
Date: Fri, 04 Aug 2017 23:00:16 +0000

[Message part 1 (text/plain, inline)]

Ok, I will reformat them when I get the chance. Would you also like me to
provide an example where the old code does the wrong thing?

On Fri, Aug 4, 2017 at 3:53 PM <npostavs <at> users.sourceforge.net> wrote:

> tags 27841 + patch
> quit
>
> Ryan <rct <at> thompsonclan.org> writes:
>
> > When the pred2 arg to completion-table-with-predicate is nil, it acts
> > like strict is non-nil, even if it isn't. I'm attaching a patch
> > (created with "git format-patch") that
> > fixes the bug.
>
> Looks reasonable, though I'm not very familiar with this code.  The
> commit messages should be reformatted into ChangeLog format, and the
> first one would be better rephrased into present tense.  I'm reattaching
> the patches inline here for convenience.
>
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.