Subject: Re: bug#27841: 25.2; Patch for completion-table-with-predicate

From: Noam Postavsky <[email-masked]>
Date: Tue, 07 Nov 2017 21:30:11 -0500

tags 27841 fixed
close 27841 26.1
quit

[email-masked] writes:

> Ryan Thompson <[email-masked]> writes:
>
>> 	* ../lisp/minibuffer.el (completion-table-with-predicate): Don't
>> 	act as if strict is non-nil when pred2 is nil (Bug#27841).
>> 	* ../test/lisp/minibuffer-tests.el
>> 	(completion-table-with-predicate-test): Add a test for Bug#27841.
>
> I wonder how you ended up with the ../ prefix on the filenames?

>> +(ert-deftest completion-table-with-predicate-test ()
>> +  (cl-letf* ((full-collection

>> +             ((symbol-function 'no-A)
>> +              (lambda (x) (not (string-match-p "a" x))))
>> +             ((symbol-function 'no-B)
>> +              (lambda (x) (not (string-match-p "b" x)))))
>
> It looks to me like things would be simpler with a let instead of
> cl-letf, no?

I fixed the commit message, changed this to let, and pushed to emacs-26.

[1: 255ba01148]: 2017-11-07 21:25:55 -0500
  Fix handling of nil PRED2 arg for completion-table-with-predicate
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=255ba01148f69f452937e67feb7af5d4c1466fed