From unknown Sat Sep 06 17:46:47 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#27828 <27828@debbugs.gnu.org> To: bug#27828 <27828@debbugs.gnu.org> Subject: Status: 25.2; dired-x-hands-off-my-keys unsets remap find-file Reply-To: bug#27828 <27828@debbugs.gnu.org> Date: Sun, 07 Sep 2025 00:46:47 +0000 retitle 27828 25.2; dired-x-hands-off-my-keys unsets remap find-file reassign 27828 emacs submitter 27828 Allen Li severity 27828 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 25 14:52:52 2017 Received: (at submit) by debbugs.gnu.org; 25 Jul 2017 18:52:52 +0000 Received: from localhost ([127.0.0.1]:56289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1da4wu-0005uG-1i for submit@debbugs.gnu.org; Tue, 25 Jul 2017 14:52:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50798) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1da4ws-0005u1-IX for submit@debbugs.gnu.org; Tue, 25 Jul 2017 14:52:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1da4wm-0003uK-OQ for submit@debbugs.gnu.org; Tue, 25 Jul 2017 14:52:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55223) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1da4wm-0003uD-Kj for submit@debbugs.gnu.org; Tue, 25 Jul 2017 14:52:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1da4wl-0007iW-Lq for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2017 14:52:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1da4wk-0003td-Ra for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2017 14:52:43 -0400 Received: from mail-qk0-x234.google.com ([2607:f8b0:400d:c09::234]:36351) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1da4wk-0003tA-MX for bug-gnu-emacs@gnu.org; Tue, 25 Jul 2017 14:52:42 -0400 Received: by mail-qk0-x234.google.com with SMTP id d136so78106199qkg.3 for ; Tue, 25 Jul 2017 11:52:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=nA4+/9dRjKIRNXK3Z0f1THFFbVx1ogvUXqdH0yVx5aw=; b=ovMNpG8JH9p27gtCyoSWTSo8YHSuG2AZE4H7pVMPvqMglc4qOpW8FaipCI+TXUe/Sk L/cgc0sgg/UZC7GBj6lDlEbfHKwORia4fZZzFD0NqfRar6Uz4uk4sYOHdfe1n+uUVEEx yGDeCEuuNTkHrjnSWt8L5B1Mnk2gLDOnEEM1BGoFdiw95GsBZKjo1nL+Z5jKQ5R99Oi7 tO/UXdmFBe0zL00QN+R2CynqVYuwQoTjd3RBQQkHGcqk/KQijjzVAK8WaCHD2pNv23ki tE2HDha8jFHZwN3ObsLFGMtqnNbUlKVkyewYEGhgZtSnSN3Hz7vH26PHvnI7fuvxPoYS x9vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=nA4+/9dRjKIRNXK3Z0f1THFFbVx1ogvUXqdH0yVx5aw=; b=fpViZb6k8eYVR6wfbKneGPFhKXcGb1MHCkmK91pLYz2NtDFn3MXNuo7SR3dk4rWZDu HmYrGvLDtONQ4godbmfxM8HoDdMJBiyJf8+k8D3noY3t5Znpikov/Q8FK5X1d9LvqjhA WxVDHLKaCbdD2/l+dW7XooXnKB1HnozthUrwyvAgA6Zxo6IagltXT4ZvvU0WUs+xqpIe xE6LbfE9xKW1//zjIk45yWRBYH8l5FSEQroG8t8H5HqJLHoiP6eQEPimuO+HSjzbqXzm D5sJcLZNhjBY01vPIqMDlWlZYoJpSTmc9uHMnoD4rlTdsOHVbbO1DiXWNc5z4KUPFgHZ 5FvA== X-Gm-Message-State: AIVw11040R0dDX9eeeol05yzh7pRECioRf0HWLpe+XlryU8woIMjamuy CToeDZXu3YhBJlPeBd/IyaZnRWG9LrhtFuA= X-Received: by 10.55.72.206 with SMTP id v197mr25662277qka.133.1501008760537; Tue, 25 Jul 2017 11:52:40 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.142.67 with HTTP; Tue, 25 Jul 2017 11:52:40 -0700 (PDT) From: Allen Li Date: Tue, 25 Jul 2017 11:52:40 -0700 Message-ID: Subject: 25.2; dired-x-hands-off-my-keys unsets remap find-file To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary="001a114a8cfefa07a2055528d548" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -6.8 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -6.8 (------) --001a114a8cfefa07a2055528d548 Content-Type: text/plain; charset="UTF-8" The user option `dired-x-hands-off-my-keys' implies that dired-x won't touch the users key bindings, but it will actually set [remap find-file] regardless. If I set [remap find-file] personally, `dired-x' will unset it, which contradicts the meaning of "hands off my keys" in English. In GNU Emacs 25.2.1 (x86_64-pc-linux-gnu, GTK+ Version 3.10.8), modified by Debian Windowing system distributor 'The X.Org Foundation', version 11.0.11803000 System Description: Ubuntu 14.04 LTS --001a114a8cfefa07a2055528d548 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
The user option `dired-x-hands-off-my-keys' impli= es that dired-x won't
touch the users key bindings, but it wi= ll actually set [remap find-file]
regardless.

If I set [remap find-file] personally, `dired-x' will unset it, w= hich
contradicts the meaning of "hands off my keys" in = English.

In GNU Emacs 25.2.1 (x86_64-pc-linux-gnu,= GTK+ Version 3.10.8), modified by Debian
Windowing system distri= butor 'The X.Org Foundation', version 11.0.11803000
Syste= m Description: Ubuntu 14.04 LTS

--001a114a8cfefa07a2055528d548-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 26 15:07:42 2017 Received: (at 27828) by debbugs.gnu.org; 26 Jul 2017 19:07:42 +0000 Received: from localhost ([127.0.0.1]:57665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daReo-0006az-Ij for submit@debbugs.gnu.org; Wed, 26 Jul 2017 15:07:42 -0400 Received: from mail-qk0-f178.google.com ([209.85.220.178]:33596) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daRem-0006ak-Ny for 27828@debbugs.gnu.org; Wed, 26 Jul 2017 15:07:41 -0400 Received: by mail-qk0-f178.google.com with SMTP id k2so53143482qkf.0 for <27828@debbugs.gnu.org>; Wed, 26 Jul 2017 12:07:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=2J9/IM96kPkIPCUeCVGQKOTwmcY9mQQyu4FydrKQR4A=; b=t0hXGYmfFZavh8pOub1x17R8Umk32qx01fMCpQb1Vju6A216ET1boNnpnzphKuO+8K vQ+/mEYk887kXCbiQmja/sc1U7oCJcvTUNdQe+zv22u5dkyNJgW5qaFWc4NaZAtLPVRi z1KE6SOtB+dCsEOg38ce0HLM1vipGwWVS3QXjTIunCVyUTzRyTba8F4RlEmWPNOo2t8R v/icAT1R1j1hgoKPmv7N7byXZm8pQp/RyjZed/An+WHKv6m8gsXQ8h2/Hgsj+xilaEqG VXvBuFjn1vbsb0HdUyfeMc6JIkRhmRyWzR4gjOr0fOtR+SB4Cx+Tou8ess1W8qRJRXGs lzvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=2J9/IM96kPkIPCUeCVGQKOTwmcY9mQQyu4FydrKQR4A=; b=Ce0eVbr/rrfVIunKN+mwXjP1L/eiWqTdQD53sX+qgficm7L7DUanI8vR9DwlAdN31t UhzLLlwfXMFgo04ddJT7R0MlwTpvwtLU4C+lyibEFB1CiJldD4azlmIKz7B9IwHCJaUW AylG215gBysIhol3DVkLckkrDDD/rbvP4wAJOOHevY4Yg8oFE/rHG1ax+QgzNRF9cerN kj9gSgQwdleKishqbQuXqEd167OYC1r239uUNY8ZpaeNm4HGGsW9A5tozjIMRgpYlQ+L ifgfUnSgK1W+xujk9nxKBY2FmbN3QSlqsX64QsW6WoO3p5eNb6KjTmiiXCI90XScKJk4 xR4A== X-Gm-Message-State: AIVw112OUkQiVdmaFed+vumpAt3WAop01MlNxbP+ox8hyRnjgIJk4lXb PM22itpVtMbRvU0qL2/sjLQRtdS1k+yyVS0= X-Received: by 10.55.133.69 with SMTP id h66mr2645589qkd.153.1501096055122; Wed, 26 Jul 2017 12:07:35 -0700 (PDT) MIME-Version: 1.0 Received: by 10.12.142.67 with HTTP; Wed, 26 Jul 2017 12:07:34 -0700 (PDT) From: Allen Li Date: Wed, 26 Jul 2017 12:07:34 -0700 Message-ID: Subject: [PATCH] Do not unset user key remaps in dired-x To: 27828@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 27828 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) * lisp/dired-x.el (dired-x-bind-find-file): Don't map any keys if user sets dired-x-hands-off-my-keys. --- lisp/dired-x.el | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/lisp/dired-x.el b/lisp/dired-x.el index 915550991d..1425278bdc 100644 --- a/lisp/dired-x.el +++ b/lisp/dired-x.el @@ -1629,10 +1629,11 @@ Binding direction based on `dired-x-hands-off-my-keys'." (if (called-interactively-p 'interactive) (setq dired-x-hands-off-my-keys (not (y-or-n-p "Bind dired-x-find-file over find-file? ")))) - (define-key (current-global-map) [remap find-file] - (if (not dired-x-hands-off-my-keys) 'dired-x-find-file)) - (define-key (current-global-map) [remap find-file-other-window] - (if (not dired-x-hands-off-my-keys) 'dired-x-find-file-other-window))) + (unless dired-x-hands-off-my-keys + (define-key (current-global-map) [remap find-file] + 'dired-x-find-file) + (define-key (current-global-map) [remap find-file-other-window] + 'dired-x-find-file-other-window))) ;; Now call it so binding is correct. This could go in the :initialize ;; slot, but then dired-x-bind-find-file has to be defined before the -- 2.14.0.rc0.400.g1c36432dff-goog From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 29 05:02:35 2017 Received: (at 27828-done) by debbugs.gnu.org; 29 Jul 2017 09:02:35 +0000 Received: from localhost ([127.0.0.1]:60565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbNdr-0000mA-2P for submit@debbugs.gnu.org; Sat, 29 Jul 2017 05:02:35 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42928) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbNdp-0000ly-Ro for 27828-done@debbugs.gnu.org; Sat, 29 Jul 2017 05:02:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbNdh-00074I-GA for 27828-done@debbugs.gnu.org; Sat, 29 Jul 2017 05:02:28 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55341) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbNdh-00074B-CI; Sat, 29 Jul 2017 05:02:25 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4217 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dbNdg-0006oy-53; Sat, 29 Jul 2017 05:02:24 -0400 Date: Sat, 29 Jul 2017 12:02:15 +0300 Message-Id: <83mv7n39bc.fsf@gnu.org> From: Eli Zaretskii To: Allen Li In-reply-to: (message from Allen Li on Wed, 26 Jul 2017 12:07:34 -0700) Subject: Re: bug#27828: [PATCH] Do not unset user key remaps in dired-x References: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27828-done Cc: 27828-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Allen Li > Date: Wed, 26 Jul 2017 12:07:34 -0700 > > * lisp/dired-x.el (dired-x-bind-find-file): Don't map any keys if user > sets dired-x-hands-off-my-keys. Thanks, pushed. From unknown Sat Sep 06 17:46:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 26 Aug 2017 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator