GNU bug report logs - #27827
[PATCH] gnu: python2-urwid: Actually build urwid for Python 2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27827 in the body.
You can then email your comments to 27827 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kei <at> openmailbox.org>
Subject: [PATCH] gnu: python2-urwid: Actually build urwid for Python 2.
Date: Tue, 25 Jul 2017 14:50:16 -0400

* gnu/packages/python.scm (python2-urwid)[arguments]: Add #:python.
---
 gnu/packages/python.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 89c2de63b..03f813411 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -5871,7 +5871,11 @@ features useful for text console applications.")
       (inherit python2-urwid)
       (arguments
        (append
-        '(#:phases
+        `(;; Explicitly using Python 2 is necessary due the argument list being
+          ;; built from only the 'delete-test_vterm.py' phase and python-urwid's
+          ;; package arguments, which by default assumes the use of Python 3.
+          #:python ,python-2
+          #:phases
           (modify-phases %standard-phases
             ;; Disable the vterm tests because of non-deterministic failures
             ;; with Python 2. See https://github.com/urwid/urwid/issues/230.
-- 
2.13.3

Message #8 received at 27827 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 27827 <at> debbugs.gnu.org
Subject: Re: [bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for
 Python 2.
Date: Tue, 25 Jul 2017 15:21:58 -0400

[Message part 1 (text/plain, inline)]

On Tue, Jul 25, 2017 at 02:50:16PM -0400, Kei Kebreau wrote:
> * gnu/packages/python.scm (python2-urwid)[arguments]: Add #:python.

Good catch! I didn't test this change with `guix gc --references`, but
if that shows the right thing your end, please push!

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 27827-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 27827-done <at> debbugs.gnu.org
Subject: Re: [bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for
 Python 2.
Date: Tue, 25 Jul 2017 15:30:51 -0400

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Tue, Jul 25, 2017 at 02:50:16PM -0400, Kei Kebreau wrote:
>> * gnu/packages/python.scm (python2-urwid)[arguments]: Add #:python.
>
> Good catch! I didn't test this change with `guix gc --references`, but
> if that shows the right thing your end, please push!

Yes, python2-urwid shows up now. Prior to the patch it did not.

Pushed to master! Thanks again for the review.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 27827-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 27827-done <at> debbugs.gnu.org
Subject: Re: [bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for
 Python 2.
Date: Tue, 25 Jul 2017 15:42:50 -0400

[Message part 1 (text/plain, inline)]

On Tue, Jul 25, 2017 at 03:30:51PM -0400, Kei Kebreau wrote:
> Leo Famulari <leo <at> famulari.name> writes:
> 
> > On Tue, Jul 25, 2017 at 02:50:16PM -0400, Kei Kebreau wrote:
> >> * gnu/packages/python.scm (python2-urwid)[arguments]: Add #:python.
> >
> > Good catch! I didn't test this change with `guix gc --references`, but
> > if that shows the right thing your end, please push!
> 
> Yes, python2-urwid shows up now. Prior to the patch it did not.
> 
> Pushed to master! Thanks again for the review.

I just tested it, and it fails to build for me. But, I've noticed the
urwid test suite is pretty flaky. Let's see if it builds on Hydra.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 27827-done <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: Leo Famulari <leo <at> famulari.name>
Cc: 27827-done <at> debbugs.gnu.org
Subject: Re: [bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for
 Python 2.
Date: Wed, 02 Aug 2017 16:45:21 -0400

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Tue, Jul 25, 2017 at 03:30:51PM -0400, Kei Kebreau wrote:
>> Leo Famulari <leo <at> famulari.name> writes:
>> 
>> > On Tue, Jul 25, 2017 at 02:50:16PM -0400, Kei Kebreau wrote:
>> >> * gnu/packages/python.scm (python2-urwid)[arguments]: Add #:python.
>> >
>> > Good catch! I didn't test this change with `guix gc --references`, but
>> > if that shows the right thing your end, please push!
>> 
>> Yes, python2-urwid shows up now. Prior to the patch it did not.
>> 
>> Pushed to master! Thanks again for the review.
>
> I just tested it, and it fails to build for me. But, I've noticed the
> urwid test suite is pretty flaky. Let's see if it builds on Hydra.

I've since updated my system and wicd-curses still works. Does it build
on Hydra? I haven't been able to check because of 504 HTTP response
codes from https://hydra.gnu.org most of the time.

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 27827-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Kei Kebreau <kei <at> openmailbox.org>
Cc: 27827-done <at> debbugs.gnu.org
Subject: Re: [bug#27827] [PATCH] gnu: python2-urwid: Actually build urwid for
 Python 2.
Date: Wed, 2 Aug 2017 18:47:45 -0400

[Message part 1 (text/plain, inline)]

On Wed, Aug 02, 2017 at 04:45:21PM -0400, Kei Kebreau wrote:
> Leo Famulari <leo <at> famulari.name> writes:
> > I just tested it, and it fails to build for me. But, I've noticed the
> > urwid test suite is pretty flaky. Let's see if it builds on Hydra.
> 
> I've since updated my system and wicd-curses still works. Does it build
> on Hydra? I haven't been able to check because of 504 HTTP response
> codes from https://hydra.gnu.org most of the time.

I just got a substitute for it, so it must have worked :)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.