From unknown Sun Jun 22 07:42:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#27791] [PATCH] gnu: Add passmenu Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 22 Jul 2017 12:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27791 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 27791@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.150072697428680 (code B ref -1); Sat, 22 Jul 2017 12:37:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Jul 2017 12:36:14 +0000 Received: from localhost ([127.0.0.1]:51986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYtdm-0007SW-0f for submit@debbugs.gnu.org; Sat, 22 Jul 2017 08:36:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYtdk-0007SK-Ng for submit@debbugs.gnu.org; Sat, 22 Jul 2017 08:36:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYtde-0005j1-Ku for submit@debbugs.gnu.org; Sat, 22 Jul 2017 08:36:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dYtde-0005iu-HC for submit@debbugs.gnu.org; Sat, 22 Jul 2017 08:36:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYtdd-0006Uc-Ec for guix-patches@gnu.org; Sat, 22 Jul 2017 08:36:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYtdc-0005gw-KK for guix-patches@gnu.org; Sat, 22 Jul 2017 08:36:05 -0400 Received: from mail.fsfe.org ([2001:aa8:ffed::3:102]:44763) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dYtdc-0005bA-9y for guix-patches@gnu.org; Sat, 22 Jul 2017 08:36:04 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.fsfe.org (Postfix) with ESMTP id 31F2A63BE5A for ; Sat, 22 Jul 2017 14:36:00 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.fsfe.org Received: from mail.fsfe.org ([127.0.0.1]) by localhost (cavendish.fsfeurope.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 38kMp+GTRIa1 for ; Sat, 22 Jul 2017 14:36:00 +0200 (CEST) Received: by mail-io0-f169.google.com with SMTP id g13so30187932ioj.5 for ; Sat, 22 Jul 2017 05:35:59 -0700 (PDT) X-Gm-Message-State: AIVw110P+EGRq3yQzaH3YoNo+hDuPm7GsLnl2vHUvCfdy1h790SGAdFj ipFnY2tE++7/jqNQC5+mcQmUoOQkaA== X-Received: by 10.107.164.199 with SMTP id d68mr8607174ioj.85.1500726957421; Sat, 22 Jul 2017 05:35:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.175.7 with HTTP; Sat, 22 Jul 2017 05:35:56 -0700 (PDT) From: Jelle Licht Date: Sat, 22 Jul 2017 14:35:56 +0200 X-Gmail-Original-Message-ID: Message-ID: Content-Type: multipart/mixed; boundary="001a11421e5a33e2540554e739f4" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -7.8 (-------) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.8 (-------) --001a11421e5a33e2540554e739f4 Content-Type: multipart/alternative; boundary="001a11421e5a33e2510554e739f2" --001a11421e5a33e2510554e739f2 Content-Type: text/plain; charset="UTF-8" Hello guix, Attached is a patch to include passmenu, a dmenu interface to the pass password store. I was not quite sure how to structure this patch, as it basically installs and wraps a shell script from the `password-store' sources. We could instead include it as a separate output of our `password-store' package, but I already had it like this in my GUIX_PACKAGE_PATH and I was not even sure if that approach was in general preferable. - Jelle --001a11421e5a33e2510554e739f2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello guix,

Attached is a patc= h to include passmenu, a dmenu interface to the pass password store.
I was not quite sure how to structure this patch, as it basically in= stalls and wraps a shell script from the `password-store' sources. We c= ould instead include it as a separate output of our `password-store' pa= ckage, but I already had it like this in my GUIX_PACKAGE_PATH and I was not= even sure if that approach was in general preferable.

- Jelle=
--001a11421e5a33e2510554e739f2-- --001a11421e5a33e2540554e739f4 Content-Type: application/octet-stream; name="0001-gnu-Add-passmenu.patch" Content-Disposition: attachment; filename="0001-gnu-Add-passmenu.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j5fa1vr40 RnJvbSA3ZmVjMGJkODc0NGQyMmY1NWJlY2QzNmM0NjM1ZjM2NWRlMGM2NzZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWxsZSBMaWNodCA8amxpY2h0QGZzZmUub3JnPgpEYXRlOiBT YXQsIDIyIEp1bCAyMDE3IDE0OjIzOjE4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gZ251OiBBZGQg cGFzc21lbnUuCgoqIGdudS9wYWNrYWdlcy9wYXNzd29yZC11dGlscy5zY20gKHBhc3NtZW51KTog TmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9wYXNzd29yZC11dGlscy5zY20gfCAzOCAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDM4 IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvcGFzc3dvcmQtdXRpbHMu c2NtIGIvZ251L3BhY2thZ2VzL3Bhc3N3b3JkLXV0aWxzLnNjbQppbmRleCAwODU5MWQxMDguLjE1 NWU3MTEwYSAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL3Bhc3N3b3JkLXV0aWxzLnNjbQorKysg Yi9nbnUvcGFja2FnZXMvcGFzc3dvcmQtdXRpbHMuc2NtCkBAIC00OCw2ICs0OCw3IEBACiAgICM6 dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIG5jdXJzZXMpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBh Y2thZ2VzIHBrZy1jb25maWcpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHB5dGhvbikK KyAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgc3Vja2xlc3MpCiAgICM6dXNlLW1vZHVsZSAo Z251IHBhY2thZ2VzIHRscykKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgcXQpCiAgICM6 dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHZlcnNpb24tY29udHJvbCkKQEAgLTQ0NiwzICs0NDcs NDAgQEAgdXNlIHBhc3MsIHRoZSBzdGFuZGFyZCB1bml4IHBhc3N3b3JkIG1hbmFnZXIsIGFzIHRo ZSBjcmVkZW50aWFsIGJhY2tlbmQgZm9yCiB5b3VyIGdpdCByZXBvc2l0b3JpZXMuICBUaGlzIGlz IGFjaGlldmVkIGJ5IGV4cGxpY2l0bHkgZGVmaW5pbmcgbWFwcGluZ3MKIGJldHdlZW4gaG9zdHMg YW5kIGVudHJpZXMgaW4gdGhlIHBhc3N3b3JkIHN0b3JlLiIpCiAgICAgKGxpY2Vuc2UgbGljZW5z ZTpsZ3BsMyspKSkKKworKGRlZmluZS1wdWJsaWMgcGFzc21lbnUKKyAgKHBhY2thZ2UKKyAgICAo aW5oZXJpdCBwYXNzd29yZC1zdG9yZSkKKyAgICAobmFtZSAicGFzc21lbnUiKQorICAgIChidWls ZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRzCisgICAgIGAoIzpwaGFz ZXMKKyAgICAgICAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAoZGVs ZXRlICdjb25maWd1cmUpCisgICAgICAgICAoZGVsZXRlICdidWlsZCkKKyAgICAgICAgIChyZXBs YWNlICdpbnN0YWxsCisgICAgICAgICAgIChsYW1iZGEqICgjOmtleSBvdXRwdXRzICM6YWxsb3ct b3RoZXIta2V5cykKKyAgICAgICAgICAgICAobGV0KiAoKG91dCAoYXNzb2MtcmVmIG91dHB1dHMg Im91dCIpKQorICAgICAgICAgICAgICAgICAgICAoYmluIChzdHJpbmctYXBwZW5kIG91dCAiL2Jp biIpKSkKKyAgICAgICAgICAgICAgIChta2Rpci1wIGJpbikKKyAgICAgICAgICAgICAgIChjb3B5 LWZpbGUgImNvbnRyaWIvZG1lbnUvcGFzc21lbnUiCisgICAgICAgICAgICAgICAgICAgICAgICAg IChzdHJpbmctYXBwZW5kIGJpbiAiL3Bhc3NtZW51IikpCisgICAgICAgICAgICAgICAjdCkpKQor ICAgICAgICAgKGFkZC1hZnRlciAnaW5zdGFsbCAnd3JhcC1wYXRoCisgICAgICAgICAgIChsYW1i ZGEqICgjOmtleSBpbnB1dHMgb3V0cHV0cyAjOmFsbG93LW90aGVyLWtleXMpCisgICAgICAgICAg ICAgKGxldCAoKG91dCAoYXNzb2MtcmVmIG91dHB1dHMgIm91dCIpKQorICAgICAgICAgICAgICAg ICAgIChwYXRoIChtYXAgKGxhbWJkYSAocGtnKQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoc3RyaW5nLWFwcGVuZCAoYXNzb2MtcmVmIGlucHV0cyBwa2cpICIvYmluIikpCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAnKCJwYXNzd29yZC1zdG9yZSIgImRtZW51IiAieGRv dG9vbCIpKSkpCisgICAgICAgICAgICAgICAod3JhcC1wcm9ncmFtIChzdHJpbmctYXBwZW5kIG91 dCAiL2Jpbi9wYXNzbWVudSIpCisgICAgICAgICAgICAgICAgIGAoIlBBVEgiICI6IiBwcmVmaXgg KCwoc3RyaW5nLWpvaW4gcGF0aCAiOiIpKSkpCisgICAgICAgICAgICAgICAjdCkpKSkKKyAgICAg ICAjOnRlc3RzPyAjZikpCisgICAgKGlucHV0cworICAgICBgKCgicGFzc3dvcmQtc3RvcmUiICxw YXNzd29yZC1zdG9yZSkKKyAgICAgICAoInhkb3Rvb2wiICx4ZG90b29sKQorICAgICAgICgiZG1l bnUiICxkbWVudSkpKQorICAgIChzeW5vcHNpcyAiU2ltcGxlIGRtZW51IGludGVyZmFjZSB0byB0 aGUgcGFzcyBwYXNzd29yZCBtYW5hZ2VyIikKKyAgICAoZGVzY3JpcHRpb24gInBhc3NtZW51IGFs bG93cyB5b3UgdG8gdXNlIEBjb2Rle2RtZW51fSBhcyBhbiBpbnRlcmZhY2UgdG8KK3lvdXIgQGNv ZGV7cGFzc30gcGFzc3dvcmQgZGF0YS4gIEl0IHN1cHBvcnRzIGludGVncmF0aW9uIHdpdGggYm90 aCBYMTEKK2NsaXBib2FyZCBhbmQgQGNvZGV7eGRvdG9vbH0uIikpKQotLSAKMi4xMy4zCgo= --001a11421e5a33e2540554e739f4-- From unknown Sun Jun 22 07:42:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#27791] [PATCH] gnu: Add passmenu Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 22 Jul 2017 13:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27791 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jelle Licht , 27791@debbugs.gnu.org Received: via spool by 27791-submit@debbugs.gnu.org id=B27791.150072843730897 (code B ref 27791); Sat, 22 Jul 2017 13:01:02 +0000 Received: (at 27791) by debbugs.gnu.org; 22 Jul 2017 13:00:37 +0000 Received: from localhost ([127.0.0.1]:52008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYu1N-00082H-6s for submit@debbugs.gnu.org; Sat, 22 Jul 2017 09:00:37 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:45171) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYu1L-000829-5f for 27791@debbugs.gnu.org; Sat, 22 Jul 2017 09:00:35 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id E22C520792; Sat, 22 Jul 2017 09:00:34 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Sat, 22 Jul 2017 09:00:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=jPn1KUv7FAB7MXKPKpVdibaFoDK0hIrMMmax1rnu3 80=; b=PYb48Ze4u7F/UKCw+JetCbOwSkG9XQ7uo2+r3XMUijhlqNAxxyRa9dsFh WiY7HYzeKcf1Ct69yzQy6F9gLyUa+caZ7iOtGobBsggxbmn0rnLnrpEcjO2rtvJ6 QYdUnHH6/aWSkjsDZYf/iZn2hJS1WfBdgCirzSOw749FYpVpUUSBuayrUDLtSICv kjeej5qxk/AJneZ1xf5GzJu3XZUWRaWR4mFVnLyDw5JdPHtUeAM6Z76M6mtd3gA9 EtFMF+LhRR048YAuMQ8ypq8B1j0vhQpmkdP0/1h5g/2dBjMw/RSd/vdNuz//OWaM AjZSyBXW9XFI+S+jPhMbPkHsGcaYQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=jPn1KUv7FAB7MXKPKp VdibaFoDK0hIrMMmax1rnu380=; b=ZFXPEdvVsiRPH4G42KsOg0rl+ZapTIggt8 x8K9aO7h0C3IIwWcmaRy6MfdQsVVU5SPRCnHasZGpbT3Y9uoNWr1lr5tGNrvoJ2S OBFLyzWNpE3DhcIptHtmZiiFTKuw8TSDfDmhkeayOuZxM4dZVzIB/Ck4urivPZ0t /hcQ8b86p99g/iDmM+Ex/d68Bjs8rXCQuwyuLNHawWowmsLrAc/dvtJ4saqWNW2e A03iezuF+bs+L7HmgST3LGy9fCs7J1G5HBlRiQ7lZoptktdCKIgErD5zn5BL8ifN SHejzM/qEEN2B6MH56tmBkO0pnH0/P8EqSSbC/kStBzSc2PrHdhQ== X-ME-Sender: X-Sasl-enc: ebz3jfXkiyn2+DmZQy/pl8VopAxHg3uOJoNCdtxww7fy 1500728434 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 70E9C241E0; Sat, 22 Jul 2017 09:00:34 -0400 (EDT) From: Marius Bakke In-Reply-To: References: User-Agent: Notmuch/0.24.2 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Sat, 22 Jul 2017 15:00:32 +0200 Message-ID: <87zibw4oen.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Hi Jelle, Jelle Licht writes: > Hello guix, > > Attached is a patch to include passmenu, a dmenu interface to the pass > password store. > > I was not quite sure how to structure this patch, as it basically installs > and wraps a shell script from the `password-store' sources. We could > instead include it as a separate output of our `password-store' package, > but I already had it like this in my GUIX_PACKAGE_PATH and I was not even > sure if that approach was in general preferable. I don't think wrapping it with dmenu in PATH is necessary. Users of this script are expected to have dmenu from before, and may want to use another implementation (e.g. rofi), another version, etc. Can you try to simply add a phase to the normal password-store package that copies this file to out/bin? We can probably avoid the wrapper too by giving it the full path to `xdotool`, e.g.: (substitute "passmenu" (("xdotool") (string-append (assoc-ref inputs "xdotool") "/bin/xdotool"))) Adding 'xdotool' adds ~8MiB to the password-store closure size, so I don't think we need a separate output either. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAllzTHEACgkQoqBt8qM6 VPqCMggAlerDrLkGVmGF0/uo/4cGpAU4wn8qDuPPsYZLVsEIVzzrAIxk7j5qT+86 XiwHcLZW4siORg7P8HnhEVXjBob/7VG6eDRO82M/j3ujLtGr17QHs3Q9XHVbmo5D 6/SMYBSB+Wd7q6N+TXE0QmXt69/cyDvUAxHmi3EVIsR6c00EKv4zgSrgMxwwapfU wrtlDHAKnoHhhxf8uNfV3CFyO2E/LDIt2znd+NflfA6+9D5EEgCnUBepuP/uXN7X x8Q6vLQ1mywnHL4KbDxE/ZPecVP49hFrUsCjQ4+q3fi6VS5QYhc+Wd7yO55N05jt mmHwUH8hFEA7L0tcQ7+pWPw1f3DTVg== =MAXW -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 07:42:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#27791] [PATCH] gnu: Add passmenu Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Oct 2017 13:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27791 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 27791@debbugs.gnu.org, Jelle Licht Received: via spool by 27791-submit@debbugs.gnu.org id=B27791.150816017320182 (code B ref 27791); Mon, 16 Oct 2017 13:23:01 +0000 Received: (at 27791) by debbugs.gnu.org; 16 Oct 2017 13:22:53 +0000 Received: from localhost ([127.0.0.1]:42654 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e45M5-0005FS-1h for submit@debbugs.gnu.org; Mon, 16 Oct 2017 09:22:53 -0400 Received: from hera.aquilenet.fr ([141.255.128.1]:32878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e45M1-0005FJ-Kh for 27791@debbugs.gnu.org; Mon, 16 Oct 2017 09:22:51 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 3BA8BF121; Mon, 16 Oct 2017 15:22:50 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id f37vLtqcm5y1; Mon, 16 Oct 2017 15:22:48 +0200 (CEST) Received: from ribbon (unknown [193.50.110.215]) by hera.aquilenet.fr (Postfix) with ESMTPSA id A2CF6F114; Mon, 16 Oct 2017 15:22:48 +0200 (CEST) From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87zibw4oen.fsf@fastmail.com> Date: Mon, 16 Oct 2017 15:22:47 +0200 In-Reply-To: <87zibw4oen.fsf@fastmail.com> (Marius Bakke's message of "Sat, 22 Jul 2017 15:00:32 +0200") Message-ID: <87tvyzcjmg.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hi Jelle, Is anything holding this back? https://bugs.gnu.org/27791 TIA! :-) Ludo=E2=80=99. Marius Bakke skribis: > Hi Jelle, > > Jelle Licht writes: > >> Hello guix, >> >> Attached is a patch to include passmenu, a dmenu interface to the pass >> password store. >> >> I was not quite sure how to structure this patch, as it basically instal= ls >> and wraps a shell script from the `password-store' sources. We could >> instead include it as a separate output of our `password-store' package, >> but I already had it like this in my GUIX_PACKAGE_PATH and I was not even >> sure if that approach was in general preferable. > > I don't think wrapping it with dmenu in PATH is necessary. Users of this > script are expected to have dmenu from before, and may want to use > another implementation (e.g. rofi), another version, etc. > > Can you try to simply add a phase to the normal password-store package > that copies this file to out/bin? We can probably avoid the wrapper too > by giving it the full path to `xdotool`, e.g.: > > (substitute "passmenu" > (("xdotool") (string-append (assoc-ref inputs "xdotool") > "/bin/xdotool"))) > > Adding 'xdotool' adds ~8MiB to the password-store closure size, so I > don't think we need a separate output either. > > Thanks! From unknown Sun Jun 22 07:42:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#27791] [PATCH] gnu: Add passmenu Resent-From: Jelle Licht Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Oct 2017 14:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27791 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27791@debbugs.gnu.org, Marius Bakke , Jelle Licht Received: via spool by 27791-submit@debbugs.gnu.org id=B27791.150816273232491 (code B ref 27791); Mon, 16 Oct 2017 14:06:02 +0000 Received: (at 27791) by debbugs.gnu.org; 16 Oct 2017 14:05:32 +0000 Received: from localhost ([127.0.0.1]:43923 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e461L-0008Ry-Sz for submit@debbugs.gnu.org; Mon, 16 Oct 2017 10:05:32 -0400 Received: from mail.fsfe.org ([217.69.89.162]:50686) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e461K-0008Rl-Fu for 27791@debbugs.gnu.org; Mon, 16 Oct 2017 10:05:31 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.fsfe.org (Postfix) with ESMTP id 3FF456393A2; Mon, 16 Oct 2017 16:05:24 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.fsfe.org Received: from mail.fsfe.org ([127.0.0.1]) by localhost (cavendish.fsfeurope.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jYgQ9UA5Cjup; Mon, 16 Oct 2017 16:05:24 +0200 (CEST) References: <87zibw4oen.fsf@fastmail.com> <87tvyzcjmg.fsf@gnu.org> From: Jelle Licht In-reply-to: <87tvyzcjmg.fsf@gnu.org> Date: Mon, 16 Oct 2017 16:05:22 +0200 Message-ID: <87shejmbml.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Ludovic Courtès writes: > Hi Jelle, > > Is anything holding this back? > > https://bugs.gnu.org/27791 It just fell through the cracks, thanks for reminding me :-). I still needed to address some of Marius' concerns though... > > TIA! :-) > > Ludo’. > > Marius Bakke skribis: > >> Hi Jelle, >> >> Jelle Licht writes: >> >>> Hello guix, >>> >>> Attached is a patch to include passmenu, a dmenu interface to the pass >>> password store. >>> >>> I was not quite sure how to structure this patch, as it basically installs >>> and wraps a shell script from the `password-store' sources. We could >>> instead include it as a separate output of our `password-store' package, >>> but I already had it like this in my GUIX_PACKAGE_PATH and I was not even >>> sure if that approach was in general preferable. >> >> I don't think wrapping it with dmenu in PATH is necessary. Users of this >> script are expected to have dmenu from before, and may want to use >> another implementation (e.g. rofi), another version, etc. While I agree with your general thoughts, wasn't guix supposed to prevent this ad-hoc mishmash of software? If someone wants to use another implementation (e.g. rofi), they could just create their own package that inherits from `password-store' and overrides the "dmenu" input. Case in point, I am not currently a user of dmenu (besides indirectly through the passmenu script). If people still see Marius' proposed solution as preferable, I am also okay with that. >> >> Can you try to simply add a phase to the normal password-store package >> that copies this file to out/bin? We can probably avoid the wrapper too >> by giving it the full path to `xdotool`, e.g.: >> >> (substitute "passmenu" >> (("xdotool") (string-append (assoc-ref inputs "xdotool") >> "/bin/xdotool"))) This seems nicer indeed. >> >> Adding 'xdotool' adds ~8MiB to the password-store closure size, so I >> don't think we need a separate output either. Fair enough. >> >> Thanks! Thank you for the review. From unknown Sun Jun 22 07:42:30 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#27791] [PATCH] gnu: Add passmenu Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 16 Oct 2017 22:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27791 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Jelle Licht , Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 27791@debbugs.gnu.org, Jelle Licht Received: via spool by 27791-submit@debbugs.gnu.org id=B27791.150819180328808 (code B ref 27791); Mon, 16 Oct 2017 22:11:02 +0000 Received: (at 27791) by debbugs.gnu.org; 16 Oct 2017 22:10:03 +0000 Received: from localhost ([127.0.0.1]:44385 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4DaE-0007UY-Co for submit@debbugs.gnu.org; Mon, 16 Oct 2017 18:10:02 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:58615) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4DaD-0007UF-7J for 27791@debbugs.gnu.org; Mon, 16 Oct 2017 18:10:01 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 2FB3720BCD; Mon, 16 Oct 2017 18:09:59 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Mon, 16 Oct 2017 18:09:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=4311LLY5Kpgz54WxbtjIz9bHZRGm+R7qQgDpnma5DkY=; b=Epf4yh/h AakmLkKmex+856cA/ko78hqUPhlPkSjMbtBmZ8PuL4jg6+dXdTu0Rj8eAPiOwo6C nOYRuDEhux1gAmR74R4ji/g0voXHfb92lNJEIIFxBpV1Aa9OKWvQLsAn79zevIeA usHAHxJZ9OQJZuOi2reODrtT3+bT3WNXJT7l3Kw/ngdfLgsmC/NB+MxO+RILO9Ux 8UN5ug1QAna1Bb4HUSQjJq4TZoNJOHSJm8nGF9os9WVlD8gdXaBkzo+h45TGZlss NsAMc384aUDuOn6uhkDgGT5r8vmIvTdVQXeeqbUCCBEDUijNp4VeXfkcoCH4kJ/c OztAcRMthi12AQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=4311LLY5Kpgz54WxbtjIz9bHZRGm+ R7qQgDpnma5DkY=; b=ZkjqWnTAZtUak5rH9Q/Lg385y1g2X61kfGZJ2aDfcDLA+ PuZOyAZcK2M5rkiAqbiIbXaW+c7jzIVk2id9s421VKBLVBbeT7aBcGYjBvLhMU3V 4hcaWImsC5wfbKcDg91Ot1RFg8SGG7shsXXo79Qa8OBc+yYWIy6jI9PIGdOYmjUL EyktCXtMJ7IrEhTV95NDk9sw5Y6nAbd6DpWThrC4g5yky0YofIq64zzpksYP7WCo ccBsIDt4QOWzlDC3IcxtJzXnyIh6jzGyZuGfGX32CMESaHwPwCB4ydd5mdEwBxSL rgaOR73Q6U0w7tqWvb3s+hu/X1DDrar4s1XFkQvTg== X-ME-Sender: Received: from localhost (cm-84.214.173.174.getinternet.no [84.214.173.174]) by mail.messagingengine.com (Postfix) with ESMTPA id AD88E7E3DC; Mon, 16 Oct 2017 18:09:58 -0400 (EDT) From: Marius Bakke In-Reply-To: <87shejmbml.fsf@fsfe.org> References: <87zibw4oen.fsf@fastmail.com> <87tvyzcjmg.fsf@gnu.org> <87shejmbml.fsf@fsfe.org> User-Agent: Notmuch/0.25.1 (https://notmuchmail.org) Emacs/25.3.1 (x86_64-pc-linux-gnu) Date: Tue, 17 Oct 2017 00:09:56 +0200 Message-ID: <87efq27nij.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Jelle Licht writes: > Ludovic =?UTF-8?Q?Court=C3=A8s?= writes: > >> Hi Jelle, >> >> Is anything holding this back? >> >> https://bugs.gnu.org/27791 > > It just fell through the cracks, thanks for reminding me :-). > I still needed to address some of Marius' concerns though... > >> >> TIA! :-) >> >> =?UTF-8?Q?Ludo=E2=80=99.?= >> >> Marius Bakke skribis: >> >>> Hi Jelle, >>> >>> Jelle Licht writes: >>> >>>> Hello guix, >>>> >>>> Attached is a patch to include passmenu, a dmenu interface to the pass >>>> password store. >>>> >>>> I was not quite sure how to structure this patch, as it basically installs >>>> and wraps a shell script from the `password-store' sources. We could >>>> instead include it as a separate output of our `password-store' package, >>>> but I already had it like this in my GUIX_PACKAGE_PATH and I was not even >>>> sure if that approach was in general preferable. >>> >>> I don't think wrapping it with dmenu in PATH is necessary. Users of this >>> script are expected to have dmenu from before, and may want to use >>> another implementation (e.g. rofi), another version, etc. > > While I agree with your general thoughts, wasn't guix supposed to > prevent this ad-hoc mishmash of software? If someone wants to use > another implementation (e.g. rofi), they could just create their own > package that inherits from `password-store' and overrides the "dmenu" > input. Case in point, I am not currently a user of dmenu (besides > indirectly through the passmenu script). [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [66.111.4.28 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (mbakke[at]fastmail.com) -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [66.111.4.28 listed in wl.mailspike.net] 2.2 THIS_AD "This ad" and variants 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Jelle Licht writes: > Ludovic =?UTF-8?Q?Court=C3=A8s?= writes: > >> Hi Jelle, >> >> Is anything holding this back? >> >> https://bugs.gnu.org/27791 > > It just fell through the cracks, thanks for reminding me :-). > I still needed to address some of Marius' concerns though... > >> >> TIA! :-) >> >> =?UTF-8?Q?Ludo=E2=80=99.?= >> >> Marius Bakke skribis: >> >>> Hi Jelle, >>> >>> Jelle Licht writes: >>> >>>> Hello guix, >>>> >>>> Attached is a patch to include passmenu, a dmenu interface to the pass >>>> password store. >>>> >>>> I was not quite sure how to structure this patch, as it basically installs >>>> and wraps a shell script from the `password-store' sources. We could >>>> instead include it as a separate output of our `password-store' package, >>>> but I already had it like this in my GUIX_PACKAGE_PATH and I was not even >>>> sure if that approach was in general preferable. >>> >>> I don't think wrapping it with dmenu in PATH is necessary. Users of this >>> script are expected to have dmenu from before, and may want to use >>> another implementation (e.g. rofi), another version, etc. > > While I agree with your general thoughts, wasn't guix supposed to > prevent this ad-hoc mishmash of software? If someone wants to use > another implementation (e.g. rofi), they could just create their own > package that inherits from `password-store' and overrides the "dmenu" > input. Case in point, I am not currently a user of dmenu (besides > indirectly through the passmenu script). [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [66.111.4.28 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [66.111.4.28 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (mbakke[at]fastmail.com) 2.2 THIS_AD "This ad" and variants 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Jelle Licht writes: > Ludovic Court=C3=A8s writes: > >> Hi Jelle, >> >> Is anything holding this back? >> >> https://bugs.gnu.org/27791 > > It just fell through the cracks, thanks for reminding me :-). > I still needed to address some of Marius' concerns though... > >> >> TIA! :-) >> >> Ludo=E2=80=99. >> >> Marius Bakke skribis: >> >>> Hi Jelle, >>> >>> Jelle Licht writes: >>> >>>> Hello guix, >>>> >>>> Attached is a patch to include passmenu, a dmenu interface to the pass >>>> password store. >>>> >>>> I was not quite sure how to structure this patch, as it basically inst= alls >>>> and wraps a shell script from the `password-store' sources. We could >>>> instead include it as a separate output of our `password-store' packag= e, >>>> but I already had it like this in my GUIX_PACKAGE_PATH and I was not e= ven >>>> sure if that approach was in general preferable. >>> >>> I don't think wrapping it with dmenu in PATH is necessary. Users of this >>> script are expected to have dmenu from before, and may want to use >>> another implementation (e.g. rofi), another version, etc. > > While I agree with your general thoughts, wasn't guix supposed to > prevent this ad-hoc mishmash of software? If someone wants to use > another implementation (e.g. rofi), they could just create their own > package that inherits from `password-store' and overrides the "dmenu" > input. Case in point, I am not currently a user of dmenu (besides > indirectly through the passmenu script). In the "rofi" case it would be overriding dmenu and providing some extra command-line arguments, but overall I agree with you and don't really have a strong opinion. To my knowledge there is no established policy for when to allow "impurities" (aka unqualified paths), but optional dependencies often get a free pass. I'm happy either way, so do what you think is best :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlnlLjUACgkQoqBt8qM6 VPpIoQf9F3Wb2X/gS1dQ/Uq/QiQS1IS3n0NcAfTHW29+P+moAp2c/pQFbkQB/o/A hJoX/+brzhLV+U096cfBcpWwWLxydWhyWhiGej40TZ2JZETZk1/oqCQYUrV2D5U9 g2Kz44XlWdQaUA6qnn88har69QG5bKRwKlTqeFolPhh00VGFaiXxHyVWps9GPtIx TxrpK3GLmmVUrLqZy0O2IOl+EGvajEKKwnhF8fnqdMhzCrLEaUk7cvEjUc9nKLdj o0Qnw2UowjkgsEKvHF4cnRIJtJRXTjoW+H41cy753ilksQi6KM9oYDitff2RUKc4 vtF8KmcblVLlHPDDncUy4iZqYfZRLw== =WFwq -----END PGP SIGNATURE----- --=-=-=-- From unknown Sun Jun 22 07:42:30 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jelle Licht Subject: bug#27791: closed (Re: [bug#27791] [PATCH] gnu: Add passmenu) Message-ID: References: <87r2t69ran.fsf@fsfe.org> X-Gnu-PR-Message: they-closed 27791 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 27791@debbugs.gnu.org Date: Fri, 10 Nov 2017 13:51:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1510321861-7517-1" This is a multi-part message in MIME format... ------------=_1510321861-7517-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #27791: [PATCH] gnu: Add passmenu which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 27791@debbugs.gnu.org. --=20 27791: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D27791 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1510321861-7517-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 27791-done) by debbugs.gnu.org; 10 Nov 2017 13:50:20 +0000 Received: from localhost ([127.0.0.1]:33357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD9hL-0001wK-LP for submit@debbugs.gnu.org; Fri, 10 Nov 2017 08:50:19 -0500 Received: from mail.fsfe.org ([217.69.89.162]:48254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eD9hJ-0001w7-MG for 27791-done@debbugs.gnu.org; Fri, 10 Nov 2017 08:50:18 -0500 Received: from localhost (localhost [127.0.0.1]) by mail.fsfe.org (Postfix) with ESMTP id 7F33763D2B8; Fri, 10 Nov 2017 14:50:11 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at mail.fsfe.org Received: from mail.fsfe.org ([127.0.0.1]) by localhost (cavendish.fsfeurope.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Vh7bH9HFVEAV; Fri, 10 Nov 2017 14:50:11 +0100 (CET) References: <87zibw4oen.fsf@fastmail.com> <87tvyzcjmg.fsf@gnu.org> <87shejmbml.fsf@fsfe.org> <87efq27nij.fsf@fastmail.com> From: Jelle Licht To: 27791-done@debbugs.gnu.org Subject: Re: [bug#27791] [PATCH] gnu: Add passmenu In-reply-to: <87efq27nij.fsf@fastmail.com> Date: Fri, 10 Nov 2017 14:50:08 +0100 Message-ID: <87r2t69ran.fsf@fsfe.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27791-done Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , Jelle Licht , Marius Bakke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) In the end, I simply added dmenu to the list of `inputs' and replaced my calls to `wrap-program' with a `substitute*' call. Pushed as 177475cfb5 to master. Someone wanting to make use of an alternative to dmenu could just inherit from `password-store' in order to override the relevant inputs and/or phases. The closure size of password-store went from ~421MB to ~440MB, but as it is not a dependency of any non-password-store related items, this should not be a big problem. Thanks again for the guidance and reminders. Marius Bakke writes: > Jelle Licht writes: > >> Ludovic Courtès writes: >> >>> Hi Jelle, >>> >>> Is anything holding this back? >>> >>> https://bugs.gnu.org/27791 >> >> It just fell through the cracks, thanks for reminding me :-). >> I still needed to address some of Marius' concerns though... >> >>> >>> TIA! :-) >>> >>> Ludo’. >>> >>> Marius Bakke skribis: >>> >>>> Hi Jelle, >>>> >>>> Jelle Licht writes: >>>> >>>>> Hello guix, >>>>> >>>>> Attached is a patch to include passmenu, a dmenu interface to the pass >>>>> password store. >>>>> >>>>> I was not quite sure how to structure this patch, as it basically installs >>>>> and wraps a shell script from the `password-store' sources. We could >>>>> instead include it as a separate output of our `password-store' package, >>>>> but I already had it like this in my GUIX_PACKAGE_PATH and I was not even >>>>> sure if that approach was in general preferable. >>>> >>>> I don't think wrapping it with dmenu in PATH is necessary. Users of this >>>> script are expected to have dmenu from before, and may want to use >>>> another implementation (e.g. rofi), another version, etc. >> >> While I agree with your general thoughts, wasn't guix supposed to >> prevent this ad-hoc mishmash of software? If someone wants to use >> another implementation (e.g. rofi), they could just create their own >> package that inherits from `password-store' and overrides the "dmenu" >> input. Case in point, I am not currently a user of dmenu (besides >> indirectly through the passmenu script). > > In the "rofi" case it would be overriding dmenu and providing some extra > command-line arguments, but overall I agree with you and don't really > have a strong opinion. To my knowledge there is no established policy > for when to allow "impurities" (aka unqualified paths), but optional > dependencies often get a free pass. > > I'm happy either way, so do what you think is best :) ------------=_1510321861-7517-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Jul 2017 12:36:14 +0000 Received: from localhost ([127.0.0.1]:51986 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYtdm-0007SW-0f for submit@debbugs.gnu.org; Sat, 22 Jul 2017 08:36:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:44716) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYtdk-0007SK-Ng for submit@debbugs.gnu.org; Sat, 22 Jul 2017 08:36:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYtde-0005j1-Ku for submit@debbugs.gnu.org; Sat, 22 Jul 2017 08:36:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,HTML_MESSAGE autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dYtde-0005iu-HC for submit@debbugs.gnu.org; Sat, 22 Jul 2017 08:36:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYtdd-0006Uc-Ec for guix-patches@gnu.org; Sat, 22 Jul 2017 08:36:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYtdc-0005gw-KK for guix-patches@gnu.org; Sat, 22 Jul 2017 08:36:05 -0400 Received: from mail.fsfe.org ([2001:aa8:ffed::3:102]:44763) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dYtdc-0005bA-9y for guix-patches@gnu.org; Sat, 22 Jul 2017 08:36:04 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.fsfe.org (Postfix) with ESMTP id 31F2A63BE5A for ; Sat, 22 Jul 2017 14:36:00 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail.fsfe.org Received: from mail.fsfe.org ([127.0.0.1]) by localhost (cavendish.fsfeurope.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 38kMp+GTRIa1 for ; Sat, 22 Jul 2017 14:36:00 +0200 (CEST) Received: by mail-io0-f169.google.com with SMTP id g13so30187932ioj.5 for ; Sat, 22 Jul 2017 05:35:59 -0700 (PDT) X-Gm-Message-State: AIVw110P+EGRq3yQzaH3YoNo+hDuPm7GsLnl2vHUvCfdy1h790SGAdFj ipFnY2tE++7/jqNQC5+mcQmUoOQkaA== X-Received: by 10.107.164.199 with SMTP id d68mr8607174ioj.85.1500726957421; Sat, 22 Jul 2017 05:35:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.175.7 with HTTP; Sat, 22 Jul 2017 05:35:56 -0700 (PDT) From: Jelle Licht Date: Sat, 22 Jul 2017 14:35:56 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: [PATCH] gnu: Add passmenu To: guix-patches@gnu.org Content-Type: multipart/mixed; boundary="001a11421e5a33e2540554e739f4" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -7.8 (-------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.8 (-------) --001a11421e5a33e2540554e739f4 Content-Type: multipart/alternative; boundary="001a11421e5a33e2510554e739f2" --001a11421e5a33e2510554e739f2 Content-Type: text/plain; charset="UTF-8" Hello guix, Attached is a patch to include passmenu, a dmenu interface to the pass password store. I was not quite sure how to structure this patch, as it basically installs and wraps a shell script from the `password-store' sources. We could instead include it as a separate output of our `password-store' package, but I already had it like this in my GUIX_PACKAGE_PATH and I was not even sure if that approach was in general preferable. - Jelle --001a11421e5a33e2510554e739f2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello guix,

Attached is a patc= h to include passmenu, a dmenu interface to the pass password store.
I was not quite sure how to structure this patch, as it basically in= stalls and wraps a shell script from the `password-store' sources. We c= ould instead include it as a separate output of our `password-store' pa= ckage, but I already had it like this in my GUIX_PACKAGE_PATH and I was not= even sure if that approach was in general preferable.

- Jelle=
--001a11421e5a33e2510554e739f2-- --001a11421e5a33e2540554e739f4 Content-Type: application/octet-stream; name="0001-gnu-Add-passmenu.patch" Content-Disposition: attachment; filename="0001-gnu-Add-passmenu.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j5fa1vr40 RnJvbSA3ZmVjMGJkODc0NGQyMmY1NWJlY2QzNmM0NjM1ZjM2NWRlMGM2NzZlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKZWxsZSBMaWNodCA8amxpY2h0QGZzZmUub3JnPgpEYXRlOiBT YXQsIDIyIEp1bCAyMDE3IDE0OjIzOjE4ICswMjAwClN1YmplY3Q6IFtQQVRDSF0gZ251OiBBZGQg cGFzc21lbnUuCgoqIGdudS9wYWNrYWdlcy9wYXNzd29yZC11dGlscy5zY20gKHBhc3NtZW51KTog TmV3IHZhcmlhYmxlLgotLS0KIGdudS9wYWNrYWdlcy9wYXNzd29yZC11dGlscy5zY20gfCAzOCAr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDM4 IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9nbnUvcGFja2FnZXMvcGFzc3dvcmQtdXRpbHMu c2NtIGIvZ251L3BhY2thZ2VzL3Bhc3N3b3JkLXV0aWxzLnNjbQppbmRleCAwODU5MWQxMDguLjE1 NWU3MTEwYSAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL3Bhc3N3b3JkLXV0aWxzLnNjbQorKysg Yi9nbnUvcGFja2FnZXMvcGFzc3dvcmQtdXRpbHMuc2NtCkBAIC00OCw2ICs0OCw3IEBACiAgICM6 dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIG5jdXJzZXMpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBh Y2thZ2VzIHBrZy1jb25maWcpCiAgICM6dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHB5dGhvbikK KyAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgc3Vja2xlc3MpCiAgICM6dXNlLW1vZHVsZSAo Z251IHBhY2thZ2VzIHRscykKICAgIzp1c2UtbW9kdWxlIChnbnUgcGFja2FnZXMgcXQpCiAgICM6 dXNlLW1vZHVsZSAoZ251IHBhY2thZ2VzIHZlcnNpb24tY29udHJvbCkKQEAgLTQ0NiwzICs0NDcs NDAgQEAgdXNlIHBhc3MsIHRoZSBzdGFuZGFyZCB1bml4IHBhc3N3b3JkIG1hbmFnZXIsIGFzIHRo ZSBjcmVkZW50aWFsIGJhY2tlbmQgZm9yCiB5b3VyIGdpdCByZXBvc2l0b3JpZXMuICBUaGlzIGlz IGFjaGlldmVkIGJ5IGV4cGxpY2l0bHkgZGVmaW5pbmcgbWFwcGluZ3MKIGJldHdlZW4gaG9zdHMg YW5kIGVudHJpZXMgaW4gdGhlIHBhc3N3b3JkIHN0b3JlLiIpCiAgICAgKGxpY2Vuc2UgbGljZW5z ZTpsZ3BsMyspKSkKKworKGRlZmluZS1wdWJsaWMgcGFzc21lbnUKKyAgKHBhY2thZ2UKKyAgICAo aW5oZXJpdCBwYXNzd29yZC1zdG9yZSkKKyAgICAobmFtZSAicGFzc21lbnUiKQorICAgIChidWls ZC1zeXN0ZW0gZ251LWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRzCisgICAgIGAoIzpwaGFz ZXMKKyAgICAgICAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAoZGVs ZXRlICdjb25maWd1cmUpCisgICAgICAgICAoZGVsZXRlICdidWlsZCkKKyAgICAgICAgIChyZXBs YWNlICdpbnN0YWxsCisgICAgICAgICAgIChsYW1iZGEqICgjOmtleSBvdXRwdXRzICM6YWxsb3ct b3RoZXIta2V5cykKKyAgICAgICAgICAgICAobGV0KiAoKG91dCAoYXNzb2MtcmVmIG91dHB1dHMg Im91dCIpKQorICAgICAgICAgICAgICAgICAgICAoYmluIChzdHJpbmctYXBwZW5kIG91dCAiL2Jp biIpKSkKKyAgICAgICAgICAgICAgIChta2Rpci1wIGJpbikKKyAgICAgICAgICAgICAgIChjb3B5 LWZpbGUgImNvbnRyaWIvZG1lbnUvcGFzc21lbnUiCisgICAgICAgICAgICAgICAgICAgICAgICAg IChzdHJpbmctYXBwZW5kIGJpbiAiL3Bhc3NtZW51IikpCisgICAgICAgICAgICAgICAjdCkpKQor ICAgICAgICAgKGFkZC1hZnRlciAnaW5zdGFsbCAnd3JhcC1wYXRoCisgICAgICAgICAgIChsYW1i ZGEqICgjOmtleSBpbnB1dHMgb3V0cHV0cyAjOmFsbG93LW90aGVyLWtleXMpCisgICAgICAgICAg ICAgKGxldCAoKG91dCAoYXNzb2MtcmVmIG91dHB1dHMgIm91dCIpKQorICAgICAgICAgICAgICAg ICAgIChwYXRoIChtYXAgKGxhbWJkYSAocGtnKQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAoc3RyaW5nLWFwcGVuZCAoYXNzb2MtcmVmIGlucHV0cyBwa2cpICIvYmluIikpCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAnKCJwYXNzd29yZC1zdG9yZSIgImRtZW51IiAieGRv dG9vbCIpKSkpCisgICAgICAgICAgICAgICAod3JhcC1wcm9ncmFtIChzdHJpbmctYXBwZW5kIG91 dCAiL2Jpbi9wYXNzbWVudSIpCisgICAgICAgICAgICAgICAgIGAoIlBBVEgiICI6IiBwcmVmaXgg KCwoc3RyaW5nLWpvaW4gcGF0aCAiOiIpKSkpCisgICAgICAgICAgICAgICAjdCkpKSkKKyAgICAg ICAjOnRlc3RzPyAjZikpCisgICAgKGlucHV0cworICAgICBgKCgicGFzc3dvcmQtc3RvcmUiICxw YXNzd29yZC1zdG9yZSkKKyAgICAgICAoInhkb3Rvb2wiICx4ZG90b29sKQorICAgICAgICgiZG1l bnUiICxkbWVudSkpKQorICAgIChzeW5vcHNpcyAiU2ltcGxlIGRtZW51IGludGVyZmFjZSB0byB0 aGUgcGFzcyBwYXNzd29yZCBtYW5hZ2VyIikKKyAgICAoZGVzY3JpcHRpb24gInBhc3NtZW51IGFs bG93cyB5b3UgdG8gdXNlIEBjb2Rle2RtZW51fSBhcyBhbiBpbnRlcmZhY2UgdG8KK3lvdXIgQGNv ZGV7cGFzc30gcGFzc3dvcmQgZGF0YS4gIEl0IHN1cHBvcnRzIGludGVncmF0aW9uIHdpdGggYm90 aCBYMTEKK2NsaXBib2FyZCBhbmQgQGNvZGV7eGRvdG9vbH0uIikpKQotLSAKMi4xMy4zCgo= --001a11421e5a33e2540554e739f4-- ------------=_1510321861-7517-1--