From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 21 16:20:19 2017 Received: (at submit) by debbugs.gnu.org; 21 Jul 2017 20:20:19 +0000 Received: from localhost ([127.0.0.1]:51557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYePJ-00011s-6I for submit@debbugs.gnu.org; Fri, 21 Jul 2017 16:20:19 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37876) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYeHd-0000q5-EY for submit@debbugs.gnu.org; Fri, 21 Jul 2017 16:12:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYeHX-0002rS-7I for submit@debbugs.gnu.org; Fri, 21 Jul 2017 16:12:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:56129) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dYeHX-0002rO-4H for submit@debbugs.gnu.org; Fri, 21 Jul 2017 16:12:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYeHW-0005HZ-27 for guix-patches@gnu.org; Fri, 21 Jul 2017 16:12:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYeHS-0002qg-1c for guix-patches@gnu.org; Fri, 21 Jul 2017 16:12:14 -0400 Received: from mail-pg0-x22d.google.com ([2607:f8b0:400e:c05::22d]:38829) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dYeHR-0002qS-QX for guix-patches@gnu.org; Fri, 21 Jul 2017 16:12:09 -0400 Received: by mail-pg0-x22d.google.com with SMTP id s4so32673423pgr.5 for ; Fri, 21 Jul 2017 13:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=gp8fzQZqHbFobUVpjtoHLefnjySw0RJmCga2N0ysPjA=; b=How0ZMJnGsp35nw9elSEeYki6yts2kVbeVL88nOc3Ds2ah0jjCxlBO0e77iOCZpn8s uLqONwKaqck5CuTtQFmBs/1LouhCDaN3k8kO0QszMHhHniEBBOesHT0e4jybEkD+Jqvk jmbx8arhFrD6A0q/TqNKd7AQxJMkHlI8WYhxlT2n+XjguO6PCXX2FXo+CMQO77cSJg/Z zdG0DjL7rqz+MhxrRG5f3Szn+uBtsrrgK3AuWcwzXHDu9RsUCOqVHlLUZe6fb9DQ0Js7 4nb5NdAAs7ROZU9wc+kNx085ubvBPeS8jMStOnIA063cjMAE9g1FXSMJQwQyMqahOnkk NHSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=gp8fzQZqHbFobUVpjtoHLefnjySw0RJmCga2N0ysPjA=; b=uN8W+4RWeeuoIUCx8KcIub51L+bQ3ihrD8bHFbAnyiaIiar+JpwpvcNRqqs85rdT18 GUEvrjdToINHDIg/rLw3J6cogJoGub4vOzffEk3MCSbpAWOI5Ews/nC8Q6vUvVUU2F4L MtETc+DJBQvMmjXFreaWBqKYVk8LrnYFizTxR4XNYAtc+4TXC10p4KDWPZaLPuUMmpXk uw7nCujmpJ8cV5+rjSOEYvGxgojQuPNHFihHY6dsFjL24nCkpW9DsJD1+6erxFYnjLgN keiNGsVLBxpqL2cpmwEmPe49YrwTrU/1hV7CQfzQhdeVo97jQNqwIRi9C92rfyRvx+J5 FapA== X-Gm-Message-State: AIVw1112NjZlT9927ZlLREOURNUoURVK5LAAjqbVyzTcXUPeEHAe5Dfv qom86aYqurYpCkIW X-Received: by 10.99.39.69 with SMTP id n66mr8503822pgn.94.1500667927224; Fri, 21 Jul 2017 13:12:07 -0700 (PDT) Received: from localhost.localdomain (c-71-236-204-34.hsd1.wa.comcast.net. [71.236.204.34]) by smtp.googlemail.com with ESMTPSA id q13sm12892005pgn.48.2017.07.21.13.12.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 21 Jul 2017 13:12:06 -0700 (PDT) From: Ryan Moe To: guix-patches@gnu.org Subject: [PATCH] gnu: quassel: Enable SSL Date: Fri, 21 Jul 2017 13:12:01 -0700 Message-Id: <20170721201201.17846-1-ryan.moe@gmail.com> X-Mailer: git-send-email 2.13.3 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 21 Jul 2017 16:20:16 -0400 Cc: Ryan Moe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This allows quasselclient to connect to SSL-enabled quasselcore instances. * gnu/packages/patches/quassel-fix-ssl-check.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/irc.scm (quassel)[arguments]: Use it. --- gnu/local.mk | 1 + gnu/packages/irc.scm | 3 ++- gnu/packages/patches/quassel-fix-ssl-check.patch | 21 +++++++++++++++++++++ 3 files changed, 24 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/quassel-fix-ssl-check.patch diff --git a/gnu/local.mk b/gnu/local.mk index 6d9e57062..f1f343b86 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -984,6 +984,7 @@ dist_patch_DATA = \ %D%/packages/patches/qt4-ldflags.patch \ %D%/packages/patches/qtscript-disable-tests.patch \ %D%/packages/patches/quagga-reproducible-build.patch \ + %D%/packages/patches/quassel-fix-ssl-check.patch \ %D%/packages/patches/quickswitch-fix-dmenu-check.patch \ %D%/packages/patches/rapicorn-isnan.patch \ %D%/packages/patches/raptor2-heap-overflow.patch \ diff --git a/gnu/packages/irc.scm b/gnu/packages/irc.scm index 011665d38..8bd877d28 100644 --- a/gnu/packages/irc.scm +++ b/gnu/packages/irc.scm @@ -68,7 +68,8 @@ version ".tar.bz2")) (sha256 (base32 - "0ka456fb8ha3w7g74xlzfg6w4azxjjxgrhl4aqpbwg3lnd6fbr4k")))) + "0ka456fb8ha3w7g74xlzfg6w4azxjjxgrhl4aqpbwg3lnd6fbr4k")) + (patches (search-patches "quassel-fix-ssl-check.patch")))) (build-system cmake-build-system) (arguments ;; The three binaries are not mutually exlusive, and are all built diff --git a/gnu/packages/patches/quassel-fix-ssl-check.patch b/gnu/packages/patches/quassel-fix-ssl-check.patch new file mode 100644 index 000000000..f825cb77e --- /dev/null +++ b/gnu/packages/patches/quassel-fix-ssl-check.patch @@ -0,0 +1,21 @@ +The check in qglobal.h requires -fPIC (not -fPIE as it +is now). When this check fails SSL is disabled. + +This patch comes from upstream master and can be removed when +the next version is packaged. + +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -428,6 +428,11 @@ endif() + cmake_push_check_state(RESET) + set(CMAKE_REQUIRED_INCLUDES ${QT_INCLUDES} ${Qt5Core_INCLUDE_DIRS}) + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${Qt5Core_EXECUTABLE_COMPILE_FLAGS}") ++ ++if (USE_QT5 AND Qt5_POSITION_INDEPENDENT_CODE) ++ set(CMAKE_REQUIRED_FLAGS "-fPIC -DQT_NO_VERSION_TAGGING") ++endif() ++ + check_cxx_source_compiles(" + #include \"qglobal.h\" + #if defined QT_NO_SSL + -- 2.13.3 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 22 08:37:58 2017 Received: (at 27784) by debbugs.gnu.org; 22 Jul 2017 12:37:58 +0000 Received: from localhost ([127.0.0.1]:51994 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYtfR-0007VE-Bq for submit@debbugs.gnu.org; Sat, 22 Jul 2017 08:37:58 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:52149) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYtfM-0007V2-4c for 27784@debbugs.gnu.org; Sat, 22 Jul 2017 08:37:55 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9BDC120886; Sat, 22 Jul 2017 08:37:51 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Sat, 22 Jul 2017 08:37:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=b3UbF/RthPcgpZmmjfl55SQt1Igk1AMmGyWSI8jZ5 lI=; b=mW2Z5A9o1GLW2eAzxOZsNlRWj2xu4q5Q4SWKAEDoj2AgYXosr2ANFP/Jq syTDguQ4tSHAG6gFoUMSl4LA813kLFWmxSWQNbSB+K/Azd6wFvcVeRCOZLWkD4mV Rki6wVj6z9Qklx0I4C27qvLf3aRLsPZWQ56YbwhporDEB0qHHRF3kZBh8jNObbVi x7m0dabI+EiPmQUcZMg4LN591YDu/TsyKrD05kWYOWs57VU3zzkk9SEkPImnPQHD eyoUWz8JfhTWvEkJgPUBCsEkrdl3v0o6DuulqSFdkBig5D6fx4E76XGjsZnjzU7I f1p7Qp6R3o01vKKByxTdul1FfcT9A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=b3UbF/RthPcgpZmmjf l55SQt1Igk1AMmGyWSI8jZ5lI=; b=nxZpuxwq+KTobt/SjgDrab+zkQkyJqMlSQ UGe6oZiAR2RE3Bm48UEtLGlsq67dyEVjCGkRjOTC/sC3WMaaUXiYTBTKNoVTTyCI GyQnZovg/wwgiA0+6vAz7Eeumc9ZRH4Xz5cikgearwbIpNg0cYy7EL8kXZmbbfvq RMGV132IwWlr8qZ54Lz1xyo3rItaC1FhRmwMcUXKKkmamlJIBmG+WsQHEOgwoMjW 9fD73AsV9MpGEYTTbqrTE4Llcct+0sx2jBgK/x9O2QPmH6dgAg6mchDo2r3XLcke Rhr9aPO3n0YmGPHCFdLDYf9OhlmtaUs3E34bAeHmmfTFWPj/ptJQ== X-ME-Sender: X-Sasl-enc: 8k0BuWAZliXzVEh+Uoq+K68lpOZ/5+f8rmu2cgnGuScV 1500727071 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 31339241E0; Sat, 22 Jul 2017 08:37:51 -0400 (EDT) From: Marius Bakke To: Ryan Moe , 27784@debbugs.gnu.org Subject: Re: [bug#27784] [PATCH] gnu: quassel: Enable SSL In-Reply-To: <20170721201201.17846-1-ryan.moe@gmail.com> References: <20170721201201.17846-1-ryan.moe@gmail.com> User-Agent: Notmuch/0.24.2 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Sat, 22 Jul 2017 14:37:49 +0200 Message-ID: <8760ek640y.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27784 Cc: Ryan Moe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Hello! Ryan Moe writes: > This allows quasselclient to connect to SSL-enabled quasselcore > instances. > > * gnu/packages/patches/quassel-fix-ssl-check.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add it. > * gnu/packages/irc.scm (quassel)[arguments]: Use it. [...] > diff --git a/gnu/packages/patches/quassel-fix-ssl-check.patch b/gnu/packages/patches/quassel-fix-ssl-check.patch > new file mode 100644 > index 000000000..f825cb77e > --- /dev/null > +++ b/gnu/packages/patches/quassel-fix-ssl-check.patch > @@ -0,0 +1,21 @@ > +The check in qglobal.h requires -fPIC (not -fPIE as it > +is now). When this check fails SSL is disabled. > + > +This patch comes from upstream master and can be removed when > +the next version is packaged. Can you add the URL to the relevant upstream commit? Apart from that this LGTM. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAllzRx0ACgkQoqBt8qM6 VPqOVgf7BCIQ1OHFslkXyZxC0g7gIDoBDGgsmf2weLaBN2kgaBG27uQYqsFNMWbf O3E5zeQhkKY351DXiqPamWTZQXMFFKjUGMRPIcjkU7onD9jUCRUfnbqDSZSHM5sP GXAIW4prRbaBXLn3E5/F4siX5/clJ2+B3bIWLJ51BjofAjiIju99hKiyy+cr+Nt3 0KId/R258AKFgTC5Vit3cATvZReyr92v6IOUWUV7Z0yTBFHF97gRu+463jomF5bM NWyEvP5nptTcmVJHhb64W0BACSAldLo6UGD4gz3zlXszhkKw0VsrHkf7f8jULWbR EqJI+ULeRxRXbbV6vWOUPdKuU3zVCQ== =UKZM -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 22 13:23:56 2017 Received: (at 27784) by debbugs.gnu.org; 22 Jul 2017 17:23:56 +0000 Received: from localhost ([127.0.0.1]:52582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYy88-0007eV-Vy for submit@debbugs.gnu.org; Sat, 22 Jul 2017 13:23:56 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:36944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYvF8-0001Vz-A4 for 27784@debbugs.gnu.org; Sat, 22 Jul 2017 10:18:57 -0400 Received: by mail-pf0-f196.google.com with SMTP id d18so6939739pfe.4 for <27784@debbugs.gnu.org>; Sat, 22 Jul 2017 07:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id; bh=Ckcls5ToHs8hWApYPXaz0C1xQDq4izPI5igKgbHbEyA=; b=Ssn4+Izpk+Q8I05UeGC3N4wifrq3YsuO/xLTzk+pD4A7bidvD48Wl/OE+toLg5ukAM OQr+dpLW2yOcdCVZtZ9ZDMqymd9iMAT5eOdLncm+z2tHdKFZuW8tcWayJwNWfSXjJ3DZ bANwYc26gsorIMkFd5auIxK1tbYJMPmHOgTSxyCIKv15IJIAXlqcyBoo4pYaWhpAorvn e3qXIRgoaxOfD1qNKRuvOJEazPq06RIjvAXRW2QfwMrQf0srzrW0lNPG2zOUr0La+1VP O+udtkXTnLeoAMVtDmWWtpcBIX5jPzVTivHR87dfUuLeJZ1acne1/Jpg8nrICknBrd7z 1mIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=Ckcls5ToHs8hWApYPXaz0C1xQDq4izPI5igKgbHbEyA=; b=dtgxjHdhmJHdkhBhqCVbIrRNXWLHsJpR00U+tjxsDROYewpqMwXsuRgYD8Xk/UTqOf RS2hyNY6aMiSHNbI5LJknL5/9j7K9mJzqi5F9NNhHaGsWegILAXTAQYAk+hZGydtMjyK Gqsl9HXOfyJvCJ/fKm9Rfi+fRS5XOj1AgiuboIoJlRz1cPoEFLcQYIWLyf0dY84uXZbp NLMCseq0chS+t7xK0aYa0/Rgly3iXBCccFrTVrWwJDlR3HNk7P73Lv6TUcCxC8OsAGVs 6WTFSOnBWsmwE00ISmJ9aULgjkfdVQ1QEAyOfYd8xeJV9Jmz6yn1tpRsK5xMAboi7Mf9 7TVQ== X-Gm-Message-State: AIVw112huqcADo5x8xacg2gTlAXF1kdWveaMpQAz8H0AGd/1UQgetIoh nPfg+2xdFZmaJL3G X-Received: by 10.98.70.206 with SMTP id o75mr10762542pfi.60.1500733128118; Sat, 22 Jul 2017 07:18:48 -0700 (PDT) Received: from localhost.localdomain (c-71-236-204-34.hsd1.wa.comcast.net. [71.236.204.34]) by smtp.googlemail.com with ESMTPSA id q79sm13022870pfi.99.2017.07.22.07.18.47 for <27784@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Jul 2017 07:18:47 -0700 (PDT) From: Ryan Moe To: 27784@debbugs.gnu.org Subject: [PATCH] gnu: quassel: Enable SSL Date: Sat, 22 Jul 2017 07:18:42 -0700 Message-Id: <20170722141842.8429-1-ryan.moe@gmail.com> X-Mailer: git-send-email 2.13.3 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 27784 X-Mailman-Approved-At: Sat, 22 Jul 2017 13:23:51 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This allows quasselclient to connect to SSL-enabled quasselcore instances. * gnu/packages/patches/quassel-fix-ssl-check.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. * gnu/packages/irc.scm (quassel)[arguments]: Use it. --- gnu/local.mk | 1 + gnu/packages/irc.scm | 3 ++- gnu/packages/patches/quassel-fix-ssl-check.patch | 23 +++++++++++++++++++++++ 3 files changed, 26 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/quassel-fix-ssl-check.patch diff --git a/gnu/local.mk b/gnu/local.mk index 6d9e57062..f1f343b86 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -984,6 +984,7 @@ dist_patch_DATA = \ %D%/packages/patches/qt4-ldflags.patch \ %D%/packages/patches/qtscript-disable-tests.patch \ %D%/packages/patches/quagga-reproducible-build.patch \ + %D%/packages/patches/quassel-fix-ssl-check.patch \ %D%/packages/patches/quickswitch-fix-dmenu-check.patch \ %D%/packages/patches/rapicorn-isnan.patch \ %D%/packages/patches/raptor2-heap-overflow.patch \ diff --git a/gnu/packages/irc.scm b/gnu/packages/irc.scm index 011665d38..8bd877d28 100644 --- a/gnu/packages/irc.scm +++ b/gnu/packages/irc.scm @@ -68,7 +68,8 @@ version ".tar.bz2")) (sha256 (base32 - "0ka456fb8ha3w7g74xlzfg6w4azxjjxgrhl4aqpbwg3lnd6fbr4k")))) + "0ka456fb8ha3w7g74xlzfg6w4azxjjxgrhl4aqpbwg3lnd6fbr4k")) + (patches (search-patches "quassel-fix-ssl-check.patch")))) (build-system cmake-build-system) (arguments ;; The three binaries are not mutually exlusive, and are all built diff --git a/gnu/packages/patches/quassel-fix-ssl-check.patch b/gnu/packages/patches/quassel-fix-ssl-check.patch new file mode 100644 index 000000000..14c57883f --- /dev/null +++ b/gnu/packages/patches/quassel-fix-ssl-check.patch @@ -0,0 +1,23 @@ +The check in qglobal.h requires -fPIC (not -fPIE as it +is now). When this check fails SSL is disabled. + +This patch comes from upstream master [0] and can be removed +when the next version is packaged. + +[0] https://github.com/quassel/quassel/commit/4768c9e99 + +--- a/CMakeLists.txt ++++ b/CMakeLists.txt +@@ -428,6 +428,11 @@ endif() + cmake_push_check_state(RESET) + set(CMAKE_REQUIRED_INCLUDES ${QT_INCLUDES} ${Qt5Core_INCLUDE_DIRS}) + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${Qt5Core_EXECUTABLE_COMPILE_FLAGS}") ++ ++if (USE_QT5 AND Qt5_POSITION_INDEPENDENT_CODE) ++ set(CMAKE_REQUIRED_FLAGS "-fPIC -DQT_NO_VERSION_TAGGING") ++endif() ++ + check_cxx_source_compiles(" + #include \"qglobal.h\" + #if defined QT_NO_SSL + -- 2.13.3 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 22 20:08:30 2017 Received: (at 27784-done) by debbugs.gnu.org; 23 Jul 2017 00:08:31 +0000 Received: from localhost ([127.0.0.1]:52734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZ4Ri-0008OL-Ni for submit@debbugs.gnu.org; Sat, 22 Jul 2017 20:08:30 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:56129) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZ4Re-0008OA-Iy for 27784-done@debbugs.gnu.org; Sat, 22 Jul 2017 20:08:28 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 71EF4208EC; Sat, 22 Jul 2017 20:08:26 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Sat, 22 Jul 2017 20:08:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=gWV4tN66fMvspDODGMR93500chd+kMnParDOUg lDNZA=; b=NmkuUCKr+8h5oarG22Ua57wkd4KejHcC17PoLmhk1Ru4SkotWhdER+ 80hKtr98I1mrVQ4cLnwohpXfu+euCHqTde0WL+fjdF/55PS2coo0rw+jJcLK+K9u h3dqknezrB1G7z7B3B3HOT2e2HYRQ/Uy/WbHK9fVswPuCwneMKxJU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=gWV4tN66fMvspDODGM R93500chd+kMnParDOUglDNZA=; b=mRsV651RmoOnUmr7xM/kr7OLaKTowlUH+D IhntOoVJewx00J5Ph9v0bkeRbOYVVUGAW/YH94BdaaCdUAdWgeODpifjm3zf9Tee PTzD9xtt+XRnDCFbIKPdeig/32bx5P+VbTyjfSBisILlFG14Hafnuh9obDav9rgM a6oBhNAgnUQ/B2p/sAn6YmB9gJe7kqMquXntVWcPb2y6zNHeoYnNS6DWRL4hr7UF SFhzYV8+xxML0wH0yUaaAK+OcLPnka7o9OKY0DaYNRZSGBSgZ2Q3II89oV8tNLDU CDnV1LdAdfe4qC88NDObsG2wfUIX3c1uGYMngzdKWpsXJiQtqUqg== X-ME-Sender: X-Sasl-enc: Aa+BcUBwBMIE++3DKAecSIrRiE7HJg/EY1zWTaD+mK1W 1500768506 Received: from localhost (static-108-36-103-174.phlapa.fios.verizon.net [108.36.103.174]) by mail.messagingengine.com (Postfix) with ESMTPA id 3674A7E568; Sat, 22 Jul 2017 20:08:26 -0400 (EDT) Date: Sat, 22 Jul 2017 20:08:25 -0400 From: Leo Famulari To: Ryan Moe Subject: Re: [bug#27784] [PATCH] gnu: quassel: Enable SSL Message-ID: <20170723000825.GA24840@jasmine.lan> References: <20170721201201.17846-1-ryan.moe@gmail.com> <20170722141842.8429-1-ryan.moe@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Kj7319i9nmIyA2yE" Content-Disposition: inline In-Reply-To: <20170722141842.8429-1-ryan.moe@gmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27784-done Cc: 27784-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --Kj7319i9nmIyA2yE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Jul 22, 2017 at 07:18:42AM -0700, Ryan Moe wrote: Thanks for this updated patch! I pushed as 36378bd57ec31ba2bbedbdbdbd77b5b0f82f3b8a with the following changes: I changed all mention of SSL to TLS, which is (optimistically) more accurate nowadays since all the SSL protocols have been broken and deprecated. > This allows quasselclient to connect to SSL-enabled quasselcore > instances. I moved this comment into the patch. > * gnu/packages/patches/quassel-fix-ssl-check.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add it. > * gnu/packages/irc.scm (quassel)[arguments]: Use it. s/arguments/source > diff --git a/gnu/packages/patches/quassel-fix-ssl-check.patch b/gnu/packages/patches/quassel-fix-ssl-check.patch > new file mode 100644 > index 000000000..14c57883f > --- /dev/null > +++ b/gnu/packages/patches/quassel-fix-ssl-check.patch > @@ -0,0 +1,23 @@ > +The check in qglobal.h requires -fPIC (not -fPIE as it > +is now). When this check fails SSL is disabled. > + > +This patch comes from upstream master [0] and can be removed > +when the next version is packaged. > + > +[0] https://github.com/quassel/quassel/commit/4768c9e99 I used the full commit hash here. Plus various stylistic and cosmetic changes. --Kj7319i9nmIyA2yE Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAllz6PkACgkQJkb6MLrK fwiFMhAAsPAxP9NpjfMOLzLYf2ARVdAuJO+I9Alg2aB336yqE/ZkAF04L2x2XUDS eiPeyffyTFf28I4/zR9k79oiogRJzk1WuoYl3LGgdmDEfxRxjfQxbVmiG6/gcKh7 LRdikPWfvHxE/ZGwS0M1Dj5X1x6IL2ZfzpYEfhQKYH156+e/Ftay0NKPMAts/YY5 LrF4QbgI8eZXOS2FACxkofxnCVNYVs6STJeXLugjk/n+d8TkBITRX+17PIjGbifg rDtq8NJKPfoVgOmx9vqnL4gsSLXVDqyIvOXMVpBmasVzwqf/8obqTPLrT6KcOkY1 /iq+MYv6dPI2InA3cRgIXetSQsiqV/2zJVo4gHHkZn1oOsdUsSZCtaPB/RMCzRA1 HqiMI9SK76jJ4SkE7zuMj/Ol8AKvkl0sUxw4QFcoCjMFWxepNMKdsPCR7l7l5wAl tfv7tSQg2fRS9pv+Ui1PBHqUTHEj8hFAQmMFKwpgbUhFvtYOlqmd+ulEngP1XkyX L0hB29+Xwx0sXSsAF+3BVsP0zWumc7kRdcCplU/jT3GuuQ90UtUeoR6nqxhdSfUD 7Qaet25G4iL5/FiNDOkvTGEi2hH9R50+ShDaLZyFqfU56pfRkrJfDWK/TdTF6NAo 18mO5lIXok97Lf/jQ+B7s3xk+OWXPw7Wbco9nmpIgI5TQQV2tsY= =TLkE -----END PGP SIGNATURE----- --Kj7319i9nmIyA2yE-- From unknown Sun Aug 17 22:11:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 20 Aug 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator