GNU bug report logs - #27781
LIBOBJS should depend on LIBOBJDIR

Previous Next

Full log

Message #63 received at 27781 <at> debbugs.gnu.org (full text, mbox):

From: Michael Haubenwallner <michael.haubenwallner <at> ssi-schaefer.com>
To: Mathieu Lirzin <mthl <at> gnu.org>
Cc: Nick Bowler <nbowler <at> draconx.ca>, 27781 <at> debbugs.gnu.org
Subject: Re: bug#27781: LIBOBJS should depend on LIBOBJDIR
Date: Tue, 5 Sep 2017 11:16:16 +0200

[Message part 1 (text/plain, inline)]

On 08/27/2017 05:23 PM, Mathieu Lirzin wrote:
> Michael Haubenwallner <michael.haubenwallner <at> ssi-schaefer.com> writes:
>> On 08/24/2017 11:35 AM, Mathieu Lirzin wrote:
>>
>>> Instead of this dummy target, I would rather prefer adding the dirstamp
>>> dependency for each explicit object file separately.  this should be computed
>>> from the '%libsources' variable.  However after a quick look in the code, it
>>> seems that this variable is not properly populated by the
>>> 'scan_autoconf_traces' subroutine.  It only contains the files that are
>>> explicitely defined by scanning the AC_LIBSOURCE macro and not by AC_LIBOBJ or
>>> AC_LIBSOURCES in 'configure.ac'.
>>>
>>> Michael: Are you interested in looking into this?
>>>
>>
>> Here's an attempt to use the explicit AC_LIBSOURCE values to depend on the
>> LIBOBJDIR dirstamp. IMHO, tracing AC_LIBOBJ would not provide additional
>> information over AC_LIBSOURCE, as AC_LIBOBJ by itself uses AC_LIBSOURCE.
> 
> I stand corrected.  This is indeed working properly since
> 'scan_autoconf_traces' doesn't simply scan "configure.ac" but the output
> 'autoconf --trace=...'.
> 
>> >From 4465bb9e31c12a8f59c199c61aaef17966e1ffc4 Mon Sep 17 00:00:00 2001
>> From: Michael Haubenwallner <michael.haubenwallner <at> ssi-schaefer.com>
>> Date: Wed, 16 Aug 2017 18:16:12 +0200
>> Subject: [PATCH] automake: Depend on LIBOBJDIR for LIBOBJS.
>>
>> This change fixes automake bug#27781.
>>
>> * bin/automake.in: Add Makefile dependency on LIBOBJDIR/dirstamp for
>> each LIBOBJS/ALLOCA source file found.
>> ---
> 
> This patch can't be applied on the 'minor' branch, which corresponds to
> the branch of the next release (I know this is confusing [1]).  Could
> resend it after rebasing onto the 'minor' branch?
> 

Here we go, also removing t/libobj-no-dependency-tracking.sh from XFAIL_TESTS.

Thanks,
/haubi/

[0001-automake-Depend-on-LIBOBJDIR-for-LIBOBJS.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.