Subject: Re: bug#27781: LIBOBJS should depend on LIBOBJDIR

From: Michael Haubenwallner <[email-masked]>
Date: Mon, 28 Aug 2017 09:54:33 +0200

On 08/27/2017 04:07 PM, Mathieu Lirzin wrote:
> Michael Haubenwallner <[email-masked]> writes:
>> On 08/23/2017 11:24 PM, Mathieu Lirzin wrote:
>>> Michael Haubenwallner <[email-masked]> writes:
>>>> On 08/22/2017 12:40 AM, Mathieu Lirzin wrote:
>>>>> Michael Haubenwallner <[email-masked]> writes:

>>> --8<---------------cut here---------------start------------->8---
>>
>>> 	  # If LTLIBOBJS is used, we must also clear LIBOBJS (which might
>>> 	  # be created by libtool as a side-effect of creating LTLIBOBJS).
>>> 	  $clean_files{"\$($var)"} = MOSTLY_CLEAN if $var =~ s/^LT//;
>>
>> Crucial here is that trailing { if $var =~ s/^LT// }:
>> First, leading 'LT' eventually is dropped: $var = 'LIBOBJS';
>> If the leading 'LT' was actually found: $clean_files{'LIBOBJS'} = MOSTLY_CLEAN;
> 
> I overlooked the regexp substitution.  This code is too complex for what it
> achieves.  I have pushed the following patch in commit
> 5521219348c55af354878583b99c5f9d66d6d38a
> 

> -	  $clean_files{"\$($var)"} = MOSTLY_CLEAN if $var =~ s/^LT//;
> +	  $clean_files{"\$(LIBOBJS)"} = MOSTLY_CLEAN if $var eq "LTLIBOBJS";

One more note: IMHO, the idea was to also support "LTALLOCA" here - even
if AC_FUNC_ALLOCA does not (yet?).

/haubi/