GNU bug report logs - #27772
25.2; Choosing tags files

Previous Next

Package: emacs;

Reported by: Daniel Lopez <daniel.lopez999 <at> gmail.com>

Date: Thu, 20 Jul 2017 13:51:02 UTC

Severity: minor

Tags: fixed, patch

Found in version 25.2

Fixed in version 26.1

Done: npostavs <at> users.sourceforge.net

Bug is archived. No further changes may be made.

Full log

Message #15 received at 27772 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: npostavs <at> users.sourceforge.net
Cc: 27772 <at> debbugs.gnu.org, daniel.lopez999 <at> gmail.com
Subject: Re: bug#27772: 25.2; Choosing tags files
Date: Mon, 07 Aug 2017 19:10:38 +0300

> From: npostavs <at> users.sourceforge.net
> Date: Sun, 06 Aug 2017 21:45:56 -0400
> Cc: 27772 <at> debbugs.gnu.org
> 
> The problem is that the buffer gets changed by the time we reach there.
> The following patch seems to fix it (no need to explicitly use
> `buffer-local-variables' since normal variable access will check the
> buffer-local value first.

Seems reasonable, thanks.

> * lisp/progmodes/etags.el (visit-tags-table-buffer): Save the current
                                                                ^^^^^^^
You meant "current buffer", I presume.

Do etags-tests.el still pass after this change?  If so, would it be
possible to add a test for this bug?

Other than that, LGTM.
This bug report was last modified 8 years ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.