GNU bug report logs - #27762
26.0.50; ls-lisp: misalignment when dired-directory is a cons

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: 27762 <at> debbugs.gnu.org
Subject: bug#27762: 26.0.50; ls-lisp: misalignment when dired-directory is a cons
Date: Tue, 01 Aug 2017 16:46:02 +0300

> From: Tino Calancha <tino.calancha <at> gmail.com>
> Cc: 27762 <at> debbugs.gnu.org
> Date: Tue, 01 Aug 2017 16:01:17 +0900
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> > Looks OK, but why this complicated code:
> >
> >> +        (when-let* ((col-diff (- (point) (point-at-bol)))
> >> +                    (higher (> col-diff target)))
> >> +          (setq target col-diff)))
> >> +      (and (/= first target) target))))
> >
> > Doesn't current-column do its job in this case?
> That is to work regardless on the `dired-hide-details-mode' value.
> If we use `current-column' we are in trouble.

Then (a) please mention this issue in a comment before this fragment,
and (b) please don't call the variable "column", because it's
confusing.

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.