From unknown Sun Sep 07 01:27:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27746: 26.0.50; Need a better test of whether running on Hydra than $NIX_STORE Resent-From: Gemini Lasswell Original-Sender: "Debbugs-submit" Resent-CC: michael.albinus@gmx.de, bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jul 2017 02:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 27746@debbugs.gnu.org Cc: michael.albinus@gmx.de X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: michael.albinus@gmx.de Received: via spool by submit@debbugs.gnu.org id=B.150034343222323 (code B ref -1); Tue, 18 Jul 2017 02:04:01 +0000 Received: (at submit) by debbugs.gnu.org; 18 Jul 2017 02:03:52 +0000 Received: from localhost ([127.0.0.1]:45132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXHrb-0005nz-SG for submit@debbugs.gnu.org; Mon, 17 Jul 2017 22:03:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXHrY-0005nj-VQ for submit@debbugs.gnu.org; Mon, 17 Jul 2017 22:03:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXHrS-0002sT-TC for submit@debbugs.gnu.org; Mon, 17 Jul 2017 22:03:43 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34745) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dXHrS-0002sO-QY for submit@debbugs.gnu.org; Mon, 17 Jul 2017 22:03:42 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44509) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXHrR-0008PQ-LD for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2017 22:03:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXHrO-0002qa-Hy for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2017 22:03:41 -0400 Received: from aibo.runbox.com ([91.220.196.211]:59058) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dXHrO-0002pn-87 for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2017 22:03:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=rbselector1; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=bzV3s1bcNbb+G9lbIBRgTi2tr5qo5ZNhHMjhncrlcQ0=; b=f0icqNBbpmGWnQvSKgL4MOHNp CVUe4qCXQkzPdx4MARoxLlJHAVZZvzVBQe+loYZXEsaclXEfCsWgk/1Y8OhvXivICLk5ijpoY/ipE 52Y7zIj1cvVQ4pk4zsjhIzFnFZdWRZoSHJM923d6GA1WX+qo6VAEA3OLKtkZV0lIAgia1HBqXgy7q Gz1OJ/4z5DfUtovNwesaeQrrHgyakQGLgvI9pzj00ws/4GIvHIPvUvLMkE/jK5vUnx08BmR1jDcEJ hk+XZJfRNDrcrFtDqKaTo14ZolPpzSnfHgzIl+e9bsWO0E63p8fNVNUnwm+mCHPTVxTdzWop0eZzY TcCQHSqIg==; Received: from [10.9.9.211] (helo=mailfront11.runbox.com) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1dXHrM-0004zB-97 for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2017 04:03:36 +0200 Received: from c-24-22-244-161.hsd1.wa.comcast.net ([24.22.244.161] helo=chinook) by mailfront11.runbox.com with esmtpsa (uid:179284 ) (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) id 1dXHrB-0003V1-Ok for bug-gnu-emacs@gnu.org; Tue, 18 Jul 2017 04:03:26 +0200 From: Gemini Lasswell Date: Mon, 17 Jul 2017 19:03:16 -0700 Message-ID: <87eftepkm3.fsf@chinook> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) There are places in the test code in Emacs which use the existence of the NIX_STORE environment variable to change test behavior when running on Hydra. However, Emacs should have a different and more specific test for whether it is running on Hydra, so that those behavior changes don't happen on other machines running NixOS or the Nix package manager. I noticed this because of Michael Albinus's recent addition of some NIX_STORE checks to test/Makefile.in and tramp-tests.el in an attempt to track down test failures on Hydra. Those changes cause tramp-tests.el to run much slower on my machine and spam its logfile to standard output. In addition, checks of NIX_STORE cause a few eieio tests to be skipped and ERT to print more detailed test summaries. Then there's this bit of code, found in both tramp-tests.el and filenotify-tests.el: ;; This shall happen on hydra only. (when (getenv "NIX_STORE") (add-to-list 'tramp-remote-path 'tramp-own-remote-path)) which looks a bit backwards to me because changing tramp-remote-path is necessary on my Mac to make Tramp able to talk to a NixOS (or Guix) machine. But it's not necessary to change tramp-remote-path to make Tramp on the NixOS machine remotely connect to the Mac. Presumably Hydra is always talking to another NixOS machine here, and the use of NIX_STORE should be replaced by something more specific to Hydra. But it would be more generally correct to look at the value of NIX_STORE on the machine that REMOTE_TEMPORARY_FILE_DIRECTORY points to. From unknown Sun Sep 07 01:27:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27746: 26.0.50; Need a better test of whether running on Hydra than $NIX_STORE Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jul 2017 07:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Gemini Lasswell Cc: 27746@debbugs.gnu.org Received: via spool by 27746-submit@debbugs.gnu.org id=B27746.150036150024149 (code B ref 27746); Tue, 18 Jul 2017 07:05:02 +0000 Received: (at 27746) by debbugs.gnu.org; 18 Jul 2017 07:05:00 +0000 Received: from localhost ([127.0.0.1]:45257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXMZ2-0006HR-JM for submit@debbugs.gnu.org; Tue, 18 Jul 2017 03:05:00 -0400 Received: from mout.gmx.net ([212.227.17.20]:53752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXMZ0-0006HD-Uy for 27746@debbugs.gnu.org; Tue, 18 Jul 2017 03:04:59 -0400 Received: from detlef.gmx.de ([212.86.40.150]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LosFD-1e8t2H3lnP-00go4R; Tue, 18 Jul 2017 09:04:51 +0200 From: Michael Albinus References: <87eftepkm3.fsf@chinook> Date: Tue, 18 Jul 2017 09:04:48 +0200 In-Reply-To: <87eftepkm3.fsf@chinook> (Gemini Lasswell's message of "Mon, 17 Jul 2017 19:03:16 -0700") Message-ID: <87379u444v.fsf@detlef> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:w1LqZf79nZ8Ka0GXje4fS/txfT7vmL29R4VfNRHXh82lht+WjiV n2tfnw983wsMA2TZGXnnZCHVvnIbQsTJpyG9N/iQCFtJeKk6LS/sBalOfPrE1Jo6IXejNNo HP6QuMksG6aq6muYWLuhorpYocSP6+vb2o1mpmoYyOjUtzKeCEcGbtqm+unf4CDBI0ud6dZ ofitaTMqPjCzWFnjXovBw== X-UI-Out-Filterresults: notjunk:1;V01:K0:OiSg3Lzgq9A=:OKUJEh/I6AUHrbiv7Y8Lu0 mFC8+j8YZwAQ5YAA+cgA9gIhylPBOZYNSvYlLBtbWmMUHD2lHak2gf3gkKi+o39PG+baJCeeG xMdoMpjCL38yms0vEwZX8Ldb5BNYK840tELHtdi/JXVrsOzEhlDK+ImUYQyEg2wEjvfR66MJl vwM2ZlxQoOuoOdTx8tUF8S03DnMRQaZPoEhNQhiuqPzv/BLP2QU4ovgDeYg5M+DmBmOevv5Fp aM4rJ88+0NJz4KrtINFbw6afJyqAN2Y8P4EQaqW+PeuQVbV27VUwqWbNyyIY5qt3xL0ieL3ae U2BiOPfIIZEq8zTELaoPwq0RDrr6y1zLy1av+VL6B73wfIhOQYCms8AuavQb7VYgjPoyLU+1v XmDfd6U14LVcZRfnSXQiZhJ5pxpD+tdmFgKow5nhrAoN9dRFYk+YZlkr1SPcqkq4WM09XvyI5 ngthd6Soi5Dx4h/vV6Zl7FJ6PjgaSsA+MhDa827E1Sp42TYwMqgSWscY2eQ6iC3mNkAss9HUL 2mRtOP80eQ/f1IuQURt/LJWPb3gmy8cl5XkowX3yj4SGeM/aM6Y2rXOYsBWruUP18wKyEnNOq nEnvu2mCpF+6uxQ0FETkHQ6eAzN+i0PPcdXsCjuibHPOLZQHyC9dHq6pT72DdDGrCwGJ9PeaX QE4S/x1ghoTyoFYWDYKD57iEUN+5D6iD9PXdgBDp7jgAVljqRkmvvqqmbf19R6LKalOegKo1l L4bddzUq4+pbA5m2OT1Wpwf1eAqIQB+uHgIQKE2LqxYRhEBxd5wjxnhdoCt4uqwfzDO5FIw+k kbuWt+x/E+aAXMFPBIciPdUE9fN5SNRAZIWJHHukoEdvWzYL6Q= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Gemini Lasswell writes: Hi Gemini, > There are places in the test code in Emacs which use the existence of > the NIX_STORE environment variable to change test behavior when > running on Hydra. However, Emacs should have a different and more > specific test for whether it is running on Hydra, so that those > behavior changes don't happen on other machines running NixOS or the > Nix package manager. I agree. Checking the existence of $NIX_STORE is just a heuristic. A better approach might be setting an environment variable or so in the Emacs recipe for hydra. Glenn? > But it would be more generally correct to look at the value of > NIX_STORE on the machine that REMOTE_TEMPORARY_FILE_DIRECTORY points > to. The tests running on hydra use always the mockup file name (format "/mock::%s" temporary-file-directory) This is on the local host; a proper test for hydra would be sufficient. Best regards, Michael. From unknown Sun Sep 07 01:27:57 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27746: 26.0.50; Need a better test of whether running on Hydra than $NIX_STORE Resent-From: Glenn Morris Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Jul 2017 16:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27746 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Albinus Cc: Gemini Lasswell , 27746@debbugs.gnu.org Received: via spool by 27746-submit@debbugs.gnu.org id=B27746.15003970172849 (code B ref 27746); Tue, 18 Jul 2017 16:57:02 +0000 Received: (at 27746) by debbugs.gnu.org; 18 Jul 2017 16:56:57 +0000 Received: from localhost ([127.0.0.1]:46877 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXVnt-0000jt-HJ for submit@debbugs.gnu.org; Tue, 18 Jul 2017 12:56:57 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXVnr-0000jf-La for 27746@debbugs.gnu.org; Tue, 18 Jul 2017 12:56:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXVnl-0005Aq-MO for 27746@debbugs.gnu.org; Tue, 18 Jul 2017 12:56:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55984) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXVnd-00059D-5f; Tue, 18 Jul 2017 12:56:41 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dXVnb-0005bO-8O; Tue, 18 Jul 2017 12:56:39 -0400 From: Glenn Morris References: <87eftepkm3.fsf@chinook> <87379u444v.fsf@detlef> X-Spook: kilderkin Suicide bomber Noriega SP4 bemd virus JPL USCOI X-Ran: *jAO.R2oF8iwL8_ADSerex?h_}">T\%_Mq8@}.@Pp%8DbQlS3{~[]WLr!r%d)R\T05[5O: X-Hue: cyan X-Attribution: GM Date: Tue, 18 Jul 2017 12:56:39 -0400 In-Reply-To: <87379u444v.fsf@detlef> (Michael Albinus's message of "Tue, 18 Jul 2017 09:04:48 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Michael Albinus wrote: > I agree. Checking the existence of $NIX_STORE is just a heuristic. A > better approach might be setting an environment variable or so in the > Emacs recipe for hydra. Oh right, it is that easy. Done in 5ab9102. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 18 12:57:08 2017 Received: (at control) by debbugs.gnu.org; 18 Jul 2017 16:57:08 +0000 Received: from localhost ([127.0.0.1]:46881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXVo4-0000kf-O4 for submit@debbugs.gnu.org; Tue, 18 Jul 2017 12:57:08 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41784) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXVo3-0000kG-A5 for control@debbugs.gnu.org; Tue, 18 Jul 2017 12:57:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXVnx-0005En-M1 for control@debbugs.gnu.org; Tue, 18 Jul 2017 12:57:02 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55988) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXVnx-0005Eh-JO for control@debbugs.gnu.org; Tue, 18 Jul 2017 12:57:01 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dXVnx-0005iM-DY for control@debbugs.gnu.org; Tue, 18 Jul 2017 12:57:01 -0400 Subject: control message for bug 27746 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Tue, 18 Jul 2017 12:57:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) # 5ab9102 close 27746