GNU bug report logs - #27746
26.0.50; Need a better test of whether running on Hydra than $NIX_STORE

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27746 in the body.
You can then email your comments to 27746 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gemini Lasswell <gazally <at> runbox.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50;
 Need a better test of whether running on Hydra than $NIX_STORE
Date: Mon, 17 Jul 2017 19:03:16 -0700

There are places in the test code in Emacs which use the existence of
the NIX_STORE environment variable to change test behavior when
running on Hydra. However, Emacs should have a different and more
specific test for whether it is running on Hydra, so that those
behavior changes don't happen on other machines running NixOS or the
Nix package manager.

I noticed this because of Michael Albinus's recent addition of some
NIX_STORE checks to test/Makefile.in and tramp-tests.el in an attempt
to track down test failures on Hydra. Those changes cause
tramp-tests.el to run much slower on my machine and spam its logfile
to standard output.

In addition, checks of NIX_STORE cause a few eieio tests to be skipped
and ERT to print more detailed test summaries. Then there's this bit
of code, found in both tramp-tests.el and filenotify-tests.el:

;; This shall happen on hydra only.
(when (getenv "NIX_STORE")
  (add-to-list 'tramp-remote-path 'tramp-own-remote-path))

which looks a bit backwards to me because changing tramp-remote-path
is necessary on my Mac to make Tramp able to talk to a NixOS (or Guix)
machine. But it's not necessary to change tramp-remote-path to make
Tramp on the NixOS machine remotely connect to the Mac. Presumably
Hydra is always talking to another NixOS machine here, and the use of
NIX_STORE should be replaced by something more specific to Hydra. But
it would be more generally correct to look at the value of NIX_STORE
on the machine that REMOTE_TEMPORARY_FILE_DIRECTORY points to.

Message #8 received at 27746 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Gemini Lasswell <gazally <at> runbox.com>
Cc: 27746 <at> debbugs.gnu.org
Subject: Re: bug#27746: 26.0.50;
 Need a better test of whether running on Hydra than $NIX_STORE
Date: Tue, 18 Jul 2017 09:04:48 +0200

Gemini Lasswell <gazally <at> runbox.com> writes:

Hi Gemini,

> There are places in the test code in Emacs which use the existence of
> the NIX_STORE environment variable to change test behavior when
> running on Hydra. However, Emacs should have a different and more
> specific test for whether it is running on Hydra, so that those
> behavior changes don't happen on other machines running NixOS or the
> Nix package manager.

I agree. Checking the existence of $NIX_STORE is just a heuristic. A
better approach might be setting an environment variable or so in the
Emacs recipe for hydra.

Glenn?

> But it would be more generally correct to look at the value of
> NIX_STORE on the machine that REMOTE_TEMPORARY_FILE_DIRECTORY points
> to.

The tests running on hydra use always the mockup file name

(format "/mock::%s" temporary-file-directory)

This is on the local host; a proper test for hydra would be sufficient.

Best regards, Michael.

Message #11 received at 27746 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Gemini Lasswell <gazally <at> runbox.com>, 27746 <at> debbugs.gnu.org
Subject: Re: bug#27746: 26.0.50;
 Need a better test of whether running on Hydra than $NIX_STORE
Date: Tue, 18 Jul 2017 12:56:39 -0400

Michael Albinus wrote:

> I agree. Checking the existence of $NIX_STORE is just a heuristic. A
> better approach might be setting an environment variable or so in the
> Emacs recipe for hydra.

Oh right, it is that easy.
Done in 5ab9102.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.