From unknown Sat Aug 16 10:44:50 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#27735 <27735@debbugs.gnu.org> To: bug#27735 <27735@debbugs.gnu.org> Subject: Status: Unbootable images with GuixSD on... "GuixSD" Reply-To: bug#27735 <27735@debbugs.gnu.org> Date: Sat, 16 Aug 2025 17:44:50 +0000 retitle 27735 Unbootable images with GuixSD on... "GuixSD" reassign 27735 guix submitter 27735 Tobias Geerinckx-Rice severity 27735 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 10:47:30 2017 Received: (at submit) by debbugs.gnu.org; 17 Jul 2017 14:47:30 +0000 Received: from localhost ([127.0.0.1]:44574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dX7J4-00087Q-8W for submit@debbugs.gnu.org; Mon, 17 Jul 2017 10:47:30 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dX7J2-00087D-62 for submit@debbugs.gnu.org; Mon, 17 Jul 2017 10:47:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dX7Iv-0000uy-TV for submit@debbugs.gnu.org; Mon, 17 Jul 2017 10:47:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51689) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dX7Iv-0000up-Pg for submit@debbugs.gnu.org; Mon, 17 Jul 2017 10:47:21 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36261) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dX7Iu-0004zB-FQ for bug-guix@gnu.org; Mon, 17 Jul 2017 10:47:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dX7It-0000sD-5S for bug-guix@gnu.org; Mon, 17 Jul 2017 10:47:20 -0400 Received: from tobias.gr ([2001:470:cc92::1]:47232) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dX7Is-0000qF-RH for bug-guix@gnu.org; Mon, 17 Jul 2017 10:47:19 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 9559ded2 for ; Mon, 17 Jul 2017 14:47:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=to:from :subject:message-id:date:mime-version:content-type; s=201706; bh=+fw1IG0X6xMep3yQB92VJzPhOaf2HnHD2q5JdSN2BjA=; b=sd4wDAA3iF6y 1mZIzg/7D0jeF3Ebt0qFcG3wVSTPHiB80vJ9PVnYNuapurvO8Eqo72mRhJ5+VTCq qBwMxfPAyeRYS8+OoPnr96ZAI08iOz4/KCodVcToukpUGLtE30FtuygcQz0IDTdi XL/AB/nB95fb+btJGU+6YTyAc5zgAdWaGSSVTg7sVFHYKxHXqtKP4UFYIAC+qqYD lyjhdXHlNiydShrIIL/KEnRvb6WgMSoI2FBZ87bJQU2CX8LZRQOHamhNBbbGoA41 DUjcfWZuL8QMSInj/2Yt8K+d0jD723pfcMFgCCahePfLI94y5l1+Ro2lXdOhvbFf elfZi35XUw== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 94ec6d94 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for ; Mon, 17 Jul 2017 14:40:30 +0000 (UTC) To: bug-guix@gnu.org From: Tobias Geerinckx-Rice Subject: Unbootable images with GuixSD on... "GuixSD" Message-ID: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> Date: Mon, 17 Jul 2017 16:40:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="HU6hhLiOEs1lAe2V7De72IAHdPun5MQjb" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --HU6hhLiOEs1lAe2V7De72IAHdPun5MQjb Content-Type: multipart/mixed; boundary="OtRPe9L1PHa26TiuI7RP8DG4JCsljhrbb"; protected-headers="v1" From: Tobias Geerinckx-Rice To: bug-guix@gnu.org Message-ID: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> Subject: Unbootable images with GuixSD on... "GuixSD" --OtRPe9L1PHa26TiuI7RP8DG4JCsljhrbb Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Guix, [I lost most hours of sleep to this. I might ramble more than usual.] The default label for images was recently changed[1] to "GuixSD". While I think it's a fine label, that's also a problem: I've been using it for years for my root partitions. And when one broke last night, I couldn't use the GuixSD installer to rescue it. The installer's now expects exactly one "GuixSD" partition when booting =E2=80=94 at least on UEFI. If the GRUB finds two, the GRUB will randomly= choose. In my case, the GRUB chose a frozen system. (With a black screen that made debugging hell, but that's probably an unrelated effect of the roughness of our UEFI support.) The real problem here is that we're using a label as a UUID. =46rom gnu/build/vm.scm: ;; Create a tiny configuration file telling the embedded grub ;; where to load the real thing. (call-with-output-file grub-config (lambda (port) (format port "insmod part_msdos~@ search --set=3Droot --label GuixSD~@ configfile /boot/grub/grub.cfg~%"))) I'm not the first to think so, as noted in gnu/system/vm.scm: (define root-label ;; Volume name of the root file system. Since we don't know which device ;; will hold it, we use the volume name to find it (using the UUID wo= uld ;; be even better, but somewhat less convenient.) (normalize-label "GuixSD")) I like that understatement. I'm not sure how to go about creating a reproducible almost-UUID based on the store hash and passing it to all the right places in a reasonably non-horrible manner either, random hacker. And it would mean even more work and testing after all the heroic effort on the new installer image + UEFI support by Danny, Marius, and others. Until it does happen, I suggest we change the name to "GuixSD-image"[2]. Still fragile, but not the PR fail that =E2=80=98don't call your GuixSD f= ile system GuixSD or it will break GuixSD=E2=80=99 would be. Zzz, T G-R [1]: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D651de2bdb5fd451c5= 0933dcf8d647d470d826261 [2]: Or whatever. I remember someone (Danny?) calling "-image" an implementation detail. I think it's a description of the end result. --OtRPe9L1PHa26TiuI7RP8DG4JCsljhrbb-- --HU6hhLiOEs1lAe2V7De72IAHdPun5MQjb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFBBAEBCgArFiEEeqzfDJ8DWw5d4xcqkczbm0hUG5kFAllszHkNHG1lQHRvYmlh cy5ncgAKCRCRzNubSFQbmQuXB/45wH+KpPdTnLpLukC9KS/zOOYGgMmTu5ca8T1S g4yKF8egsNTTQI3AdT3sHqGjmzhWJf1NHsulTYH4AVjgSVg8UZaQ5EkFDwD9Mo7q xynyNhTd3VuOjiFFpKFFnvhfLuyxLmx2ULqJYiqS2Sc1wdML/TSpeIVph7kkxymi 2g7r6rjnJCnFGODyZzJTgqnJAmF4zRLH3R1GtnDDgCNNRB3aN3NyL8dqk16P6ciP 7deulUPQVgbnIJTvkB7MAESHnwZ2fv+dDLcAQ9lMwQtZtQx2e4FOESkV5VqX4lDG LR3y7eJULvrmqDLbA02Pv93zEPFzAqLgRz9cySo7tNb9n9X0 =vYha -----END PGP SIGNATURE----- --HU6hhLiOEs1lAe2V7De72IAHdPun5MQjb-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 10:50:31 2017 Received: (at 27735) by debbugs.gnu.org; 17 Jul 2017 14:50:31 +0000 Received: from localhost ([127.0.0.1]:44580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dX7Lx-0008C4-ON for submit@debbugs.gnu.org; Mon, 17 Jul 2017 10:50:31 -0400 Received: from tobias.gr ([51.15.135.5]:34840) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dX7Lv-0008Bt-G9 for 27735@debbugs.gnu.org; Mon, 17 Jul 2017 10:50:27 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id d06a3390 for <27735@debbugs.gnu.org>; Mon, 17 Jul 2017 14:50:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to :subject:date:message-id:mime-version:content-transfer-encoding; s=201706; bh=NctpWrI7ZQfDkjV1apQmOV1iWE0tkAJ0HlnMHpH10Lc=; b=HW gGowxF+5LnQ1SUoRQpwYZRFwuSwqjC+A6C0byFRJqLLvzeANkMyoPYNficjncmYg 7aVo90Buz7f0wCIh5VpBtcAsyOQK5+0UOBXOUmy6QEUqTuQYgJ2wLt65Sa3MZ20x I0ViNbdSNuhjIiu0BmxcqCQbYn9dXkOOUHRMHorqP7Fp6yzhD0KBvzxkMFZn7Sug PRSSIc9dBUPvw1Q5b9m40No92gU6P8nHcyEmJWJflXTkktAx4dUUAbLTDok1eaFV 8DJe8qggGjYkoBoaSJH3wQKFC3hMiukYsVorhX1dngYHmjZNfQLoiIlMfmd5fA4V hWLzaaTPQ87HJpAL7/fQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 45e9a9f6 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <27735@debbugs.gnu.org>; Mon, 17 Jul 2017 14:50:22 +0000 (UTC) From: Tobias Geerinckx-Rice To: 27735@debbugs.gnu.org Subject: [PATCH 1/2] build, vm: Use a slightly less generic label. Date: Mon, 17 Jul 2017 16:51:51 +0200 Message-Id: <20170717145151.12222-1-me@tobias.gr> X-Mailer: git-send-email 2.13.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27735 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) * gnu/build/vm.scm (initialize-hard-disk): Use "GuixSD-image" as label. * gnu/system/install.scm (installation-os): Likewise. * gnu/system/vm.scm (system-disk-image): Likewise. --- Or GuixSD-bikeshed or whatever. gnu/build/vm.scm | 7 +++++-- gnu/system/install.scm | 2 +- gnu/system/vm.scm | 2 +- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/gnu/build/vm.scm b/gnu/build/vm.scm index d8c53ef37..e71b1b92e 100644 --- a/gnu/build/vm.scm +++ b/gnu/build/vm.scm @@ -354,7 +354,7 @@ SYSTEM-DIRECTORY is the name of the directory of the 'system' derivation." (error "failed to create GRUB EFI image")))) (define* (make-iso9660-image grub config-file os-drv target - #:key (volume-id "GuixSD") (volume-uuid #f)) + #:key (volume-id "GuixSD-image") (volume-uuid #f)) "Given a GRUB package, creates an iso image as TARGET, using CONFIG-FILE as Grub configuration and OS-DRV as the stuff in it." (let ((grub-mkrescue (string-append grub "/bin/grub-mkrescue"))) @@ -440,11 +440,14 @@ passing it a directory name where it is mounted." ;; Create a tiny configuration file telling the embedded grub ;; where to load the real thing. + ;; XXX This is quite fragile, and can leave the system in an unusable + ;; state when there's more than one volume with this label present. + ;; Reproducible (not-)UUIDs could reduce the risk but not eliminate it. (call-with-output-file grub-config (lambda (port) (format port "insmod part_msdos~@ - search --set=root --label GuixSD~@ + search --set=root --label GuixSD-image~@ configfile /boot/grub/grub.cfg~%"))) (display "creating EFI firmware image...") diff --git a/gnu/system/install.scm b/gnu/system/install.scm index f9aa7f673..866440eb4 100644 --- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -306,7 +306,7 @@ Use Alt-F2 for documentation. ;; the appropriate one. (cons* (file-system (mount-point "/") - (device "GuixSD") + (device "GuixSD-image") (title 'label) (type "ext4")) diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index dd9be2c6f..6e06781d5 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -345,7 +345,7 @@ to USB sticks meant to be read-only." ;; Volume name of the root file system. Since we don't know which device ;; will hold it, we use the volume name to find it (using the UUID would ;; be even better, but somewhat less convenient.) - (normalize-label "GuixSD")) + (normalize-label "GuixSD-image")) (define file-systems-to-keep (remove (lambda (fs) -- 2.13.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 13:17:42 2017 Received: (at 27735) by debbugs.gnu.org; 17 Jul 2017 17:17:42 +0000 Received: from localhost ([127.0.0.1]:44740 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dX9eQ-00070K-0W for submit@debbugs.gnu.org; Mon, 17 Jul 2017 13:17:42 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:37622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dX9eO-00070C-96 for 27735@debbugs.gnu.org; Mon, 17 Jul 2017 13:17:40 -0400 Received: from localhost (77.118.197.241.wireless.dyn.drei.com [77.118.197.241]) by dd1012.kasserver.com (Postfix) with ESMTPSA id E37F21CA0071; Mon, 17 Jul 2017 19:17:37 +0200 (CEST) Date: Mon, 17 Jul 2017 19:17:31 +0200 From: Danny Milosavljevic To: Tobias Geerinckx-Rice Subject: Re: bug#27735: Unbootable images with GuixSD on... "GuixSD" Message-ID: <20170717191731.2d3ad604@scratchpost.org> In-Reply-To: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27735 Cc: 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi T G-R, On Mon, 17 Jul 2017 16:40:56 +0200 Tobias Geerinckx-Rice wrote: > The installer's now expects exactly one "GuixSD" partition when booting > =E2=80=94 at least on UEFI. If the GRUB finds two, the GRUB will randomly > choose. In my case, the GRUB chose a frozen system. Sorry! > The real problem here is that we're using a label as a UUID. I agree. Unfortunately Guix UUIDs are difficult to use consistently or I w= ould have changed it over to begin with. > (define root-label > ;; Volume name of the root file system. Since we don't know which > device > ;; will hold it, we use the volume name to find it (using the UUID wo= uld > ;; be even better, but somewhat less convenient.) > (normalize-label "GuixSD")) >=20 > I like that understatement. I'm not sure how to go about creating a > reproducible almost-UUID based on the store hash and passing it to all > the right places in a reasonably non-horrible manner either, random > hacker. And it would mean even more work and testing after all the > heroic effort on the new installer image + UEFI support by Danny, > Marius, and others. Yeah, having the UUID actually be derived from the store hash would be good. I think for now having a random UUID be generated would be fine too. > Until it does happen, I suggest we change the name to "GuixSD-image"[2]. > Still fragile, but not the PR fail that =E2=80=98don't call your GuixSD f= ile > system GuixSD or it will break GuixSD=E2=80=99 would be. I think for the time being that's a good workaround. But I think we should= get the UUIDs for booting working. > [1]: https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3D651de2bdb5fd= 451c50933dcf8d647d470d826261 The actual reason I had to change it is because of the dashes (which are no= t valid in ECMA-6 IRV). > [2]: Or whatever.=20 "GuixSD_installer" ? Well anyway, just pick one, doesn't matter much which= , except that the characters have to be out of [A-Za-z0-9_] (will be upperc= ased for ISO-9660) because of ECMA-119 Appendix A (ECMA-6 IRV). >I remember someone (Danny?) calling "-image" an > implementation detail. I think it's a description of the end result. Yeah, that was me. I don't understand how an actual operating system on a = drive is an image. Maybe I'm old-fashioned, dunno, but I think an image is= something that is made up by light rays on a screen, not the real object. = In the case of computing an image is a backup file of a drive, not what is= on the drive to begin with. Also, even if it were an image, the image shouldn't say " image" in th= e image itself. A mirror which doesn't add anything to your image when you= look into it, either :) From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 13:20:45 2017 Received: (at 27735) by debbugs.gnu.org; 17 Jul 2017 17:20:45 +0000 Received: from localhost ([127.0.0.1]:44745 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dX9hN-00074e-Ic for submit@debbugs.gnu.org; Mon, 17 Jul 2017 13:20:45 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:37860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dX9hM-00074V-94 for 27735@debbugs.gnu.org; Mon, 17 Jul 2017 13:20:44 -0400 Received: from localhost (77.118.197.241.wireless.dyn.drei.com [77.118.197.241]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 4D3D11CA0071; Mon, 17 Jul 2017 19:20:43 +0200 (CEST) Date: Mon, 17 Jul 2017 19:20:38 +0200 From: Danny Milosavljevic To: Tobias Geerinckx-Rice Subject: Re: bug#27735: [PATCH 1/2] build, vm: Use a slightly less generic label. Message-ID: <20170717192038.5b19d711@scratchpost.org> In-Reply-To: <20170717145151.12222-1-me@tobias.gr> References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717145151.12222-1-me@tobias.gr> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27735 Cc: 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dash is invalid. Otherwise OK! From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 13:56:38 2017 Received: (at 27735) by debbugs.gnu.org; 17 Jul 2017 17:56:38 +0000 Received: from localhost ([127.0.0.1]:44751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXAG6-0007sC-HG for submit@debbugs.gnu.org; Mon, 17 Jul 2017 13:56:38 -0400 Received: from tobias.gr ([51.15.135.5]:47576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXAG4-0007s2-95 for 27735@debbugs.gnu.org; Mon, 17 Jul 2017 13:56:36 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id e7744c33; Mon, 17 Jul 2017 17:56:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=subject:to :references:from:message-id:date:mime-version:in-reply-to :content-type; s=201706; bh=t5+4l6TwRkNIQhDK+BRxcU76wt+yLZWsgxl6 kIE2uQA=; b=b6Z02fHZFqGB29Z4+yRPglYGJVLjHOPUv/hzDomTFU0obUcnKdNU 2NYx7wGywh+LqgphGasuI3VxR1xJkk671992SU3gmYaMOwf7m6hgEj7PsX4Pd+D9 1bphHTA0o4O/Qj/Ja57J4Cac5Ejnq6kwgBKIYq1z9MZDIUfuD3M/Mxh7eSsusLZi 1kBURqVJ6A8+h9upTZN/l5H9B34M40fRKxZYmdq/QrRuq26tkuc/zOOH6Qvho4UC CKXlZdhF+6cNDMj9y7CS/22re2Y9HYubV5R8KWfO7k61+vGyUhLU27CuaVuPWf64 6EE6fza6q0/SZb34l63UcaAbmPbVZw04Nw== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 2d1a8d89 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Mon, 17 Jul 2017 17:56:24 +0000 (UTC) Subject: Re: bug#27735: [PATCH 1/2] build, vm: Use a slightly less generic label. To: dannym@scratchpost.org, 27735@debbugs.gnu.org References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717145151.12222-1-me@tobias.gr> <20170717192038.5b19d711@scratchpost.org> From: Tobias Geerinckx-Rice Message-ID: <4ad6ce9e-d710-df7f-9097-a214fd0b05ed@tobias.gr> Date: Mon, 17 Jul 2017 19:58:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170717192038.5b19d711@scratchpost.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2FgFGL2dkFStIdrW46gMO6cUhcpNHDdjv" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27735 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2FgFGL2dkFStIdrW46gMO6cUhcpNHDdjv Content-Type: multipart/mixed; boundary="KQ54KmD6TNTpCTgH7qkuc6gupOVOkLI13"; protected-headers="v1" From: Tobias Geerinckx-Rice To: dannym@scratchpost.org, 27735@debbugs.gnu.org Message-ID: <4ad6ce9e-d710-df7f-9097-a214fd0b05ed@tobias.gr> Subject: Re: bug#27735: [PATCH 1/2] build, vm: Use a slightly less generic label. References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717145151.12222-1-me@tobias.gr> <20170717192038.5b19d711@scratchpost.org> In-Reply-To: <20170717192038.5b19d711@scratchpost.org> --KQ54KmD6TNTpCTgH7qkuc6gupOVOkLI13 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Danny, On 17/07/17 19:20, Danny Milosavljevic wrote: > Dash is invalid. Otherwise OK! Good to know (I consider you an expert on file system label esoterica, mainly so I don't have to be). Thanks! Kind regards, T G-R --KQ54KmD6TNTpCTgH7qkuc6gupOVOkLI13-- --2FgFGL2dkFStIdrW46gMO6cUhcpNHDdjv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFBBAEBCgArFiEEeqzfDJ8DWw5d4xcqkczbm0hUG5kFAlls+qkNHG1lQHRvYmlh cy5ncgAKCRCRzNubSFQbmd5ECACM4eK2Z8d4EyC7jFwnY4tCvtXpA6/JTp9b136y 5hGDsgWdVlOf6L4dOJR7Rcuc+vwV94FDkCOz4IY0op8NHAAr6qEpz6YbtYxQfDiU CsSBO40BSfEUecVLZ2dyEY0yqZ+QlnrgnSteb141wykTnR/BGKevGfP4exRyGeAU SXg6QmVqtdtsyDdRry2m+8e+8Hf8V3FxKBAdFQbyQ26GynZboMpdzz+ZxgijAa8W lpsHS0w9EVULLqWs0RyMN2PftGovQPUFshgUDOHlnpGe0zV4mSZkt4gXaxmCM5SE 7SHCmTZFMxCgu3g78aoabIUa/J4fMNGuRIhSLfi4+gs7mEIZ =thmu -----END PGP SIGNATURE----- --2FgFGL2dkFStIdrW46gMO6cUhcpNHDdjv-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 14:11:24 2017 Received: (at 27735) by debbugs.gnu.org; 17 Jul 2017 18:11:24 +0000 Received: from localhost ([127.0.0.1]:44768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXAUO-0008Df-Gb for submit@debbugs.gnu.org; Mon, 17 Jul 2017 14:11:24 -0400 Received: from tobias.gr ([51.15.135.5]:48638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXAUM-0008DW-5X for 27735@debbugs.gnu.org; Mon, 17 Jul 2017 14:11:22 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 5dada7f1; Mon, 17 Jul 2017 18:11:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=subject:to :references:cc:from:message-id:date:mime-version:in-reply-to :content-type; s=201706; bh=NIbEECWBRvozNbidDID4ZOTkQgYgq+akuVUH nOt98ek=; b=sqqSAcnh6LHL5buP50852QfVv0r0Y7bVlzHglCx9VHIU1s4rxyly /jBnJQrOwzqNzGb0+GsF5ogo46K0fOHFJoUOvBKu7RRA7pTqZMW+zcKXW4MfEKB0 5UUSWBEWgBzOdlm5sto4YP2U1mi1Mnp4QG2SgTuTy6kSX6GcW8rcEkb0TJiGzCqj sbHwClCBim7Rnv7f9ua+/3+yp/sRrfkMvifpoOpIDP5OP0DzzLUHv89HYDcVqcQ9 BgKhDlsf9rDAa6ofP3P4rTNJ8+jHBnJA9l0L/EtTg2kM6S3y4EnCl7RKF/rnUiFb 7G1o9nvxA3ZWj646uVq/9U/uDr0ZsAaFig== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 96e310fe (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Mon, 17 Jul 2017 18:11:13 +0000 (UTC) Subject: Re: bug#27735: Unbootable images with GuixSD on... "GuixSD" To: dannym@scratchpost.org References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> From: Tobias Geerinckx-Rice Message-ID: <8a8ece74-7035-9893-f62b-875cae3cfd7a@tobias.gr> Date: Mon, 17 Jul 2017 20:12:50 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170717191731.2d3ad604@scratchpost.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="nUictl2LCmd0jjJQTW8tNVveVxq17Im7x" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27735 Cc: 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --nUictl2LCmd0jjJQTW8tNVveVxq17Im7x Content-Type: multipart/mixed; boundary="RxIWCroQLHL7LAj7AwKMJh9uPWA698qIx"; protected-headers="v1" From: Tobias Geerinckx-Rice To: dannym@scratchpost.org Cc: 27735@debbugs.gnu.org Message-ID: <8a8ece74-7035-9893-f62b-875cae3cfd7a@tobias.gr> Subject: Re: bug#27735: Unbootable images with GuixSD on... "GuixSD" References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> In-Reply-To: <20170717191731.2d3ad604@scratchpost.org> --RxIWCroQLHL7LAj7AwKMJh9uPWA698qIx Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 17/07/17 19:17, Danny Milosavljevic wrote:> Hi T G-R, > Yeah, that was me. I don't understand how an actual operating system > on a drive is an image. Maybe I'm old-fashioned, dunno, but I think > an image is something that is made up by light rays on a screen, not > the real object. In the case of computing an image is a backup file > of a drive, not what is on the drive to begin with. >=20 > Also, even if it were an image, the image shouldn't say " image" > in the image itself. A mirror which doesn't add anything to your > image when you look into it, either :) I agree completely. I've become so used to dd'ing ISOs to USB drives that I've come to think *only* in terms of fake discs, but you're right. I chose =E2=80=98image=E2=80=99 reluctantly, because my first ideas (=E2=80= =98installer=E2=80=99, =E2=80=98vm=E2=80=99) were even less relevant: this label's used for all disc images. Oh well. We could choose the worst and ugliest label possible: that'd compel someone to fix this! (No. "GuixSD_image" it is.) Thanks, T G-R --RxIWCroQLHL7LAj7AwKMJh9uPWA698qIx-- --nUictl2LCmd0jjJQTW8tNVveVxq17Im7x Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFBBAEBCgArFiEEeqzfDJ8DWw5d4xcqkczbm0hUG5kFAlls/iMNHG1lQHRvYmlh cy5ncgAKCRCRzNubSFQbmREzB/9SugtMB/iMid3iStr8KNenw/jPVw7LycZ12O5a AhJCD3Vm8a/evX04DoCYi/BBjEq8DOmKRzPoGYD3B4lH8wc7qKyZwYntPXMTCNpw o9mGuKdMGHrJCa44BSyrHfRnS5dmyN5ThKypVzfCwagU1vBq0OJI5Hi1wq34fghJ /JFkZWmKT71/RqgHZCpN98UEZd6rxOlyJ9QlBoJ2NoGnztgbMO/eGSTEE2TcCpKv Xk8sVYC/w3iYcTH54WHdcNmm2mfIBQnG/Mm89m5w9W4WPtZ4WkfQMDgKv0GnV98x YNokBrKWa7PXaQQUbN0khxGwaa/3L6wkC1iVrd45uy+LdGGe =gM/S -----END PGP SIGNATURE----- --nUictl2LCmd0jjJQTW8tNVveVxq17Im7x-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 14:36:10 2017 Received: (at 27735-done) by debbugs.gnu.org; 17 Jul 2017 18:36:10 +0000 Received: from localhost ([127.0.0.1]:44779 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXAsK-0000Lt-UX for submit@debbugs.gnu.org; Mon, 17 Jul 2017 14:36:10 -0400 Received: from tobias.gr ([51.15.135.5]:50454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXAsJ-0000Lk-68 for 27735-done@debbugs.gnu.org; Mon, 17 Jul 2017 14:36:07 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 0b6f254f for <27735-done@debbugs.gnu.org>; Mon, 17 Jul 2017 18:36:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=subject :references:to:from:message-id:date:mime-version:in-reply-to :content-type; s=201706; bh=jximJeWC0Kd8hSg2JNxWonXjQ6L7AtYD3rYg vCB6AAc=; b=rs7bzV3w2GGtmXWSd0FQN/GRQJ3xYPSYgjlKZx/CejsCAqHsqXhR zIBKg/SswDC+4Os7k7+GeyxVPDyUXV4tAz5sWZBDxM3XljL/kxt40waWMM/sWv9u UuDUTcyvtv9SuaDZTF1X+9++sE4AbcC6KgPsQIBaHf1SXseb+Y67rh3bea9nRtaB XisdAni99T2mUlr0b1wVAO/exlHvqEAxGU6f1FQCqHSZWxl5vhTcTzCzkEBIZqNE 57lK3aWIa3IrxQ4+g8KiItDz70g9XfvYMqfEjqhLQa+UZ6t8HTrRgRsUc8WCdwTz 5sxj5DUXU2XscWzWXbZf8FYyGSl0UIbxHQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 273cdf47 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <27735-done@debbugs.gnu.org>; Mon, 17 Jul 2017 18:35:59 +0000 (UTC) Subject: Re: bug#27735: Unbootable images with GuixSD on... "GuixSD" References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> <8a8ece74-7035-9893-f62b-875cae3cfd7a@tobias.gr> To: 27735-done@debbugs.gnu.org From: Tobias Geerinckx-Rice Message-ID: <2b71a313-b00b-9df8-dc38-3e8332ac184f@tobias.gr> Date: Mon, 17 Jul 2017 20:37:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <8a8ece74-7035-9893-f62b-875cae3cfd7a@tobias.gr> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="agG562bPB9MwI32xwSgwp3Tn78Pbcm8o3" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27735-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --agG562bPB9MwI32xwSgwp3Tn78Pbcm8o3 Content-Type: multipart/mixed; boundary="7h7ub5xgMHL7CGf5s5ovt3Pxp9tICaWlO"; protected-headers="v1" From: Tobias Geerinckx-Rice To: 27735-done@debbugs.gnu.org Message-ID: <2b71a313-b00b-9df8-dc38-3e8332ac184f@tobias.gr> Subject: Re: bug#27735: Unbootable images with GuixSD on... "GuixSD" References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> <8a8ece74-7035-9893-f62b-875cae3cfd7a@tobias.gr> In-Reply-To: <8a8ece74-7035-9893-f62b-875cae3cfd7a@tobias.gr> --7h7ub5xgMHL7CGf5s5ovt3Pxp9tICaWlO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Done with commit 0862b95433cacf91e44248097caa09119fc532a6. Kind regards, T G-R --7h7ub5xgMHL7CGf5s5ovt3Pxp9tICaWlO-- --agG562bPB9MwI32xwSgwp3Tn78Pbcm8o3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFBBAEBCgArFiEEeqzfDJ8DWw5d4xcqkczbm0hUG5kFAlltA/ENHG1lQHRvYmlh cy5ncgAKCRCRzNubSFQbmSaDCACqlDS45KXhL6ZcBTcDBh12d9nDXC7/Gv4CV1s5 y0uhrxSC1e/XMeuLq8ydlOLggYCt+pkoc/pVQvjTyvPsTZJUi56DAuxp/Cw1RhNJ jqVQiQOYaR57V2PbrwXNYh4O1ntBKH8XTGwZFAXdKB3aagcVyO4Z16GKYbeTpr0t TAUm2Ijj/jPF/RWTqKRifTDvLs3BLXBlvtrnbX4wpX4Toa8F94QkuXJggy4/Oaxe v7ZjnpzBBhso7MZMpUCCw1e5mAGI7Rl+xwoPtNi7fPyYlBJJhn9C0ZI1Q43HcQAq VxM7PA2pXYkw+2Vx/hV2vtR6LZY70aRqWG+1npUl0tWg0Vdd =/u20 -----END PGP SIGNATURE----- --agG562bPB9MwI32xwSgwp3Tn78Pbcm8o3-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 18 06:09:14 2017 Received: (at 27735) by debbugs.gnu.org; 18 Jul 2017 10:09:14 +0000 Received: from localhost ([127.0.0.1]:45361 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXPRK-00025j-M9 for submit@debbugs.gnu.org; Tue, 18 Jul 2017 06:09:14 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45172) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXPRJ-00025W-6E for 27735@debbugs.gnu.org; Tue, 18 Jul 2017 06:09:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXPRA-0004QA-Sv for 27735@debbugs.gnu.org; Tue, 18 Jul 2017 06:09:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49030) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXPRA-0004Q6-Qa; Tue, 18 Jul 2017 06:09:04 -0400 Received: from [193.50.110.220] (port=39788 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dXPRA-0006vL-EJ; Tue, 18 Jul 2017 06:09:04 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: bug#27735: [PATCH 1/2] build, vm: Use a slightly less generic label. References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717145151.12222-1-me@tobias.gr> <20170717192038.5b19d711@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 Messidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Tue, 18 Jul 2017 12:09:02 +0200 In-Reply-To: <20170717192038.5b19d711@scratchpost.org> (Danny Milosavljevic's message of "Mon, 17 Jul 2017 19:20:38 +0200") Message-ID: <87lgnm12gx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27735 Cc: Tobias Geerinckx-Rice , 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Danny Milosavljevic skribis: > Dash is invalid. Otherwise OK! Can we do =E2=80=98string-map=E2=80=99 to replace dash with underscore, jus= t like we did =E2=80=98normalize-label=E2=80=99? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 18 07:49:15 2017 Received: (at 27735) by debbugs.gnu.org; 18 Jul 2017 11:49:15 +0000 Received: from localhost ([127.0.0.1]:45411 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXR06-00087K-Qk for submit@debbugs.gnu.org; Tue, 18 Jul 2017 07:49:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51741) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXR04-000877-Vq for 27735@debbugs.gnu.org; Tue, 18 Jul 2017 07:49:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXQzw-0008Vb-Qs for 27735@debbugs.gnu.org; Tue, 18 Jul 2017 07:49:07 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD, T_FILL_THIS_FORM_SHORT autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50221) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXQzw-0008VX-Mr; Tue, 18 Jul 2017 07:49:04 -0400 Received: from [193.50.110.220] (port=39796 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dXQzw-00027U-5l; Tue, 18 Jul 2017 07:49:04 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: bug#27735: Unbootable images with GuixSD on... "GuixSD" References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 Messidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Tue, 18 Jul 2017 13:49:01 +0200 In-Reply-To: <20170717191731.2d3ad604@scratchpost.org> (Danny Milosavljevic's message of "Mon, 17 Jul 2017 19:17:31 +0200") Message-ID: <87bmoi0xua.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27735 Cc: Tobias Geerinckx-Rice , 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Hello, Danny Milosavljevic skribis: >> The real problem here is that we're using a label as a UUID. > > I agree. Unfortunately Guix UUIDs are difficult to use consistently or I would have changed it over to begin with. What about generating a UUID in a deterministic yet somewhat unique fashion along these lines (untested): --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index ec3fb031a..6b53eacbf 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -56,9 +56,12 @@ #:use-module (gnu system file-systems) #:use-module (gnu system) #:use-module (gnu services) + #:use-module ((gnu build file-systems) + #:select (string->iso9660-uuid)) #:use-module (srfi srfi-1) #:use-module (srfi srfi-26) + #:use-module (rnrs bytevectors) #:use-module (ice-9 match) #:export (expression->derivation-in-linux-vm @@ -344,12 +347,29 @@ to USB sticks meant to be read-only." (if (string=? "iso9660" file-system-type) string-upcase identity)) + (define root-label - ;; Volume name of the root file system. Since we don't know which device - ;; will hold it, we use the volume name to find it (using the UUID would - ;; be even better, but somewhat less convenient.) + ;; Volume name of the root file system. (normalize-label "GuixSD_image")) + (define root-uuid + ;; UUID of the root file system, computed in a deterministic fashion. + (if (string=? "iso9660" file-system-type) + (let ((pad (compose (cut string-pad <> 2 #\0) + number->string))) + (string->iso9660-uuid + (string-append "1970-01-01-" + (pad (hash name 24)) + (pad (hash file-system-type 60)) + (pad (hash (operating-system-host-name os) 60))))) + (uint-list->bytevector + (list (hash (string-append file-system-type name) + (expt 2 64)) + (hash (operating-system-host-name os) + (expt 2 64))) + (endianness little) + 8))) + (define file-systems-to-keep (remove (lambda (fs) (string=? (file-system-mount-point fs) "/")) @@ -367,8 +387,8 @@ to USB sticks meant to be read-only." ;; Force our own root file system. (file-systems (cons (file-system (mount-point "/") - (device root-label) - (title 'label) + (device root-uuid) + (title 'uuid) (type file-system-type)) file-systems-to-keep))))) @@ -376,8 +396,7 @@ to USB sticks meant to be read-only." (bootcfg (operating-system-bootcfg os))) (if (string=? "iso9660" file-system-type) (iso9660-image #:name name - #:file-system-label root-label - #:file-system-uuid #f + #:file-system-uuid root-uuid #:os-drv os-drv #:bootcfg-drv bootcfg #:bootloader (bootloader-configuration-bootloader @@ -395,7 +414,7 @@ to USB sticks meant to be read-only." file-system-type) "ext4" file-system-type) - #:file-system-label root-label + #:file-system-label root-label ;FIXME: use ROOT-UUID #:copy-inputs? #t #:register-closures? #t #:inputs `(("system" ,os-drv) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable We cannot use the store file name=E2=80=99s hash, unfortunately, because the UUID has to be given on the =E2=80=9Chost side.=E2=80=9D Thoughts? Ludo=E2=80=99. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 18 08:28:38 2017 Received: (at 27735) by debbugs.gnu.org; 18 Jul 2017 12:28:38 +0000 Received: from localhost ([127.0.0.1]:45493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXRcE-0000hO-Kj for submit@debbugs.gnu.org; Tue, 18 Jul 2017 08:28:38 -0400 Received: from tobias.gr ([51.15.135.5]:40094) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXRcD-0000hF-4s for 27735@debbugs.gnu.org; Tue, 18 Jul 2017 08:28:37 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 111e1808; Tue, 18 Jul 2017 12:28:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=subject:to :references:cc:from:message-id:date:mime-version:in-reply-to :content-type; s=201706; bh=4SJ3e02udoQ+IJHyDjN53lycAoNMTG5SDRGD U9dgX+k=; b=hKp3U01BPt4NeY05WVM6XTtbTuLWDLwyIkMfflPWqweGHlWvxWfY +0hA44BdfIZFevw7Rb45L1dZ9PchDKRMursPJaxI1V9oAehxemHrx070iP+fvVNY Pd3kEzRSF94m9XUV8pZxKJk9nH0Tk1J5k/xqOer21FfF5nnYt/KCnoZYs6GmgSTf Nx7wEbpXjXlJ6p37tSvsrGg8SB7CB5RAZLGb8BmDT4Xzirsy7NlzwPPrVClq9VgH t/LCgDszTzg/fIF/xOEhV6v0t+0LhdzAeaZ7FOuGbHezz0Jz2m0WX2NhMbdCaBqt CSGqzjCFtBvIX21m2AsRk+yYzM7irjty6g== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id cb1cdf27 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Tue, 18 Jul 2017 12:28:31 +0000 (UTC) Subject: Re: bug#27735: [PATCH 1/2] build, vm: Use a slightly less generic label. To: ludo@gnu.org, dannym@scratchpost.org References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717145151.12222-1-me@tobias.gr> <20170717192038.5b19d711@scratchpost.org> <87lgnm12gx.fsf@gnu.org> From: Tobias Geerinckx-Rice Message-ID: Date: Tue, 18 Jul 2017 14:30:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <87lgnm12gx.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="WfWmoFUIp41HVB2mCi5qMBAFpXv6miCao" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27735 Cc: 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WfWmoFUIp41HVB2mCi5qMBAFpXv6miCao Content-Type: multipart/mixed; boundary="4a2mChv9Aok5PkTNn6flGrxti1qCRauBO"; protected-headers="v1" From: Tobias Geerinckx-Rice To: ludo@gnu.org, dannym@scratchpost.org Cc: 27735@debbugs.gnu.org Message-ID: Subject: Re: bug#27735: [PATCH 1/2] build, vm: Use a slightly less generic label. References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717145151.12222-1-me@tobias.gr> <20170717192038.5b19d711@scratchpost.org> <87lgnm12gx.fsf@gnu.org> In-Reply-To: <87lgnm12gx.fsf@gnu.org> --4a2mChv9Aok5PkTNn6flGrxti1qCRauBO Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludo', On 18/07/17 12:09, Ludovic Court=C3=A8s wrote: > Can we do =E2=80=98string-map=E2=80=99 to replace dash with underscore,= just like we did > =E2=80=98normalize-label=E2=80=99? That would have been a better approach. :-) Kind regards, T G-R --4a2mChv9Aok5PkTNn6flGrxti1qCRauBO-- --WfWmoFUIp41HVB2mCi5qMBAFpXv6miCao Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFBBAEBCgArFiEEeqzfDJ8DWw5d4xcqkczbm0hUG5kFAllt/1INHG1lQHRvYmlh cy5ncgAKCRCRzNubSFQbmSX8B/9HV7VZEGdbAgDEVj8R3nxrbCDlDzDm8ebmBtcN DruJptSjFjgmI7AFOy8lazu7Lj5coxMkBto7J6woQ7x6qrsD6JpXQZSq5O49iH8z Y9t8K7oBbrHNXK2xzPW4+t4rz0Ln38yAdZgTFoG89nejz1wFheu102+m8rnwlG1p nxUqN66YoCzsVCrtTxf5T7DPGungypTw1nONP3RkVl5GtEKAb0YYbOCmSgclGHcQ ztuKUUzCLHVWcRzP8CYW9RQO/JozF6qwkSm9uW9Q5bMwY3Vjl/EJS1ttQha7fUan 1NUv7NlodZKTLbLzXik1cH7JaNvqRvO2h0K4fqfyy0Vivq2M =tjGU -----END PGP SIGNATURE----- --WfWmoFUIp41HVB2mCi5qMBAFpXv6miCao-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 18 09:48:57 2017 Received: (at 27735) by debbugs.gnu.org; 18 Jul 2017 13:48:57 +0000 Received: from localhost ([127.0.0.1]:45554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXSrw-0002Z5-7a for submit@debbugs.gnu.org; Tue, 18 Jul 2017 09:48:57 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:53904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXSrt-0002Yn-CA for 27735@debbugs.gnu.org; Tue, 18 Jul 2017 09:48:54 -0400 Received: from localhost (178.113.167.130.wireless.dyn.drei.com [178.113.167.130]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 8A6141CA02BE; Tue, 18 Jul 2017 15:48:51 +0200 (CEST) Date: Tue, 18 Jul 2017 15:48:45 +0200 From: Danny Milosavljevic To: Tobias Geerinckx-Rice Subject: Re: bug#27735: [PATCH 1/2] build, vm: Use a slightly less generic label. Message-ID: <20170718154845.5cd79c48@scratchpost.org> In-Reply-To: References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717145151.12222-1-me@tobias.gr> <20170717192038.5b19d711@scratchpost.org> <87lgnm12gx.fsf@gnu.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27735 Cc: ludo@gnu.org, 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi T G-R, Hi Ludo, On Tue, 18 Jul 2017 14:30:10 +0200 Tobias Geerinckx-Rice wrote: > On 18/07/17 12:09, Ludovic Court=C3=A8s wrote: > > Can we do =E2=80=98string-map=E2=80=99 to replace dash with underscore,= just like we did > > =E2=80=98normalize-label=E2=80=99? =20 Yes. > That would have been a better approach. :-) I disagree that that would be better. Every map is a source of error and a= lso makes it difficult to follow what is going on (i.e. difficult to mainta= in). Best is only to use the common intersection of all the valid charsets and n= ot map anything to anything else. We can map it and it's OK but it's not good in the long run. I've learnt t= hat the hard way over many years. But since we do string-upcase already, it doesn't matter anymore. Better h= ope we don't break it by accident one day (or right away), though. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 18 11:07:51 2017 Received: (at 27735) by debbugs.gnu.org; 18 Jul 2017 15:07:51 +0000 Received: from localhost ([127.0.0.1]:46771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXU6I-0006bS-VY for submit@debbugs.gnu.org; Tue, 18 Jul 2017 11:07:51 -0400 Received: from tobias.gr ([51.15.135.5]:47606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXU6G-0006bJ-UN for 27735@debbugs.gnu.org; Tue, 18 Jul 2017 11:07:49 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 5690ef90; Tue, 18 Jul 2017 15:07:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=subject:to :references:cc:from:message-id:date:mime-version:in-reply-to :content-type; s=201706; bh=BElnBEPeYCDohS0K3ga19FTD3fudlE2bed9l XTUktms=; b=XX6KZxsTcwqjdVxiRY5scbLQWB8ErPUkBzVf58GXS2wAUim1ob32 ka1E4AbIvdIyzf6BLjle/61KjlJNDYz/UZjvCGP5v8xoF4O5AngyBh5g8WvQKHHx E4db1ZVHrt81gf0VPkVUya9nU9x8xprObRt3zaX5syvQTBsPHB5+fuRmPn4hltMU kDdjlFQ/UdrBeE8Jd3va31jEhpcn93nnFMV3sHcoByGSPWL7r7ogHz4HlM2Wk1G5 nAhaPwI6bWHOqo3InsvTEvsX23YIBS7+ZzLNTpFHS9KPHd5kzTq/e1wbAYLqgFLR 0XHFBETgYDymhezac+Ty/qaQ8/pwdT2POA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id a3e97cdd (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Tue, 18 Jul 2017 15:07:29 +0000 (UTC) Subject: Re: bug#27735: Unbootable images with GuixSD on... "GuixSD" To: ludo@gnu.org, dannym@scratchpost.org References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> <87bmoi0xua.fsf@gnu.org> From: Tobias Geerinckx-Rice Message-ID: <9b7cffa7-96a4-a799-c207-854bbcc7df04@tobias.gr> Date: Tue, 18 Jul 2017 17:09:08 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <87bmoi0xua.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="rDLhNsset0PCCRPlGhGqmaXor9OmU6Hji" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27735 Cc: 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --rDLhNsset0PCCRPlGhGqmaXor9OmU6Hji Content-Type: multipart/mixed; boundary="FPVCdikmf3d20qmi4fb260e4IHUg5SHAn"; protected-headers="v1" From: Tobias Geerinckx-Rice To: ludo@gnu.org, dannym@scratchpost.org Cc: 27735@debbugs.gnu.org Message-ID: <9b7cffa7-96a4-a799-c207-854bbcc7df04@tobias.gr> Subject: Re: bug#27735: Unbootable images with GuixSD on... "GuixSD" References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> <87bmoi0xua.fsf@gnu.org> In-Reply-To: <87bmoi0xua.fsf@gnu.org> --FPVCdikmf3d20qmi4fb260e4IHUg5SHAn Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludo', On 18/07/17 13:49, Ludovic Court=C3=A8s wrote: > What about generating a UUID in a deterministic yet somewhat unique > fashion along these lines (untested): Not great, but I can't think of a better way. :-) > + (define root-uuid > + ;; UUID of the root file system, computed in a deterministic fashi= on. > + (if (string=3D? "iso9660" file-system-type) > + (let ((pad (compose (cut string-pad <> 2 #\0) > + number->string))) > + (string->iso9660-uuid > + (string-append "1970-01-01-" > + (pad (hash name 24)) > + (pad (hash file-system-type 60)) > + (pad (hash (operating-system-host-name os) 6= 0))))) > + (uint-list->bytevector > + (list (hash (string-append file-system-type name) > + (expt 2 64)) > + (hash (operating-system-host-name os) > + (expt 2 64))) > + (endianness little) > + 8))) > + Why not throw SIZE into this mix as well? When building without =E2=80=98--image-size=E2=80=99 (the default nowaday= s), it's a function of the exact size of the entire graph and reasonably sensitive to most kinds of input changes. > We cannot use the store file name=E2=80=99s hash, unfortunately, becaus= e the > UUID has to be given on the =E2=80=9Chost side.=E2=80=9D That is unfortunate, but a best-effort heuristic will do. Kind regards, T G-R --FPVCdikmf3d20qmi4fb260e4IHUg5SHAn-- --rDLhNsset0PCCRPlGhGqmaXor9OmU6Hji Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFBBAEBCgArFiEEeqzfDJ8DWw5d4xcqkczbm0hUG5kFAlluJJQNHG1lQHRvYmlh cy5ncgAKCRCRzNubSFQbmfG3CACfCji9bICDRuEYF8m2FZ2LyLuboWK3CIeubA9h SAeTY8bgXAmwMqlnDS3AXj9uM3fMX4FWIlYdF8RuMm/sHve7t9BtxRI190YCWXWv ZITMQB5oxzC8yIwOzIalJUCzGEwcALgVSo4Uj/mTYOnBUUSpQnMRdUBCMkRiV1At dDC8Gw5opm6iQmlOl/UoQOf///PfSXaGrKS6UEDQHSqR+zwSucPf0iOMCteEP7Hy yFh1xvywnhJIWVzt4WQhpCS6krNlFsHhoEBKzKa84kUYsjPGgSngwKTpKOZA8RHm ktzRwnjZaF9nGlbURG8u6zwnSA5yS/8wnYzdo0T2mBo/n40o =+Imj -----END PGP SIGNATURE----- --rDLhNsset0PCCRPlGhGqmaXor9OmU6Hji-- From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 18 14:59:48 2017 Received: (at 27735) by debbugs.gnu.org; 18 Jul 2017 18:59:48 +0000 Received: from localhost ([127.0.0.1]:46938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXXim-0005O3-Ad for submit@debbugs.gnu.org; Tue, 18 Jul 2017 14:59:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45920) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXXik-0005Nr-Ma for 27735@debbugs.gnu.org; Tue, 18 Jul 2017 14:59:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXXia-0007eX-G2 for 27735@debbugs.gnu.org; Tue, 18 Jul 2017 14:59:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57482) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXXia-0007eR-CY; Tue, 18 Jul 2017 14:59:36 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:42284 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dXXiZ-0005Ls-SA; Tue, 18 Jul 2017 14:59:36 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Tobias Geerinckx-Rice Subject: Re: bug#27735: Unbootable images with GuixSD on... "GuixSD" References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> <87bmoi0xua.fsf@gnu.org> <9b7cffa7-96a4-a799-c207-854bbcc7df04@tobias.gr> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 30 Messidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Tue, 18 Jul 2017 20:59:33 +0200 In-Reply-To: <9b7cffa7-96a4-a799-c207-854bbcc7df04@tobias.gr> (Tobias Geerinckx-Rice's message of "Tue, 18 Jul 2017 17:09:08 +0200") Message-ID: <87lgnlpo4q.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27735 Cc: dannym@scratchpost.org, 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Heya, Tobias Geerinckx-Rice skribis: > On 18/07/17 13:49, Ludovic Court=C3=A8s wrote: >> What about generating a UUID in a deterministic yet somewhat unique >> fashion along these lines (untested): > > Not great, but I can't think of a better way. :-) Yup. >> + (define root-uuid >> + ;; UUID of the root file system, computed in a deterministic fashio= n. >> + (if (string=3D? "iso9660" file-system-type) >> + (let ((pad (compose (cut string-pad <> 2 #\0) >> + number->string))) >> + (string->iso9660-uuid >> + (string-append "1970-01-01-" >> + (pad (hash name 24)) >> + (pad (hash file-system-type 60)) >> + (pad (hash (operating-system-host-name os) 60= ))))) >> + (uint-list->bytevector >> + (list (hash (string-append file-system-type name) >> + (expt 2 64)) >> + (hash (operating-system-host-name os) >> + (expt 2 64))) >> + (endianness little) >> + 8))) >> + > > Why not throw SIZE into this mix as well? Because it can be the symbol 'guess or a number, so that makes things needlessly complicated IMO. > When building without =E2=80=98--image-size=E2=80=99 (the default nowaday= s), it's a > function of the exact size of the entire graph and reasonably sensitive > to most kinds of input changes. The actual size is not known until the derivation is built; we don=E2=80=99t have access to that information here. >> We cannot use the store file name=E2=80=99s hash, unfortunately, because= the >> UUID has to be given on the =E2=80=9Chost side.=E2=80=9D > > That is unfortunate, but a best-effort heuristic will do. Yeah, still better than a hard-coded label I guess. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 18 16:40:50 2017 Received: (at 27735) by debbugs.gnu.org; 18 Jul 2017 20:40:51 +0000 Received: from localhost ([127.0.0.1]:46960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXZIY-0007o0-OG for submit@debbugs.gnu.org; Tue, 18 Jul 2017 16:40:50 -0400 Received: from tobias.gr ([51.15.135.5]:35162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXZIW-0007nr-4t for 27735@debbugs.gnu.org; Tue, 18 Jul 2017 16:40:48 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 805a645e; Tue, 18 Jul 2017 20:40:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=subject:to :references:cc:from:message-id:date:mime-version:in-reply-to :content-type; s=201706; bh=xcGpd7SCsCfOkARXe4AOtpzvsVuebrWivFUh aqCGxsw=; b=eCtDuHsi0kTc60h8mKvEwr1Z/mZvNnxebeWBsJUXRv/5XWQyc6Ws 9E2EpADE1uZL1T6fXu9MQN5fM9Cr9BuYmrgjQqD6WZ6NnbT5Eg4xOBVvbjvA31Cw F9GQhTHHoL4LglQsHJRwrkZEXXNNF+z9R8onqAYUXq3OOg+8xqndHnVvmVCjag+5 1c9cXqFkmJXv9FA9bLEU6xLYslVGfcb0KtEoYxwskW4adx8zGAixPidKFSjIoG+3 xNLUeIrm8DtmraWjFNJx4i0N+O5J6wREK4FSC4SbhV3DdB+j3B7BVazopx5U1/gk YJJGQ+gA8nccJhB3Qcf7wFnNnuNpTjji4A== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 322175db (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Tue, 18 Jul 2017 20:40:44 +0000 (UTC) Subject: Re: bug#27735: Unbootable images with GuixSD on... "GuixSD" To: ludo@gnu.org References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> <87bmoi0xua.fsf@gnu.org> <9b7cffa7-96a4-a799-c207-854bbcc7df04@tobias.gr> <87lgnlpo4q.fsf@gnu.org> From: Tobias Geerinckx-Rice Message-ID: <350d9a8b-9916-79f6-24f5-9cf223681729@tobias.gr> Date: Tue, 18 Jul 2017 22:42:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <87lgnlpo4q.fsf@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="fcW1ogbrcFIa0E7TU8v7gD22ctweCaclx" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27735 Cc: 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fcW1ogbrcFIa0E7TU8v7gD22ctweCaclx Content-Type: multipart/mixed; boundary="6fH6H8NQt94kkQeFcHVM9fbraCiN6XCQH"; protected-headers="v1" From: Tobias Geerinckx-Rice To: ludo@gnu.org Cc: 27735@debbugs.gnu.org Message-ID: <350d9a8b-9916-79f6-24f5-9cf223681729@tobias.gr> Subject: Re: bug#27735: Unbootable images with GuixSD on... "GuixSD" References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> <87bmoi0xua.fsf@gnu.org> <9b7cffa7-96a4-a799-c207-854bbcc7df04@tobias.gr> <87lgnlpo4q.fsf@gnu.org> In-Reply-To: <87lgnlpo4q.fsf@gnu.org> --6fH6H8NQt94kkQeFcHVM9fbraCiN6XCQH Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludo', On 18/07/17 20:59, Ludovic Court=C3=A8s wrote: >> Why not throw SIZE into this mix as well? >=20 > Because it can be the symbol 'guess or a number, so that makes things > needlessly complicated IMO. Of course. Thanks for your patience. I got completely lost in the gexp/ungexps of expression->derivation-in-linux-vm. Stupid. Kind regards, T G-R --6fH6H8NQt94kkQeFcHVM9fbraCiN6XCQH-- --fcW1ogbrcFIa0E7TU8v7gD22ctweCaclx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQFBBAEBCgArFiEEeqzfDJ8DWw5d4xcqkczbm0hUG5kFAllucq8NHG1lQHRvYmlh cy5ncgAKCRCRzNubSFQbmeHUB/sGa+oZSHZnV2EzyEDd5v+LfVQCkibAbrA4jF3q SS/zoMteaBDqFIWObHk5ijTTPw0gsMaykFfOHORXpgtRwo3neqrniq4B4hOH/8JP BEQuH6WZz5u35T/Q0IEC+wKro5ip/4BLDlw5nhMiLh+E09oIaw0VR453m4d3XKAn xz4LAeMbZIQq6L7/6Y7zUI834NU6Ck2vKrzGFMuM73Asw66nCNHJCOYND5w0Xwqg Vul9uZAzK8j/bg8nw3LWhn0a3QTrkk8QAa469qVzYN4/mPJthFH+c/SHIj5eR3/u eKoCQ0NLi8I0Mera+F5zf9tv8dpyHPOmSarEnpwS8kkjNwvk =78C6 -----END PGP SIGNATURE----- --fcW1ogbrcFIa0E7TU8v7gD22ctweCaclx-- From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 19 15:11:15 2017 Received: (at 27735) by debbugs.gnu.org; 19 Jul 2017 19:11:16 +0000 Received: from localhost ([127.0.0.1]:48141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXuNP-00024P-Ob for submit@debbugs.gnu.org; Wed, 19 Jul 2017 15:11:15 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:56508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXuNN-00024H-RY for 27735@debbugs.gnu.org; Wed, 19 Jul 2017 15:11:14 -0400 Received: from localhost (77.118.227.94.wireless.dyn.drei.com [77.118.227.94]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 7AA3B1CA0156; Wed, 19 Jul 2017 21:11:12 +0200 (CEST) Date: Wed, 19 Jul 2017 21:11:07 +0200 From: Danny Milosavljevic To: ludo@gnu.org (Ludovic =?ISO-8859-1?Q?Court=E8s?=) Subject: Re: bug#27735: Unbootable images with GuixSD on... "GuixSD" Message-ID: <20170719211107.51ebe24b@scratchpost.org> In-Reply-To: <87bmoi0xua.fsf@gnu.org> References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> <87bmoi0xua.fsf@gnu.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27735 Cc: Tobias Geerinckx-Rice , 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Ludo, I think it's a good interim solution. On Tue, 18 Jul 2017 13:49:01 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > + (define root-uuid > + ;; UUID of the root file system, computed in a deterministic fashion. > + (if (string=3D? "iso9660" file-system-type) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > + (let ((pad (compose (cut string-pad <> 2 #\0) > + number->string))) > + (string->iso9660-uuid > + (string-append "1970-01-01-" > + (pad (hash name 24)) > + (pad (hash file-system-type 60)) ^^^^^^^^^^^^^^^^^^^^^^^^^^ hmm... isn't t= hat constant? From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 19 18:32:37 2017 Received: (at 27735) by debbugs.gnu.org; 19 Jul 2017 22:32:37 +0000 Received: from localhost ([127.0.0.1]:48274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXxWG-0006zr-Ov for submit@debbugs.gnu.org; Wed, 19 Jul 2017 18:32:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXxWF-0006zc-0X for 27735@debbugs.gnu.org; Wed, 19 Jul 2017 18:32:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dXxW5-0000mk-3w for 27735@debbugs.gnu.org; Wed, 19 Jul 2017 18:32:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD, T_FILL_THIS_FORM_SHORT autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:48641) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dXxW4-0000mg-Ua; Wed, 19 Jul 2017 18:32:25 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:46310 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dXxW4-0003zZ-4O; Wed, 19 Jul 2017 18:32:24 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Lookup by UUID References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> <87bmoi0xua.fsf@gnu.org> <20170719211107.51ebe24b@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 Thermidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Thu, 20 Jul 2017 00:32:21 +0200 In-Reply-To: <20170719211107.51ebe24b@scratchpost.org> (Danny Milosavljevic's message of "Wed, 19 Jul 2017 21:11:07 +0200") Message-ID: <87tw28kqh6.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27735 Cc: Tobias Geerinckx-Rice , 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! Danny Milosavljevic skribis: > I think it's a good interim solution. Based on your feedback I=E2=80=99ve come up with the two attached patches. = I=E2=80=99ve checked at the REPL that =E2=80=98operating-system-uuid=E2=80=99 gives reas= onable results for different =E2=80=98operating-system=E2=80=99 configs, and deter= ministic results for a given config (OSes that are not =E2=80=98eq?=E2=80=99 but tha= t are equal.) On ext4 =E2=80=9Cguix system disk-image=E2=80=9D produces an image that wor= ks like a charm. With iso9660, it works=E2=80=A6 by chance, because GRUB=E2=80=99s =E2=80=9C= search --fs-uuid=E2=80=9D fails. Guess why? Because it compares UUIDs as strings, and we format it as a DCE UUID instead of an ISO UUID. Sounds familiar no? :-) So that=E2=80=99s where we are. Thoughts on how to address it? Cheers, Ludo=E2=80=99. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-vm-Allow-partitions-to-be-initialized-with-a-given-U.patch Content-Description: the first patch >From 00d49f0199dc51b02f2113c3669ea07f4461b102 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ludovic=20Court=C3=A8s?= Date: Thu, 20 Jul 2017 00:15:43 +0200 Subject: [PATCH] vm: Allow partitions to be initialized with a given UUID. * gnu/build/vm.scm ()[uuid]: New field. (create-ext-file-system): Add #:uuid and honor it. (create-fat-file-system): Add #:uuid. (format-partition): Add #:uuid and honor it. (initialize-partition): Honor the 'uuid' field of PARTITION. --- gnu/build/vm.scm | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git a/gnu/build/vm.scm b/gnu/build/vm.scm index 727494ad9..8dfaf2789 100644 --- a/gnu/build/vm.scm +++ b/gnu/build/vm.scm @@ -163,6 +163,7 @@ the #:references-graphs parameter of 'derivation'." (size partition-size) (file-system partition-file-system (default "ext4")) (label partition-label (default #f)) + (uuid partition-uuid (default #f)) (flags partition-flags (default '())) (initializer partition-initializer (default (const #t)))) @@ -236,22 +237,26 @@ actual /dev name based on DEVICE." (define MS_BIND 4096) ; again! (define* (create-ext-file-system partition type - #:key label) + #:key label uuid) "Create an ext-family filesystem of TYPE on PARTITION. If LABEL is true, -use that as the volume name." +use that as the volume name. If UUID is true, use it as the partition UUID." (format #t "creating ~a partition...\n" type) (unless (zero? (apply system* (string-append "mkfs." type) "-F" partition - (if label - `("-L" ,label) - '()))) + `(,@(if label + `("-L" ,label) + '()) + ,@(if uuid + `("-U" ,(uuid->string uuid)) + '())))) (error "failed to create partition"))) (define* (create-fat-file-system partition - #:key label) + #:key label uuid) "Create a FAT filesystem on PARTITION. The number of File Allocation Tables will be determined based on filesystem size. If LABEL is true, use that as the volume name." + ;; FIXME: UUID is ignored! (format #t "creating FAT partition...\n") (unless (zero? (apply system* "mkfs.fat" partition (if label @@ -260,13 +265,13 @@ volume name." (error "failed to create FAT partition"))) (define* (format-partition partition type - #:key label) + #:key label uuid) "Create a file system TYPE on PARTITION. If LABEL is true, use that as the volume name." (cond ((string-prefix? "ext" type) - (create-ext-file-system partition type #:label label)) + (create-ext-file-system partition type #:label label #:uuid uuid)) ((or (string-prefix? "fat" type) (string= "vfat" type)) - (create-fat-file-system partition #:label label)) + (create-fat-file-system partition #:label label #:uuid uuid)) (else (error "Unsupported file system.")))) (define (initialize-partition partition) @@ -275,7 +280,8 @@ it, run its initializer, and unmount it." (let ((target "/fs")) (format-partition (partition-device partition) (partition-file-system partition) - #:label (partition-label partition)) + #:label (partition-label partition) + #:uuid (partition-uuid partition)) (mkdir-p target) (mount (partition-device partition) target (partition-file-system partition)) -- 2.13.2 --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index 6f979aee4..bd1e1b3e5 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -56,9 +56,12 @@ #:use-module (gnu system file-systems) #:use-module (gnu system) #:use-module (gnu services) + #:use-module ((gnu build file-systems) + #:select (string->iso9660-uuid)) #:use-module (srfi srfi-1) #:use-module (srfi srfi-26) + #:use-module (rnrs bytevectors) #:use-module (ice-9 match) #:export (expression->derivation-in-linux-vm @@ -234,6 +237,7 @@ INPUTS is a list of inputs (as for packages)." (disk-image-format "qcow2") (file-system-type "ext4") file-system-label + file-system-uuid os-drv bootcfg-drv bootloader @@ -293,6 +297,7 @@ the image." (partitions (list (partition (size root-size) (label #$file-system-label) + (uuid #$file-system-uuid) (file-system #$file-system-type) (flags '(boot)) (initializer initialize)) @@ -330,6 +335,31 @@ the image." ;;; VM and disk images. ;;; +(define* (operating-system-uuid os #:optional (type 'dce)) + "Compute a deterministic \"UUID\" for OS, of the given TYPE (one of 'iso9660 +or 'dce)." + (if (eq? type 'iso9660) + (let ((pad (compose (cut string-pad <> 2 #\0) + number->string)) + (h (hash (operating-system-services os) 3600))) + (string->iso9660-uuid + (string-append "1970-01-01-" + (pad (hash (operating-system-host-name os) 24)) "-" + (pad (quotient h 60)) "-" + (pad (modulo h 60)) "-" + (pad (hash (operating-system-file-systems os) 100))))) + (uint-list->bytevector + (list (hash file-system-type + (expt 2 32)) + (hash (operating-system-host-name os) + (expt 2 32)) + (hash (operating-system-services os) + (expt 2 32)) + (hash (operating-system-file-systems os) + (expt 2 32))) + (endianness little) + 4))) + (define* (system-disk-image os #:key (name "disk-image") @@ -346,12 +376,20 @@ to USB sticks meant to be read-only." (if (string=? "iso9660" file-system-type) string-upcase identity)) + (define root-label - ;; Volume name of the root file system. Since we don't know which device - ;; will hold it, we use the volume name to find it (using the UUID would - ;; be even better, but somewhat less convenient.) + ;; Volume name of the root file system. (normalize-label "GuixSD_image")) + (define root-uuid + ;; UUID of the root file system, computed in a deterministic fashion. + ;; This is what we use to locate the root file system so it has to be + ;; different from the user's own file system UUIDs. + (operating-system-uuid os + (if (string=? file-system-type "iso9660") + 'iso9660 + 'dce))) + (define file-systems-to-keep (remove (lambda (fs) (string=? (file-system-mount-point fs) "/")) @@ -369,8 +407,8 @@ to USB sticks meant to be read-only." ;; Force our own root file system. (file-systems (cons (file-system (mount-point "/") - (device root-label) - (title 'label) + (device root-uuid) + (title 'uuid) (type file-system-type)) file-systems-to-keep))))) @@ -379,7 +417,7 @@ to USB sticks meant to be read-only." (if (string=? "iso9660" file-system-type) (iso9660-image #:name name #:file-system-label root-label - #:file-system-uuid #f + #:file-system-uuid root-uuid #:os-drv os-drv #:bootcfg-drv bootcfg #:bootloader (bootloader-configuration-bootloader @@ -398,6 +436,7 @@ to USB sticks meant to be read-only." "ext4" file-system-type) #:file-system-label root-label + #:file-system-uuid root-uuid #:copy-inputs? #t #:register-closures? #t #:inputs `(("system" ,os-drv) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 13:38:11 2017 Received: (at 27735) by debbugs.gnu.org; 20 Jul 2017 17:38:12 +0000 Received: from localhost ([127.0.0.1]:49968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYFOt-0003Gb-Cf for submit@debbugs.gnu.org; Thu, 20 Jul 2017 13:38:11 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:52594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYFOr-0003GT-LR for 27735@debbugs.gnu.org; Thu, 20 Jul 2017 13:38:09 -0400 Received: from localhost (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id DC0981CA06C4; Thu, 20 Jul 2017 19:38:06 +0200 (CEST) Date: Thu, 20 Jul 2017 19:38:01 +0200 From: Danny Milosavljevic To: ludo@gnu.org (Ludovic =?ISO-8859-1?Q?Court=E8s?=) Subject: Re: Lookup by UUID Message-ID: <20170720193801.131a59c7@scratchpost.org> In-Reply-To: <87tw28kqh6.fsf_-_@gnu.org> References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> <87bmoi0xua.fsf@gnu.org> <20170719211107.51ebe24b@scratchpost.org> <87tw28kqh6.fsf_-_@gnu.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27735 Cc: Tobias Geerinckx-Rice , 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Ludo, > With iso9660, it works=E2=80=A6 by chance, because GRUB=E2=80=99s =E2=80= =9Csearch --fs-uuid=E2=80=9D > fails. Guess why? Because it compares UUIDs as strings, and we format > it as a DCE UUID instead of an ISO UUID. Sounds familiar no? :-) Yeah :) > So that=E2=80=99s where we are. Thoughts on how to address it? https://www.gnu.org/software/grub/manual/grub.html#Making-a-GRUB-bootable-C= D_002dROM says: >...grub-mkrescue >This produces a file named grub.iso, which then can be burned into a CD (o= r a DVD), or written to a USB mass storage device. >The root device will be set up appropriately on entering your grub.cfg con= figuration file, so you can refer to file names on the CD without needing t= o use an explicit device name. This makes it easier to produce rescue image= s that will work on both optical drives and USB mass storage devices.=20 So... just leave the entire "search" instruction off if it's created by gru= b-mkrescue ? That's how one could interpret thir "root device" sentence... From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 16:32:44 2017 Received: (at 27735) by debbugs.gnu.org; 20 Jul 2017 20:32:44 +0000 Received: from localhost ([127.0.0.1]:50075 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYI7o-0007NA-Cm for submit@debbugs.gnu.org; Thu, 20 Jul 2017 16:32:44 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYI7m-0007Mx-Ku for 27735@debbugs.gnu.org; Thu, 20 Jul 2017 16:32:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYI7c-00089x-Js for 27735@debbugs.gnu.org; Thu, 20 Jul 2017 16:32:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35191) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYI7c-00089r-Fa; Thu, 20 Jul 2017 16:32:32 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:47970 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dYI7b-00024V-Ux; Thu, 20 Jul 2017 16:32:32 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: Lookup by UUID References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> <87bmoi0xua.fsf@gnu.org> <20170719211107.51ebe24b@scratchpost.org> <87tw28kqh6.fsf_-_@gnu.org> <20170720193801.131a59c7@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 Thermidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Thu, 20 Jul 2017 22:32:29 +0200 In-Reply-To: <20170720193801.131a59c7@scratchpost.org> (Danny Milosavljevic's message of "Thu, 20 Jul 2017 19:38:01 +0200") Message-ID: <87379qn92a.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27735 Cc: Tobias Geerinckx-Rice , 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Heya, Danny Milosavljevic skribis: >> With iso9660, it works=E2=80=A6 by chance, because GRUB=E2=80=99s =E2=80= =9Csearch --fs-uuid=E2=80=9D >> fails. Guess why? Because it compares UUIDs as strings, and we format >> it as a DCE UUID instead of an ISO UUID. Sounds familiar no? :-) > > Yeah :) > >> So that=E2=80=99s where we are. Thoughts on how to address it? > > https://www.gnu.org/software/grub/manual/grub.html#Making-a-GRUB-bootable= -CD_002dROM says: > >>...grub-mkrescue >>This produces a file named grub.iso, which then can be burned into a CD (= or a DVD), or written to a USB mass storage device. >>The root device will be set up appropriately on entering your grub.cfg co= nfiguration file, so you can refer to file names on the CD without needing = to use an explicit device name. This makes it easier to produce rescue imag= es that will work on both optical drives and USB mass storage devices.=20 > > So... just leave the entire "search" instruction off if it's created by g= rub-mkrescue ? That's how one could interpret thir "root device" sentence.= .. Oooh, interesting, that comes in handy. :-) Now, how can we pass the information to =E2=80=98grub-configuration-file=E2= =80=99 so that it doesn=E2=80=99t emit that =E2=80=9Csearch=E2=80=9D command? It seems that the bootloader API doesn=E2=80=99t leave room to pass bootloader-specific options. Thoughts? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 17:51:24 2017 Received: (at 27735) by debbugs.gnu.org; 20 Jul 2017 21:51:24 +0000 Received: from localhost ([127.0.0.1]:50112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYJLw-0000l6-1X for submit@debbugs.gnu.org; Thu, 20 Jul 2017 17:51:24 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:44792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYJLu-0000ky-LL for 27735@debbugs.gnu.org; Thu, 20 Jul 2017 17:51:23 -0400 Received: from localhost (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id B91731CA0503; Thu, 20 Jul 2017 23:51:20 +0200 (CEST) Date: Thu, 20 Jul 2017 23:51:15 +0200 From: Danny Milosavljevic To: ludo@gnu.org (Ludovic =?ISO-8859-1?Q?Court=E8s?=) Subject: Re: Lookup by UUID Message-ID: <20170720235115.0958266c@scratchpost.org> In-Reply-To: <87379qn92a.fsf@gnu.org> References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> <87bmoi0xua.fsf@gnu.org> <20170719211107.51ebe24b@scratchpost.org> <87tw28kqh6.fsf_-_@gnu.org> <20170720193801.131a59c7@scratchpost.org> <87379qn92a.fsf@gnu.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27735 Cc: Tobias Geerinckx-Rice , 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Ludo, On Thu, 20 Jul 2017 22:32:29 +0200 ludo@gnu.org (Ludovic Court=C3=A8s) wrote: > > So... just leave the entire "search" instruction off if it's created by= grub-mkrescue ? That's how one could interpret thir "root device" sentenc= e... =20 >=20 > Oooh, interesting, that comes in handy. :-) >=20 > Now, how can we pass the information to =E2=80=98grub-configuration-file= =E2=80=99 so > that it doesn=E2=80=99t emit that =E2=80=9Csearch=E2=80=9D command? >=20 > It seems that the bootloader API doesn=E2=80=99t leave room to pass > bootloader-specific options. I can't believe I'm suggesting this (we've come full circle now) but we cou= ld add a new bootloader in gnu/bootloader/grub.scm,=20 (define* grub-hybrid-bootloader ; or grub-mkrescue-bootloader, maybe less m= isleading. (bootloader (inherit grub-efi-bootloader) (configuration-file-generator grub-configuration-file-without-search-emi= ssion) ; this here could parametrize grub-configuration-file somehow or may= be we could refactor grub-configuration-file instead. ; Note: name is still 'grub-efi, so the public boot parameters API doesn= 't change. (package grub-hybrid))) ; probably; or grub-efi if you just want a quick= test with EFI only. ... and use it in iso9660-image or gnu/system/install.scm . From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 13:50:40 2017 Received: (at 27735) by debbugs.gnu.org; 5 Aug 2017 17:50:40 +0000 Received: from localhost ([127.0.0.1]:43644 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1de3Dk-0004qg-Lr for submit@debbugs.gnu.org; Sat, 05 Aug 2017 13:50:40 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:48638) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1de3Dj-0004qY-6i for 27735@debbugs.gnu.org; Sat, 05 Aug 2017 13:50:39 -0400 Received: from localhost (178.113.252.190.wireless.dyn.drei.com [178.113.252.190]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 148ED1CA0026; Sat, 5 Aug 2017 19:50:37 +0200 (CEST) Date: Sat, 5 Aug 2017 19:50:35 +0200 From: Danny Milosavljevic To: ludo@gnu.org (Ludovic =?ISO-8859-1?Q?Court=E8s?=) Subject: Re: Lookup by UUID Message-ID: <20170805195035.2e2a93ed@scratchpost.org> In-Reply-To: <87379qn92a.fsf@gnu.org> References: <327af9f3-fdfb-7916-f0ea-9aec0fae20f3@tobias.gr> <20170717191731.2d3ad604@scratchpost.org> <87bmoi0xua.fsf@gnu.org> <20170719211107.51ebe24b@scratchpost.org> <87tw28kqh6.fsf_-_@gnu.org> <20170720193801.131a59c7@scratchpost.org> <87379qn92a.fsf@gnu.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27735 Cc: Tobias Geerinckx-Rice , 27735@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Ludo, > > So... just leave the entire "search" instruction off if it's created by= grub-mkrescue ? That's how one could interpret thir "root device" sentenc= e... =20 >=20 > Oooh, interesting, that comes in handy. :-) >=20 > Now, how can we pass the information to =E2=80=98grub-configuration-file= =E2=80=99 so > that it doesn=E2=80=99t emit that =E2=80=9Csearch=E2=80=9D command? I've gone ahead and pushed bug# 27705 to master. That means that there's n= ow a new bootloader "grub-mkrescue-bootloader" in gnu/bootloaders/grub.scm = . So you can just override its "configuration-file-generator" by one that d= oesn't emit the "search" command (remainder should be fine as-is). I wonder what would happen (to Grub) if someone did guix system reconfigure= in a system booted from the ISO9660 image, though. I think it would be be= tter to not install any bootloader in the case of mkrescue and guix system = reconfigure. We might want to do a follow-up commit that adds a dummy inst= aller to the "installer" field of grub-mkrescue-bootloader. WDYT? From unknown Sat Aug 16 10:44:50 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 03 Sep 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator