Subject: Re: bug#27735: [PATCH 1/2] build, vm: Use a slightly less generic label.

From: Danny Milosavljevic <[email-masked]>
Date: Tue, 18 Jul 2017 15:48:45 +0200

Hi T G-R,
Hi Ludo,

On Tue, 18 Jul 2017 14:30:10 +0200
Tobias Geerinckx-Rice <[email-masked]> wrote:

> On 18/07/17 12:09, Ludovic Courtès wrote:
> > Can we do ‘string-map’ to replace dash with underscore, just like we did
> > ‘normalize-label’?  

Yes.

> That would have been a better approach. :-)

I disagree that that would be better.  Every map is a source of error and also makes it difficult to follow what is going on (i.e. difficult to maintain).

Best is only to use the common intersection of all the valid charsets and not map anything to anything else.

We can map it and it's OK but it's not good in the long run.  I've learnt that the hard way over many years.

But since we do string-upcase already, it doesn't matter anymore.  Better hope we don't break it by accident one day (or right away), though.