Subject: bug#27725: Lapack 3.7.1 hash changed

From: Maxim Cournoyer <[email-masked]>
Date: Sun, 16 Jul 2017 12:23:55 -0700

Hello Guix!

It seems our LAPACK substitute is now different than what is offered
upstream:

--8<---------------cut here---------------start------------->8---
Starting download of /gnu/store/g77svvbbamdd8k4wgv9kmp8jbqfn9dvs-lapack-3.7.1.tgz
From http://www.netlib.org/lapack/lapack-3.7.1.tgz...
 lapack-3.7.1.tgz  8.7MiB           1.7MiB/s 00:05 [####################] 100.0%
output path `/gnu/store/g77svvbbamdd8k4wgv9kmp8jbqfn9dvs-lapack-3.7.1.tgz' should have sha256 hash `0yavf6m9l78pwlnk5g61cg8x28mr30j0g8gkai0jrdqfjjmf3whs', instead has `1j51r7n5w4k7r3lrvy7710xrpkg40wf4rqnmngfz6ck9ypckzign'
cannot build derivation `/gnu/store/i4498667sjsnl24fb32mf97la1jdp22s-lapack-3.7.1.drv': 1 dependencies couldn't be built--8<---------------cut here---------------end--------------->8---

Investigating a bit with diff, one can find that many hidden files have
been cleaned up from the release:

--8<---------------cut here---------------start------------->8---
diff -ur lapack-3.7.1-guix/ lapack-3.7.1-upstream/
Only in lapack-3.7.1-guix/: ._lapack-3.7.1
Only in lapack-3.7.1-guix/lapack-3.7.1: ._appveyor.yml
Only in lapack-3.7.1-guix/lapack-3.7.1/BLAS: ._blas.pc.in
Only in lapack-3.7.1-guix/lapack-3.7.1/BLAS: ._CMakeLists.txt
Only in lapack-3.7.1-guix/lapack-3.7.1/BLAS: ._Makefile
Only in lapack-3.7.1-guix/lapack-3.7.1/BLAS/SRC: ._caxpy.f
Only in lapack-3.7.1-guix/lapack-3.7.1/BLAS/SRC: ._ccopy.f
Only in lapack-3.7.1-guix/lapack-3.7.1/BLAS/SRC: ._cdotc.f
Only in lapack-3.7.1-guix/lapack-3.7.1/BLAS/SRC: ._cdotu.f
Only in lapack-3.7.1-guix/lapack-3.7.1/BLAS/SRC: ._cgbmv.f

[...]

Only in lapack-3.7.1-guix/lapack-3.7.1/TESTING: ._zgbal.in
Only in lapack-3.7.1-guix/lapack-3.7.1/TESTING: ._zgd.in
Only in lapack-3.7.1-guix/lapack-3.7.1/TESTING: ._zgg.in
Only in lapack-3.7.1-guix/lapack-3.7.1/TESTING: ._zsb.in
Only in lapack-3.7.1-guix/lapack-3.7.1/TESTING: ._zsg.in
Only in lapack-3.7.1-guix/lapack-3.7.1/TESTING: ._ztest.in
Only in lapack-3.7.1-guix/lapack-3.7.1/TESTING: ._ztest_rfp.in
Only in lapack-3.7.1-guix/lapack-3.7.1: ._TESTING
Only in lapack-3.7.1-guix/lapack-3.7.1: ._.travis.ym
--8<---------------cut here---------------end--------------->8---

The attached patch fixes the hash, and an issue was opened here [0] to
let the maintainers know of the problem.

I've built lapack myself with this change and all the tests still pass.

Thanks,

Maxim

From f69c6bbb8bee804057ccc1dc076311d3cbf5e89c Mon Sep 17 00:00:00 2001
From: Maxim Cournoyer <[email-masked]>
Date: Sun, 16 Jul 2017 12:01:59 -0700
Subject: [PATCH] gnu: lapack: Fix hash of release 3.7.1

Apparently the release was modified (cleaned-up) in-place. An issue was opened
at https://github.com/Reference-LAPACK/lapack-release/issues/4.

* gnu/packages/maths.scm (lapack): Fix sha256 hash.
---
 gnu/packages/maths.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/maths.scm b/gnu/packages/maths.scm
index 1bf049fc4..f8967cd94 100644
--- a/gnu/packages/maths.scm
+++ b/gnu/packages/maths.scm
@@ -437,7 +437,7 @@ large scale eigenvalue problems.")
                           version ".tgz"))
       (sha256
        (base32
-        "0yavf6m9l78pwlnk5g61cg8x28mr30j0g8gkai0jrdqfjjmf3whs"))))
+        "1j51r7n5w4k7r3lrvy7710xrpkg40wf4rqnmngfz6ck9ypckzign"))))
     (build-system cmake-build-system)
     (home-page "http://www.netlib.org/lapack/")
     (inputs `(("fortran" ,gfortran)
-- 
2.13.1