GNU bug report logs - #27713
[PATCH] gnu: Move ncurses/gpm to (gnu packages ncurses).

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27713 in the body.
You can then email your comments to 27713 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: guix-patches <at> gnu.org
Cc: dannym <at> scratchpost.org
Subject: [PATCH] gnu: Move ncurses/gpm to (gnu packages ncurses).
Date: Sat, 15 Jul 2017 21:15:21 +0200

* gnu/packages/linux.scm (ncurses/gpm): Move from here...
* gnu/packages/ncurses.scm (ncurses/gpm): ...to here.
---

I think this makes sense. What you, Danny?

Kind regards,

T G-R

 gnu/packages/linux.scm   | 12 ------------
 gnu/packages/ncurses.scm | 12 ++++++++++++
 2 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm
index 58f6f3662..1a9e9d709 100644
--- a/gnu/packages/linux.scm
+++ b/gnu/packages/linux.scm
@@ -3013,18 +3013,6 @@ applications running on the Linux console.  It allows users to select items
 and copy/paste text in the console and in xterm.")
     (license license:gpl2+)))
 
-(define-public ncurses/gpm
-  (package/inherit ncurses
-    (name "ncurses-with-gpm")
-    (arguments
-        (substitute-keyword-arguments (package-arguments ncurses)
-         ((#:configure-flags cf)
-          `(cons (string-append "--with-gpm="
-                                (assoc-ref %build-inputs "gpm")
-                                "/lib/libgpm.so.2") ,cf))))
-    (inputs
-     `(("gpm" ,gpm)))))
-
 (define-public btrfs-progs
   (package
     (name "btrfs-progs")
diff --git a/gnu/packages/ncurses.scm b/gnu/packages/ncurses.scm
index 0b23baf12..0262d4d7a 100644
--- a/gnu/packages/ncurses.scm
+++ b/gnu/packages/ncurses.scm
@@ -200,6 +200,18 @@ ncursesw library provides wide character support.")
             (origin-patches (package-source ncurses))
             (search-patches "ncurses-CVE-2017-10684-10685.patch")))))))
 
+(define-public ncurses/gpm
+  (package/inherit ncurses
+    (name "ncurses-with-gpm")
+    (arguments
+        (substitute-keyword-arguments (package-arguments ncurses)
+         ((#:configure-flags cf)
+          `(cons (string-append "--with-gpm="
+                                (assoc-ref %build-inputs "gpm")
+                                "/lib/libgpm.so.2") ,cf))))
+    (inputs
+     `(("gpm" ,gpm)))))
+
 (define-public dialog
   (package
     (name "dialog")
-- 
2.13.1

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: guix-patches <at> gnu.org
Subject: Re: [PATCH] gnu: Move ncurses/gpm to (gnu packages ncurses).
Date: Sat, 15 Jul 2017 21:30:00 +0200

Hi T G-R,

On Sat, 15 Jul 2017 21:15:21 +0200
Tobias Geerinckx-Rice <me <at> tobias.gr> wrote:

> * gnu/packages/linux.scm (ncurses/gpm): Move from here...
> * gnu/packages/ncurses.scm (ncurses/gpm): ...to here.
> ---
> 
> I think this makes sense. What you, Danny?

If it still finds gpm, sure.  But I don't like creating cycles between modules if it can be avoided.  I think that in a certain sense it is true that if gpm is Linux-specific, ncurses-with-gpm is Linux-specific as well.

> +    (inputs
> +     `(("gpm" ,gpm)))))
                  ^^^
Please make sure that "guix build ncurses-with-gpm" still works.

Message #13 received at 27713-done <at> debbugs.gnu.org (full text, mbox):

From: Danny Milosavljevic <dannym <at> scratchpost.org>
To: 27713-done <at> debbugs.gnu.org
Subject: Move ncurses/gpm to (gnu packages ncurses)
Date: Mon, 24 Jul 2017 14:56:24 +0200

Mark committed it as c67d80563fc7021484602889454de534469f2785.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.