GNU bug report logs - #27710
[PATCH] gnu: go@1.8: Fix test failure.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Famulari <leo <at> famulari.name>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#27710: closed ([PATCH] gnu: go <at> 1.8: Fix test failure.)
Date: Sat, 15 Jul 2017 20:17:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 15 Jul 2017 16:15:42 -0400
with message-id <20170715201542.GA18529 <at> jasmine.lan>
and subject line Re: [bug#27710] [PATCH] gnu: go <at> 1.8: Fix test failure.
has caused the debbugs.gnu.org bug report #27710,
regarding [PATCH] gnu: go <at> 1.8: Fix test failure.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
27710: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27710
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Alex Vong <alexvong1995 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: go <at> 1.8: Fix test failure.
Date: Sun, 16 Jul 2017 00:59:01 +0800

[Message part 3 (text/plain, inline)]

Tags: fixed-upstream
Forwarded: https://github.com/golang/go/issues/20007

Hello,

This patch fixes the test failure in core-updates. I've tried to
cherry-pick upstream's commit, but it doesn't work. So I fall back to
fix it directly instead. The bug has already been fixed upstream, and
the fix will be in the next release (1.9). See [0] for details.

[0001-gnu-go-1.8-Fix-test-failure.patch (text/x-diff, inline)]

From 023f866f8838df457639a38af9c2c733e445435d Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995 <at> gmail.com>
Date: Sun, 16 Jul 2017 00:41:17 +0800
Subject: [PATCH] gnu: go <at> 1.8: Fix test failure.

* gnu/packages/golang.scm (go-1.8)[arguments]: Escape braces in test data in
'prebuild' phase.
---
 gnu/packages/golang.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index 70cae6d87..884a49689 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -6,6 +6,7 @@
 ;;; Copyright © 2016, 2017 Petter <petter <at> mykolab.ch>
 ;;; Copyright © 2016, 2017 Leo Famulari <leo <at> famulari.name>
 ;;; Copyright © 2017 Sergei Trofimovich <slyfox <at> inbox.ru>
+;;; Copyright © 2017 Alex Vong <alexvong1995 <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -296,6 +297,12 @@ sequential processes (CSP) concurrent programming features added.")
                  (substitute* "../misc/cgo/testcarchive/carchive_test.go"
                    (("#!/usr/bin/env") (string-append "#!" (which "env"))))
 
+                 ;; escape braces in test data to workaround test failure, see:
+                 ;; https://github.com/golang/go/issues/20007
+                 ;; FIXME: remove this once we upgrade to 1.9
+                 (substitute* "cmd/vet/testdata/copylock_func.go"
+                   (("struct\\{lock sync.Mutex\\}") "struct\\{lock sync.Mutex\\}"))
+
                  (substitute* "net/lookup_unix.go"
                    (("/etc/protocols") (string-append net-base "/etc/protocols")))
                  (substitute* "net/port_unix.go"
-- 
2.13.3

[Message part 5 (text/plain, inline)]

Cheers,
Alex

[0]: https://github.com/golang/go/issues/20007

[signature.asc (application/pgp-signature, inline)]

[Message part 7 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: Alex Vong <alexvong1995 <at> gmail.com>
Cc: 27710-done <at> debbugs.gnu.org
Subject: Re: [bug#27710] [PATCH] gnu: go <at> 1.8: Fix test failure.
Date: Sat, 15 Jul 2017 16:15:42 -0400

[Message part 8 (text/plain, inline)]

On Sun, Jul 16, 2017 at 12:59:01AM +0800, Alex Vong wrote:
> Tags: fixed-upstream
> Forwarded: https://github.com/golang/go/issues/20007
> 
> Hello,
> 
> This patch fixes the test failure in core-updates. I've tried to
> cherry-pick upstream's commit, but it doesn't work. So I fall back to
> fix it directly instead. The bug has already been fixed upstream, and
> the fix will be in the next release (1.9). See [0] for details.
> 

> From 023f866f8838df457639a38af9c2c733e445435d Mon Sep 17 00:00:00 2001
> From: Alex Vong <alexvong1995 <at> gmail.com>
> Date: Sun, 16 Jul 2017 00:41:17 +0800
> Subject: [PATCH] gnu: go <at> 1.8: Fix test failure.
> 
> * gnu/packages/golang.scm (go-1.8)[arguments]: Escape braces in test data in
> 'prebuild' phase.

Thanks! Pushed as eaca9ff07e4762c3d33e3090bab999c7cf74c98a.

BTW, I've attached an update to the latest Go, 1.9beta2. I can
successfully build Syncthing with it.

[0001-WIP-go-Update-to-1.9beta2.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.