From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 12:14:37 2017 Received: (at submit) by debbugs.gnu.org; 15 Jul 2017 16:14:37 +0000 Received: from localhost ([127.0.0.1]:40538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWPiH-00057q-Cz for submit@debbugs.gnu.org; Sat, 15 Jul 2017 12:14:37 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWPiF-00057e-PD for submit@debbugs.gnu.org; Sat, 15 Jul 2017 12:14:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWPi9-0001TE-DW for submit@debbugs.gnu.org; Sat, 15 Jul 2017 12:14:30 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42650) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dWPi9-0001Sz-9o for submit@debbugs.gnu.org; Sat, 15 Jul 2017 12:14:29 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWPi5-0006tT-Bh for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2017 12:14:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWPi1-0001Ks-92 for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2017 12:14:25 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:47342) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dWPi0-0001J1-VW for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2017 12:14:21 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2E3B51601CD for ; Sat, 15 Jul 2017 09:14:19 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id a580xxBXJYcC; Sat, 15 Jul 2017 09:14:15 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B29B41601C6; Sat, 15 Jul 2017 09:14:15 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id J0ggfjx2Lo7t; Sat, 15 Jul 2017 09:14:15 -0700 (PDT) Received: from day.fios-router.home (unknown [47.153.184.153]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9424D160168; Sat, 15 Jul 2017 09:14:15 -0700 (PDT) From: Paul Eggert To: bug-gnu-emacs@gnu.org Subject: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. Date: Sat, 15 Jul 2017 09:14:05 -0700 Message-Id: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> X-Mailer: git-send-email 2.7.4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) There's only one GnuTLS, so configuring these symbols at 'configure' time is overkill. Simplify things by moving their configuration to src/gnutls.h. * configure.ac (HAVE_GNUTLS3, HAVE_GNUTLS3_HMAC, HAVE_GNUTLS3_AEAD) (HAVE_GNUTLS3_CIPHER, HAVE_GNUTLS3_DIGEST): Move these definitions from here ... * src/gnutls.h: ... to here, and simplify. --- configure.ac | 83 ------------------------------------------------------------ src/gnutls.h | 12 +++++++-- 2 files changed, 10 insertions(+), 85 deletions(-) diff --git a/configure.ac b/configure.ac index 056c8c3..329a590 100644 --- a/configure.ac +++ b/configure.ac @@ -2829,89 +2829,6 @@ AC_DEFUN [HAVE_GNUTLS=yes], [HAVE_GNUTLS=no]) if test "${HAVE_GNUTLS}" = "yes"; then AC_DEFINE(HAVE_GNUTLS, 1, [Define if using GnuTLS.]) - EMACS_CHECK_MODULES([LIBGNUTLS3], [gnutls >= 3.0.0], - [AC_DEFINE(HAVE_GNUTLS3, 1, [Define if using GnuTLS v3.])], []) - - AC_CACHE_CHECK([for GnuTLS v3 with HMAC], [emacs_cv_gnutls3_hmac], - [AC_COMPILE_IFELSE( - [AC_LANG_PROGRAM([[ - #include - #include - ]], [[ - int - main (void) - { - gnutls_hmac_hd_t handle; - gnutls_hmac_deinit (handle, NULL); - } - ]])], - [emacs_cv_gnutls3_hmac=yes], - [emacs_cv_gnutls3_hmac=no])]) - if test "$emacs_cv_gnutls3_hmac" = yes; then - AC_DEFINE([HAVE_GNUTLS3_HMAC], [1], - [Define if using GnuTLS v3 with HMAC support.]) - fi - - AC_CACHE_CHECK([for GnuTLS v3 with AEAD], [emacs_cv_gnutls3_aead], - [AC_COMPILE_IFELSE( - [AC_LANG_PROGRAM([[ - #include - #include - ]], [[ - int - main (void) - { - gnutls_aead_cipher_hd_t handle; - gnutls_aead_cipher_deinit (handle); - } - ]])], - [emacs_cv_gnutls3_aead=yes], - [emacs_cv_gnutls3_aead=no])]) - if test "$emacs_cv_gnutls3_aead" = yes; then - AC_DEFINE([HAVE_GNUTLS3_AEAD], [1], - [Define if using GnuTLS v3 with AEAD support.]) - fi - - AC_CACHE_CHECK([for GnuTLS v3 with cipher], [emacs_cv_gnutls3_cipher], - [AC_COMPILE_IFELSE( - [AC_LANG_PROGRAM([[ - #include - #include - ]], [[ - int - main (void) - { - gnutls_cipher_hd_t handle; - gnutls_cipher_encrypt2 (handle, NULL, 0, NULL, 0); - gnutls_cipher_deinit (handle); - } - ]])], - [emacs_cv_gnutls3_cipher=yes], - [emacs_cv_gnutls3_cipher=no])]) - if test "$emacs_cv_gnutls3_cipher" = yes; then - AC_DEFINE([HAVE_GNUTLS3_CIPHER], [1], - [Define if using GnuTLS v3 with cipher support.]) - fi - - AC_CACHE_CHECK([for GnuTLS v3 with digest], [emacs_cv_gnutls3_digest], - [AC_COMPILE_IFELSE( - [AC_LANG_PROGRAM([[ - #include - #include - ]], [[ - int - main (void) - { - gnutls_hash_hd_t handle; - gnutls_hash_deinit (handle, NULL); - } - ]])], - [emacs_cv_gnutls3_digest=yes], - [emacs_cv_gnutls3_digest=no])]) - if test "$emacs_cv_gnutls3_digest" = yes; then - AC_DEFINE([HAVE_GNUTLS3_DIGEST], [1], - [Define if using GnuTLS v3 with digest support.]) - fi fi # Windows loads GnuTLS dynamically diff --git a/src/gnutls.h b/src/gnutls.h index 3ec86a8..19c1686 100644 --- a/src/gnutls.h +++ b/src/gnutls.h @@ -23,8 +23,16 @@ along with GNU Emacs. If not, see . */ #include #include -#ifdef HAVE_GNUTLS3 -#include +#if 0x030000 <= GNUTLS_VERSION_NUMBER +# define HAVE_GNUTLS3 +# include +#endif + +#if 0x030400 <= GNUTLS_VERSION_NUMBER +# define HAVE_GNUTLS3_AEAD +# define HAVE_GNUTLS3_CIPHER +# define HAVE_GNUTLS3_DIGEST +# define HAVE_GNUTLS3_HMAC #endif #include "lisp.h" -- 2.7.4 From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 12:33:46 2017 Received: (at 27708) by debbugs.gnu.org; 15 Jul 2017 16:33:46 +0000 Received: from localhost ([127.0.0.1]:40548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWQ0o-0007OT-JK for submit@debbugs.gnu.org; Sat, 15 Jul 2017 12:33:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52122) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWQ0n-0007OI-8I for 27708@debbugs.gnu.org; Sat, 15 Jul 2017 12:33:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWQ0e-0003Cf-KO for 27708@debbugs.gnu.org; Sat, 15 Jul 2017 12:33:39 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33021) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWQ0e-0003CY-Hv; Sat, 15 Jul 2017 12:33:36 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2115 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dWQ0d-00027P-Sh; Sat, 15 Jul 2017 12:33:36 -0400 Date: Sat, 15 Jul 2017 19:33:40 +0300 Message-Id: <83shhxek2j.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> (message from Paul Eggert on Sat, 15 Jul 2017 09:14:05 -0700) Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27708 Cc: 27708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Paul Eggert > Date: Sat, 15 Jul 2017 09:14:05 -0700 > Cc: Paul Eggert > > diff --git a/src/gnutls.h b/src/gnutls.h > index 3ec86a8..19c1686 100644 > --- a/src/gnutls.h > +++ b/src/gnutls.h > @@ -23,8 +23,16 @@ along with GNU Emacs. If not, see . */ > #include > #include > > -#ifdef HAVE_GNUTLS3 > -#include > +#if 0x030000 <= GNUTLS_VERSION_NUMBER > +# define HAVE_GNUTLS3 > +# include > +#endif > + > +#if 0x030400 <= GNUTLS_VERSION_NUMBER > +# define HAVE_GNUTLS3_AEAD > +# define HAVE_GNUTLS3_CIPHER > +# define HAVE_GNUTLS3_DIGEST > +# define HAVE_GNUTLS3_HMAC > #endif If we want to support the new APIs only starting with GnuTLS 3.4.0, then this is a step in the right direction. But is that the intent? Most of the functions we need are available in much older versions, and others since 3.2.0. Only a few appeared in 3.4.0. So it might also make sense to make our code more fine-grained, not less, if we want to make as many of these APIs available on as many platforms as possible. But I'm not sure what was Ted's intent, and what we want as a project. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 15:11:10 2017 Received: (at 27708) by debbugs.gnu.org; 15 Jul 2017 19:11:10 +0000 Received: from localhost ([127.0.0.1]:40640 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWST8-0006Zd-JY for submit@debbugs.gnu.org; Sat, 15 Jul 2017 15:11:10 -0400 Received: from mail-qt0-f174.google.com ([209.85.216.174]:33478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWST7-0006ZR-7R for 27708@debbugs.gnu.org; Sat, 15 Jul 2017 15:11:09 -0400 Received: by mail-qt0-f174.google.com with SMTP id r30so83190709qtc.0 for <27708@debbugs.gnu.org>; Sat, 15 Jul 2017 12:11:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version; bh=xyFSt3pfD1yneFDpclr0/uUgLvqFLiGANvFKmSxUyV0=; b=vQki5WPwu5qrI3clYX7vj0cYLTpkQy9CSP75CKmC7K4dRL1m0I80VJn5vJjJouDFjQ sAKmQa/U3pyO4VuuUHSsIqAK1LD9gfzabMFryfazXZUveer6Vvz05Yl9e8YOrugXvrpF C8qnWFk0caJi6adwEP+N1PxWiLyBCdkej+hzY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version; bh=xyFSt3pfD1yneFDpclr0/uUgLvqFLiGANvFKmSxUyV0=; b=JWbw7lsSpNEaLoTc1ulAjup4DiwyAjA4SIzObiJs0IhKfpZZQ4ktWt5HV6gwEw6dYU rQFIfcd/PugxgCcxmpZVL7zDe8VTeQWNdrgupFeO9VRJOe257GXbB9hgesbMbJIZYtUs ziJQ/45zGWt+xM5hXn7S2m1IhVkKHDgLuvGEtt5Ym7S6D8HHoEoZeVvWrLmz+O2rUYgH Ot3W3Iny0HEIdy59jHcyd/xsq/cT8f0k2pgOglzrRNabBOtjEV8r4lK5SUg3wVRIox4h FUK8NPuqqB8VIoYYoPY+HA0HvuisBQSwTN1Qser2gTSm9iRxCgGU3VuZ45wauKoc2dfX QMew== X-Gm-Message-State: AIVw113aMG465bvnyJsvZw4KwkAX8JSnYAQZmgkN7yOQCqf+qjCS/8Yy +kokrxqnzf9tlTvhUQmIWQ== X-Received: by 10.200.45.12 with SMTP id n12mr817877qta.15.1500145863552; Sat, 15 Jul 2017 12:11:03 -0700 (PDT) Received: from flea (c-76-28-41-155.hsd1.ma.comcast.net. [76.28.41.155]) by smtp.gmail.com with ESMTPSA id m27sm9542597qki.64.2017.07.15.12.11.02 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 15 Jul 2017 12:11:02 -0700 (PDT) From: Ted Zlatanov To: Eli Zaretskii Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Date: Sat, 15 Jul 2017 15:11:01 -0400 In-Reply-To: <83shhxek2j.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 15 Jul 2017 19:33:40 +0300") Message-ID: <87zic5ecsa.fsf@lifelogs.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 27708 Cc: Paul Eggert , 27708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Sat, 15 Jul 2017 19:33:40 +0300 Eli Zaretskii wrote: EZ> If we want to support the new APIs only starting with GnuTLS 3.4.0, EZ> then this is a step in the right direction. But is that the intent? EZ> Most of the functions we need are available in much older versions, EZ> and others since 3.2.0. Only a few appeared in 3.4.0. So it might EZ> also make sense to make our code more fine-grained, not less, if we EZ> want to make as many of these APIs available on as many platforms as EZ> possible. EZ> But I'm not sure what was Ted's intent, and what we want as a project. Exactly, and I replied on emacs-devel in the same vein. I'd like to ensure people on 3.2.x have as much functionality as possible because they may not be able to upgrade quickly. I also worry about forward compatibility with a future 4.x or later GnuTLS API. So I'd like comments and votes on this. A good starting point is https://www.gnutls.org/manual/html_node/Cryptographic-API.html which will show the ebb and flow of the API since the 2.x versions. Ted From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 15:22:26 2017 Received: (at 27708) by debbugs.gnu.org; 15 Jul 2017 19:22:26 +0000 Received: from localhost ([127.0.0.1]:40650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWSe1-0006qE-U2 for submit@debbugs.gnu.org; Sat, 15 Jul 2017 15:22:26 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45476) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWSe0-0006q0-Hc for 27708@debbugs.gnu.org; Sat, 15 Jul 2017 15:22:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWSds-0002Pe-7H for 27708@debbugs.gnu.org; Sat, 15 Jul 2017 15:22:19 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:35227) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWSds-0002PY-4G; Sat, 15 Jul 2017 15:22:16 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2247 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dWSdq-0000la-J9; Sat, 15 Jul 2017 15:22:16 -0400 Date: Sat, 15 Jul 2017 22:22:14 +0300 Message-Id: <83mv85ec9l.fsf@gnu.org> From: Eli Zaretskii To: Ted Zlatanov In-reply-to: <87zic5ecsa.fsf@lifelogs.com> (message from Ted Zlatanov on Sat, 15 Jul 2017 15:11:01 -0400) Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27708 Cc: eggert@cs.ucla.edu, 27708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Ted Zlatanov > Cc: Paul Eggert , 27708@debbugs.gnu.org > Date: Sat, 15 Jul 2017 15:11:01 -0400 > > On Sat, 15 Jul 2017 19:33:40 +0300 Eli Zaretskii wrote: > > EZ> If we want to support the new APIs only starting with GnuTLS 3.4.0, > EZ> then this is a step in the right direction. But is that the intent? > EZ> Most of the functions we need are available in much older versions, > EZ> and others since 3.2.0. Only a few appeared in 3.4.0. So it might > EZ> also make sense to make our code more fine-grained, not less, if we > EZ> want to make as many of these APIs available on as many platforms as > EZ> possible. > > EZ> But I'm not sure what was Ted's intent, and what we want as a project. > > Exactly, and I replied on emacs-devel in the same vein. I'd like to > ensure people on 3.2.x have as much functionality as possible because > they may not be able to upgrade quickly. I see your point, but in that case the code needs "more work", since in quite a few places the Lisp primitives you wrote mix up functions available in very old GnuTLS versions with one or two that are only available in latest versions. To be able to support older versions of the library, we need graceful degradation, and that hasn't been coded. All we can easily do with the current code is return nil instead of useful information, but that doesn't strike me as "graceful". > A good starting point is > https://www.gnutls.org/manual/html_node/Cryptographic-API.html which > will show the ebb and flow of the API since the 2.x versions. Alas, the GnuTLS manual doesn't say for each function in what version it was introduced, it does so only for some of them. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 20:32:11 2017 Received: (at 27708) by debbugs.gnu.org; 16 Jul 2017 00:32:11 +0000 Received: from localhost ([127.0.0.1]:40891 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWXTl-0007Ug-3V for submit@debbugs.gnu.org; Sat, 15 Jul 2017 20:32:11 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:41418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWXTj-0007UF-8l for 27708@debbugs.gnu.org; Sat, 15 Jul 2017 20:32:07 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5F073160165; Sat, 15 Jul 2017 17:32:00 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id TC8n0_bd9Ycs; Sat, 15 Jul 2017 17:31:59 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id EDC7B1601CD; Sat, 15 Jul 2017 17:31:58 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id kUcstx4_imjb; Sat, 15 Jul 2017 17:31:58 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.153.184.153]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id C8059160165; Sat, 15 Jul 2017 17:31:58 -0700 (PDT) Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. To: Eli Zaretskii , Ted Zlatanov References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Sat, 15 Jul 2017 17:31:58 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <83mv85ec9l.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 27708 Cc: 27708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii wrote: > the GnuTLS manual doesn't say for each function in what version > it was introduced The GnuTLS folks are pretty good about documenting API changes, it's just= not in=20 the main manual. For example: http://www.gnutls.org/abi-tracker/timeline/gnutls/ I used that list, along with a copy of the GnuTLS development history, to= come=20 up with the version numbers in the proposed patch. The patch should not = change=20 Emacs functionality at all: all it should do is simplify configuration (a= nd make=20 'configure' run a bit faster :-). From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 22:36:36 2017 Received: (at 27708) by debbugs.gnu.org; 16 Jul 2017 02:36:36 +0000 Received: from localhost ([127.0.0.1]:40904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWZQC-0001y9-Kl for submit@debbugs.gnu.org; Sat, 15 Jul 2017 22:36:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41084) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWZQB-0001xw-1E for 27708@debbugs.gnu.org; Sat, 15 Jul 2017 22:36:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWZQ1-0006vZ-Ii for 27708@debbugs.gnu.org; Sat, 15 Jul 2017 22:36:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40559) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWZQ1-0006vT-Ep; Sat, 15 Jul 2017 22:36:25 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2439 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dWZQ0-0003dV-Sr; Sat, 15 Jul 2017 22:36:25 -0400 Date: Sun, 16 Jul 2017 05:36:30 +0300 Message-Id: <83k239ds5t.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: (message from Paul Eggert on Sat, 15 Jul 2017 17:31:58 -0700) Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27708 Cc: tzz@lifelogs.com, 27708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: 27708@debbugs.gnu.org > From: Paul Eggert > Date: Sat, 15 Jul 2017 17:31:58 -0700 > > http://www.gnutls.org/abi-tracker/timeline/gnutls/ > > I used that list, along with a copy of the GnuTLS development history, to come > up with the version numbers in the proposed patch. The patch should not change > Emacs functionality at all: all it should do is simplify configuration (and make > 'configure' run a bit faster :-). I didn't say your patch changed any functionality. I'm saying that if we want to allow as many of these APIs to be useful on as many platforms, we need to do more work on the code. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 16 11:19:07 2017 Received: (at 27708) by debbugs.gnu.org; 16 Jul 2017 15:19:07 +0000 Received: from localhost ([127.0.0.1]:42595 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWlK7-00057E-2t for submit@debbugs.gnu.org; Sun, 16 Jul 2017 11:19:07 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:55332) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWlK5-00056j-7E for 27708@debbugs.gnu.org; Sun, 16 Jul 2017 11:19:05 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4ADB8160061; Sun, 16 Jul 2017 08:18:58 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 3ERBrYMHv6gG; Sun, 16 Jul 2017 08:18:57 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 97145160168; Sun, 16 Jul 2017 08:18:57 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id rJSRd4AKT4v0; Sun, 16 Jul 2017 08:18:57 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.153.184.153]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 76D7E16006D; Sun, 16 Jul 2017 08:18:57 -0700 (PDT) Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. To: Eli Zaretskii References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> <83k239ds5t.fsf@gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <6277b486-12c8-8363-cd9f-a79b6bda9304@cs.ucla.edu> Date: Sun, 16 Jul 2017 08:18:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <83k239ds5t.fsf@gnu.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 27708 Cc: tzz@lifelogs.com, 27708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Eli Zaretskii wrote: > if > we want to allow as many of these APIs to be useful on as many > platforms, we need to do more work on the code. One possible step forward is to use each of the APIs starting when they became available, as opposed to the current practice of using some of them only in GnuTLS v3 or later (even though they were available earlier). I could adjust my proposed patch to do that, if you like. Unlike my proposed patch, this would change Emacs behavior (but only on older GnuTLS platforms). From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 16 12:08:50 2017 Received: (at 27708) by debbugs.gnu.org; 16 Jul 2017 16:08:50 +0000 Received: from localhost ([127.0.0.1]:42619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWm6D-0006Dp-PQ for submit@debbugs.gnu.org; Sun, 16 Jul 2017 12:08:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWm6C-0006Dc-0c for 27708@debbugs.gnu.org; Sun, 16 Jul 2017 12:08:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWm62-0003EX-T6 for 27708@debbugs.gnu.org; Sun, 16 Jul 2017 12:08:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47039) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWm62-0003EQ-PT; Sun, 16 Jul 2017 12:08:38 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3089 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dWm62-00036f-Dm; Sun, 16 Jul 2017 12:08:38 -0400 Date: Sun, 16 Jul 2017 19:08:45 +0300 Message-Id: <837ez8e54i.fsf@gnu.org> From: Eli Zaretskii To: Paul Eggert In-reply-to: <6277b486-12c8-8363-cd9f-a79b6bda9304@cs.ucla.edu> (message from Paul Eggert on Sun, 16 Jul 2017 08:18:57 -0700) Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> <83k239ds5t.fsf@gnu.org> <6277b486-12c8-8363-cd9f-a79b6bda9304@cs.ucla.edu> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27708 Cc: tzz@lifelogs.com, 27708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > Cc: tzz@lifelogs.com, 27708@debbugs.gnu.org > From: Paul Eggert > Date: Sun, 16 Jul 2017 08:18:57 -0700 > > Eli Zaretskii wrote: > > if > > we want to allow as many of these APIs to be useful on as many > > platforms, we need to do more work on the code. > > One possible step forward is to use each of the APIs starting when they became > available, as opposed to the current practice of using some of them only in > GnuTLS v3 or later (even though they were available earlier). I could adjust my > proposed patch to do that, if you like. Unlike my proposed patch, this would > change Emacs behavior (but only on older GnuTLS platforms). Yes, that's what I meant, but I think this won't be useful unless we also introduce some fallbacks into the code which uses those new functions. AFAICT, it is the case in some of the new APIs that almost all of the GnuTLS functions they use are available even before v3.X, but then just one function they call needs 3.2.X or 3.4.X. This makes the entire API useless (it returns nil), which is a pity, since I'm guessing we could code some workaround or maybe provide partial functionality instead. Alas, I don't know enough about these functions to code such fallbacks. From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 11:04:20 2017 Received: (at submit) by debbugs.gnu.org; 17 Jul 2017 15:04:21 +0000 Received: from localhost ([127.0.0.1]:44622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dX7ZM-00008C-NR for submit@debbugs.gnu.org; Mon, 17 Jul 2017 11:04:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dX7ZL-000082-2c for submit@debbugs.gnu.org; Mon, 17 Jul 2017 11:04:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dX7Z9-00006S-Uc for submit@debbugs.gnu.org; Mon, 17 Jul 2017 11:04:13 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:55191) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dX7Z9-00006M-Rs for submit@debbugs.gnu.org; Mon, 17 Jul 2017 11:04:07 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41338) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dX7Z8-00039p-MX for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2017 11:04:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dX7Z2-0008W5-Ny for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2017 11:04:06 -0400 Received: from [195.159.176.226] (port=45654 helo=blaine.gmane.org) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dX7Z2-0008Vd-H1 for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2017 11:04:00 -0400 Received: from list by blaine.gmane.org with local (Exim 4.84_2) (envelope-from ) id 1dX7Yr-0003b2-2p for bug-gnu-emacs@gnu.org; Mon, 17 Jul 2017 17:03:49 +0200 X-Injected-Via-Gmane: http://gmane.org/ Mail-Followup-To: bug-gnu-emacs@gnu.org To: bug-gnu-emacs@gnu.org From: Ted Zlatanov Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. Date: Mon, 17 Jul 2017 11:03:45 -0400 Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos Lines: 26 Message-ID: <8760ercdgu.fsf@lifelogs.com> References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> <83k239ds5t.fsf@gnu.org> <6277b486-12c8-8363-cd9f-a79b6bda9304@cs.ucla.edu> <837ez8e54i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain X-Complaints-To: usenet@blaine.gmane.org User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Cancel-Lock: sha1:PnNoOSB5nqQxP1W2yt/5Yw+g6a4= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On Sun, 16 Jul 2017 19:08:45 +0300 Eli Zaretskii wrote: EZ> Yes, that's what I meant, but I think this won't be useful unless we EZ> also introduce some fallbacks into the code which uses those new EZ> functions. AFAICT, it is the case in some of the new APIs that almost EZ> all of the GnuTLS functions they use are available even before v3.X, EZ> but then just one function they call needs 3.2.X or 3.4.X. This makes EZ> the entire API useless (it returns nil), which is a pity, since I'm EZ> guessing we could code some workaround or maybe provide partial EZ> functionality instead. Alas, I don't know enough about these EZ> functions to code such fallbacks. I think the risk of providing broken or subtly insecure functionality is bigger if we do workarounds. Also the maintenance effort will be lower if we pin to specific versions instead of features. I'm inclined to take Paul's advice on this since he knows this area so well. Another point is that I'd rather not support GnuTLS 2.x for the new functionality; 2.12 is deprecated and won't get new updates according to https://lists.gnupg.org/pipermail/gnutls-devel/2016-November/008220.html so we should make an effort not to rely on it. I'd even recommend dropping 2.x support altogether in Emacs 26. So maybe Paul's approach was best after all :) Ted From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 26 17:05:13 2017 Received: (at submit) by debbugs.gnu.org; 26 Jul 2017 21:05:13 +0000 Received: from localhost ([127.0.0.1]:57739 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daTUW-0000s7-VV for submit@debbugs.gnu.org; Wed, 26 Jul 2017 17:05:13 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34343) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daTUV-0000rs-Vi for submit@debbugs.gnu.org; Wed, 26 Jul 2017 17:05:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daTUQ-0007Qo-9A for submit@debbugs.gnu.org; Wed, 26 Jul 2017 17:05:06 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52145) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1daTUQ-0007QP-6s for submit@debbugs.gnu.org; Wed, 26 Jul 2017 17:05:06 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53529) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daTUP-00011L-5L for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 17:05:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daTUL-0007Mj-7M for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 17:05:05 -0400 Received: from mail-wm0-x22f.google.com ([2a00:1450:400c:c09::22f]:37290) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1daTUL-0007LQ-0o for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 17:05:01 -0400 Received: by mail-wm0-x22f.google.com with SMTP id c184so91637372wmd.0 for ; Wed, 26 Jul 2017 14:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version; bh=5sEM3AZnnub0W1nq6ZvyHt0XrQIpdx4HLYmAt5sW2XA=; b=GIbAvEqzMlS1mMUZz8lcWgMpeDPRMhm5teM6lvGrckzZqyh/hZhzTC2B/5xlJxbOCo eknVZB7NktxEz3f2wTGnhyAm8+2oTgy6jXNytzEBWeAZXtZLUeD+q/Em1F+jmhV2pHto 1sUrGY8I/CrPh4+D5OMF6Rtl64TVJmFGl7vs4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version; bh=5sEM3AZnnub0W1nq6ZvyHt0XrQIpdx4HLYmAt5sW2XA=; b=XPDhwPAERDzeOkwZwxp5nXO98mBXHP7c4+hRkyADq0o3TMOTigPwD4+AO+/UZWctUg JhHIltvFoP4fyBkP39PlZHHyW2sz3uD/2CS5nv8kEvvnKChUN9gq3z4YbDmG03gWh0sd ABa0G5iEQIzlkrqcIUS83S1DVDW8DKS5HcnDppzK95XXTsemzcJR8cIkkpGMApJAt9g8 I7Drdb9M1tR1JvZB8q3VkvGz+PXFABT7B4eEcj9PzWA5zR0PjoUyqxHDEfRauB8Y7dgD IjVlsjrcBKCbsQEWlca+MSZQmWyFuoGDsfOimvPYz4N0oLDIeZrn4kX99N1uiWHYAdBK RnZw== X-Gm-Message-State: AIVw111+pTuGoB8xYC7X5pVrYZTRXGD5IgCbdph4Z6O9X6iDC4ins8PR oLTX1qUp+tiWqpNf X-Received: by 10.28.208.202 with SMTP id h193mr1523188wmg.101.1501103098428; Wed, 26 Jul 2017 14:04:58 -0700 (PDT) Received: from lll.local (185-20-156-89.ip.btc-net.bg. [185.20.156.89]) by smtp.gmail.com with ESMTPSA id i32sm37125053wra.5.2017.07.26.14.04.56 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Jul 2017 14:04:57 -0700 (PDT) From: Ted Zlatanov To: bug-gnu-emacs@gnu.org Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> <83k239ds5t.fsf@gnu.org> <6277b486-12c8-8363-cd9f-a79b6bda9304@cs.ucla.edu> <837ez8e54i.fsf@gnu.org> <8760ercdgu.fsf@lifelogs.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Date: Thu, 27 Jul 2017 00:04:54 +0300 In-Reply-To: <8760ercdgu.fsf@lifelogs.com> (Ted Zlatanov's message of "Mon, 17 Jul 2017 11:03:45 -0400") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Paul Eggert X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) On Mon, 17 Jul 2017 11:03:45 -0400 Ted Zlatanov wrote: TZ> So maybe Paul's approach was best after all :) Paul, do you want to use your original patch as we discussed? Ted From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 26 19:23:52 2017 Received: (at submit) by debbugs.gnu.org; 26 Jul 2017 23:23:53 +0000 Received: from localhost ([127.0.0.1]:57765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daVei-00041X-O1 for submit@debbugs.gnu.org; Wed, 26 Jul 2017 19:23:52 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daVeg-00041K-RX for submit@debbugs.gnu.org; Wed, 26 Jul 2017 19:23:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daVea-0000eQ-TS for submit@debbugs.gnu.org; Wed, 26 Jul 2017 19:23:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57527) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1daVea-0000eF-QA for submit@debbugs.gnu.org; Wed, 26 Jul 2017 19:23:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58883) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daVeZ-00048l-Tw for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 19:23:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daVeV-0000Z8-W9 for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 19:23:43 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:47120) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1daVeV-0000Xu-Ov for bug-gnu-emacs@gnu.org; Wed, 26 Jul 2017 19:23:39 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 661C016069A; Wed, 26 Jul 2017 16:23:37 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id D5n2T-Z-fkWF; Wed, 26 Jul 2017 16:23:36 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id BDBA61606A5; Wed, 26 Jul 2017 16:23:36 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id B1QbeRDGB0XB; Wed, 26 Jul 2017 16:23:36 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.153.184.153]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 9F7861606A1; Wed, 26 Jul 2017 16:23:36 -0700 (PDT) Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. To: Ted Zlatanov , bug-gnu-emacs@gnu.org References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> <83k239ds5t.fsf@gnu.org> <6277b486-12c8-8363-cd9f-a79b6bda9304@cs.ucla.edu> <837ez8e54i.fsf@gnu.org> <8760ercdgu.fsf@lifelogs.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: Date: Wed, 26 Jul 2017 16:23:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Ted Zlatanov wrote: > Paul, do you want to use your original patch as we discussed? I'd prefer that, yes. It's not a big deal. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 27 17:11:56 2017 Received: (at 27708) by debbugs.gnu.org; 27 Jul 2017 21:11:56 +0000 Received: from localhost ([127.0.0.1]:58985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daq4a-0006A3-F4 for submit@debbugs.gnu.org; Thu, 27 Jul 2017 17:11:56 -0400 Received: from mail-qk0-f170.google.com ([209.85.220.170]:34714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daq4X-00069p-Rd for 27708@debbugs.gnu.org; Thu, 27 Jul 2017 17:11:54 -0400 Received: by mail-qk0-f170.google.com with SMTP id u139so48083478qka.1 for <27708@debbugs.gnu.org>; Thu, 27 Jul 2017 14:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version; bh=T6fjOAT6p8O3l6b7VMpsKR1UW6W/sGGAWHDMOGs7ElQ=; b=hR+WgzWNd1HHIy27DYgv+l/L2n/7+BnPaqbeKnTSBSI/sYVKvRxNvagqHRsNzOVsJl WyEgh7/6Pvx3x7h//4143TC9fy2nPoDh1T5rVWuWCwqG4NPtwWVrLZZMVq17T+Chux76 WWTMK5OPdEfc+UWK3de6HoujuBzkx0Hpy7Qmc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version; bh=T6fjOAT6p8O3l6b7VMpsKR1UW6W/sGGAWHDMOGs7ElQ=; b=HpXvva1P8eh9ffjxQj5+f5zShTvojQgpPa69Rv5VCNFqslbL4iZALvZkAofcR8gL3u 0lizwd5MQdrmEEvHrHL+5P9AwzaPVYZkLwS4ZM2x+oUxhETJsMzKn4/X9IdcXOSP/sIt aiy1T0NX5EENBLEdhRvR1A7A1t/ui2ZdW3aEafeQjoHMJ60lYYA5ZVOqSQs6rQ4HDYhD uCRNGyZMfSUH7NIxuK84Vpijrx+P0q4FIX3iPB4gJhYr5sBqZPZwyJcToH3QxBjLq4/7 OJDt08l7C9fPgoHbNRzRCwGEvApnMX8rD+hic7DkJxtBGBDmcbJ3qtIkA/RcJWHHZ86h NZTg== X-Gm-Message-State: AIVw111zkyDZTfpL+kxJEZYa5dBvNHBdIEW3MNW+BRlzq3QfDwn/xGB0 GN6LXXsu42NtWveqcnSbZQ== X-Received: by 10.55.48.70 with SMTP id w67mr7002373qkw.207.1501189908208; Thu, 27 Jul 2017 14:11:48 -0700 (PDT) Received: from lll.local (185-20-156-89.ip.btc-net.bg. [185.20.156.89]) by smtp.gmail.com with ESMTPSA id 13sm14115619qkd.70.2017.07.27.14.11.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Jul 2017 14:11:47 -0700 (PDT) From: Ted Zlatanov To: Paul Eggert Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> <83k239ds5t.fsf@gnu.org> <6277b486-12c8-8363-cd9f-a79b6bda9304@cs.ucla.edu> <837ez8e54i.fsf@gnu.org> <8760ercdgu.fsf@lifelogs.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Date: Fri, 28 Jul 2017 00:11:43 +0300 In-Reply-To: (Paul Eggert's message of "Wed, 26 Jul 2017 16:23:30 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (darwin) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 27708 Cc: 27708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Wed, 26 Jul 2017 16:23:30 -0700 Paul Eggert wrote: PE> Ted Zlatanov wrote: >> Paul, do you want to use your original patch as we discussed? PE> I'd prefer that, yes. It's not a big deal. Great. Would you like to apply it? Ted From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 02 22:50:23 2017 Received: (at 27708-done) by debbugs.gnu.org; 3 Aug 2017 02:50:23 +0000 Received: from localhost ([127.0.0.1]:39173 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dd6DP-0006FM-Jx for submit@debbugs.gnu.org; Wed, 02 Aug 2017 22:50:23 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:46650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dd6DO-0006F9-Iy for 27708-done@debbugs.gnu.org; Wed, 02 Aug 2017 22:50:23 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id AA6B8160739; Wed, 2 Aug 2017 19:50:15 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id fIX7LgnJXjwr; Wed, 2 Aug 2017 19:50:15 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 06524160736; Wed, 2 Aug 2017 19:50:15 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id C5VEiNufV9PR; Wed, 2 Aug 2017 19:50:14 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.153.184.153]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D69C4160719; Wed, 2 Aug 2017 19:50:14 -0700 (PDT) Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. To: Ted Zlatanov References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> <83k239ds5t.fsf@gnu.org> <6277b486-12c8-8363-cd9f-a79b6bda9304@cs.ucla.edu> <837ez8e54i.fsf@gnu.org> <8760ercdgu.fsf@lifelogs.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <70d33c4c-eace-723a-ec89-a83089a94ee9@cs.ucla.edu> Date: Wed, 2 Aug 2017 19:50:14 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27708-done Cc: 27708-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ted Zlatanov wrote: > Would you like to apply it? Sure, done, and closing this bug report. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 03 12:06:39 2017 Received: (at 27708) by debbugs.gnu.org; 3 Aug 2017 16:06:39 +0000 Received: from localhost ([127.0.0.1]:40184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddIdz-0002oz-2s for submit@debbugs.gnu.org; Thu, 03 Aug 2017 12:06:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddIdx-0002on-L8 for 27708@debbugs.gnu.org; Thu, 03 Aug 2017 12:06:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddIdr-0001JK-Mg for 27708@debbugs.gnu.org; Thu, 03 Aug 2017 12:06:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD, URIBL_BLOCKED autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddIdr-0001JF-K9; Thu, 03 Aug 2017 12:06:31 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ddIdq-0003vQ-R6; Thu, 03 Aug 2017 12:06:30 -0400 From: Glenn Morris To: 27708@debbugs.gnu.org Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> <83k239ds5t.fsf@gnu.org> <6277b486-12c8-8363-cd9f-a79b6bda9304@cs.ucla.edu> <837ez8e54i.fsf@gnu.org> <8760ercdgu.fsf@lifelogs.com> <70d33c4c-eace-723a-ec89-a83089a94ee9@cs.ucla.edu> X-Spook: National laboratory diwn Crowell Agent Pandemic S Key X-Ran: \x'lK\#;Og8G9Hl}U.74b,QgMDTXM\>vV$X_4,AYXjQPkpDu5]g|2r{]ofRajW}o'N?}SW X-Hue: brightgreen X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 03 Aug 2017 12:06:30 -0400 In-Reply-To: <70d33c4c-eace-723a-ec89-a83089a94ee9@cs.ucla.edu> (Paul Eggert's message of "Wed, 2 Aug 2017 19:50:14 -0700") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27708 Cc: eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This causes a test failure in test-gnutls-000-availability. https://hydra.nixos.org/build/57926906 (Reproduced on rhel7 with gnutls-3.3.24.) From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 03 16:20:22 2017 Received: (at 27708) by debbugs.gnu.org; 3 Aug 2017 20:20:22 +0000 Received: from localhost ([127.0.0.1]:40409 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddMbW-0000Hx-1l for submit@debbugs.gnu.org; Thu, 03 Aug 2017 16:20:22 -0400 Received: from mail-qt0-f181.google.com ([209.85.216.181]:33439) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddMbT-0000Hj-FH for 27708@debbugs.gnu.org; Thu, 03 Aug 2017 16:20:19 -0400 Received: by mail-qt0-f181.google.com with SMTP id a18so14395581qta.0 for <27708@debbugs.gnu.org>; Thu, 03 Aug 2017 13:20:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version; bh=a3mfC0k0peh1g8ehGwval5oSzJLs5xJkjo70Clj5wXw=; b=o+mtqUvmQXE5iqOS7eOCfRHpRzL9dbzMDLBb7mKtotmkyIwmk6vIvYH5OYF3jftLn0 SZCJ8///bUzj6pc1I5jQpEH8l9mEcCPNOj/LGX8hlaYTtpfxT9H3Gl09UjEJ1veMAr2o 2DQysMY/8Cf2K0dM8l2qaq/XarOSF6acyWDx4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version; bh=a3mfC0k0peh1g8ehGwval5oSzJLs5xJkjo70Clj5wXw=; b=CV4QMTDUak1KzqF3fMpV8sQGl2XpE6eynbSEXOLdibR4MfINu0L5Gmg94zIyd5t4Ch 1BT18gSWYXAC238vfxa02F0fSyQoUtXTS1END+MdoV/NZURNbKSCPRm1YJSOCusNejjQ /bd9vnaXOGUCMrzg91tkWZDZ9y66CfN7NFU5r6nLOhCfzmwcW2Cs1JCuJRLUgO3CwY+X 1dUc3O+f8wZakkyITUrXU2vF8lULq/GUWwqdPb3K/k+w7ie0K78av4GBt/uaEiPjXzyu l8WSkEuDcNPou1DzAhgmEMLXDC+ZvQ4tCWfEBPJFM9mio8o/miXEdgF0kHDArr2hcv3d cXTw== X-Gm-Message-State: AHYfb5jMiCWUuChJztwyUXLZ7fgBPH/WTh5YzgxQyprOPYI495jsdGwl 1v1W/xFA7TyjovtH X-Received: by 10.200.45.98 with SMTP id o31mr41876qta.43.1501791613620; Thu, 03 Aug 2017 13:20:13 -0700 (PDT) Received: from flea (c-76-28-41-155.hsd1.ma.comcast.net. [76.28.41.155]) by smtp.gmail.com with ESMTPSA id b71sm26796631qkj.8.2017.08.03.13.20.12 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Aug 2017 13:20:12 -0700 (PDT) From: Ted Zlatanov To: Glenn Morris Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> <83k239ds5t.fsf@gnu.org> <6277b486-12c8-8363-cd9f-a79b6bda9304@cs.ucla.edu> <837ez8e54i.fsf@gnu.org> <8760ercdgu.fsf@lifelogs.com> <70d33c4c-eace-723a-ec89-a83089a94ee9@cs.ucla.edu> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Date: Thu, 03 Aug 2017 16:20:12 -0400 In-Reply-To: (Glenn Morris's message of "Thu, 03 Aug 2017 12:06:30 -0400") Message-ID: <874lto9zer.fsf@lifelogs.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 27708 Cc: 27708@debbugs.gnu.org, eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) On Thu, 03 Aug 2017 12:06:30 -0400 Glenn Morris wrote: GM> This causes a test failure in test-gnutls-000-availability. GM> https://hydra.nixos.org/build/57926906 GM> (Reproduced on rhel7 with gnutls-3.3.24.) I think that this means that one of MD5, SHA1, SHA224, SHA256, SHA384, or SHA512 (the `secure-hash-algorithms' members currently) are not in that version of GnuTLS. That is not really necessary. I was overzealous writing the tests; we can just test the `secure-hash-algorithms' that are in GnuTLS. Can we check the patch below against Hydra without pushing it to master yet? (I'm having a strange problem building Emacs as of this morning, so I haven't been able to test the patch fully. Sorry.) Thanks Ted diff --git a/test/lisp/net/gnutls-tests.el b/test/lisp/net/gnutls-tests.el index 9dbb6c05b9..94dcb6c4ce 100644 --- a/test/lisp/net/gnutls-tests.el +++ b/test/lisp/net/gnutls-tests.el @@ -41,8 +41,10 @@ gnutls-tests-hexstring-equal (and (stringp a) (stringp b) (string-equal (encode-hex-string a) (encode-hex-string b)))) (defvar gnutls-tests-internal-macs-upcased - (mapcar (lambda (sym) (cons sym (intern (upcase (symbol-name sym))))) - (secure-hash-algorithms))) + (cl-intersection + (mapcar (lambda (sym) (cons sym (intern (upcase (symbol-name sym))))) + (secure-hash-algorithms)) + (mapcar 'car (gnutls-macs)))) (defvar gnutls-tests-tested-macs (when (gnutls-available-p) From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 03 16:31:41 2017 Received: (at 27708) by debbugs.gnu.org; 3 Aug 2017 20:31:41 +0000 Received: from localhost ([127.0.0.1]:40415 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddMmT-0000Yk-7p for submit@debbugs.gnu.org; Thu, 03 Aug 2017 16:31:41 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:36036) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddMmR-0000YY-Qz for 27708@debbugs.gnu.org; Thu, 03 Aug 2017 16:31:40 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 445C61606FD; Thu, 3 Aug 2017 13:31:34 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id mwRmyPoQfVW3; Thu, 3 Aug 2017 13:31:33 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7A844160732; Thu, 3 Aug 2017 13:31:33 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id OW2KCIUg8u6F; Thu, 3 Aug 2017 13:31:33 -0700 (PDT) Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 5DF3E1606FD; Thu, 3 Aug 2017 13:31:33 -0700 (PDT) Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. To: Ted Zlatanov , Glenn Morris References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> <83k239ds5t.fsf@gnu.org> <6277b486-12c8-8363-cd9f-a79b6bda9304@cs.ucla.edu> <837ez8e54i.fsf@gnu.org> <8760ercdgu.fsf@lifelogs.com> <70d33c4c-eace-723a-ec89-a83089a94ee9@cs.ucla.edu> <874lto9zer.fsf@lifelogs.com> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <2c1e9ab3-75f7-1972-1353-5b6a8219b6a4@cs.ucla.edu> Date: Thu, 3 Aug 2017 13:31:33 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <874lto9zer.fsf@lifelogs.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27708 Cc: 27708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On 08/03/2017 01:20 PM, Ted Zlatanov wrote: > I was overzealous writing the tests; we > can just test the `secure-hash-algorithms' that are in GnuTLS. Can we > check the patch below against Hydra without pushing it to master yet? I tried that patch on my own copy (on Fedora 26, with GnuTLS 3.5.14) and it failed as noted at the end of this email. > I'm having a strange problem building Emacs as of this morning, so I > haven't been able to test the patch What problem is it? Some of the recent changes probably suggest a 'make bootstrap', so I'd try that first. Here's the failure I got: Running 7 tests (2017-08-03 13:24:54-0700) Test test-gnutls-000-availability backtrace: signal(ert-test-failed (((should (> (length gnutls-tests-internal-ma ert-fail(((should (> (length gnutls-tests-internal-macs-upcased) 5)) (if (unwind-protect (setq value-7 (apply fn-5 args-6)) (setq form-de (let (form-description-9) (if (unwind-protect (setq value-7 (apply f (let ((value-7 'ert-form-evaluation-aborted-8)) (let (form-descripti (let ((fn-5 (function >)) (args-6 (list (length gnutls-tests-interna (lambda nil (let ((fn-0 (function memq)) (args-1 (list 'gnutls3 (gnu ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name test-gnutls-000-availability :documen ert-run-or-rerun-test(#s(ert--stats :selector (not (tag :expensive-t ert-run-tests((not (tag :expensive-test)) #f(compiled-function (even ert-run-tests-batch((not (tag :expensive-test))) ert-run-tests-batch-and-exit((not (tag :expensive-test))) eval((ert-run-tests-batch-and-exit '(not (tag :expensive-test)))) command-line-1(("-L" ":." "-l" "ert" "-l" "lisp/net/gnutls-tests.el" command-line() normal-top-level() Test test-gnutls-000-availability condition: (ert-test-failed ((should (> (length gnutls-tests-internal-macs-upcased) 5)) :form (> 0 5) :value nil)) FAILED 1/7 test-gnutls-000-availability From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 03 16:45:12 2017 Received: (at 27708) by debbugs.gnu.org; 3 Aug 2017 20:45:12 +0000 Received: from localhost ([127.0.0.1]:40421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddMzY-0000rK-Io for submit@debbugs.gnu.org; Thu, 03 Aug 2017 16:45:12 -0400 Received: from mail-qt0-f169.google.com ([209.85.216.169]:36400) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddMzW-0000r8-Vt for 27708@debbugs.gnu.org; Thu, 03 Aug 2017 16:45:11 -0400 Received: by mail-qt0-f169.google.com with SMTP id v29so14707308qtv.3 for <27708@debbugs.gnu.org>; Thu, 03 Aug 2017 13:45:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version; bh=XoiYJstAtcBa2BRVoI+uK3q6fXH9YEmsZkjY46ovhYE=; b=QjAczcWN0lrp+LxdJZJVyHb1lN4H8MU6fOmAFNB2G/4wM+vmd8iVrcMu2buBZvNoGD oYUlthH6UclACtZ55oPiM2k/qp2VI3NZe1tExzO6sCw9svfYacPg4UE4uOofMjHsdkA3 xCccj2Cj+elHds0gpL6DGrMhg+XRjECgZ6fuE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version; bh=XoiYJstAtcBa2BRVoI+uK3q6fXH9YEmsZkjY46ovhYE=; b=ejdwa7T30PwQhehtJM5BuzvdVvXAWr0QXBbMK0xEKEAt/GyZvou9bj4lsFGkYrAD7A BAjU9N95FYOsg7A38+aEX51vKMuJJPbhxRP/nGVJiL0Tdh/eSX07pSQ1BVJMDSfjoipq GH2u4Xx5JdZzRnxRdIwx17RWDS1udB2JrgcyZDXsqAjiOlvrWfyXQSrHWSY3yBn0uK6V LErTrMpCcM4v/1gSME3FanGA8q7N85Wof61eU4L+FMj4EyKPAS5aAVK4Ne1ejQ3Lhqnc zTS7cHvMMkO7SziMcAfF2zrxlkMRX2KOtNdf28SvTzjrMepgdJJWe3Vq1noj8AlIcU/B EYwg== X-Gm-Message-State: AHYfb5hdnDmzHiquMrCDYYKUTvsi/eoaAjtZ5Op5yz4ekOO5rkViw0Vu VbuF/Fkui9zLlYTCz96CiA== X-Received: by 10.237.42.67 with SMTP id k3mr172815qtf.122.1501793105129; Thu, 03 Aug 2017 13:45:05 -0700 (PDT) Received: from flea (c-76-28-41-155.hsd1.ma.comcast.net. [76.28.41.155]) by smtp.gmail.com with ESMTPSA id u16sm13802539qtc.81.2017.08.03.13.45.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 03 Aug 2017 13:45:03 -0700 (PDT) From: Ted Zlatanov To: Paul Eggert Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> <83k239ds5t.fsf@gnu.org> <6277b486-12c8-8363-cd9f-a79b6bda9304@cs.ucla.edu> <837ez8e54i.fsf@gnu.org> <8760ercdgu.fsf@lifelogs.com> <70d33c4c-eace-723a-ec89-a83089a94ee9@cs.ucla.edu> <874lto9zer.fsf@lifelogs.com> <2c1e9ab3-75f7-1972-1353-5b6a8219b6a4@cs.ucla.edu> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Date: Thu, 03 Aug 2017 16:45:03 -0400 In-Reply-To: <2c1e9ab3-75f7-1972-1353-5b6a8219b6a4@cs.ucla.edu> (Paul Eggert's message of "Thu, 3 Aug 2017 13:31:33 -0700") Message-ID: <877eyk8jow.fsf@lifelogs.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 27708 Cc: Glenn Morris , 27708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Thu, 3 Aug 2017 13:31:33 -0700 Paul Eggert wrote: PE> On 08/03/2017 01:20 PM, Ted Zlatanov wrote: >> I was overzealous writing the tests; we >> can just test the `secure-hash-algorithms' that are in GnuTLS. Can we >> check the patch below against Hydra without pushing it to master yet? PE> I tried that patch on my own copy (on Fedora 26, with GnuTLS 3.5.14) and it PE> failed as noted at the end of this email. That's a new error from the last one; we need to also drop the expected number of MACs, removing this line: - (should (> (length gnutls-tests-internal-macs-upcased) 5)) >> I'm having a strange problem building Emacs as of this morning, so I >> haven't been able to test the patch PE> What problem is it? Some of the recent changes probably suggest a 'make PE> bootstrap', so I'd try that first. It's a renaming error. I posted on emacs-devel since it may be specific to my setup. I'll try again later today or tomorrow. Thanks! Ted From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 03 17:33:07 2017 Received: (at 27708) by debbugs.gnu.org; 3 Aug 2017 21:33:07 +0000 Received: from localhost ([127.0.0.1]:40440 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddNjv-0001ww-48 for submit@debbugs.gnu.org; Thu, 03 Aug 2017 17:33:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddNju-0001wS-8A for 27708@debbugs.gnu.org; Thu, 03 Aug 2017 17:33:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddNjo-0004zU-CN for 27708@debbugs.gnu.org; Thu, 03 Aug 2017 17:33:01 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59437) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddNjo-0004zH-8e; Thu, 03 Aug 2017 17:33:00 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1ddNjn-0003nx-5V; Thu, 03 Aug 2017 17:32:59 -0400 From: Glenn Morris To: 27708@debbugs.gnu.org Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> <83k239ds5t.fsf@gnu.org> <6277b486-12c8-8363-cd9f-a79b6bda9304@cs.ucla.edu> <837ez8e54i.fsf@gnu.org> <8760ercdgu.fsf@lifelogs.com> <70d33c4c-eace-723a-ec89-a83089a94ee9@cs.ucla.edu> <874lto9zer.fsf@lifelogs.com> X-Spook: initiative Earthquake Clinton Serbian Downing Street FMD X-Ran: dnNHMJ./]z2y)~.O)T_,b`0w}t$HrYm00_Q(A\Se)2D/7g)[a)|OM"t#jv@q!dob"{r>J| X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Thu, 03 Aug 2017 17:32:59 -0400 In-Reply-To: <874lto9zer.fsf@lifelogs.com> (Ted Zlatanov's message of "Thu, 03 Aug 2017 16:20:12 -0400") Message-ID: <8th8xonxpw.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27708 Cc: eggert@cs.ucla.edu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Ted Zlatanov wrote: > I think that this means that one of MD5, SHA1, SHA224, SHA256, SHA384, > or SHA512 (the `secure-hash-algorithms' members currently) are not in > that version of GnuTLS. > > That is not really necessary. I was overzealous writing the tests; we > can just test the `secure-hash-algorithms' that are in GnuTLS. Before a8a81df: (mapcar 'car (gnutls-ciphers)) -> (RC2-40 ARCFOUR-40 DES-CBC 3DES-CBC CAMELLIA-256-GCM CAMELLIA-128-GCM CAMELLIA-128-CBC CAMELLIA-192-CBC CAMELLIA-256-CBC SALSA20-256 ESTREAM-SALSA20-256 ARCFOUR-128 AES-256-GCM AES-128-GCM AES-128-CBC AES-192-CBC AES-256-CBC) After a8a81df: (gnutls-ciphers) -> nil which seems a pretty drastic change to me. Again, this is with: #define GNUTLS_VERSION "3.3.24" #define GNUTLS_VERSION_NUMBER 0x030318 From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 03 21:42:11 2017 Received: (at 27708) by debbugs.gnu.org; 4 Aug 2017 01:42:11 +0000 Received: from localhost ([127.0.0.1]:40631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddRcw-0007Zl-G4 for submit@debbugs.gnu.org; Thu, 03 Aug 2017 21:42:11 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:43264) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddRct-0007ZZ-Aa for 27708@debbugs.gnu.org; Thu, 03 Aug 2017 21:42:09 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 996A816073E; Thu, 3 Aug 2017 18:42:00 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id rzLrfpjRz7Ct; Thu, 3 Aug 2017 18:41:57 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D81CB16073B; Thu, 3 Aug 2017 18:41:57 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id VAlkXqiS3aIF; Thu, 3 Aug 2017 18:41:57 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.153.184.153]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id AA729160727; Thu, 3 Aug 2017 18:41:57 -0700 (PDT) Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. To: Glenn Morris , 27708@debbugs.gnu.org References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> <83k239ds5t.fsf@gnu.org> <6277b486-12c8-8363-cd9f-a79b6bda9304@cs.ucla.edu> <837ez8e54i.fsf@gnu.org> <8760ercdgu.fsf@lifelogs.com> <70d33c4c-eace-723a-ec89-a83089a94ee9@cs.ucla.edu> <874lto9zer.fsf@lifelogs.com> <8th8xonxpw.fsf@fencepost.gnu.org> From: Paul Eggert Organization: UCLA Computer Science Department Message-ID: <995b3bf5-1215-56ae-9f4a-b94d65f6875e@cs.ucla.edu> Date: Thu, 3 Aug 2017 18:41:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <8th8xonxpw.fsf@fencepost.gnu.org> Content-Type: multipart/mixed; boundary="------------D4B5C36BC6AD98A47881DA63" Content-Language: en-US X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27708 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This is a multi-part message in MIME format. --------------D4B5C36BC6AD98A47881DA63 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Glenn Morris wrote: > After a8a81df: >=20 > (gnutls-ciphers) -> nil >=20 > which seems a pretty drastic change to me. Yes, sorry, that wasn't intended. I installed the attached to try to fix = that. --------------D4B5C36BC6AD98A47881DA63 Content-Type: text/x-patch; name="0001-Fix-version-numbers-for-some-GnuTLS-features.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Fix-version-numbers-for-some-GnuTLS-features.patch" =46rom 260cd8b07c9844a391e18f1deb18bcc977436e05 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 3 Aug 2017 17:57:24 -0700 Subject: [PATCH] Fix version numbers for some GnuTLS features Problem reported by Glenn Morris (Bug#27708#58). * src/gnutls.c (HAVE_GNUTLS_X509_SYSTEM_TRUST): New macro. Use it instead of low-level version number checks. (HAVE_GNUTLS_AEAD): Move here from gnutls.h, and rename from HAVE_GNUTLS3_AEAD. All uses changed. Indent preprocessor lines. * src/gnutls.h (HAVE_GNUTLS3_CIPHER, HAVE_GNUTLS3_DIGEST) (HAVE_GNUTLS3_HMAC): Remove, since these were available before GnuTLS 3.0.0 and the code checks them only if HAVE_GNUTLS3 is defined. Remove all uses; this simplifies the code a bit. --- src/gnutls.c | 370 +++++++++++++++++++++++++++--------------------------= ------ src/gnutls.h | 16 --- 2 files changed, 171 insertions(+), 215 deletions(-) diff --git a/src/gnutls.c b/src/gnutls.c index 5969407..188f995 100644 --- a/src/gnutls.c +++ b/src/gnutls.c @@ -26,22 +26,36 @@ along with GNU Emacs. If not, see . */ #include "coding.h" #include "buffer.h" =20 -#ifdef HAVE_GNUTLS +#if 0x030014 <=3D GNUTLS_VERSION_NUMBER +# define HAVE_GNUTLS_X509_SYSTEM_TRUST +#endif =20 -#ifdef WINDOWSNT -#include -#include "w32.h" +/* Although AEAD support started in GnuTLS 3.4.0 and works in 3.5.14, + it was broken through at least GnuTLS 3.4.10; see: + https://lists.gnu.org/archive/html/emacs-devel/2017-07/msg00992.html + The relevant fix seems to have been made in GnuTLS 3.5.1; see: + https://gitlab.com/gnutls/gnutls/commit/568935848dd6b82b9315d8b6c529d= 00e2605e03d + So, require 3.5.1. */ +#if 0x030501 <=3D GNUTLS_VERSION_NUMBER +# define HAVE_GNUTLS_AEAD #endif =20 +#ifdef HAVE_GNUTLS + +# ifdef WINDOWSNT +# include +# include "w32.h" +# endif + static bool emacs_gnutls_handle_error (gnutls_session_t, int); =20 static bool gnutls_global_initialized; =20 static void gnutls_log_function (int, const char *); static void gnutls_log_function2 (int, const char *, const char *); -#ifdef HAVE_GNUTLS3 +# ifdef HAVE_GNUTLS3 static void gnutls_audit_log_function (gnutls_session_t, const char *); -#endif +# endif =20 enum extra_peer_verification { @@ -49,7 +63,7 @@ enum extra_peer_verification }; =20 =0C -#ifdef WINDOWSNT +# ifdef WINDOWSNT =20 DEF_DLL_FN (gnutls_alert_description_t, gnutls_alert_get, (gnutls_session_t)); @@ -74,12 +88,10 @@ DEF_DLL_FN (int, gnutls_certificate_set_x509_crl_file= , DEF_DLL_FN (int, gnutls_certificate_set_x509_key_file, (gnutls_certificate_credentials_t, const char *, const char *, gnutls_x509_crt_fmt_t)); -# if ((GNUTLS_VERSION_MAJOR \ - + (GNUTLS_VERSION_MINOR > 0 || GNUTLS_VERSION_PATCH >=3D 20)) \ - > 3) +# ifdef HAVE_GNUTLS_X509_SYSTEM_TRUST DEF_DLL_FN (int, gnutls_certificate_set_x509_system_trust, (gnutls_certificate_credentials_t)); -# endif +# endif DEF_DLL_FN (int, gnutls_certificate_set_x509_trust_file, (gnutls_certificate_credentials_t, const char *, gnutls_x509_crt_fmt_t)); @@ -96,9 +108,9 @@ DEF_DLL_FN (int, gnutls_dh_get_prime_bits, (gnutls_ses= sion_t)); DEF_DLL_FN (int, gnutls_error_is_fatal, (int)); DEF_DLL_FN (int, gnutls_global_init, (void)); DEF_DLL_FN (void, gnutls_global_set_log_function, (gnutls_log_func)); -# ifdef HAVE_GNUTLS3 +# ifdef HAVE_GNUTLS3 DEF_DLL_FN (void, gnutls_global_set_audit_log_function, (gnutls_audit_lo= g_func)); -# endif +# endif DEF_DLL_FN (void, gnutls_global_set_log_level, (int)); DEF_DLL_FN (int, gnutls_handshake, (gnutls_session_t)); DEF_DLL_FN (int, gnutls_init, (gnutls_session_t *, unsigned int)); @@ -172,14 +184,13 @@ DEF_DLL_FN (const char *, gnutls_cipher_get_name, DEF_DLL_FN (gnutls_mac_algorithm_t, gnutls_mac_get, (gnutls_session_t));= DEF_DLL_FN (const char *, gnutls_mac_get_name, (gnutls_mac_algorithm_t))= ; =20 -# ifdef HAVE_GNUTLS3 +# ifdef HAVE_GNUTLS3 DEF_DLL_FN (int, gnutls_rnd, (gnutls_rnd_level_t, void *, size_t)); DEF_DLL_FN (const gnutls_mac_algorithm_t *, gnutls_mac_list, (void)); DEF_DLL_FN (size_t, gnutls_mac_get_nonce_size, (gnutls_mac_algorithm_t))= ; DEF_DLL_FN (size_t, gnutls_mac_get_key_size, (gnutls_mac_algorithm_t)); DEF_DLL_FN (const gnutls_digest_algorithm_t *, gnutls_digest_list, (void= )); DEF_DLL_FN (const char *, gnutls_digest_get_name, (gnutls_digest_algorit= hm_t)); -# ifdef HAVE_GNUTLS3_CIPHER DEF_DLL_FN (gnutls_cipher_algorithm_t *, gnutls_cipher_list, (void)); DEF_DLL_FN (int, gnutls_cipher_get_iv_size, (gnutls_cipher_algorithm_t))= ; DEF_DLL_FN (size_t, gnutls_cipher_get_key_size, (gnutls_cipher_algorithm= _t)); @@ -194,7 +205,7 @@ DEF_DLL_FN (int, gnutls_cipher_encrypt2, DEF_DLL_FN (void, gnutls_cipher_deinit, (gnutls_cipher_hd_t)); DEF_DLL_FN (int, gnutls_cipher_decrypt2, (gnutls_cipher_hd_t, const void *, size_t, void *, size_t)); -# ifdef HAVE_GNUTLS3_AEAD +# ifdef HAVE_GNUTLS_AEAD DEF_DLL_FN (int, gnutls_aead_cipher_init, (gnutls_aead_cipher_hd_t *, gnutls_cipher_algorithm_t, const gnutls_datum_t *)); @@ -205,25 +216,20 @@ DEF_DLL_FN (int, gnutls_aead_cipher_encrypt, DEF_DLL_FN (int, gnutls_aead_cipher_decrypt, (gnutls_aead_cipher_hd_t, const void *, size_t, const void *, size_t, size_t, const void *, size_t, void *, size_t *)); -# endif /* HAVE_GNUTLS3_AEAD */ -# ifdef HAVE_GNUTLS3_HMAC +# endif DEF_DLL_FN (int, gnutls_hmac_init, (gnutls_hmac_hd_t *, gnutls_mac_algorithm_t, const void *, size_t))= ; DEF_DLL_FN (int, gnutls_hmac_get_len, (gnutls_mac_algorithm_t)); DEF_DLL_FN (int, gnutls_hmac, (gnutls_hmac_hd_t, const void *, size_t));= DEF_DLL_FN (void, gnutls_hmac_deinit, (gnutls_hmac_hd_t, void *)); DEF_DLL_FN (void, gnutls_hmac_output, (gnutls_hmac_hd_t, void *)); -# endif /* HAVE_GNUTLS3_HMAC */ -# endif /* HAVE_GNUTLS3_CIPHER */ -# ifdef HAVE_GNUTLS3_DIGEST DEF_DLL_FN (int, gnutls_hash_init, (gnutls_hash_hd_t *, gnutls_digest_algorithm_t)); DEF_DLL_FN (int, gnutls_hash_get_len, (gnutls_digest_algorithm_t)); DEF_DLL_FN (int, gnutls_hash, (gnutls_hash_hd_t, const void *, size_t));= DEF_DLL_FN (void, gnutls_hash_deinit, (gnutls_hash_hd_t, void *)); DEF_DLL_FN (void, gnutls_hash_output, (gnutls_hash_hd_t, void *)); -# endif /* HAVE_GNUTLS3_DIGEST */ -# endif /* HAVE_GNUTLS3 */ +# endif /* HAVE_GNUTLS3 */ =20 =20 static bool @@ -249,11 +255,9 @@ init_gnutls_functions (void) LOAD_DLL_FN (library, gnutls_certificate_set_verify_flags); LOAD_DLL_FN (library, gnutls_certificate_set_x509_crl_file); LOAD_DLL_FN (library, gnutls_certificate_set_x509_key_file); -# if ((GNUTLS_VERSION_MAJOR \ - + (GNUTLS_VERSION_MINOR > 0 || GNUTLS_VERSION_PATCH >=3D 20)) \ - > 3) +# ifdef HAVE_GNUTLS_X509_SYSTEM_TRUST LOAD_DLL_FN (library, gnutls_certificate_set_x509_system_trust); -# endif +# endif LOAD_DLL_FN (library, gnutls_certificate_set_x509_trust_file); LOAD_DLL_FN (library, gnutls_certificate_type_get); LOAD_DLL_FN (library, gnutls_certificate_verify_peers2); @@ -264,9 +268,9 @@ init_gnutls_functions (void) LOAD_DLL_FN (library, gnutls_error_is_fatal); LOAD_DLL_FN (library, gnutls_global_init); LOAD_DLL_FN (library, gnutls_global_set_log_function); -# ifdef HAVE_GNUTLS3 +# ifdef HAVE_GNUTLS3 LOAD_DLL_FN (library, gnutls_global_set_audit_log_function); -# endif +# endif LOAD_DLL_FN (library, gnutls_global_set_log_level); LOAD_DLL_FN (library, gnutls_handshake); LOAD_DLL_FN (library, gnutls_init); @@ -309,14 +313,13 @@ init_gnutls_functions (void) LOAD_DLL_FN (library, gnutls_cipher_get_name); LOAD_DLL_FN (library, gnutls_mac_get); LOAD_DLL_FN (library, gnutls_mac_get_name); -# ifdef HAVE_GNUTLS3 +# ifdef HAVE_GNUTLS3 LOAD_DLL_FN (library, gnutls_rnd); LOAD_DLL_FN (library, gnutls_mac_list); LOAD_DLL_FN (library, gnutls_mac_get_nonce_size); LOAD_DLL_FN (library, gnutls_mac_get_key_size); LOAD_DLL_FN (library, gnutls_digest_list); LOAD_DLL_FN (library, gnutls_digest_get_name); -# ifdef HAVE_GNUTLS3_CIPHER LOAD_DLL_FN (library, gnutls_cipher_list); LOAD_DLL_FN (library, gnutls_cipher_get_iv_size); LOAD_DLL_FN (library, gnutls_cipher_get_key_size); @@ -327,28 +330,23 @@ init_gnutls_functions (void) LOAD_DLL_FN (library, gnutls_cipher_encrypt2); LOAD_DLL_FN (library, gnutls_cipher_deinit); LOAD_DLL_FN (library, gnutls_cipher_decrypt2); -# ifdef HAVE_GNUTLS3_AEAD +# ifdef HAVE_GNUTLS_AEAD LOAD_DLL_FN (library, gnutls_aead_cipher_init); LOAD_DLL_FN (library, gnutls_aead_cipher_deinit); LOAD_DLL_FN (library, gnutls_aead_cipher_encrypt); LOAD_DLL_FN (library, gnutls_aead_cipher_decrypt); # endif -# ifdef HAVE_GNUTLS3_HMAC LOAD_DLL_FN (library, gnutls_hmac_init); LOAD_DLL_FN (library, gnutls_hmac_get_len); LOAD_DLL_FN (library, gnutls_hmac); LOAD_DLL_FN (library, gnutls_hmac_deinit); LOAD_DLL_FN (library, gnutls_hmac_output); -# endif /* HAVE_GNUTLS3_HMAC */ -# endif /* HAVE_GNUTLS3_CIPHER */ -# ifdef HAVE_GNUTLS3_DIGEST LOAD_DLL_FN (library, gnutls_hash_init); LOAD_DLL_FN (library, gnutls_hash_get_len); LOAD_DLL_FN (library, gnutls_hash); LOAD_DLL_FN (library, gnutls_hash_deinit); LOAD_DLL_FN (library, gnutls_hash_output); -# endif -# endif /* HAVE_GNUTLS3 */ +# endif /* HAVE_GNUTLS3 */ =20 max_log_level =3D global_gnutls_log_level; =20 @@ -361,111 +359,105 @@ init_gnutls_functions (void) return 1; } =20 -# define gnutls_alert_get fn_gnutls_alert_get -# define gnutls_alert_get_name fn_gnutls_alert_get_name -# define gnutls_anon_allocate_client_credentials fn_gnutls_anon_allocate= _client_credentials -# define gnutls_anon_free_client_credentials fn_gnutls_anon_free_client_= credentials -# define gnutls_bye fn_gnutls_bye -# define gnutls_certificate_allocate_credentials fn_gnutls_certificate_a= llocate_credentials -# define gnutls_certificate_free_credentials fn_gnutls_certificate_free_= credentials -# define gnutls_certificate_get_peers fn_gnutls_certificate_get_peers -# define gnutls_certificate_set_verify_flags fn_gnutls_certificate_set_v= erify_flags -# define gnutls_certificate_set_x509_crl_file fn_gnutls_certificate_set_= x509_crl_file -# define gnutls_certificate_set_x509_key_file fn_gnutls_certificate_set_= x509_key_file -# define gnutls_certificate_set_x509_system_trust fn_gnutls_certificate_= set_x509_system_trust -# define gnutls_certificate_set_x509_trust_file fn_gnutls_certificate_se= t_x509_trust_file -# define gnutls_certificate_type_get fn_gnutls_certificate_type_get -# define gnutls_certificate_verify_peers2 fn_gnutls_certificate_verify_p= eers2 -# define gnutls_cipher_get fn_gnutls_cipher_get -# define gnutls_cipher_get_name fn_gnutls_cipher_get_name -# define gnutls_credentials_set fn_gnutls_credentials_set -# define gnutls_deinit fn_gnutls_deinit -# define gnutls_dh_get_prime_bits fn_gnutls_dh_get_prime_bits -# define gnutls_dh_set_prime_bits fn_gnutls_dh_set_prime_bits -# define gnutls_error_is_fatal fn_gnutls_error_is_fatal -# define gnutls_global_init fn_gnutls_global_init -# define gnutls_global_set_audit_log_function fn_gnutls_global_set_audit= _log_function -# define gnutls_global_set_log_function fn_gnutls_global_set_log_functio= n -# define gnutls_global_set_log_level fn_gnutls_global_set_log_level -# define gnutls_handshake fn_gnutls_handshake -# define gnutls_init fn_gnutls_init -# define gnutls_kx_get fn_gnutls_kx_get -# define gnutls_kx_get_name fn_gnutls_kx_get_name -# define gnutls_mac_get fn_gnutls_mac_get -# define gnutls_mac_get_name fn_gnutls_mac_get_name -# define gnutls_pk_algorithm_get_name fn_gnutls_pk_algorithm_get_name -# define gnutls_pk_bits_to_sec_param fn_gnutls_pk_bits_to_sec_param -# define gnutls_priority_set_direct fn_gnutls_priority_set_direct -# define gnutls_protocol_get_name fn_gnutls_protocol_get_name -# define gnutls_protocol_get_version fn_gnutls_protocol_get_version -# define gnutls_record_check_pending fn_gnutls_record_check_pending -# define gnutls_record_recv fn_gnutls_record_recv -# define gnutls_record_send fn_gnutls_record_send -# define gnutls_sec_param_get_name fn_gnutls_sec_param_get_name -# define gnutls_server_name_set fn_gnutls_server_name_set -# define gnutls_sign_get_name fn_gnutls_sign_get_name -# define gnutls_strerror fn_gnutls_strerror -# define gnutls_transport_set_errno fn_gnutls_transport_set_errno -# define gnutls_transport_set_ptr2 fn_gnutls_transport_set_ptr2 -# define gnutls_transport_set_pull_function fn_gnutls_transport_set_pull= _function -# define gnutls_transport_set_push_function fn_gnutls_transport_set_push= _function -# define gnutls_x509_crt_check_hostname fn_gnutls_x509_crt_check_hostnam= e -# define gnutls_x509_crt_check_issuer fn_gnutls_x509_crt_check_issuer -# define gnutls_x509_crt_deinit fn_gnutls_x509_crt_deinit -# define gnutls_x509_crt_get_activation_time fn_gnutls_x509_crt_get_acti= vation_time -# define gnutls_x509_crt_get_dn fn_gnutls_x509_crt_get_dn -# define gnutls_x509_crt_get_expiration_time fn_gnutls_x509_crt_get_expi= ration_time -# define gnutls_x509_crt_get_fingerprint fn_gnutls_x509_crt_get_fingerpr= int -# define gnutls_x509_crt_get_issuer_dn fn_gnutls_x509_crt_get_issuer_dn -# define gnutls_x509_crt_get_issuer_unique_id fn_gnutls_x509_crt_get_iss= uer_unique_id -# define gnutls_x509_crt_get_key_id fn_gnutls_x509_crt_get_key_id -# define gnutls_x509_crt_get_pk_algorithm fn_gnutls_x509_crt_get_pk_algo= rithm -# define gnutls_x509_crt_get_serial fn_gnutls_x509_crt_get_serial -# define gnutls_x509_crt_get_signature_algorithm fn_gnutls_x509_crt_get_= signature_algorithm -# define gnutls_x509_crt_get_subject_unique_id fn_gnutls_x509_crt_get_su= bject_unique_id -# define gnutls_x509_crt_get_version fn_gnutls_x509_crt_get_version -# define gnutls_x509_crt_import fn_gnutls_x509_crt_import -# define gnutls_x509_crt_init fn_gnutls_x509_crt_init -# ifdef HAVE_GNUTLS3 -# define gnutls_rnd fn_gnutls_rnd -# define gnutls_mac_list fn_gnutls_mac_list -# define gnutls_mac_get_nonce_size fn_gnutls_mac_get_nonce_size -# define gnutls_mac_get_key_size fn_gnutls_mac_get_key_size -# define gnutls_digest_list fn_gnutls_digest_list -# define gnutls_digest_get_name fn_gnutls_digest_get_name -# ifdef HAVE_GNUTLS3_CIPHER -# define gnutls_cipher_list fn_gnutls_cipher_list -# define gnutls_cipher_get_iv_size fn_gnutls_cipher_get_iv_size -# define gnutls_cipher_get_key_size fn_gnutls_cipher_get_key_size -# define gnutls_cipher_get_block_size fn_gnutls_cipher_get_block_size -# define gnutls_cipher_get_tag_size fn_gnutls_cipher_get_tag_size -# define gnutls_cipher_init fn_gnutls_cipher_init -# define gnutls_cipher_set_iv fn_gnutls_cipher_set_iv -# define gnutls_cipher_encrypt2 fn_gnutls_cipher_encrypt2 -# define gnutls_cipher_decrypt2 fn_gnutls_cipher_decrypt2 -# define gnutls_cipher_deinit fn_gnutls_cipher_deinit -# ifdef HAVE_GNUTLS3_AEAD -# define gnutls_aead_cipher_encrypt fn_gnutls_aead_cipher_encrypt -# define gnutls_aead_cipher_decrypt fn_gnutls_aead_cipher_decrypt -# define gnutls_aead_cipher_init fn_gnutls_aead_cipher_init -# define gnutls_aead_cipher_deinit fn_gnutls_aead_cipher_deinit -# endif /* HAVE_GNUTLS3_AEAD */ -# ifdef HAVE_GNUTLS3_HMAC -# define gnutls_hmac_init fn_gnutls_hmac_init -# define gnutls_hmac_get_len fn_gnutls_hmac_get_len -# define gnutls_hmac fn_gnutls_hmac -# define gnutls_hmac_deinit fn_gnutls_hmac_deinit -# define gnutls_hmac_output fn_gnutls_hmac_output -# endif /* HAVE_GNUTLS3_HMAC */ -# endif /* HAVE_GNUTLS3_CIPHER */ -# ifdef HAVE_GNUTLS3_DIGEST -# define gnutls_hash_init fn_gnutls_hash_init -# define gnutls_hash_get_len fn_gnutls_hash_get_len -# define gnutls_hash fn_gnutls_hash -# define gnutls_hash_deinit fn_gnutls_hash_deinit -# define gnutls_hash_output fn_gnutls_hash_output -# endif -# endif /* HAVE_GNUTLS3 */ +# define gnutls_alert_get fn_gnutls_alert_get +# define gnutls_alert_get_name fn_gnutls_alert_get_name +# define gnutls_anon_allocate_client_credentials fn_gnutls_anon_allocat= e_client_credentials +# define gnutls_anon_free_client_credentials fn_gnutls_anon_free_client= _credentials +# define gnutls_bye fn_gnutls_bye +# define gnutls_certificate_allocate_credentials fn_gnutls_certificate_= allocate_credentials +# define gnutls_certificate_free_credentials fn_gnutls_certificate_free= _credentials +# define gnutls_certificate_get_peers fn_gnutls_certificate_get_peers +# define gnutls_certificate_set_verify_flags fn_gnutls_certificate_set_= verify_flags +# define gnutls_certificate_set_x509_crl_file fn_gnutls_certificate_set= _x509_crl_file +# define gnutls_certificate_set_x509_key_file fn_gnutls_certificate_set= _x509_key_file +# define gnutls_certificate_set_x509_system_trust fn_gnutls_certificate= _set_x509_system_trust +# define gnutls_certificate_set_x509_trust_file fn_gnutls_certificate_s= et_x509_trust_file +# define gnutls_certificate_type_get fn_gnutls_certificate_type_get +# define gnutls_certificate_verify_peers2 fn_gnutls_certificate_verify_= peers2 +# define gnutls_cipher_get fn_gnutls_cipher_get +# define gnutls_cipher_get_name fn_gnutls_cipher_get_name +# define gnutls_credentials_set fn_gnutls_credentials_set +# define gnutls_deinit fn_gnutls_deinit +# define gnutls_dh_get_prime_bits fn_gnutls_dh_get_prime_bits +# define gnutls_dh_set_prime_bits fn_gnutls_dh_set_prime_bits +# define gnutls_error_is_fatal fn_gnutls_error_is_fatal +# define gnutls_global_init fn_gnutls_global_init +# define gnutls_global_set_audit_log_function fn_gnutls_global_set_audi= t_log_function +# define gnutls_global_set_log_function fn_gnutls_global_set_log_functi= on +# define gnutls_global_set_log_level fn_gnutls_global_set_log_level +# define gnutls_handshake fn_gnutls_handshake +# define gnutls_init fn_gnutls_init +# define gnutls_kx_get fn_gnutls_kx_get +# define gnutls_kx_get_name fn_gnutls_kx_get_name +# define gnutls_mac_get fn_gnutls_mac_get +# define gnutls_mac_get_name fn_gnutls_mac_get_name +# define gnutls_pk_algorithm_get_name fn_gnutls_pk_algorithm_get_name +# define gnutls_pk_bits_to_sec_param fn_gnutls_pk_bits_to_sec_param +# define gnutls_priority_set_direct fn_gnutls_priority_set_direct +# define gnutls_protocol_get_name fn_gnutls_protocol_get_name +# define gnutls_protocol_get_version fn_gnutls_protocol_get_version +# define gnutls_record_check_pending fn_gnutls_record_check_pending +# define gnutls_record_recv fn_gnutls_record_recv +# define gnutls_record_send fn_gnutls_record_send +# define gnutls_sec_param_get_name fn_gnutls_sec_param_get_name +# define gnutls_server_name_set fn_gnutls_server_name_set +# define gnutls_sign_get_name fn_gnutls_sign_get_name +# define gnutls_strerror fn_gnutls_strerror +# define gnutls_transport_set_errno fn_gnutls_transport_set_errno +# define gnutls_transport_set_ptr2 fn_gnutls_transport_set_ptr2 +# define gnutls_transport_set_pull_function fn_gnutls_transport_set_pul= l_function +# define gnutls_transport_set_push_function fn_gnutls_transport_set_pus= h_function +# define gnutls_x509_crt_check_hostname fn_gnutls_x509_crt_check_hostna= me +# define gnutls_x509_crt_check_issuer fn_gnutls_x509_crt_check_issuer +# define gnutls_x509_crt_deinit fn_gnutls_x509_crt_deinit +# define gnutls_x509_crt_get_activation_time fn_gnutls_x509_crt_get_act= ivation_time +# define gnutls_x509_crt_get_dn fn_gnutls_x509_crt_get_dn +# define gnutls_x509_crt_get_expiration_time fn_gnutls_x509_crt_get_exp= iration_time +# define gnutls_x509_crt_get_fingerprint fn_gnutls_x509_crt_get_fingerp= rint +# define gnutls_x509_crt_get_issuer_dn fn_gnutls_x509_crt_get_issuer_dn= +# define gnutls_x509_crt_get_issuer_unique_id fn_gnutls_x509_crt_get_is= suer_unique_id +# define gnutls_x509_crt_get_key_id fn_gnutls_x509_crt_get_key_id +# define gnutls_x509_crt_get_pk_algorithm fn_gnutls_x509_crt_get_pk_alg= orithm +# define gnutls_x509_crt_get_serial fn_gnutls_x509_crt_get_serial +# define gnutls_x509_crt_get_signature_algorithm fn_gnutls_x509_crt_get= _signature_algorithm +# define gnutls_x509_crt_get_subject_unique_id fn_gnutls_x509_crt_get_s= ubject_unique_id +# define gnutls_x509_crt_get_version fn_gnutls_x509_crt_get_version +# define gnutls_x509_crt_import fn_gnutls_x509_crt_import +# define gnutls_x509_crt_init fn_gnutls_x509_crt_init +# ifdef HAVE_GNUTLS3 +# define gnutls_rnd fn_gnutls_rnd +# define gnutls_mac_list fn_gnutls_mac_list +# define gnutls_mac_get_nonce_size fn_gnutls_mac_get_nonce_size +# define gnutls_mac_get_key_size fn_gnutls_mac_get_key_size +# define gnutls_digest_list fn_gnutls_digest_list +# define gnutls_digest_get_name fn_gnutls_digest_get_name +# define gnutls_cipher_list fn_gnutls_cipher_list +# define gnutls_cipher_get_iv_size fn_gnutls_cipher_get_iv_size +# define gnutls_cipher_get_key_size fn_gnutls_cipher_get_key_size +# define gnutls_cipher_get_block_size fn_gnutls_cipher_get_block_size +# define gnutls_cipher_get_tag_size fn_gnutls_cipher_get_tag_size +# define gnutls_cipher_init fn_gnutls_cipher_init +# define gnutls_cipher_set_iv fn_gnutls_cipher_set_iv +# define gnutls_cipher_encrypt2 fn_gnutls_cipher_encrypt2 +# define gnutls_cipher_decrypt2 fn_gnutls_cipher_decrypt2 +# define gnutls_cipher_deinit fn_gnutls_cipher_deinit +# ifdef HAVE_GNUTLS_AEAD +# define gnutls_aead_cipher_encrypt fn_gnutls_aead_cipher_encrypt +# define gnutls_aead_cipher_decrypt fn_gnutls_aead_cipher_decrypt +# define gnutls_aead_cipher_init fn_gnutls_aead_cipher_init +# define gnutls_aead_cipher_deinit fn_gnutls_aead_cipher_deinit +# endif +# define gnutls_hmac_init fn_gnutls_hmac_init +# define gnutls_hmac_get_len fn_gnutls_hmac_get_len +# define gnutls_hmac fn_gnutls_hmac +# define gnutls_hmac_deinit fn_gnutls_hmac_deinit +# define gnutls_hmac_output fn_gnutls_hmac_output +# define gnutls_hash_init fn_gnutls_hash_init +# define gnutls_hash_get_len fn_gnutls_hash_get_len +# define gnutls_hash fn_gnutls_hash +# define gnutls_hash_deinit fn_gnutls_hash_deinit +# define gnutls_hash_output fn_gnutls_hash_output +# endif /* HAVE_GNUTLS3 */ =20 /* This wrapper is called from fns.c, which doesn't know about the LOAD_DLL_FN stuff above. */ @@ -475,7 +467,7 @@ w32_gnutls_rnd (gnutls_rnd_level_t level, void *data,= size_t len) return gnutls_rnd (level, data, len); } =20 -#endif /* WINDOWSNT */ +# endif /* WINDOWSNT */ =20 =0C /* Report memory exhaustion if ERR is an out-of-memory indication. */ @@ -489,7 +481,7 @@ check_memory_full (int err) memory_full (0); } =20 -#ifdef HAVE_GNUTLS3 +# ifdef HAVE_GNUTLS3 /* Log a simple audit message. */ static void gnutls_audit_log_function (gnutls_session_t session, const char *string)= @@ -499,7 +491,7 @@ gnutls_audit_log_function (gnutls_session_t session, = const char *string) message ("gnutls.c: [audit] %s", string); } } -#endif +# endif =20 /* Log a simple message. */ static void @@ -552,7 +544,7 @@ gnutls_try_handshake (struct Lisp_Process *proc) return ret; } =20 -#ifndef WINDOWSNT +# ifndef WINDOWSNT static int emacs_gnutls_nonblock_errno (gnutls_transport_ptr_t ptr) { @@ -560,13 +552,13 @@ emacs_gnutls_nonblock_errno (gnutls_transport_ptr_t= ptr) =20 switch (err) { -# ifdef _AIX +# ifdef _AIX /* This is taken from the GnuTLS system_errno function circa 2016;= see . */ case 0: errno =3D EAGAIN; /* Fall through. */ -# endif +# endif case EINPROGRESS: case ENOTCONN: return EAGAIN; @@ -575,7 +567,7 @@ emacs_gnutls_nonblock_errno (gnutls_transport_ptr_t p= tr) return err; } } -#endif /* !WINDOWSNT */ +# endif /* !WINDOWSNT */ =20 static int emacs_gnutls_handshake (struct Lisp_Process *proc) @@ -587,7 +579,7 @@ emacs_gnutls_handshake (struct Lisp_Process *proc) =20 if (proc->gnutls_initstage < GNUTLS_STAGE_TRANSPORT_POINTERS_SET) { -#ifdef WINDOWSNT +# ifdef WINDOWSNT /* On W32 we cannot transfer socket handles between different runt= ime libraries, so we tell GnuTLS to use our special push/pull functions. */ @@ -596,7 +588,7 @@ emacs_gnutls_handshake (struct Lisp_Process *proc) (gnutls_transport_ptr_t) proc); gnutls_transport_set_push_function (state, &emacs_gnutls_push); gnutls_transport_set_pull_function (state, &emacs_gnutls_pull); -#else +# else /* This is how GnuTLS takes sockets: as file descriptors passed in. For an Emacs process socket, infd and outfd are the same but we use this two-argument version for clarity. */ @@ -606,7 +598,7 @@ emacs_gnutls_handshake (struct Lisp_Process *proc) if (proc->is_non_blocking_client) gnutls_transport_set_errno_function (state, emacs_gnutls_nonblock_errno); -#endif +# endif =20 proc->gnutls_initstage =3D GNUTLS_STAGE_TRANSPORT_POINTERS_SET; } @@ -620,13 +612,13 @@ emacs_gnutls_record_check_pending (gnutls_session_t= state) return gnutls_record_check_pending (state); } =20 -#ifdef WINDOWSNT +# ifdef WINDOWSNT void emacs_gnutls_transport_set_errno (gnutls_session_t state, int err) { gnutls_transport_set_errno (state, err); } -#endif +# endif =20 ptrdiff_t emacs_gnutls_write (struct Lisp_Process *proc, const char *buf, ptrdiff_= t nbyte) @@ -732,10 +724,10 @@ emacs_gnutls_handle_error (gnutls_session_t session= , int err) /* Mostly ignore "The TLS connection was non-properly terminated" message which just means that the peer closed the connection. */ -#ifdef HAVE_GNUTLS3 +# ifdef HAVE_GNUTLS3 if (err =3D=3D GNUTLS_E_PREMATURE_TERMINATION) level =3D 3; -#endif +# endif =20 GNUTLS_LOG2 (level, max_log_level, "fatal error:", str); ret =3D false; @@ -1300,7 +1292,7 @@ gnutls_ip_address_p (char *string) return true; } =20 -#if 0 +# if 0 /* Deinitialize global GnuTLS state. See also `gnutls-global-init'. */ static Lisp_Object @@ -1313,7 +1305,7 @@ emacs_gnutls_global_deinit (void) =20 return gnutls_make_error (GNUTLS_E_SUCCESS); } -#endif +# endif =20 static void ATTRIBUTE_FORMAT_PRINTF (2, 3) boot_error (struct Lisp_Process *p, const char *m, ...) @@ -1585,9 +1577,9 @@ one trustfile (usually a CA bundle). */) if (TYPE_RANGED_INTEGERP (int, loglevel)) { gnutls_global_set_log_function (gnutls_log_function); -#ifdef HAVE_GNUTLS3 +# ifdef HAVE_GNUTLS3 gnutls_global_set_audit_log_function (gnutls_audit_log_function); -#endif +# endif gnutls_global_set_log_level (XINT (loglevel)); max_log_level =3D XINT (loglevel); XPROCESS (proc)->gnutls_log_level =3D max_log_level; @@ -1649,8 +1641,7 @@ one trustfile (usually a CA bundle). */) int file_format =3D GNUTLS_X509_FMT_PEM; Lisp_Object tail; =20 -#if GNUTLS_VERSION_MAJOR + \ - (GNUTLS_VERSION_MINOR > 0 || GNUTLS_VERSION_PATCH >=3D 20) > 3 +# ifdef HAVE_GNUTLS_X509_SYSTEM_TRUST ret =3D gnutls_certificate_set_x509_system_trust (x509_cred); if (ret < GNUTLS_E_SUCCESS) { @@ -1658,7 +1649,7 @@ one trustfile (usually a CA bundle). */) GNUTLS_LOG2i (4, max_log_level, "setting system trust failed with code ", ret); } -#endif +# endif =20 for (tail =3D trustfiles; CONSP (tail); tail =3D XCDR (tail)) { @@ -1668,12 +1659,12 @@ one trustfile (usually a CA bundle). */) GNUTLS_LOG2 (1, max_log_level, "setting the trustfile: ", SSDATA (trustfile)); trustfile =3D ENCODE_FILE (trustfile); -#ifdef WINDOWSNT +# ifdef WINDOWSNT /* Since GnuTLS doesn't support UTF-8 or UTF-16 encoded file names on Windows, we need to re-encode the file name using the current ANSI codepage. */ trustfile =3D ansi_encode_filename (trustfile); -#endif +# endif ret =3D gnutls_certificate_set_x509_trust_file (x509_cred, SSDATA (trustfile), @@ -1698,9 +1689,9 @@ one trustfile (usually a CA bundle). */) GNUTLS_LOG2 (1, max_log_level, "setting the CRL file: ", SSDATA (crlfile)); crlfile =3D ENCODE_FILE (crlfile); -#ifdef WINDOWSNT +# ifdef WINDOWSNT crlfile =3D ansi_encode_filename (crlfile); -#endif +# endif ret =3D gnutls_certificate_set_x509_crl_file (x509_cred, SSDATA (crlfile), file_format); =20 @@ -1727,10 +1718,10 @@ one trustfile (usually a CA bundle). */) SSDATA (certfile)); keyfile =3D ENCODE_FILE (keyfile); certfile =3D ENCODE_FILE (certfile); -#ifdef WINDOWSNT +# ifdef WINDOWSNT keyfile =3D ansi_encode_filename (keyfile); certfile =3D ansi_encode_filename (certfile); -#endif +# endif ret =3D gnutls_certificate_set_x509_key_file (x509_cred, SSDATA (certfile), SSDATA (keyfile), file_format); =20 @@ -1755,10 +1746,10 @@ one trustfile (usually a CA bundle). */) =20 GNUTLS_LOG (1, max_log_level, "gnutls_init"); int gnutls_flags =3D GNUTLS_CLIENT; -#ifdef GNUTLS_NONBLOCK +# ifdef GNUTLS_NONBLOCK if (XPROCESS (proc)->is_non_blocking_client) gnutls_flags |=3D GNUTLS_NONBLOCK; -#endif +# endif ret =3D gnutls_init (&state, gnutls_flags); XPROCESS (proc)->gnutls_state =3D state; if (ret < GNUTLS_E_SUCCESS) @@ -1852,7 +1843,6 @@ The alist key is the cipher name. */) { Lisp_Object ciphers =3D Qnil; =20 -#ifdef HAVE_GNUTLS3_CIPHER const gnutls_cipher_algorithm_t *gciphers =3D gnutls_cipher_list (); for (ptrdiff_t pos =3D 0; gciphers[pos] !=3D 0; pos++) { @@ -1886,7 +1876,6 @@ The alist key is the cipher name. */) =20 ciphers =3D Fcons (cp, ciphers); } -#endif =20 return ciphers; } @@ -1899,7 +1888,7 @@ gnutls_symmetric_aead (bool encrypting, gnutls_ciph= er_algorithm_t gca, const char *idata, ptrdiff_t isize, Lisp_Object aead_auth) { -#ifdef HAVE_GNUTLS3_AEAD +# ifdef HAVE_GNUTLS_AEAD =20 const char *desc =3D encrypting ? "encrypt" : "decrypt"; Lisp_Object actual_iv =3D make_unibyte_string (vdata, vsize); @@ -1969,10 +1958,10 @@ gnutls_symmetric_aead (bool encrypting, gnutls_ci= pher_algorithm_t gca, =20 SAFE_FREE (); return list2 (output, actual_iv); -#else +# else printmax_t print_gca =3D gca; error ("GnuTLS AEAD cipher %"pMd" is invalid or not found", print_gca)= ; -#endif +# endif } =20 static Lisp_Object @@ -2181,7 +2170,6 @@ name. */) (void) { Lisp_Object mac_algorithms =3D Qnil; -#ifdef HAVE_GNUTLS3_HMAC const gnutls_mac_algorithm_t *macs =3D gnutls_mac_list (); for (ptrdiff_t pos =3D 0; macs[pos] !=3D 0; pos++) { @@ -2204,7 +2192,6 @@ name. */) make_number (gnutls_mac_get_nonce_size (gm= a))); mac_algorithms =3D Fcons (mp, mac_algorithms); } -#endif =20 return mac_algorithms; } @@ -2218,7 +2205,6 @@ method name. */) (void) { Lisp_Object digest_algorithms =3D Qnil; -#ifdef HAVE_GNUTLS3_DIGEST const gnutls_digest_algorithm_t *digests =3D gnutls_digest_list (); for (ptrdiff_t pos =3D 0; digests[pos] !=3D 0; pos++) { @@ -2236,7 +2222,6 @@ method name. */) =20 digest_algorithms =3D Fcons (mp, digest_algorithms); } -#endif =20 return digest_algorithms; } @@ -2423,25 +2408,17 @@ GnuTLS AEAD ciphers : the list will contain `= AEAD-ciphers'. */) =20 # ifdef HAVE_GNUTLS3 capabilities =3D Fcons (intern("gnutls3"), capabilities); - -# ifdef HAVE_GNUTLS3_DIGEST capabilities =3D Fcons (intern("digests"), capabilities); -# endif - -# ifdef HAVE_GNUTLS3_CIPHER capabilities =3D Fcons (intern("ciphers"), capabilities); =20 -# ifdef HAVE_GNUTLS3_AEAD +# ifdef HAVE_GNUTLS_AEAD capabilities =3D Fcons (intern("AEAD-ciphers"), capabilities); -# endif +# endif =20 -# ifdef HAVE_GNUTLS3_HMAC capabilities =3D Fcons (intern("macs"), capabilities); -# endif -# endif /* HAVE_GNUTLS3_CIPHER */ # endif /* HAVE_GNUTLS3 */ =20 -#ifdef WINDOWSNT +# ifdef WINDOWSNT Lisp_Object found =3D Fassq (Qgnutls, Vlibrary_cache); if (CONSP (found)) return XCDR (found); @@ -2452,15 +2429,10 @@ GnuTLS AEAD ciphers : the list will contain `= AEAD-ciphers'. */) Vlibrary_cache =3D Fcons (Fcons (Qgnutls, status), Vlibrary_cache)= ; return status; } -#else /* !WINDOWSNT */ +# endif /* WINDOWSNT */ +#endif /* HAVE_GNUTLS */ =20 return capabilities; - -#endif /* WINDOWSNT */ - -#else /* !HAVE_GNUTLS */ - return Qnil; -#endif /* HAVE_GNUTLS */ } =20 void diff --git a/src/gnutls.h b/src/gnutls.h index 8fe4ac3..9323cd1 100644 --- a/src/gnutls.h +++ b/src/gnutls.h @@ -28,22 +28,6 @@ along with GNU Emacs. If not, see . */ # include #endif =20 -#if 0x030400 <=3D GNUTLS_VERSION_NUMBER -# define HAVE_GNUTLS3_CIPHER -# define HAVE_GNUTLS3_DIGEST -# define HAVE_GNUTLS3_HMAC -#endif - -/* Although AEAD support started in GnuTLS 3.4.0 and works in 3.5.14, - it was broken through at least GnuTLS 3.4.10; see: - https://lists.gnu.org/archive/html/emacs-devel/2017-07/msg00992.html - The relevant fix seems to have been made in GnuTLS 3.5.1; see: - https://gitlab.com/gnutls/gnutls/commit/568935848dd6b82b9315d8b6c529d= 00e2605e03d - So use 3.5.1 for now. */ -#if 0x030501 <=3D GNUTLS_VERSION_NUMBER -# define HAVE_GNUTLS3_AEAD -#endif - #include "lisp.h" =20 /* This limits the attempts to handshake per process (connection). It --=20 2.7.4 --------------D4B5C36BC6AD98A47881DA63-- From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 04 09:32:46 2017 Received: (at 27708) by debbugs.gnu.org; 4 Aug 2017 13:32:46 +0000 Received: from localhost ([127.0.0.1]:41040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddcic-0000fW-JE for submit@debbugs.gnu.org; Fri, 04 Aug 2017 09:32:46 -0400 Received: from mail-qk0-f174.google.com ([209.85.220.174]:34344) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddciZ-0000fG-Nb for 27708@debbugs.gnu.org; Fri, 04 Aug 2017 09:32:44 -0400 Received: by mail-qk0-f174.google.com with SMTP id u139so8915077qka.1 for <27708@debbugs.gnu.org>; Fri, 04 Aug 2017 06:32:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to:date :in-reply-to:message-id:user-agent:mime-version; bh=5eg07uJ+jaXypu+eAASNW1hbMXZofSoyxXuUMTpd3uM=; b=qEvzhriRYmz2a7sNLCTw56FcRRUQqkgBafu2NGJz9mVX3g7tDFp5RzPwRFWYnTlNYx ViAlJoR4yWscrTdSPNQgmSF4bfuKO5bcCpWqmQrmqmqE2UJ5/8HitMR0n/u46GhOEEw9 19u/arNnKYUUPref0YBXUksCaFp6anvKDAfGw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:date:in-reply-to:message-id:user-agent:mime-version; bh=5eg07uJ+jaXypu+eAASNW1hbMXZofSoyxXuUMTpd3uM=; b=NLrdwswM8CJDl6zG1yeTfmaT7Bx9sLrcrrxiXWFz8OtN2MArOQtXAL+/phlKBrNSJr o79XBf7X9Mx/hk3plpqC8s+bScFJADACMDCLDj2dEViS0PTrUiAzctnHV3OvM0kwCl6Y wL3e1TVaTco94GCcBbkxQhAIfFmmkl75LAp7FDF6Ouys+gtZFo1ijO6RPuUMWyYXcj6x VNyXsiCA4PfEimlFxGG3LBva2lg7J8LAEp4ZcUQfMyjEjaRubfuKTAFdhxh0XUytVWJg By9kSpijR8fPWZtDc5kQKkfaRnKr8eUTFwNuQ3NJeojOTmM2Y4R6RGWN/YtfcOu04+JB ZMmw== X-Gm-Message-State: AHYfb5go3K0xubHuZvqiQFaBP6AHKZRPZaYP2UR7WVoGKu0NNs+LzjKQ mcHE2mfQtO3AZBIYLGj7qw== X-Received: by 10.55.18.158 with SMTP id 30mr2904421qks.240.1501853557815; Fri, 04 Aug 2017 06:32:37 -0700 (PDT) Received: from flea (c-76-28-41-155.hsd1.ma.comcast.net. [76.28.41.155]) by smtp.gmail.com with ESMTPSA id a62sm985295qkd.14.2017.08.04.06.32.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 04 Aug 2017 06:32:37 -0700 (PDT) From: Ted Zlatanov To: Paul Eggert Subject: Re: bug#27708: [PROPOSED] Simplify configuration of HAVE_GNUTLS3 etc. Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <1500135245-29120-1-git-send-email-eggert@cs.ucla.edu> <83shhxek2j.fsf@gnu.org> <87zic5ecsa.fsf@lifelogs.com> <83mv85ec9l.fsf@gnu.org> <83k239ds5t.fsf@gnu.org> <6277b486-12c8-8363-cd9f-a79b6bda9304@cs.ucla.edu> <837ez8e54i.fsf@gnu.org> <8760ercdgu.fsf@lifelogs.com> <70d33c4c-eace-723a-ec89-a83089a94ee9@cs.ucla.edu> <874lto9zer.fsf@lifelogs.com> <8th8xonxpw.fsf@fencepost.gnu.org> <995b3bf5-1215-56ae-9f4a-b94d65f6875e@cs.ucla.edu> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Date: Fri, 04 Aug 2017 09:32:35 -0400 In-Reply-To: <995b3bf5-1215-56ae-9f4a-b94d65f6875e@cs.ucla.edu> (Paul Eggert's message of "Thu, 3 Aug 2017 18:41:57 -0700") Message-ID: <87d18b791o.fsf@lifelogs.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 27708 Cc: Glenn Morris , 27708@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Thu, 3 Aug 2017 18:41:57 -0700 Paul Eggert wrote: PE> Glenn Morris wrote: >> After a8a81df: >> >> (gnutls-ciphers) -> nil >> >> which seems a pretty drastic change to me. PE> Yes, sorry, that wasn't intended. I installed the attached to try to fix that. Hi Glenn, looking at https://hydra.nixos.org/jobset/gnu/emacs-trunk it seems that Paul's fix has resolved the GnuTLS tests without any patching of gnutls-tests.el as I thought was needed. Can you confirm? Thanks Ted From unknown Sun Jun 22 11:39:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 02 Sep 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator