From unknown Fri Aug 15 03:56:13 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#27705 <27705@debbugs.gnu.org> To: bug#27705 <27705@debbugs.gnu.org> Subject: Status: [PATCH 0/4] Make both EFI and non-EFI systems boot our disk images. Reply-To: bug#27705 <27705@debbugs.gnu.org> Date: Fri, 15 Aug 2025 10:56:13 +0000 retitle 27705 [PATCH 0/4] Make both EFI and non-EFI systems boot our disk i= mages. reassign 27705 guix-patches submitter 27705 Danny Milosavljevic severity 27705 normal tag 27705 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 09:35:54 2017 Received: (at submit) by debbugs.gnu.org; 15 Jul 2017 13:35:55 +0000 Received: from localhost ([127.0.0.1]:39620 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWNEg-0002PG-M0 for submit@debbugs.gnu.org; Sat, 15 Jul 2017 09:35:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53453) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWNEe-0002P2-6E for submit@debbugs.gnu.org; Sat, 15 Jul 2017 09:35:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWNEY-0005ew-6w for submit@debbugs.gnu.org; Sat, 15 Jul 2017 09:35:46 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:48294) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dWNEX-0005es-WA for submit@debbugs.gnu.org; Sat, 15 Jul 2017 09:35:46 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44422) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dWNEW-0007v8-Vf for guix-patches@gnu.org; Sat, 15 Jul 2017 09:35:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dWNET-0005eE-Sm for guix-patches@gnu.org; Sat, 15 Jul 2017 09:35:44 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:55400) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dWNET-0005cl-Lv for guix-patches@gnu.org; Sat, 15 Jul 2017 09:35:41 -0400 Received: from dayas.3.home (77.118.188.216.wireless.dyn.drei.com [77.118.188.216]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 8965A1CA02C8; Sat, 15 Jul 2017 15:35:38 +0200 (CEST) From: Danny Milosavljevic To: guix-patches@gnu.org Subject: [PATCH 0/4] Make both EFI and non-EFI systems boot our disk images. Date: Sat, 15 Jul 2017 15:35:32 +0200 Message-Id: <20170715133532.9687-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 Tags: patch X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) This is an alternative implementation of bug# 27695 without extra Guix-side bootloader. It just extends grub-efi with a few files. I've also added all the patches needed for it to actually work into the same patchset. I've tested it again with disk-image, disk-image -t iso9660, qemu with UEFI BIOS and without UEFI BIOS. Furthermore, I tested the ISO-9660 image both as CD and as HDD (in qemu). It all worked. Danny Milosavljevic (4): gnu: grub-efi: Add mtools input. build: Allow mounting of entire disks. gnu: grub-efi: Add grub. install: Use grub-efi. gnu/build/file-systems.scm | 13 ++++++++----- gnu/packages/bootloaders.scm | 25 +++++++++++++++++++++++++ gnu/system/install.scm | 3 ++- 3 files changed, 35 insertions(+), 6 deletions(-) From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 09:37:33 2017 Received: (at 27705) by debbugs.gnu.org; 15 Jul 2017 13:37:33 +0000 Received: from localhost ([127.0.0.1]:39625 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWNGH-0002S8-1k for submit@debbugs.gnu.org; Sat, 15 Jul 2017 09:37:33 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:44504) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWNGE-0002S0-Ma for 27705@debbugs.gnu.org; Sat, 15 Jul 2017 09:37:31 -0400 Received: from dayas.3.home (77.118.188.216.wireless.dyn.drei.com [77.118.188.216]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 573C71CA02C8; Sat, 15 Jul 2017 15:37:29 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH 1/4] gnu: grub-efi: Add mtools input. Date: Sat, 15 Jul 2017 15:37:13 +0200 Message-Id: <20170715133713.9799-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170715133532.9687-1-dannym@scratchpost.org> References: <20170715133532.9687-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/bootloaders.scm: Add (gnu packages mtools). (grub-efi)[inputs]: Add mtools. [arguments]: Add phase "use-absolute-mtools-path". --- gnu/packages/bootloaders.scm | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index 9ae617528..b6833dff6 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -37,6 +37,7 @@ #:use-module (gnu packages gettext) #:use-module (gnu packages linux) #:use-module (gnu packages man) + #:use-module (gnu packages mtools) #:use-module (gnu packages ncurses) #:use-module (gnu packages perl) #:use-module (gnu packages python) @@ -149,6 +150,7 @@ menu to select one of the installed operating systems.") (synopsis "GRand Unified Boot loader (UEFI version)") (inputs `(("efibootmgr" ,efibootmgr) + ("mtools", mtools) ,@(package-inputs grub))) (arguments `(;; TODO: Tests need a UEFI firmware for qemu. There is one at @@ -166,7 +168,19 @@ menu to select one of the installed operating systems.") (("efibootmgr") (string-append (assoc-ref inputs "efibootmgr") "/sbin/efibootmgr"))) - #t))))))))) + #t)) + (add-after 'patch-stuff 'use-absolute-mtools-path + (lambda* (#:key inputs #:allow-other-keys) + (let ((mtools (assoc-ref inputs "mtools"))) + (substitute* "util/grub-mkrescue.c" + (("\"mformat\"") + (string-append "\"" mtools + "/bin/mformat\""))) + (substitute* "util/grub-mkrescue.c" + (("\"mcopy\"") + (string-append "\"" mtools + "/bin/mcopy\""))) + #t)))))))))) (define-public syslinux (let ((commit "bb41e935cc83c6242de24d2271e067d76af3585c")) From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 09:38:03 2017 Received: (at 27705) by debbugs.gnu.org; 15 Jul 2017 13:38:03 +0000 Received: from localhost ([127.0.0.1]:39629 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWNGl-0002TL-B1 for submit@debbugs.gnu.org; Sat, 15 Jul 2017 09:38:03 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:44540) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWNGk-0002T2-98 for 27705@debbugs.gnu.org; Sat, 15 Jul 2017 09:38:02 -0400 Received: from dayas.3.home (77.118.188.216.wireless.dyn.drei.com [77.118.188.216]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 54B351CA02C8; Sat, 15 Jul 2017 15:38:01 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH 2/4] build: Allow mounting of entire disks. Date: Sat, 15 Jul 2017 15:37:54 +0200 Message-Id: <20170715133756.9883-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170715133532.9687-1-dannym@scratchpost.org> References: <20170715133532.9687-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/build/file-systems.scm (disk-partitions): Also return entire drives. --- gnu/build/file-systems.scm | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index b6930497d..462ed9b7f 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -377,11 +377,14 @@ not valid header was found." (string-ref str (- (string-length str) 1))) (define (partition? name major minor) - ;; Select device names that end in a digit, like libblkid's 'probe_all' - ;; function does. Checking for "/sys/dev/block/MAJOR:MINOR/partition" - ;; doesn't work for partitions coming from mapped devices. - (and (char-set-contains? char-set:digit (last-character name)) - (> major 2))) ;ignore RAM disks and floppy disks + ;; grub-mkrescue does some funny things for EFI support which + ;; makes it a lot more difficult than one would expect to support + ;; booting an ISO-9660 image from an USB flash drive. + ;; For example there's a buggy (too small) hidden partition in it + ;; which Linux rightfully refuses to mount. + ;; In any case, partition tables are supposed to be optional so + ;; here we allow checking entire disks for file systems, too. + (> major 2)) ;ignore RAM disks and floppy disks (call-with-input-file "/proc/partitions" (lambda (port) From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 09:38:05 2017 Received: (at 27705) by debbugs.gnu.org; 15 Jul 2017 13:38:05 +0000 Received: from localhost ([127.0.0.1]:39632 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWNGn-0002Tb-HL for submit@debbugs.gnu.org; Sat, 15 Jul 2017 09:38:05 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:44550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWNGm-0002TS-85 for 27705@debbugs.gnu.org; Sat, 15 Jul 2017 09:38:04 -0400 Received: from dayas.3.home (77.118.188.216.wireless.dyn.drei.com [77.118.188.216]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 4D6A31CA02C8; Sat, 15 Jul 2017 15:38:03 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH 3/4] gnu: grub-efi: Add grub. Date: Sat, 15 Jul 2017 15:37:55 +0200 Message-Id: <20170715133756.9883-2-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170715133756.9883-1-dannym@scratchpost.org> References: <20170715133532.9687-1-dannym@scratchpost.org> <20170715133756.9883-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/bootloaders.scm (grub-efi)[native-inputs]: Add grub. [arguments]: Add phase "install-non-efi". --- gnu/packages/bootloaders.scm | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index b6833dff6..f18402e21 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -152,6 +152,9 @@ menu to select one of the installed operating systems.") `(("efibootmgr" ,efibootmgr) ("mtools", mtools) ,@(package-inputs grub))) + (native-inputs + `(("grub" ,grub) + ,@(package-native-inputs grub))) (arguments `(;; TODO: Tests need a UEFI firmware for qemu. There is one at ;; https://github.com/tianocore/edk2/tree/master/OvmfPkg . @@ -180,7 +183,15 @@ menu to select one of the installed operating systems.") (("\"mcopy\"") (string-append "\"" mtools "/bin/mcopy\""))) - #t)))))))))) + #t))) + (add-after 'install 'install-non-efi + (lambda* (#:key inputs outputs #:allow-other-keys) + ;; grub-mkresuce can use it for making a hybrid image. + (copy-recursively (string-append (assoc-ref inputs "grub") + "/lib/grub/i386-pc") + (string-append (assoc-ref outputs "out") + "/lib/grub/i386-pc")) + #t))))))))) (define-public syslinux (let ((commit "bb41e935cc83c6242de24d2271e067d76af3585c")) From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 15 09:38:06 2017 Received: (at 27705) by debbugs.gnu.org; 15 Jul 2017 13:38:07 +0000 Received: from localhost ([127.0.0.1]:39635 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWNGo-0002Tp-Oj for submit@debbugs.gnu.org; Sat, 15 Jul 2017 09:38:06 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:44558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dWNGn-0002TZ-MS for 27705@debbugs.gnu.org; Sat, 15 Jul 2017 09:38:05 -0400 Received: from dayas.3.home (77.118.188.216.wireless.dyn.drei.com [77.118.188.216]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 91C2A1CA03D2; Sat, 15 Jul 2017 15:38:04 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH 4/4] install: Use grub-efi. Date: Sat, 15 Jul 2017 15:37:56 +0200 Message-Id: <20170715133756.9883-3-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170715133756.9883-1-dannym@scratchpost.org> References: <20170715133532.9687-1-dannym@scratchpost.org> <20170715133756.9883-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/system/install.scm (installation-os): Use grub-efi. --- gnu/system/install.scm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gnu/system/install.scm b/gnu/system/install.scm index f9aa7f673..97cc0c9f6 100644 --- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -299,7 +299,8 @@ Use Alt-F2 for documentation. (host-name "gnu") (timezone "Europe/Paris") (locale "en_US.utf8") - (bootloader (grub-configuration + (bootloader (bootloader-configuration + (bootloader grub-efi-bootloader) (device "/dev/sda"))) (file-systems ;; Note: the disk image build code overrides this root file system with From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 14:00:53 2017 Received: (at 27705) by debbugs.gnu.org; 17 Jul 2017 18:00:53 +0000 Received: from localhost ([127.0.0.1]:44755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXAKD-0007z8-1z for submit@debbugs.gnu.org; Mon, 17 Jul 2017 14:00:53 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:41248) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXAKB-0007z0-VU for 27705@debbugs.gnu.org; Mon, 17 Jul 2017 14:00:52 -0400 Received: from localhost (77.118.197.241.wireless.dyn.drei.com [77.118.197.241]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 8664D1CA0026 for <27705@debbugs.gnu.org>; Mon, 17 Jul 2017 20:00:50 +0200 (CEST) Date: Mon, 17 Jul 2017 20:00:45 +0200 From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: Re: [PATCH 3/4] gnu: grub-efi: Add grub. Message-ID: <20170717200045.4c5b2c43@scratchpost.org> In-Reply-To: <20170715133756.9883-2-dannym@scratchpost.org> References: <20170715133532.9687-1-dannym@scratchpost.org> <20170715133756.9883-1-dannym@scratchpost.org> <20170715133756.9883-2-dannym@scratchpost.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > + (add-after 'install 'install-non-efi > + (lambda* (#:key inputs outputs #:allow-other-keys) > + ;; grub-mkresuce can use it for making a hybrid image. > + (copy-recursively (string-append (assoc-ref inputs "grub") > + "/lib/grub/i386-pc") > + (string-append (assoc-ref outputs "out") > + "/lib/grub/i386-pc")) > + #t))))))))) Hmm, what happens on non-x86 architectures that nonetheless use grub-efi (there are apparently such). From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 17:26:11 2017 Received: (at 27705) by debbugs.gnu.org; 17 Jul 2017 21:26:12 +0000 Received: from localhost ([127.0.0.1]:44965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXDWt-0007ya-Hk for submit@debbugs.gnu.org; Mon, 17 Jul 2017 17:26:11 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:48437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXDWr-0007yN-0Y for 27705@debbugs.gnu.org; Mon, 17 Jul 2017 17:26:09 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 5F31C20A8C; Mon, 17 Jul 2017 17:26:08 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Mon, 17 Jul 2017 17:26:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=VeUuJFll2xwZxN8wdsJMJC/Xs7nERpiLdQX6Ajfj+ cQ=; b=zd4fmuwQDTpadM3QgwGz5xQtouzRlTNiCEHlQ63b2kc3j1Qd9hTzlT5tL HyFn/ZRUieam/jNL6X3bgDc9a2LqSLxllymZF5lkHVKWa/4zvaM7UHcmUWGJz/Lh YsQnz4One6AaObDr42MkXY9SfM5ygBEm2A6Tls3MyYaY94ElFjmOhXjBX3Vcq1P4 ewsBsdLbMygkMCNbTvGOdAQdPyyeXb0eyiR4wzjYsp6q+cPOL89pc04vbforEvw+ qMDfruGagXRIT3DuY+3bArQtjIqemHBsvchd7YVXgptO+FV0Ntt2XftlXqvE3NWC XB3th2v07sTKHAzUdfzCBaSU3uGXw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=VeUuJFll2xwZxN8wds JMJC/Xs7nERpiLdQX6Ajfj+cQ=; b=F32CKzN1sg1WEux/CkU4YpniqTJxX7TY07 vXLwwla9BG0TtVxP83hoicOxTBPjFUBSE8BfIjkf4ogYHUZgOiN087fwVNplLTNr ISHEo6dFMidIUJj+twjBUSO4wYK406gq6kWCJHKj6KxkivUmwDqAXkOyqDHjIjn5 32F3p1ZW79iZ0UyBsZxPoJAO+0DB5SW15qpkMkUVIcKABUmixcgAr1NHy3oNK1Rc 5eSQ1GWoKXcEWweBtX76K+Wc8iE4E6NDW/U3SghTCgEkhAKo0GXSuhs9v9bnhCeg N4aOyP2bgxNV8v22GPopvzyVrTO6YjxLndnTiqN8T131gNQ3Qofw== X-ME-Sender: X-Sasl-enc: 8tcdAKOVFpUp6uycEusOYHEVqlqFhZAwLxLzWbSMlUlj 1500326767 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id D41767E749; Mon, 17 Jul 2017 17:26:07 -0400 (EDT) From: Marius Bakke To: Danny Milosavljevic , 27705@debbugs.gnu.org Subject: Re: [bug#27705] [PATCH 3/4] gnu: grub-efi: Add grub. In-Reply-To: <20170715133756.9883-2-dannym@scratchpost.org> References: <20170715133532.9687-1-dannym@scratchpost.org> <20170715133756.9883-1-dannym@scratchpost.org> <20170715133756.9883-2-dannym@scratchpost.org> User-Agent: Notmuch/0.24.2 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Mon, 17 Jul 2017 23:26:06 +0200 Message-ID: <87wp7669ht.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Danny Milosavljevic writes: > * gnu/packages/bootloaders.scm (grub-efi)[native-inputs]: Add grub. > [arguments]: Add phase "install-non-efi". [...] > + (native-inputs > + `(("grub" ,grub) > + ,@(package-native-inputs grub))) Since we take machine-specific code from it, I think it must be a regular input. However... > (arguments > `(;; TODO: Tests need a UEFI firmware for qemu. There is one at > ;; https://github.com/tianocore/edk2/tree/master/OvmfPkg . > @@ -180,7 +183,15 @@ menu to select one of the installed operating systems.") > (("\"mcopy\"") > (string-append "\"" mtools > "/bin/mcopy\""))) > - #t)))))))))) > + #t))) > + (add-after 'install 'install-non-efi > + (lambda* (#:key inputs outputs #:allow-other-keys) > + ;; grub-mkresuce can use it for making a hybrid image. > + (copy-recursively (string-append (assoc-ref inputs "grub") > + "/lib/grub/i386-pc") > + (string-append (assoc-ref outputs "out") > + "/lib/grub/i386-pc")) > + #t))))))))) I don't think we should do this in 'grub-efi'. Now users can not be certain whether they have EFI boot or not, since grub will happily "fall back" to i386-pc if it does not detect a UEFI system. It's a regression of sorts. However... The 'grub-hybrid' approach seems okay to me (although building grub-efi again is unnecessary :)). If it works well, maybe we could deprecate the other two GRUB packages. FWIW Gentoo has taken the 'hybrid' approach for many years (building once for each target platform and consolidating out/lib/grub). But it would be good to know whether this configuration is supported upstream. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlltK24ACgkQoqBt8qM6 VPrvGAf/T2bqsFs0thWyW2V8KftGjm2vNpGYWpwF8Ondjq9njuQCOZwdhkyU1hqZ 6u/6Z93KQxK4JcSRBOn6nIA6jTPMeHI11tH/cUL94t5ukn2HE6Lv72wDboGSd4aA bZoJeIORFoeQ6nZA/gveuEMpH0NSy/ZlWC+DDI4g9gaZgbITxXvpOmmOxYwanEkH j6wo0yna9NPtRSnLJ2MCs184jVGi9ngoIOmFQT1Ek4+x300QrQSvSLjmAESXBMMY tsWc/pUcdG2BhE7ypidXlONhOhLj3HMCXNVEr0PeUvencPytk++KhVRqvMe8/FS9 KexafU2n+4sUIQsUpdJrI7lORhfXkQ== =kxS1 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 17:42:50 2017 Received: (at 27705) by debbugs.gnu.org; 17 Jul 2017 21:42:50 +0000 Received: from localhost ([127.0.0.1]:45013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXDmz-0008M3-SY for submit@debbugs.gnu.org; Mon, 17 Jul 2017 17:42:50 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:59990) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXDmx-0008Lv-Vu for 27705@debbugs.gnu.org; Mon, 17 Jul 2017 17:42:48 -0400 Received: from localhost (77.118.197.241.wireless.dyn.drei.com [77.118.197.241]) by dd1012.kasserver.com (Postfix) with ESMTPSA id A3AA21CA0026 for <27705@debbugs.gnu.org>; Mon, 17 Jul 2017 23:42:43 +0200 (CEST) Date: Mon, 17 Jul 2017 23:42:36 +0200 From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: Re: [PATCH 4/4] install: Use grub-efi. Message-ID: <20170717234049.2f6377f1@scratchpost.org> In-Reply-To: <20170715133756.9883-3-dannym@scratchpost.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This makes the system disk-image use grub-efi all the time, also for non-ISO9660. But I've successfully tested booting this non-ISO9660 image (which uses grub-efi) as well on a non-UEFI non-Libreboot x86. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 19 16:49:07 2017 Received: (at 27705) by debbugs.gnu.org; 19 Jul 2017 20:49:07 +0000 Received: from localhost ([127.0.0.1]:48186 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXvu7-0004cP-9m for submit@debbugs.gnu.org; Wed, 19 Jul 2017 16:49:07 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:36554) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dXvu6-0004cI-2U for 27705@debbugs.gnu.org; Wed, 19 Jul 2017 16:49:06 -0400 Received: from localhost (77.118.227.94.wireless.dyn.drei.com [77.118.227.94]) by dd1012.kasserver.com (Postfix) with ESMTPSA id F03A61CA0156; Wed, 19 Jul 2017 22:49:02 +0200 (CEST) Date: Wed, 19 Jul 2017 22:48:59 +0200 From: Danny Milosavljevic To: Marius Bakke Subject: Re: [bug#27705] [PATCH 3/4] gnu: grub-efi: Add grub. Message-ID: <20170719152543.01a0b071@scratchpost.org> In-Reply-To: <87wp7669ht.fsf@fastmail.com> References: <20170715133532.9687-1-dannym@scratchpost.org> <20170715133756.9883-1-dannym@scratchpost.org> <20170715133756.9883-2-dannym@scratchpost.org> <87wp7669ht.fsf@fastmail.com> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: 27705@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Marius, On Mon, 17 Jul 2017 23:26:06 +0200 Marius Bakke wrote: >However... The 'grub-hybrid' approach seems okay to me (although >building grub-efi again is unnecessary :)). No, it's not unnecessary. When you do not use this approach (for example when you create a new package which has "grub" and "grub-efi" as input) then the resulting executables (for example grub-efi's grub-mkrescue) will not find the platform support files - because the search path for multiple platforms is being hardcoded at build time. Doesn't work: +(define-public grub-hybrid + (package + (name "grub-hybrid") + (version (package-version grub-efi)) + (inputs + `(("grub-efi" ,grub-efi) ; keep as first (preferred) entry + ("grub" ,grub))) + (build-system trivial-build-system) + (arguments + '(#:modules ((guix build union)) + #:builder (begin + (use-modules (ice-9 match) + (guix build union)) + (match %build-inputs + (((names . directories) ...) + ;; Take "lib/grub/i386-pc" from grub, the remainder + ;; from grub-efi. + (union-build (assoc-ref %outputs "out") + directories)))))) + (home-page "https://www.gnu.org/software/grub/") + (synopsis "GRand Unified Boot loader (Hybrid version)") + (description "This version of GRUB tries the @code{grub-efi} and +then the traditional @code{grub}."))) + > FWIW Gentoo has taken the 'hybrid' approach for many years (building > once for each target platform and consolidating out/lib/grub). But it > would be good to know whether this configuration is supported upstream. I'm using it for grub-mkrescue and, there, it's definitely supported in the sense of there's explicit case analysis in the source code for it and also big structures to enable this kind of using multiple platforms. For other uses I don't know. From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 15:12:33 2017 Received: (at 27705) by debbugs.gnu.org; 20 Jul 2017 19:12:33 +0000 Received: from localhost ([127.0.0.1]:50002 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYGsD-0005Pd-Cb for submit@debbugs.gnu.org; Thu, 20 Jul 2017 15:12:33 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:59996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYGsB-0005PU-IE for 27705@debbugs.gnu.org; Thu, 20 Jul 2017 15:12:31 -0400 Received: from dayas.3.home (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 036021CA0503; Thu, 20 Jul 2017 21:12:29 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH v2 0/4] Make both EFI and non-EFI systems boot our ISO9660 disk images. Date: Thu, 20 Jul 2017 21:12:19 +0200 Message-Id: <20170720191223.17189-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I've successfully tested it using: $ qemu-system-x86_64 -bios $(guix build ovmf)/share/firmware/ovmf_x64.bin -m 1G -enable-kvm -cdrom Z -serial stdio $ qemu-system-x86_64 -bios $(guix build ovmf)/share/firmware/ovmf_x64.bin -m 1G -enable-kvm -hda Z -serial stdio $ qemu-system-x86_64 -m 1G -enable-kvm -cdrom Z -serial stdio $ qemu-system-x86_64 -m 1G -enable-kvm -hda Z -serial stdio Danny Milosavljevic (4): gnu: grub-efi: Add mtools input. build: Allow mounting of entire disks. gnu: Add grub-hybrid. vm: Use grub-hybrid's grub-mkrescue. gnu/build/file-systems.scm | 13 ++++++++----- gnu/packages/bootloaders.scm | 36 +++++++++++++++++++++++++++++++++++- gnu/system/vm.scm | 2 +- 3 files changed, 44 insertions(+), 7 deletions(-) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 15:12:36 2017 Received: (at 27705) by debbugs.gnu.org; 20 Jul 2017 19:12:36 +0000 Received: from localhost ([127.0.0.1]:50007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYGsG-0005Q5-Jt for submit@debbugs.gnu.org; Thu, 20 Jul 2017 15:12:36 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:60006) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYGsD-0005Pc-Ir for 27705@debbugs.gnu.org; Thu, 20 Jul 2017 15:12:33 -0400 Received: from dayas.3.home (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id A69A71CA06D1; Thu, 20 Jul 2017 21:12:32 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH v2 1/4] gnu: grub-efi: Add mtools input. Date: Thu, 20 Jul 2017 21:12:20 +0200 Message-Id: <20170720191223.17189-2-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170720191223.17189-1-dannym@scratchpost.org> References: <20170720191223.17189-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/bootloaders.scm: Add (gnu packages mtools). (grub-efi)[inputs]: Add mtools. [arguments]: Add phase "use-absolute-mtools-path". --- gnu/packages/bootloaders.scm | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index 802e8ab8d..7a91e32d9 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -37,6 +37,7 @@ #:use-module (gnu packages gettext) #:use-module (gnu packages linux) #:use-module (gnu packages man) + #:use-module (gnu packages mtools) #:use-module (gnu packages ncurses) #:use-module (gnu packages perl) #:use-module (gnu packages python) @@ -149,6 +150,7 @@ menu to select one of the installed operating systems.") (synopsis "GRand Unified Boot loader (UEFI version)") (inputs `(("efibootmgr" ,efibootmgr) + ("mtools", mtools) ,@(package-inputs grub))) (arguments `(;; TODO: Tests need a UEFI firmware for qemu. There is one at @@ -166,7 +168,19 @@ menu to select one of the installed operating systems.") (("efibootmgr") (string-append (assoc-ref inputs "efibootmgr") "/sbin/efibootmgr"))) - #t))))))))) + #t)) + (add-after 'patch-stuff 'use-absolute-mtools-path + (lambda* (#:key inputs #:allow-other-keys) + (let ((mtools (assoc-ref inputs "mtools"))) + (substitute* "util/grub-mkrescue.c" + (("\"mformat\"") + (string-append "\"" mtools + "/bin/mformat\""))) + (substitute* "util/grub-mkrescue.c" + (("\"mcopy\"") + (string-append "\"" mtools + "/bin/mcopy\""))) + #t)))))))))) (define-public syslinux (let ((commit "bb41e935cc83c6242de24d2271e067d76af3585c")) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 15:12:37 2017 Received: (at 27705) by debbugs.gnu.org; 20 Jul 2017 19:12:37 +0000 Received: from localhost ([127.0.0.1]:50009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYGsG-0005Q8-Sk for submit@debbugs.gnu.org; Thu, 20 Jul 2017 15:12:37 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:60014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYGsF-0005Pq-2p for 27705@debbugs.gnu.org; Thu, 20 Jul 2017 15:12:35 -0400 Received: from dayas.3.home (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id DC2491CA0503; Thu, 20 Jul 2017 21:12:33 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH v2 2/4] build: Allow mounting of entire disks. Date: Thu, 20 Jul 2017 21:12:21 +0200 Message-Id: <20170720191223.17189-3-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170720191223.17189-1-dannym@scratchpost.org> References: <20170720191223.17189-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/build/file-systems.scm (disk-partitions): Also return entire drives. --- gnu/build/file-systems.scm | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index b6930497d..462ed9b7f 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -377,11 +377,14 @@ not valid header was found." (string-ref str (- (string-length str) 1))) (define (partition? name major minor) - ;; Select device names that end in a digit, like libblkid's 'probe_all' - ;; function does. Checking for "/sys/dev/block/MAJOR:MINOR/partition" - ;; doesn't work for partitions coming from mapped devices. - (and (char-set-contains? char-set:digit (last-character name)) - (> major 2))) ;ignore RAM disks and floppy disks + ;; grub-mkrescue does some funny things for EFI support which + ;; makes it a lot more difficult than one would expect to support + ;; booting an ISO-9660 image from an USB flash drive. + ;; For example there's a buggy (too small) hidden partition in it + ;; which Linux rightfully refuses to mount. + ;; In any case, partition tables are supposed to be optional so + ;; here we allow checking entire disks for file systems, too. + (> major 2)) ;ignore RAM disks and floppy disks (call-with-input-file "/proc/partitions" (lambda (port) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 15:12:39 2017 Received: (at 27705) by debbugs.gnu.org; 20 Jul 2017 19:12:39 +0000 Received: from localhost ([127.0.0.1]:50012 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYGsJ-0005QR-4Q for submit@debbugs.gnu.org; Thu, 20 Jul 2017 15:12:39 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:60022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYGsG-0005Px-2N for 27705@debbugs.gnu.org; Thu, 20 Jul 2017 15:12:36 -0400 Received: from dayas.3.home (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 2CE531CA06D1; Thu, 20 Jul 2017 21:12:35 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH v2 3/4] gnu: Add grub-hybrid. Date: Thu, 20 Jul 2017 21:12:22 +0200 Message-Id: <20170720191223.17189-4-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170720191223.17189-1-dannym@scratchpost.org> References: <20170720191223.17189-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/bootloaders.scm (grub-hybrid): New variable. --- gnu/packages/bootloaders.scm | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index 7a91e32d9..a7a4f3625 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -182,6 +182,26 @@ menu to select one of the installed operating systems.") "/bin/mcopy\""))) #t)))))))))) +(define-public grub-hybrid + (package + (inherit grub-efi) + (name "grub-hybrid") + (synopsis "GRand Unified Boot loader (hybrid version)") + (native-inputs + `(("grub" ,grub) + ,@(package-native-inputs grub-efi))) + (arguments + (substitute-keyword-arguments (package-arguments grub-efi) + ((#:phases phases) + `(modify-phases ,phases + (add-after 'install 'install-non-efi + (lambda* (#:key inputs outputs #:allow-other-keys) + (copy-recursively (string-append (assoc-ref inputs "grub") + "/lib/grub/i386-pc") + (string-append (assoc-ref outputs "out") + "/lib/grub/i386-pc")) + #t)))))))) + (define-public syslinux (let ((commit "bb41e935cc83c6242de24d2271e067d76af3585c")) (package From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 15:12:39 2017 Received: (at 27705) by debbugs.gnu.org; 20 Jul 2017 19:12:39 +0000 Received: from localhost ([127.0.0.1]:50014 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYGsJ-0005QT-BM for submit@debbugs.gnu.org; Thu, 20 Jul 2017 15:12:39 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:60034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYGsI-0005QK-3Z for 27705@debbugs.gnu.org; Thu, 20 Jul 2017 15:12:38 -0400 Received: from dayas.3.home (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 02E401CA0503; Thu, 20 Jul 2017 21:12:36 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH v2 4/4] vm: Use grub-hybrid's grub-mkrescue. Date: Thu, 20 Jul 2017 21:12:23 +0200 Message-Id: <20170720191223.17189-5-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170720191223.17189-1-dannym@scratchpost.org> References: <20170720191223.17189-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/system/vm.scm (iso9660-image): Use grub-hybrid's grub-mkrescue. --- gnu/system/vm.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index 90d29b078..f9967254c 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -217,7 +217,7 @@ INPUTS is a list of inputs (as for packages)." inputs))) (set-path-environment-variable "PATH" '("bin" "sbin") inputs) - (make-iso9660-image #$(bootloader-package bootloader) + (make-iso9660-image #$grub-hybrid #$bootcfg-drv #$os-drv "/xchg/guixsd.iso" From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 16:00:20 2017 Received: (at 27705) by debbugs.gnu.org; 20 Jul 2017 20:00:20 +0000 Received: from localhost ([127.0.0.1]:50047 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYHcS-0006bM-Ei for submit@debbugs.gnu.org; Thu, 20 Jul 2017 16:00:20 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:35762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYHcR-0006bD-17 for 27705@debbugs.gnu.org; Thu, 20 Jul 2017 16:00:19 -0400 Received: from dayas.3.home (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 3286B1CA0503; Thu, 20 Jul 2017 22:00:17 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH v3 0/4] Make both EFI and non-EFI systems boot our ISO9660 disk images. Date: Thu, 20 Jul 2017 21:44:43 +0200 Message-Id: <20170720194447.796-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I've successfully tested it using: $ qemu-system-x86_64 -bios $(guix build ovmf)/share/firmware/ovmf_x64.bin -m 1G -enable-kvm -cdrom Z -serial stdio $ qemu-system-x86_64 -bios $(guix build ovmf)/share/firmware/ovmf_x64.bin -m 1G -enable-kvm -hda Z -serial stdio $ qemu-system-x86_64 -m 1G -enable-kvm -cdrom Z -serial stdio $ qemu-system-x86_64 -m 1G -enable-kvm -hda Z -serial stdio Danny Milosavljevic (4): gnu: grub-efi: Add mtools input. build: Allow mounting of entire disks. gnu: Add grub-hybrid. vm: Use grub-hybrid's grub-mkrescue. gnu/build/file-systems.scm | 13 ++++++++----- gnu/packages/bootloaders.scm | 40 +++++++++++++++++++++++++++++++++++++++- gnu/system/vm.scm | 2 +- 3 files changed, 48 insertions(+), 7 deletions(-) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 16:00:24 2017 Received: (at 27705) by debbugs.gnu.org; 20 Jul 2017 20:00:24 +0000 Received: from localhost ([127.0.0.1]:50052 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYHcW-0006bo-L9 for submit@debbugs.gnu.org; Thu, 20 Jul 2017 16:00:24 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:35772) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYHcS-0006bK-FZ for 27705@debbugs.gnu.org; Thu, 20 Jul 2017 16:00:20 -0400 Received: from dayas.3.home (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 81A171CA06C4; Thu, 20 Jul 2017 22:00:19 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH v3 1/4] gnu: grub-efi: Add mtools input. Date: Thu, 20 Jul 2017 21:44:44 +0200 Message-Id: <20170720194447.796-2-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170720194447.796-1-dannym@scratchpost.org> References: <20170720194447.796-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/bootloaders.scm: Add (gnu packages mtools). (grub-efi)[inputs]: Add mtools. [arguments]: Add phase "use-absolute-mtools-path". --- gnu/packages/bootloaders.scm | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index 802e8ab8d..7a91e32d9 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -37,6 +37,7 @@ #:use-module (gnu packages gettext) #:use-module (gnu packages linux) #:use-module (gnu packages man) + #:use-module (gnu packages mtools) #:use-module (gnu packages ncurses) #:use-module (gnu packages perl) #:use-module (gnu packages python) @@ -149,6 +150,7 @@ menu to select one of the installed operating systems.") (synopsis "GRand Unified Boot loader (UEFI version)") (inputs `(("efibootmgr" ,efibootmgr) + ("mtools", mtools) ,@(package-inputs grub))) (arguments `(;; TODO: Tests need a UEFI firmware for qemu. There is one at @@ -166,7 +168,19 @@ menu to select one of the installed operating systems.") (("efibootmgr") (string-append (assoc-ref inputs "efibootmgr") "/sbin/efibootmgr"))) - #t))))))))) + #t)) + (add-after 'patch-stuff 'use-absolute-mtools-path + (lambda* (#:key inputs #:allow-other-keys) + (let ((mtools (assoc-ref inputs "mtools"))) + (substitute* "util/grub-mkrescue.c" + (("\"mformat\"") + (string-append "\"" mtools + "/bin/mformat\""))) + (substitute* "util/grub-mkrescue.c" + (("\"mcopy\"") + (string-append "\"" mtools + "/bin/mcopy\""))) + #t)))))))))) (define-public syslinux (let ((commit "bb41e935cc83c6242de24d2271e067d76af3585c")) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 16:00:25 2017 Received: (at 27705) by debbugs.gnu.org; 20 Jul 2017 20:00:25 +0000 Received: from localhost ([127.0.0.1]:50055 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYHcW-0006br-SS for submit@debbugs.gnu.org; Thu, 20 Jul 2017 16:00:25 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:35788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYHcT-0006bZ-V0 for 27705@debbugs.gnu.org; Thu, 20 Jul 2017 16:00:22 -0400 Received: from dayas.3.home (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 02A1C1CA06C4; Thu, 20 Jul 2017 22:00:20 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH v3 2/4] build: Allow mounting of entire disks. Date: Thu, 20 Jul 2017 21:44:45 +0200 Message-Id: <20170720194447.796-3-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170720194447.796-1-dannym@scratchpost.org> References: <20170720194447.796-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/build/file-systems.scm (disk-partitions): Also return entire drives. --- gnu/build/file-systems.scm | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index b6930497d..462ed9b7f 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -377,11 +377,14 @@ not valid header was found." (string-ref str (- (string-length str) 1))) (define (partition? name major minor) - ;; Select device names that end in a digit, like libblkid's 'probe_all' - ;; function does. Checking for "/sys/dev/block/MAJOR:MINOR/partition" - ;; doesn't work for partitions coming from mapped devices. - (and (char-set-contains? char-set:digit (last-character name)) - (> major 2))) ;ignore RAM disks and floppy disks + ;; grub-mkrescue does some funny things for EFI support which + ;; makes it a lot more difficult than one would expect to support + ;; booting an ISO-9660 image from an USB flash drive. + ;; For example there's a buggy (too small) hidden partition in it + ;; which Linux rightfully refuses to mount. + ;; In any case, partition tables are supposed to be optional so + ;; here we allow checking entire disks for file systems, too. + (> major 2)) ;ignore RAM disks and floppy disks (call-with-input-file "/proc/partitions" (lambda (port) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 16:00:25 2017 Received: (at 27705) by debbugs.gnu.org; 20 Jul 2017 20:00:25 +0000 Received: from localhost ([127.0.0.1]:50057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYHcX-0006c4-3i for submit@debbugs.gnu.org; Thu, 20 Jul 2017 16:00:25 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:35812) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYHcV-0006bg-Ar for 27705@debbugs.gnu.org; Thu, 20 Jul 2017 16:00:23 -0400 Received: from dayas.3.home (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 471DE1CA0503; Thu, 20 Jul 2017 22:00:22 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH v3 3/4] gnu: Add grub-hybrid. Date: Thu, 20 Jul 2017 21:44:46 +0200 Message-Id: <20170720194447.796-4-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170720194447.796-1-dannym@scratchpost.org> References: <20170720194447.796-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/bootloaders.scm (grub-hybrid): New variable. --- gnu/packages/bootloaders.scm | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index 7a91e32d9..9d18e7d9a 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -182,6 +182,30 @@ menu to select one of the installed operating systems.") "/bin/mcopy\""))) #t)))))))))) +(define-public grub-hybrid + (package + (inherit grub-efi) + (name "grub-hybrid") + (synopsis "GRand Unified Boot loader (hybrid version)") + (inputs + `(("grub" ,grub) + ,@(package-inputs grub-efi))) + (arguments + (substitute-keyword-arguments (package-arguments grub-efi) + ((#:phases phases) + `(modify-phases ,phases + (add-after 'install 'install-non-efi + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((input-dir (string-append (assoc-ref inputs "grub") "/lib/grub")) + (output-dir (string-append (assoc-ref outputs "out") "/lib/grub"))) + (for-each + (lambda (basename) + (if (not (string-prefix? "." basename)) + (symlink (string-append input-dir "/" basename) + (string-append output-dir "/" basename)))) + ((@@ (ice-9 ftw) scandir) input-dir)) + #t))))))))) + (define-public syslinux (let ((commit "bb41e935cc83c6242de24d2271e067d76af3585c")) (package From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 16:00:30 2017 Received: (at 27705) by debbugs.gnu.org; 20 Jul 2017 20:00:30 +0000 Received: from localhost ([127.0.0.1]:50059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYHcc-0006cM-BU for submit@debbugs.gnu.org; Thu, 20 Jul 2017 16:00:30 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:35822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYHcW-0006bn-LY for 27705@debbugs.gnu.org; Thu, 20 Jul 2017 16:00:24 -0400 Received: from dayas.3.home (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 7CD2E1CA06C4; Thu, 20 Jul 2017 22:00:23 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH v3 4/4] vm: Use grub-hybrid's grub-mkrescue. Date: Thu, 20 Jul 2017 21:44:47 +0200 Message-Id: <20170720194447.796-5-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170720194447.796-1-dannym@scratchpost.org> References: <20170720194447.796-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/system/vm.scm (iso9660-image): Use grub-hybrid's grub-mkrescue. --- gnu/system/vm.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index 90d29b078..f9967254c 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -217,7 +217,7 @@ INPUTS is a list of inputs (as for packages)." inputs))) (set-path-environment-variable "PATH" '("bin" "sbin") inputs) - (make-iso9660-image #$(bootloader-package bootloader) + (make-iso9660-image #$grub-hybrid #$bootcfg-drv #$os-drv "/xchg/guixsd.iso" From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 19:08:06 2017 Received: (at 27705) by debbugs.gnu.org; 20 Jul 2017 23:08:06 +0000 Received: from localhost ([127.0.0.1]:50132 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYKYA-0002gC-40 for submit@debbugs.gnu.org; Thu, 20 Jul 2017 19:08:06 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:50544) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYKY7-0002fj-C9 for 27705@debbugs.gnu.org; Thu, 20 Jul 2017 19:08:03 -0400 Received: from dayas.3.home (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 55B861CA06D1; Fri, 21 Jul 2017 01:07:59 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH v4 1/4] gnu: grub-efi: Add mtools input. Date: Fri, 21 Jul 2017 01:06:45 +0200 Message-Id: <20170720230648.8205-2-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170720230648.8205-1-dannym@scratchpost.org> References: <20170720230648.8205-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/bootloaders.scm: Add (gnu packages mtools). (grub-efi)[inputs]: Add mtools. [arguments]: Add phase "use-absolute-mtools-path". --- gnu/packages/bootloaders.scm | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index 802e8ab8d..7a91e32d9 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -37,6 +37,7 @@ #:use-module (gnu packages gettext) #:use-module (gnu packages linux) #:use-module (gnu packages man) + #:use-module (gnu packages mtools) #:use-module (gnu packages ncurses) #:use-module (gnu packages perl) #:use-module (gnu packages python) @@ -149,6 +150,7 @@ menu to select one of the installed operating systems.") (synopsis "GRand Unified Boot loader (UEFI version)") (inputs `(("efibootmgr" ,efibootmgr) + ("mtools", mtools) ,@(package-inputs grub))) (arguments `(;; TODO: Tests need a UEFI firmware for qemu. There is one at @@ -166,7 +168,19 @@ menu to select one of the installed operating systems.") (("efibootmgr") (string-append (assoc-ref inputs "efibootmgr") "/sbin/efibootmgr"))) - #t))))))))) + #t)) + (add-after 'patch-stuff 'use-absolute-mtools-path + (lambda* (#:key inputs #:allow-other-keys) + (let ((mtools (assoc-ref inputs "mtools"))) + (substitute* "util/grub-mkrescue.c" + (("\"mformat\"") + (string-append "\"" mtools + "/bin/mformat\""))) + (substitute* "util/grub-mkrescue.c" + (("\"mcopy\"") + (string-append "\"" mtools + "/bin/mcopy\""))) + #t)))))))))) (define-public syslinux (let ((commit "bb41e935cc83c6242de24d2271e067d76af3585c")) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 19:08:06 2017 Received: (at 27705) by debbugs.gnu.org; 20 Jul 2017 23:08:06 +0000 Received: from localhost ([127.0.0.1]:50134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYKYA-0002gJ-BZ for submit@debbugs.gnu.org; Thu, 20 Jul 2017 19:08:06 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:50548) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYKY7-0002fl-C9 for 27705@debbugs.gnu.org; Thu, 20 Jul 2017 19:08:03 -0400 Received: from dayas.3.home (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 0EA871CA10C5; Fri, 21 Jul 2017 01:08:01 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH v4 3/4] gnu: Add grub-hybrid. Date: Fri, 21 Jul 2017 01:06:47 +0200 Message-Id: <20170720230648.8205-4-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170720230648.8205-1-dannym@scratchpost.org> References: <20170720230648.8205-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/packages/bootloaders.scm (grub-hybrid): New variable. --- gnu/packages/bootloaders.scm | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/gnu/packages/bootloaders.scm b/gnu/packages/bootloaders.scm index 7a91e32d9..9d18e7d9a 100644 --- a/gnu/packages/bootloaders.scm +++ b/gnu/packages/bootloaders.scm @@ -182,6 +182,30 @@ menu to select one of the installed operating systems.") "/bin/mcopy\""))) #t)))))))))) +(define-public grub-hybrid + (package + (inherit grub-efi) + (name "grub-hybrid") + (synopsis "GRand Unified Boot loader (hybrid version)") + (inputs + `(("grub" ,grub) + ,@(package-inputs grub-efi))) + (arguments + (substitute-keyword-arguments (package-arguments grub-efi) + ((#:phases phases) + `(modify-phases ,phases + (add-after 'install 'install-non-efi + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((input-dir (string-append (assoc-ref inputs "grub") "/lib/grub")) + (output-dir (string-append (assoc-ref outputs "out") "/lib/grub"))) + (for-each + (lambda (basename) + (if (not (string-prefix? "." basename)) + (symlink (string-append input-dir "/" basename) + (string-append output-dir "/" basename)))) + ((@@ (ice-9 ftw) scandir) input-dir)) + #t))))))))) + (define-public syslinux (let ((commit "bb41e935cc83c6242de24d2271e067d76af3585c")) (package From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 19:08:06 2017 Received: (at 27705) by debbugs.gnu.org; 20 Jul 2017 23:08:07 +0000 Received: from localhost ([127.0.0.1]:50136 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYKYA-0002gQ-Jw for submit@debbugs.gnu.org; Thu, 20 Jul 2017 19:08:06 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:50542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYKY7-0002fh-C7 for 27705@debbugs.gnu.org; Thu, 20 Jul 2017 19:08:04 -0400 Received: from dayas.3.home (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id AFE1F1CA104F; Fri, 21 Jul 2017 01:08:00 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH v4 2/4] build: Allow mounting of entire disks. Date: Fri, 21 Jul 2017 01:06:46 +0200 Message-Id: <20170720230648.8205-3-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170720230648.8205-1-dannym@scratchpost.org> References: <20170720230648.8205-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/build/file-systems.scm (disk-partitions): Also return entire drives. --- gnu/build/file-systems.scm | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/gnu/build/file-systems.scm b/gnu/build/file-systems.scm index b6930497d..462ed9b7f 100644 --- a/gnu/build/file-systems.scm +++ b/gnu/build/file-systems.scm @@ -377,11 +377,14 @@ not valid header was found." (string-ref str (- (string-length str) 1))) (define (partition? name major minor) - ;; Select device names that end in a digit, like libblkid's 'probe_all' - ;; function does. Checking for "/sys/dev/block/MAJOR:MINOR/partition" - ;; doesn't work for partitions coming from mapped devices. - (and (char-set-contains? char-set:digit (last-character name)) - (> major 2))) ;ignore RAM disks and floppy disks + ;; grub-mkrescue does some funny things for EFI support which + ;; makes it a lot more difficult than one would expect to support + ;; booting an ISO-9660 image from an USB flash drive. + ;; For example there's a buggy (too small) hidden partition in it + ;; which Linux rightfully refuses to mount. + ;; In any case, partition tables are supposed to be optional so + ;; here we allow checking entire disks for file systems, too. + (> major 2)) ;ignore RAM disks and floppy disks (call-with-input-file "/proc/partitions" (lambda (port) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 19:08:07 2017 Received: (at 27705) by debbugs.gnu.org; 20 Jul 2017 23:08:07 +0000 Received: from localhost ([127.0.0.1]:50138 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYKYA-0002gX-RA for submit@debbugs.gnu.org; Thu, 20 Jul 2017 19:08:06 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:50546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYKY7-0002fi-C7 for 27705@debbugs.gnu.org; Thu, 20 Jul 2017 19:08:04 -0400 Received: from dayas.3.home (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id CF91E1CA0FDF; Fri, 21 Jul 2017 01:07:57 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH v4 0/4] Make both EFI and non-EFI systems boot our ISO9660 disk images. Date: Fri, 21 Jul 2017 01:06:44 +0200 Message-Id: <20170720230648.8205-1-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) I've successfully tested it using: $ qemu-system-x86_64 -bios $(guix build ovmf)/share/firmware/ovmf_x64.bin -m 1G -enable-kvm -cdrom Z -serial stdio $ qemu-system-x86_64 -bios $(guix build ovmf)/share/firmware/ovmf_x64.bin -m 1G -enable-kvm -hda Z -serial stdio $ qemu-system-x86_64 -m 1G -enable-kvm -cdrom Z -serial stdio $ qemu-system-x86_64 -m 1G -enable-kvm -hda Z -serial stdio Danny Milosavljevic (4): gnu: grub-efi: Add mtools input. build: Allow mounting of entire disks. gnu: Add grub-hybrid. vm: Use grub-hybrid's grub-mkrescue. gnu/bootloader/grub.scm | 6 ++++++ gnu/build/file-systems.scm | 13 ++++++++----- gnu/packages/bootloaders.scm | 40 +++++++++++++++++++++++++++++++++++++++- gnu/system/vm.scm | 7 +++++++ 4 files changed, 60 insertions(+), 6 deletions(-) From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 20 19:08:11 2017 Received: (at 27705) by debbugs.gnu.org; 20 Jul 2017 23:08:11 +0000 Received: from localhost ([127.0.0.1]:50140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYKYF-0002gq-2F for submit@debbugs.gnu.org; Thu, 20 Jul 2017 19:08:11 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:50556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYKY9-0002gA-SN for 27705@debbugs.gnu.org; Thu, 20 Jul 2017 19:08:06 -0400 Received: from dayas.3.home (178.113.137.192.wireless.dyn.drei.com [178.113.137.192]) by dd1012.kasserver.com (Postfix) with ESMTPSA id CB2141CA11BC; Fri, 21 Jul 2017 01:08:03 +0200 (CEST) From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: [PATCH v4 4/4] vm: Use grub-hybrid's grub-mkrescue. Date: Fri, 21 Jul 2017 01:06:48 +0200 Message-Id: <20170720230648.8205-5-dannym@scratchpost.org> X-Mailer: git-send-email 2.13.2 In-Reply-To: <20170720230648.8205-1-dannym@scratchpost.org> References: <20170720230648.8205-1-dannym@scratchpost.org> Tags: patch X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 Cc: Danny Milosavljevic X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) * gnu/system/vm.scm (system-disk-image): Use grub-hybrid's grub-mkrescue. * gnu/bootlader/grub.scm (grub-mkrescue-bootloader): New variable. --- gnu/bootloader/grub.scm | 6 ++++++ gnu/system/vm.scm | 7 +++++++ 2 files changed, 13 insertions(+) diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm index 880491c98..e2d31c4ac 100644 --- a/gnu/bootloader/grub.scm +++ b/gnu/bootloader/grub.scm @@ -55,6 +55,7 @@ grub-bootloader grub-efi-bootloader + grub-mkrescue-bootloader grub-configuration)) @@ -413,6 +414,11 @@ submenu \"GNU system, old configurations...\" {~%") (name 'grub-efi) (package grub-efi))) +(define* grub-mkrescue-bootloader + (bootloader + (inherit grub-efi-bootloader) + (package grub-hybrid))) + ;;; ;;; Compatibility macros. diff --git a/gnu/system/vm.scm b/gnu/system/vm.scm index 90d29b078..4494af003 100644 --- a/gnu/system/vm.scm +++ b/gnu/system/vm.scm @@ -49,6 +49,7 @@ #:use-module (gnu packages admin) #:use-module (gnu bootloader) + #:use-module ((gnu bootloader grub) #:select (grub-mkrescue-bootloader)) #:use-module (gnu system shadow) #:use-module (gnu system pam) #:use-module (gnu system linux-initrd) @@ -369,6 +370,12 @@ to USB sticks meant to be read-only." #:volatile-root? #t rest))) + (bootloader (if (string=? "iso9660" file-system-type) + (bootloader-configuration + (inherit (operating-system-bootloader os)) + (bootloader grub-mkrescue-bootloader)) + (operating-system-bootloader os))) + ;; Force our own root file system. (file-systems (cons (file-system (mount-point "/") From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 29 13:59:34 2017 Received: (at 27705) by debbugs.gnu.org; 29 Jul 2017 17:59:34 +0000 Received: from localhost ([127.0.0.1]:33332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbW1W-0006vD-8D for submit@debbugs.gnu.org; Sat, 29 Jul 2017 13:59:34 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:48490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbW1V-0006v6-AD for 27705@debbugs.gnu.org; Sat, 29 Jul 2017 13:59:33 -0400 Received: from localhost (77.118.209.129.wireless.dyn.drei.com [77.118.209.129]) by dd1012.kasserver.com (Postfix) with ESMTPSA id D5F4B1CA02C8 for <27705@debbugs.gnu.org>; Sat, 29 Jul 2017 19:59:31 +0200 (CEST) Date: Sat, 29 Jul 2017 19:59:27 +0200 From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: Re: [PATCH v4 1/4] gnu: grub-efi: Add mtools input. Message-ID: <20170729195927.4877b69c@scratchpost.org> In-Reply-To: <20170720230648.8205-2-dannym@scratchpost.org> References: <20170720230648.8205-1-dannym@scratchpost.org> <20170720230648.8205-2-dannym@scratchpost.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Applied only this patch to master as 444f9dccc24138acf833f6fea17a8b47a776ba2b. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 03 10:36:58 2017 Received: (at 27705) by debbugs.gnu.org; 3 Aug 2017 14:36:59 +0000 Received: from localhost ([127.0.0.1]:40131 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddHFC-0000lv-PV for submit@debbugs.gnu.org; Thu, 03 Aug 2017 10:36:58 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:54398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddHFB-0000lm-4w for 27705@debbugs.gnu.org; Thu, 03 Aug 2017 10:36:57 -0400 Received: from localhost (77.118.188.11.wireless.dyn.drei.com [77.118.188.11]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 76DA21CA041A for <27705@debbugs.gnu.org>; Thu, 3 Aug 2017 16:36:53 +0200 (CEST) Date: Thu, 3 Aug 2017 16:36:49 +0200 From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: Re: [PATCH v4 3/4] gnu: Add grub-hybrid. Message-ID: <20170803163649.688067cb@scratchpost.org> In-Reply-To: <20170720230648.8205-4-dannym@scratchpost.org> References: <20170720230648.8205-1-dannym@scratchpost.org> <20170720230648.8205-4-dannym@scratchpost.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Pushed this patch (with minimal changes) to master as dd4b7476ec2c8c1d790f1366173a15bd6042eeee. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 03 12:12:53 2017 Received: (at 27705) by debbugs.gnu.org; 3 Aug 2017 16:12:53 +0000 Received: from localhost ([127.0.0.1]:40194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddIk1-0002xR-5Q for submit@debbugs.gnu.org; Thu, 03 Aug 2017 12:12:53 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:34010) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddIjz-0002xJ-Cz for 27705@debbugs.gnu.org; Thu, 03 Aug 2017 12:12:52 -0400 Received: from localhost (77.118.188.11.wireless.dyn.drei.com [77.118.188.11]) by dd1012.kasserver.com (Postfix) with ESMTPSA id AC2391CA041A for <27705@debbugs.gnu.org>; Thu, 3 Aug 2017 18:12:48 +0200 (CEST) Date: Thu, 3 Aug 2017 18:12:46 +0200 From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: Re: [PATCH v4 4/4] vm: Use grub-hybrid's grub-mkrescue. Message-ID: <20170803181246.7b7057ec@scratchpost.org> In-Reply-To: <20170720230648.8205-5-dannym@scratchpost.org> References: <20170720230648.8205-1-dannym@scratchpost.org> <20170720230648.8205-5-dannym@scratchpost.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Pushed this patch to master as ba4de3b3ef07a95f8a610cdc5354de554b7a4a6b. This means that these work now: $ cp `guix system disk-image -t iso9660 gnu/system/install.scm` Z $ qemu-system-x86_64 -bios $(guix build ovmf)/share/firmware/ovmf_x64.bin -m 1G -enable-kvm -cdrom Z -serial stdio $ qemu-system-x86_64 -m 1G -enable-kvm -cdrom Z -serial stdio And these don't work (as in: guest kernel crashes because it can't find the root): $ cp `guix system disk-image -t iso9660 gnu/system/install.scm` Z $ chmod +w Z $ qemu-system-x86_64 -bios $(guix build ovmf)/share/firmware/ovmf_x64.bin -m 1G -enable-kvm -hda Z -serial stdio $ qemu-system-x86_64 -m 1G -enable-kvm -hda Z -serial stdio That's because "[PATCH v4 2/4] build: Allow mounting of entire disks" is not applied. What do we do about it? Should we apply it, too? From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 13:34:21 2017 Received: (at 27705) by debbugs.gnu.org; 5 Aug 2017 17:34:22 +0000 Received: from localhost ([127.0.0.1]:43630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1de2xx-0002ek-Ny for submit@debbugs.gnu.org; Sat, 05 Aug 2017 13:34:21 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:47390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1de2xw-0002ec-Gw for 27705@debbugs.gnu.org; Sat, 05 Aug 2017 13:34:21 -0400 Received: from localhost (178.113.252.190.wireless.dyn.drei.com [178.113.252.190]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 0654E1CA0026 for <27705@debbugs.gnu.org>; Sat, 5 Aug 2017 19:34:18 +0200 (CEST) Date: Sat, 5 Aug 2017 19:34:16 +0200 From: Danny Milosavljevic To: 27705@debbugs.gnu.org Subject: Re: [PATCH v4 2/4] build: Allow mounting of entire disks. Message-ID: <20170805193416.26921205@scratchpost.org> In-Reply-To: <20170720230648.8205-3-dannym@scratchpost.org> References: <20170720230648.8205-1-dannym@scratchpost.org> <20170720230648.8205-3-dannym@scratchpost.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27705 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Okay I'm risking it. A big reason for magic numbers in all the common superblock types and also in the partition table is that this usecase of optional partition tables works. I've also excessively tested it. So I think the risk of breakage is low enough and I've pushed a variant of this patch to master as 9833bcfc08ef009b9e8b4398baa481ef65c80ad7. I'll be obsessively checking the Guix mailing lists through the next few days - and if it causes problems I'll revert. Should I be too slow, feel free to revert 9833bcfc08ef009b9e8b4398baa481ef65c80ad7 (only; the other patches of the patchset are independent and aren't a cause of concern). Since the modified code is part of the system generation one can select the older generation in the Grub boot menu should the new one not work. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 13:43:52 2017 Received: (at control) by debbugs.gnu.org; 5 Aug 2017 17:43:52 +0000 Received: from localhost ([127.0.0.1]:43638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1de379-0002ri-U0 for submit@debbugs.gnu.org; Sat, 05 Aug 2017 13:43:52 -0400 Received: from dd1012.kasserver.com ([85.13.128.8]:48052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1de378-0002rb-M6 for control@debbugs.gnu.org; Sat, 05 Aug 2017 13:43:50 -0400 Received: from localhost (178.113.252.190.wireless.dyn.drei.com [178.113.252.190]) by dd1012.kasserver.com (Postfix) with ESMTPSA id 93A001CA0026 for ; Sat, 5 Aug 2017 19:43:49 +0200 (CEST) Date: Sat, 5 Aug 2017 19:43:47 +0200 From: Danny Milosavljevic To: Message-ID: <20170805194347.2974c79b@scratchpost.org> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 27705 [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [85.13.128.8 listed in list.dnswl.org] 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 27705 [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [85.13.128.8 listed in list.dnswl.org] 0.0 TVD_SPACE_RATIO No description available. 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject close 27705 From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 17:26:05 2017 Received: (at 27705) by debbugs.gnu.org; 5 Aug 2017 21:26:05 +0000 Received: from localhost ([127.0.0.1]:43797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1de6aD-0005Da-C7 for submit@debbugs.gnu.org; Sat, 05 Aug 2017 17:26:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1de6aC-0005D5-6n for 27705@debbugs.gnu.org; Sat, 05 Aug 2017 17:26:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1de6a1-0004g5-U9 for 27705@debbugs.gnu.org; Sat, 05 Aug 2017 17:25:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57559) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1de6a1-0004fx-Qt; Sat, 05 Aug 2017 17:25:53 -0400 Received: from reverse-83.fdn.fr ([80.67.176.83]:50846 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1de6a1-0002cl-9s; Sat, 05 Aug 2017 17:25:53 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Danny Milosavljevic Subject: Re: [bug#27705] [PATCH v4 2/4] build: Allow mounting of entire disks. References: <20170720230648.8205-1-dannym@scratchpost.org> <20170720230648.8205-3-dannym@scratchpost.org> <20170805193416.26921205@scratchpost.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 18 Thermidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Sat, 05 Aug 2017 23:25:51 +0200 In-Reply-To: <20170805193416.26921205@scratchpost.org> (Danny Milosavljevic's message of "Sat, 5 Aug 2017 19:34:16 +0200") Message-ID: <87o9rtk8ps.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27705 Cc: 27705@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Danny Milosavljevic skribis: > Okay I'm risking it. A big reason for magic numbers in all the common > superblock types and also in the partition table is that this usecase > of optional partition tables works. > > I've also excessively tested it. Thanks for moving forward on this front! Ludo=E2=80=99. From unknown Fri Aug 15 03:56:13 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 03 Sep 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator