GNU bug report logs - #27672
oksh

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27672 in the body.
You can then email your comments to 27672 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: guix-patches <at> gnu.org
Subject: oksh
Date: Wed, 12 Jul 2017 19:35:00 +0000

[Message part 1 (text/plain, inline)]

This adds oksh.

The test phase is a FIXME
and the make install has some nonfatal error I did not bother
to fix because the resulting application works.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[0001-gnu-Add-oksh.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 27672 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: ng0 <ng0 <at> infotropique.org>
Cc: 27672 <at> debbugs.gnu.org
Subject: Re: [bug#27672] oksh
Date: Thu, 13 Jul 2017 01:46:02 +0530

ng0 writes:

> +    (arguments
> +     `(; FIXME:
> +       ;; starting phase `check'
> +       ;;./tests/th-sh ./tests/th -s ./tests -p ./ksh -C pdksh,sh,ksh,posix,posix-upu
> +       ;; make: ./tests/th-sh: Command not found
> +       #:tests? #f))

Actually, the test files are not present in the tarball. Look at line 62
of the Makefile listing all the test files. None of those files
exist. Also, look at the check target on line 99.

LGTM, otherwise!

Message #11 received at 27672 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 27672 <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#27672] oksh
Date: Wed, 12 Jul 2017 20:54:32 +0000

[Message part 1 (text/plain, inline)]

Arun Isaac transcribed 0.5K bytes:
> 
> ng0 writes:
> 
> > +    (arguments
> > +     `(; FIXME:
> > +       ;; starting phase `check'
> > +       ;;./tests/th-sh ./tests/th -s ./tests -p ./ksh -C pdksh,sh,ksh,posix,posix-upu
> > +       ;; make: ./tests/th-sh: Command not found
> > +       #:tests? #f))
> 
> Actually, the test files are not present in the tarball. Look at line 62
> of the Makefile listing all the test files. None of those files
> exist. Also, look at the check target on line 99.

I will take another look and maybe patch it out and/or contact upstream.
Thanks!

> LGTM, otherwise!
> 

-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 27672 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Arun Isaac <arunisaac <at> systemreboot.net>, 27672 <at> debbugs.gnu.org
Subject: Re: [bug#27672] oksh
Date: Sat, 22 Jul 2017 09:31:03 +0000

[Message part 1 (text/plain, inline)]

Updated patch appended.

I'll contact upstream and ask about the missing test files.
Thanks!
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[0001-gnu-Add-oksh.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 27672-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: 27672-done <at> debbugs.gnu.org
Subject: Re: [bug#27672] oksh
Date: Sat, 22 Jul 2017 20:16:11 -0400

[Message part 1 (text/plain, inline)]

On Sat, Jul 22, 2017 at 09:31:03AM +0000, ng0 wrote:
> Updated patch appended.
> 
> I'll contact upstream and ask about the missing test files.
> Thanks!
> -- 
> ng0
> GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> GnuPG: https://n0is.noblogs.org/my-keys
> https://www.infotropique.org https://krosos.org

> From 5d8035dddb5037b0fe5f856f14f7b5190f14b3c2 Mon Sep 17 00:00:00 2001
> From: ng0 <ng0 <at> infotropique.org>
> Date: Wed, 12 Jul 2017 19:32:51 +0000
> Subject: [PATCH] gnu: Add oksh.
> 
> * gnu/packages/shells.scm (oksh): New variable.

Thanks! Pushed as 7e3c977da6ea15acfad361200cdde12636406b61.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.