GNU bug report logs - #27644
26.0.50; [PATCH] Add binding for vc-region-history

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27644 in the body.
You can then email your comments to 27644 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Mon, 10 Jul 2017 18:43:58 +0000

[Message part 1 (text/plain, inline)]

Hello,

I have been using "C-x v H" binding for vc-region-history for a year and it
has been super-convenient for me for the instances of "I wonder who made
changes to this/these line(s) and when..".

Also the "H" binding is still unused in vc-prefix-map and a good mnemonic
for "history" too.

The attached patch binds vc-region-history to "H" in vc-prefix-map.

Thanks.
-- 

Kaushal Modi

[Message part 2 (text/html, inline)]

[0001-Bind-vc-region-history.patch (application/octet-stream, attachment)]

Message #8 received at 27644 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, 27644 <at> debbugs.gnu.org
Subject: Re: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Wed, 20 Sep 2017 14:03:30 +0000

[Message part 1 (text/plain, inline)]

Any issues getting this minor patch into 26.1?

On Mon, Jul 10, 2017 at 2:43 PM Kaushal Modi <kaushal.modi <at> gmail.com> wrote:

> Hello,
>
> I have been using "C-x v H" binding for vc-region-history for a year and
> it has been super-convenient for me for the instances of "I wonder who made
> changes to this/these line(s) and when..".
>
> Also the "H" binding is still unused in vc-prefix-map and a good mnemonic
> for "history" too.
>
> The attached patch binds vc-region-history to "H" in vc-prefix-map.
>
> Thanks.
> --
>
> Kaushal Modi
>
-- 

Kaushal Modi

[Message part 2 (text/html, inline)]

Message #11 received at 27644 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Kaushal Modi <kaushal.modi <at> gmail.com>
Cc: 27644 <at> debbugs.gnu.org
Subject: Re: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Wed, 20 Sep 2017 17:15:50 +0300

> From: Kaushal Modi <kaushal.modi <at> gmail.com>
> Date: Wed, 20 Sep 2017 14:03:30 +0000
> 
> Any issues getting this minor patch into 26.1?

It hasn't been reviewed yet.  I'd like to hear Dmitry's opinion on the
change, before we consider whether it's important enough to have in
Emacs 26.

Thanks.

Message #14 received at 27644 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 27644 <at> debbugs.gnu.org
Subject: Re: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Thu, 21 Sep 2017 03:01:17 +0000

[Message part 1 (text/plain, inline)]

Copying Dmitry.

I use vc-region-history so frequently that not having a C-x v .. binding
for it feels like a mistake. And luckily C-x v H is not taken by anything
else. This patch fixes that.

On Wed, Sep 20, 2017 at 11:10 AM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > From: Kaushal Modi <kaushal.modi <at> gmail.com>
> > Date: Wed, 20 Sep 2017 14:03:30 +0000
> >
> > Any issues getting this minor patch into 26.1?
>
> It hasn't been reviewed yet.  I'd like to hear Dmitry's opinion on the
> change, before we consider whether it's important enough to have in
> Emacs 26.
>
-- 

Kaushal Modi

[Message part 2 (text/html, inline)]

Message #17 received at 27644 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>, Kaushal Modi <kaushal.modi <at> gmail.com>
Cc: 27644 <at> debbugs.gnu.org
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Thu, 21 Sep 2017 17:22:13 +0300

On 9/20/17 5:15 PM, Eli Zaretskii wrote:
>> From: Kaushal Modi <kaushal.modi <at> gmail.com>
>> Date: Wed, 20 Sep 2017 14:03:30 +0000
>>
>> Any issues getting this minor patch into 26.1?
> 
> It hasn't been reviewed yet.  I'd like to hear Dmitry's opinion on the
> change, before we consider whether it's important enough to have in
> Emacs 26.

I don't have a strong opinion.

Does everybody like the proposed key combination? As another option, 
'C-x v e' is still free (for rEgion-history).

Message #20 received at 27644 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 27644 <at> debbugs.gnu.org, kaushal.modi <at> gmail.com
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Thu, 21 Sep 2017 17:41:12 +0300

> Cc: 27644 <at> debbugs.gnu.org
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> Date: Thu, 21 Sep 2017 17:22:13 +0300
> 
> On 9/20/17 5:15 PM, Eli Zaretskii wrote:
> >> From: Kaushal Modi <kaushal.modi <at> gmail.com>
> >> Date: Wed, 20 Sep 2017 14:03:30 +0000
> >>
> >> Any issues getting this minor patch into 26.1?
> > 
> > It hasn't been reviewed yet.  I'd like to hear Dmitry's opinion on the
> > change, before we consider whether it's important enough to have in
> > Emacs 26.
> 
> I don't have a strong opinion.

About binding this to a key in general, or about the particular key
proposed by Kaushal?  If the former, perhaps we should ask how many
others bind this to a key, or how frequently they use this command.

Thanks.

Message #23 received at 27644 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 27644 <at> debbugs.gnu.org, kaushal.modi <at> gmail.com
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Thu, 21 Sep 2017 18:29:32 +0300

On 9/21/17 5:41 PM, Eli Zaretskii wrote:

>> I don't have a strong opinion.
> 
> About binding this to a key in general, or about the particular key
> proposed by Kaushal?

Either. It's not a very technical decision, and I very rarely use this 
command myself.

> If the former, perhaps we should ask how many
> others bind this to a key, or how frequently they use this command.

Sounds good to me.

Message #26 received at 27644 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 27644 <at> debbugs.gnu.org, John Wiegley <johnw <at> gnu.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Thu, 28 Sep 2017 18:23:51 +0000

[Message part 1 (text/plain, inline)]

Hello all,

I have now attached an updated path that binds vc-region-history to C-x v h
and vc-insert-headers to C-x v H based on the discussion here[1].

The patch also reflects this change in the manual.

[1]: http://lists.gnu.org/archive/html/emacs-devel/2017-09/msg00957.html
-- 

Kaushal Modi

[Message part 2 (text/html, inline)]

[0001-Bind-vc-region-history.patch (application/octet-stream, attachment)]

Message #29 received at 27644 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Kaushal Modi <kaushal.modi <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 27644 <at> debbugs.gnu.org, John Wiegley <johnw <at> gnu.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Fri, 29 Sep 2017 13:54:18 +0200

On 9/28/17 8:23 PM, Kaushal Modi wrote:
> Hello all,
> 
> I have now attached an updated path that binds vc-region-history to C-x 
> v h and vc-insert-headers to C-x v H based on the discussion here[1].

Let's not bind vc-insert-headers to anything. Otherwise, I'm on board.

Eli? emacs-26 or master?

Message #32 received at 27644 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 27644 <at> debbugs.gnu.org, John Wiegley <johnw <at> gnu.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Fri, 29 Sep 2017 11:59:14 +0000

[Message part 1 (text/plain, inline)]

On Fri, Sep 29, 2017 at 7:54 AM Dmitry Gutov <dgutov <at> yandex.ru> wrote:

> Let's not bind vc-insert-headers to anything. Otherwise, I'm on board.
>

I am of course fine with that. I'll send another patch with that change
later today.


> Eli? emacs-26 or master?
>

(Please, emacs-26 :) It's just a binding change, and this is a major
release anyways, and we are before the first pretest.)
-- 

Kaushal Modi

[Message part 2 (text/html, inline)]

Message #35 received at 27644 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 27644 <at> debbugs.gnu.org, John Wiegley <johnw <at> gnu.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Fri, 29 Sep 2017 16:43:02 +0000

[Message part 1 (text/plain, inline)]

On Fri, Sep 29, 2017 at 7:59 AM Kaushal Modi <kaushal.modi <at> gmail.com> wrote:

> I am of course fine with that. I'll send another patch with that change
> later today.
>

New patch attached that binds vc-region-history instead of
vc-insert-headers to C-x v h.
-- 

Kaushal Modi

[Message part 2 (text/html, inline)]

[0001-Bind-vc-region-history.patch (application/octet-stream, attachment)]

Message #38 received at 27644 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 27644 <at> debbugs.gnu.org, johnw <at> gnu.org, monnier <at> iro.umontreal.ca,
 kaushal.modi <at> gmail.com
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Fri, 29 Sep 2017 20:22:29 +0300

> Cc: 27644 <at> debbugs.gnu.org, John Wiegley <johnw <at> gnu.org>,
>  Stefan Monnier <monnier <at> iro.umontreal.ca>
> From: Dmitry Gutov <dgutov <at> yandex.ru>
> Date: Fri, 29 Sep 2017 13:54:18 +0200
> 
> Eli? emacs-26 or master?

Emacs-26, please (otherwise Kaushal will keep haunting me ;-).

Message #41 received at 27644 <at> debbugs.gnu.org (full text, mbox):

From: "John Wiegley" <johnw <at> gnu.org>
To: Kaushal Modi <kaushal.modi <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 27644 <at> debbugs.gnu.org,
 Stefan Monnier <monnier <at> iro.umontreal.ca>, Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Fri, 29 Sep 2017 10:31:25 -0700

>>>>> "KM" == Kaushal Modi <kaushal.modi <at> gmail.com> writes:

KM> (Please, emacs-26 :) It's just a binding change, and this is a major
KM> release anyways, and we are before the first pretest.)

I'm fine with emacs-26.

-- 
John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

Message #44 received at 27644 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 27644 <at> debbugs.gnu.org, kaushal.modi <at> gmail.com, johnw <at> gnu.org,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Fri, 29 Sep 2017 13:39:11 -0400

>>>>> "Eli" == Eli Zaretskii <eliz <at> gnu.org> writes:
> Emacs-26, please (otherwise Kaushal will keep haunting me ;-).

>>>>> "John" == John Wiegley <johnw <at> gnu.org> writes:
> I'm fine with emacs-26.

Hmm... guys, can you make up your mind?
Should it go to emacs-26 or to Emacs-26?  Or both?


        Stefan "really confused"


PS: And now for something completely different...

Message #47 received at 27644 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 27644 <at> debbugs.gnu.org, kaushal.modi <at> gmail.com, johnw <at> gnu.org,
 dgutov <at> yandex.ru
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Fri, 29 Sep 2017 21:16:57 +0300

> From: Stefan Monnier <monnier <at> iro.umontreal.ca>
> Cc: Dmitry Gutov <dgutov <at> yandex.ru>,  kaushal.modi <at> gmail.com,  27644 <at> debbugs.gnu.org,  johnw <at> gnu.org
> Date: Fri, 29 Sep 2017 13:39:11 -0400
> 
> >>>>> "Eli" == Eli Zaretskii <eliz <at> gnu.org> writes:
> > Emacs-26, please (otherwise Kaushal will keep haunting me ;-).
> 
> >>>>> "John" == John Wiegley <johnw <at> gnu.org> writes:
> > I'm fine with emacs-26.
> 
> Hmm... guys, can you make up your mind?
> Should it go to emacs-26 or to Emacs-26?  Or both?

Yes.

Message #50 received at 27644 <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 27644 <at> debbugs.gnu.org, johnw <at> gnu.org, dgutov <at> yandex.ru
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Fri, 29 Sep 2017 18:32:51 +0000

[Message part 1 (text/plain, inline)]

On Fri, Sep 29, 2017 at 2:17 PM Eli Zaretskii <eliz <at> gnu.org> wrote:

> > >>>>> "Eli" == Eli Zaretskii <eliz <at> gnu.org> writes:
> > > Emacs-26, please (otherwise Kaushal will keep haunting me ;-).
> >
> > >>>>> "John" == John Wiegley <johnw <at> gnu.org> writes:
> > > I'm fine with emacs-26.
> >
> > Hmm... guys, can you make up your mind?
> > Should it go to emacs-26 or to Emacs-26?  Or both?
>
> Yes.
>

Thank you all! :D

Can someone please commit the last patch[1] I sent?

[1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27644#35
-- 

Kaushal Modi

[Message part 2 (text/html, inline)]

Message #55 received at 27644-done <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Kaushal Modi <kaushal.modi <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>,
 Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 27644-done <at> debbugs.gnu.org, johnw <at> gnu.org
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Sat, 30 Sep 2017 16:03:19 +0200

On 9/29/17 8:32 PM, Kaushal Modi wrote:

> Thank you all! :D
> 
> Can someone please commit the last patch[1] I sent?
> 
> [1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27644#35

Pushed. Thanks, and closing.

Next time please use the usual ChangeLog format (it was close, but not 
quite).

Message #58 received at 27644-done <at> debbugs.gnu.org (full text, mbox):

From: Kaushal Modi <kaushal.modi <at> gmail.com>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 27644-done <at> debbugs.gnu.org
Subject: Re: bug#27644: 26.0.50; [PATCH] Add binding for vc-region-history
Date: Sat, 30 Sep 2017 14:12:35 +0000

[Message part 1 (text/plain, inline)]

On Sat, Sep 30, 2017, 10:03 AM Dmitry Gutov <dgutov <at> yandex.ru> wrote:

>
> Pushed. Thanks, and closing.
>
> Next time please use the usual ChangeLog format (it was close, but not
> quite).
>

Thank you!

I was pretty sure I was following the required format. I'll review the
CONTRIBUTE again. But where did the current commit message go wrong?

> --

Kaushal Modi

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.