GNU bug report logs - #27635
[PATCH] gnu: emacs: Build with imagemagick support.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27635 in the body.
You can then email your comments to 27635 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Vong <alexvong1995 <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: emacs: Build with imagemagick support.
Date: Mon, 10 Jul 2017 12:04:21 +0800

[Message part 1 (text/plain, inline)]

Hi,

Currently, Emacs cannot resize image in image-mode because it lacks
imagemagick support. This patch adds it:

[0001-gnu-emacs-Build-with-imagemagick-support.patch (text/x-diff, inline)]

From bd4bb491b84b45c16775fb9ed2734ff3d239d9c8 Mon Sep 17 00:00:00 2001
From: Alex Vong <alexvong1995 <at> gmail.com>
Date: Mon, 10 Jul 2017 11:54:22 +0800
Subject: [PATCH] gnu: emacs: Build with imagemagick support.

* gnu/packages/emacs.scm (emacs)[inputs]: Add imagemagick.
---
 gnu/packages/emacs.scm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index a8bc58bb2..be71f140d 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -171,6 +171,7 @@
        ("libtiff" ,libtiff)
        ("giflib" ,giflib)
        ("libjpeg" ,libjpeg-8)
+       ("imagemagick" ,imagemagick)
        ("acl" ,acl)
 
        ;; When looking for libpng `configure' links with `-lpng -lz', so we
-- 
2.13.2

[Message part 3 (text/plain, inline)]

Cheers,
Alex

[signature.asc (application/pgp-signature, inline)]

Message #10 received at 27635-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Alex Vong <alexvong1995 <at> gmail.com>
Cc: 27635-done <at> debbugs.gnu.org
Subject: Re: [bug#27635] [PATCH] gnu: emacs: Build with imagemagick support.
Date: Mon, 10 Jul 2017 15:20:01 +0530

Pushed, thanks!

Message #13 received at 27635 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Alex Vong <alexvong1995 <at> gmail.com>
Cc: 27635 <at> debbugs.gnu.org
Subject: Re: [bug#27635] [PATCH] gnu: emacs: Build with imagemagick support.
Date: Mon, 10 Jul 2017 12:36:40 +0200

Hi Alex,

Alex Vong <alexvong1995 <at> gmail.com> skribis:

> Currently, Emacs cannot resize image in image-mode because it lacks
> imagemagick support. This patch adds it:

That’s good news, I always wonder whether/how this could be fixed.  :-)

It noticeably increases the size of the Emacs closure though:

--8<---------------cut here---------------start------------->8---
$ guix size emacs |tail -1
total: 795.1 MiB
$ guix size emacs imagemagick |tail -1
total: 904.4 MiB
--8<---------------cut here---------------end--------------->8---

There a few big packages showing up in the profile; we should try to
make them smaller, perhaps by introducing separate outputs:

--8<---------------cut here---------------start------------->8---
$ guix size imagemagick 
store item                                                       total    self
/gnu/store/rcwblby3chpyhqxawxh3b8ykllsx9pik-imagemagick-6.9.8-10   394.1    19.6   5.0%
/gnu/store/szar30hn9qh7g6ib89rck1sswd44mm5x-graphviz-2.38.0        306.2    62.0  15.7%
/gnu/store/kqn8ib1hnlxhkb64bn1ggh1rp0xxidyv-pango-1.40.6           212.0     3.9   1.0%
/gnu/store/1x8x3bddq7pki89kyqlyx3g7dhkvviki-harfbuzz-1.4.6         181.9     2.4   0.6%
/gnu/store/4k53v34ja39r4rb08km0piak1c65nrkn-cairo-1.14.8           152.1     6.0   1.5%
/gnu/store/17d0ywzd9cp3qsbwc6j6h8cnwh4rplj5-ghostscript-9.14.0     140.2    19.1   4.9%
/gnu/store/rmb4nh95s22lnd42sarzj5bswakd3mxx-icu4c-58.2             134.0    34.9   8.9%
--8<---------------cut here---------------end--------------->8---

Thoughts?

Thanks,
Ludo’.

Message #16 received at 27635 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Alex Vong <alexvong1995 <at> gmail.com>, 27635 <at> debbugs.gnu.org
Subject: Re: [bug#27635] [PATCH] gnu: emacs: Build with imagemagick support.
Date: Tue, 11 Jul 2017 10:58:42 +0530

Ludovic Courtès writes:

> There a few big packages showing up in the profile; we should try to
> make them smaller, perhaps by introducing separate outputs:
> Thoughts?

I have to go through the dependency tree carefully to figure out which
package to split. Do you have any suggestions off the bat?

Message #19 received at 27635 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: Alex Vong <alexvong1995 <at> gmail.com>, 27635 <at> debbugs.gnu.org
Subject: Re: [bug#27635] [PATCH] gnu: emacs: Build with imagemagick support.
Date: Tue, 11 Jul 2017 10:29:44 +0200

Arun Isaac <arunisaac <at> systemreboot.net> skribis:

> Ludovic Courtès writes:
>
>> There a few big packages showing up in the profile; we should try to
>> make them smaller, perhaps by introducing separate outputs:
>> Thoughts?
>
> I have to go through the dependency tree carefully to figure out which
> package to split. Do you have any suggestions off the bat?

ImageMagick and Graphviz are pretty big.  For the latter, ISTR there are
a couple of executables that are surprisingly big; perhaps the solution
would be to figure out why it is the case and strip them somehow, if
possible.

Ghostscript and icu4c are also rather big.

Ludo’.

Message #22 received at 27635 <at> debbugs.gnu.org (full text, mbox):

From: Alex Vong <alexvong1995 <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: Arun Isaac <arunisaac <at> systemreboot.net>, 27635 <at> debbugs.gnu.org
Subject: Re: [bug#27635] [PATCH] gnu: emacs: Build with imagemagick support.
Date: Tue, 11 Jul 2017 21:16:05 +0800

[Message part 1 (text/plain, inline)]

ludo <at> gnu.org (Ludovic Courtès) writes:

> Arun Isaac <arunisaac <at> systemreboot.net> skribis:
>
>> Ludovic Courtès writes:
>>
>>> There a few big packages showing up in the profile; we should try to
>>> make them smaller, perhaps by introducing separate outputs:
>>> Thoughts?
>>
>> I have to go through the dependency tree carefully to figure out which
>> package to split. Do you have any suggestions off the bat?
>
> ImageMagick and Graphviz are pretty big.  For the latter, ISTR there are
> a couple of executables that are surprisingly big; perhaps the solution
> would be to figure out why it is the case and strip them somehow, if
> possible.
>
> Ghostscript and icu4c are also rather big.
>
How about making a tiny version of imagemagick excluding ghostscript?
The emacs manual[0] says ghostscript is a hard requirement for
postscript files. If users don't need to render postscript files, then
we don't need it, right?

> Ludo’.

[0]: https://www.gnu.org/software/emacs/manual/html_node/emacs/Document-View.html#fnd-1

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 27635 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Alex Vong <alexvong1995 <at> gmail.com>, 27635 <at> debbugs.gnu.org
Subject: Re: [bug#27635] [PATCH] gnu: emacs: Build with imagemagick support.
Date: Tue, 11 Jul 2017 19:42:04 +0530

Ludovic Courtès writes:

> Thoughts?

Some preliminary thoughts:

`guix size emacs' lists cups, cups-minimal, ghostscript and
ghostscript-with-cups as dependencies. Can't we do with just cups and
ghostscript, or just cups-minimal and ghostscript?

Also, there are two builds (different hashes) of cairo-1.14.8 listed.

Is it acceptable to build gtk+ with cups-minimal, instead of cups?

Message #28 received at 27635 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Alex Vong <alexvong1995 <at> gmail.com>
Cc: Arun Isaac <arunisaac <at> systemreboot.net>, 27635 <at> debbugs.gnu.org
Subject: Re: [bug#27635] [PATCH] gnu: emacs: Build with imagemagick support.
Date: Tue, 11 Jul 2017 16:42:47 +0200

Alex Vong <alexvong1995 <at> gmail.com> skribis:

> ludo <at> gnu.org (Ludovic Courtès) writes:
>
>> Arun Isaac <arunisaac <at> systemreboot.net> skribis:
>>
>>> Ludovic Courtès writes:
>>>
>>>> There a few big packages showing up in the profile; we should try to
>>>> make them smaller, perhaps by introducing separate outputs:
>>>> Thoughts?
>>>
>>> I have to go through the dependency tree carefully to figure out which
>>> package to split. Do you have any suggestions off the bat?
>>
>> ImageMagick and Graphviz are pretty big.  For the latter, ISTR there are
>> a couple of executables that are surprisingly big; perhaps the solution
>> would be to figure out why it is the case and strip them somehow, if
>> possible.
>>
>> Ghostscript and icu4c are also rather big.
>>
> How about making a tiny version of imagemagick excluding ghostscript?
> The emacs manual[0] says ghostscript is a hard requirement for
> postscript files. If users don't need to render postscript files, then
> we don't need it, right?

As someone who uses DocView, I’d like to keep it.  :-)

In general I think we should work more on making our packages smaller,
but not at the cost of useful features.

Ludo’.

Message #31 received at 27635 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: Alex Vong <alexvong1995 <at> gmail.com>, 27635 <at> debbugs.gnu.org
Subject: Re: [bug#27635] [PATCH] gnu: emacs: Build with imagemagick support.
Date: Tue, 11 Jul 2017 16:44:56 +0200

Arun Isaac <arunisaac <at> systemreboot.net> skribis:

> Ludovic Courtès writes:
>
>> Thoughts?
>
> Some preliminary thoughts:
>
> `guix size emacs' lists cups, cups-minimal, ghostscript and
> ghostscript-with-cups as dependencies. Can't we do with just cups and
> ghostscript, or just cups-minimal and ghostscript?
>
> Also, there are two builds (different hashes) of cairo-1.14.8 listed.
>
> Is it acceptable to build gtk+ with cups-minimal, instead of cups?

I’m not sure, but I guess not (cups depends on cups-filters, which
depends on cups-minimal IIRC).

I suggest looking at “guix graph -t references emacs” to get an idea of
where things come from.  Stripping a dependency graph can be tricky!

Ludo’.

Message #34 received at 27635 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: Alex Vong <alexvong1995 <at> gmail.com>, 27635 <at> debbugs.gnu.org
Subject: Re: [bug#27635] [PATCH] gnu: emacs: Build with imagemagick support.
Date: Wed, 12 Jul 2017 03:01:18 +0530

Ludovic Courtès writes:

> ImageMagick and Graphviz are pretty big.  For the latter, ISTR there are
> a couple of executables that are surprisingly big;

Upgrading graphviz fixes this problem (whatever it was!). I have
submitted a patch for the same.

https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27657

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.