GNU bug report logs - #27630
26.0.50; Byte-compilation warnings in files.el

Previous Next

Package: emacs;

Reported by: Eli Zaretskii <eliz <at> gnu.org>

Date: Sun, 9 Jul 2017 17:42:02 UTC

Severity: minor

Tags: confirmed, fixed, patch

Merged with 14860, 28803

Found in version 26.0.50

Fixed in version 26.1

Done: Stefan Monnier <monnier <at> IRO.UMontreal.CA>

Bug is archived. No further changes may be made.

Full log

Message #17 received at control <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> users.sourceforge.net>
To: John Williams <jrw <at> pobox.com>
Cc: 28803 <at> debbugs.gnu.org
Subject: Re: bug#28803: [PATCH] Fixed compiler warnings for advised functions.
Date: Sat, 21 Oct 2017 19:33:23 -0400

tags 28803 fixed
close 28803 26.1
unarchive 14860
merge 28803 14860
quit

Noam Postavsky <npostavs <at> users.sourceforge.net> writes:

> John Williams <jrw <at> pobox.com> writes:
>
>> Oops. Is there anything that can be salvaged from my patch? Aside
>> from fixing the bug, it also adds a unit test and refactors the logic
>> for finding a function's argument list into a separate function
>> that's not part of the help system.
>
> We could add the test, it seems to be passing in emacs-26.

I've pushed the test.

[1: 237e96bc52]: 2017-10-21 19:20:46 -0400
  Test that advice doesn't trigger bytecomp warnings (Bug#28803)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=237e96bc5259e59ac5623a93a47f64abffab4e0b
This bug report was last modified 7 years and 214 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.