From unknown Fri Jun 20 07:09:20 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#27630 <27630@debbugs.gnu.org> To: bug#27630 <27630@debbugs.gnu.org> Subject: Status: 26.0.50; Byte-compilation warnings in files.el Reply-To: bug#27630 <27630@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:09:20 +0000 retitle 27630 26.0.50; Byte-compilation warnings in files.el reassign 27630 emacs submitter 27630 Eli Zaretskii severity 27630 minor tag 27630 confirmed fixed patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 09 13:41:59 2017 Received: (at submit) by debbugs.gnu.org; 9 Jul 2017 17:41:59 +0000 Received: from localhost ([127.0.0.1]:59084 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUGDW-0004Oc-UR for submit@debbugs.gnu.org; Sun, 09 Jul 2017 13:41:59 -0400 Received: from eggs.gnu.org ([208.118.235.92]:34642) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUGDV-0004OQ-L1 for submit@debbugs.gnu.org; Sun, 09 Jul 2017 13:41:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUGDP-00048N-GS for submit@debbugs.gnu.org; Sun, 09 Jul 2017 13:41:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:60535) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dUGDP-00048B-D7 for submit@debbugs.gnu.org; Sun, 09 Jul 2017 13:41:51 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53838) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUGDO-0006sq-0a for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2017 13:41:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUGDJ-00042y-RX for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2017 13:41:49 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55148) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUGDJ-00042o-NB for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2017 13:41:45 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3302 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dUGDJ-000702-1t for bug-gnu-emacs@gnu.org; Sun, 09 Jul 2017 13:41:45 -0400 Date: Sun, 09 Jul 2017 20:41:38 +0300 Message-Id: <83eftpjynh.fsf@gnu.org> From: Eli Zaretskii To: bug-gnu-emacs@gnu.org Subject: 26.0.50; Byte-compilation warnings in files.el X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Compiling files.el produces the following 2 warnings: In create-file-buffer: files.el:1816:8:Warning: function create-file-buffer used to take 0+ arguments, now takes 1 In insert-directory: files.el:6595:43:Warning: function insert-directory used to take 0+ arguments, now takes 2-4 These warnings are meant to be emitted when a function's signature changes, but in this case there's no change, so this seems to be a bug. The only hint I found as to why this happens is that both functions appear in advice-add (insert-directory appears in advice-add only on MS-Windows). In GNU Emacs 26.0.50 (build 780, i686-pc-mingw32) of 2017-07-09 built on HOME-C4E4A596F7 Repository revision: c6e94f894bd965c2be47c5a4d79498b48e8b94e0 Windowing system distributor 'Microsoft Corp.', version 5.1.2600 Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Configured using: 'configure --prefix=/d/usr --enable-checking=yes,glyphs --with-wide-int --with-modules 'CFLAGS=-O0 -gdwarf-4 -g3'' Configured features: XPM JPEG TIFF GIF PNG RSVG SOUND NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS MODULES Important settings: value of $LANG: ENU locale-coding-system: cp1255 Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp disp-table term/w32-win w32-win w32-vars term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote w32notify w32 multi-tty make-network-process emacs) Memory information: ((conses 16 101517 10223) (symbols 56 21182 1) (miscs 48 42 103) (strings 16 31903 2054) (string-bytes 1 784505) (vectors 16 14706) (vector-slots 8 490506 11795) (floats 8 54 62) (intervals 40 271 105) (buffers 864 11)) From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 09 13:50:38 2017 Received: (at 27630) by debbugs.gnu.org; 9 Jul 2017 17:50:38 +0000 Received: from localhost ([127.0.0.1]:59093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUGLt-0004dz-SH for submit@debbugs.gnu.org; Sun, 09 Jul 2017 13:50:38 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:34947) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUGLp-0004df-Om; Sun, 09 Jul 2017 13:50:34 -0400 Received: by mail-it0-f66.google.com with SMTP id v193so10007791itc.2; Sun, 09 Jul 2017 10:50:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=kgAXsF+0ZOkVx+U/qXLKzdhJ2SFMrnUs3EKdWNfbOmA=; b=JVH8Aitd6/DjxWgHTKKJ7O7JqrbAqne2IIgornk8lECYOKogUYPTj8mEU039/El/KS iO9dvW9ZBCqwfuLfMeQ9b+vTMB8NHgaQ1d534ENA6wcGjBQyF6+2qCXn1jAhH/Z5TQZa UgCF+adGh+u6u2e/FiBN7TWL1tCcvnOFuF7sbDOwnIhHkb1JhYOqQ2omPD6zzymXV3B8 vUDOaBwij73SG5zgElfgE+/3Dx2/uscVh8/xSfvn6CYfo2vQYLetjCF2yttuPcQiyxOX OJ395yeMjod7NyL4tDUkCCJkNhERVXqZZAt3g4ZZdt2fE3MUvh8V9oo0GB0zpQJrVuZD W1wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=kgAXsF+0ZOkVx+U/qXLKzdhJ2SFMrnUs3EKdWNfbOmA=; b=D6i0MF89V5w2FADjoN31vvaXCwhuRC5cZILsbRK8jppNwGL6DPIb7Sm2WalzqGepXC quA0ZdrkaTQaUf+tEPUCPuzq9OoM3TM/paKwrR5pwaR31slQMl83juSIe15vEhOf5sDP AgNezhVFprfBIJIEjQpsBuel9m9rl1nLdkVPtjercsYIiBGCxYKva81PB5YplAWCchUf K6zTSibdah9Xy1kZJbWFVN8fbXfzb+T7sfVif0c+VSuWUTrfob4dSgqSSbJdHB0QjwG8 EiVu1GUr2Lcn0W1sOJ+iNxPt17nCmJIbxf2jxBD97mXiS7Q7bng4pSfWx2Z06rp+Z4IV vQVQ== X-Gm-Message-State: AIVw110gzwMEfqIXk18TxCOkshWsCGexincq7z2B+NhUwioVEJQ8Ri7V RNinSzkYqKe1Mhoq X-Received: by 10.107.16.9 with SMTP id y9mr60274ioi.134.1499622628060; Sun, 09 Jul 2017 10:50:28 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id l27sm21842ioi.6.2017.07.09.10.50.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 09 Jul 2017 10:50:27 -0700 (PDT) From: npostavs@users.sourceforge.net To: Eli Zaretskii Subject: Re: bug#27630: 26.0.50; Byte-compilation warnings in files.el References: <83eftpjynh.fsf@gnu.org> Date: Sun, 09 Jul 2017 13:52:01 -0400 In-Reply-To: <83eftpjynh.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 09 Jul 2017 20:41:38 +0300") Message-ID: <877ezhh51a.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 27630 Cc: 27630@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) forcemerge 14860 27630 quit Eli Zaretskii writes: > Compiling files.el produces the following 2 warnings: > > In create-file-buffer: > files.el:1816:8:Warning: function create-file-buffer used to take 0+ > arguments, now takes 1 > > In insert-directory: > files.el:6595:43:Warning: function insert-directory used to take 0+ arguments, > now takes 2-4 > > These warnings are meant to be emitted when a function's signature > changes, but in this case there's no change, so this seems to be a > bug. The only hint I found as to why this happens is that both > functions appear in advice-add (insert-directory appears in advice-add > only on MS-Windows). I believe this is Bug#14860. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 09 14:41:39 2017 Received: (at 27630) by debbugs.gnu.org; 9 Jul 2017 18:41:39 +0000 Received: from localhost ([127.0.0.1]:59141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUH9H-0007dH-Hr for submit@debbugs.gnu.org; Sun, 09 Jul 2017 14:41:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:48081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUH9G-0007d5-4f for 27630@debbugs.gnu.org; Sun, 09 Jul 2017 14:41:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUH97-0005Zm-QN for 27630@debbugs.gnu.org; Sun, 09 Jul 2017 14:41:32 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55511) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUH97-0005Za-Me; Sun, 09 Jul 2017 14:41:29 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3344 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dUH95-00044h-0T; Sun, 09 Jul 2017 14:41:29 -0400 Date: Sun, 09 Jul 2017 21:41:07 +0300 Message-Id: <838tjxjvwc.fsf@gnu.org> From: Eli Zaretskii To: npostavs@users.sourceforge.net In-reply-to: <877ezhh51a.fsf@users.sourceforge.net> (npostavs@users.sourceforge.net) Subject: Re: bug#27630: 26.0.50; Byte-compilation warnings in files.el References: <83eftpjynh.fsf@gnu.org> <877ezhh51a.fsf@users.sourceforge.net> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27630 Cc: 27630@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: npostavs@users.sourceforge.net > Cc: 27630@debbugs.gnu.org > Date: Sun, 09 Jul 2017 13:52:01 -0400 > > > In create-file-buffer: > > files.el:1816:8:Warning: function create-file-buffer used to take 0+ > > arguments, now takes 1 > > > > In insert-directory: > > files.el:6595:43:Warning: function insert-directory used to take 0+ arguments, > > now takes 2-4 > > > > These warnings are meant to be emitted when a function's signature > > changes, but in this case there's no change, so this seems to be a > > bug. The only hint I found as to why this happens is that both > > functions appear in advice-add (insert-directory appears in advice-add > > only on MS-Windows). > > I believe this is Bug#14860. Yes, looks like that. Thanks. From unknown Fri Jun 20 07:09:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 13 Aug 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 21 19:33:34 2017 Received: (at control) by debbugs.gnu.org; 21 Oct 2017 23:33:34 +0000 Received: from localhost ([127.0.0.1]:54748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e63Go-00048j-7Y for submit@debbugs.gnu.org; Sat, 21 Oct 2017 19:33:34 -0400 Received: from mail-it0-f43.google.com ([209.85.214.43]:51373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e63Gm-00048R-6x; Sat, 21 Oct 2017 19:33:32 -0400 Received: by mail-it0-f43.google.com with SMTP id o135so2314348itb.0; Sat, 21 Oct 2017 16:33:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=nb7bUdO+WE2khXPyZlnd+K9slZRYbe3gn05Yu+faAGM=; b=eiEVajC15xE0qEzs5jU1bxznQEaR3R4Pu7WbhlX5x66PTkmy1LdEZZp3wRXMI77XoU uz6ww7LZLJreQKE8XzS4vJ6u1RceUZKx0RdUJbtdT7H7EEfginO2L+VUsxx362xwPULp plY36O5FnpwE/SB4wGmC9IlNruMNmifS+DrcC8hRJOQUYMfUQVtzOH1Z7RRCZRCWLNgq d7OKOHcbSGFKV8hLbdTf+5lAW9HrrZTpLDd4kW27mV4CkyxhR28sr0AEq0xZeVPtKb+B 7rx1EvnvIkDrmj59FarRaaLLpV/yfoKW/A3XGXqorhTg4FqD4X2vUKu2kzmSVVzenlj8 mQ8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=nb7bUdO+WE2khXPyZlnd+K9slZRYbe3gn05Yu+faAGM=; b=HCryJwJUl7Hlq3fuvkbp5PYwOPTUc0t95t3lerjdPBuFXXQFXs8a8/mOITYmcmrfdS MDOMzsXthBUiH/kmlNTmLYIiK4MyFy02Dwf4ykl8EsJBOyFRIUPKkF+9gbsivrRq2W7L wsUO3WqXTxWJWEf/sSt2ugrkqFYnLRCrXJi7YJyhjtxwzbWfujnHXuh7ObXxqSb52NV9 a6hNnbg8M+WgGvJwBp/qpk0AnasJTO2cmOWy86DJlt3PEm56u0f5uYeVJ/I9KJakqpHb 9jCeT3oN7/IdXAaTcXXgcYvoYsu4U6smGaI2D16o50pLMagSwy6o8Uq9gDxZto068L9o cHnA== X-Gm-Message-State: AMCzsaVcOe/xL0XlfNYsvEjnL/mDk0iPCqc87NDrtV8pLaoghGcG1SNF lX1SFwoWnPzJYZBQ/XXvkxMuNw== X-Google-Smtp-Source: ABhQp+QINMEhCpDuMyXNJcHA063fGxGA+DN4ZJXp2iqyIO2+aFRD/r91xTsX/rxzAr43Dr4ZYKWucQ== X-Received: by 10.36.164.75 with SMTP id v11mr4211998iti.33.1508628806353; Sat, 21 Oct 2017 16:33:26 -0700 (PDT) Received: from zebian ([45.2.119.34]) by smtp.googlemail.com with ESMTPSA id m12sm903590ita.17.2017.10.21.16.33.24 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 21 Oct 2017 16:33:25 -0700 (PDT) From: Noam Postavsky To: John Williams Subject: Re: bug#28803: [PATCH] Fixed compiler warnings for advised functions. References: <87infi9t0p.fsf@users.sourceforge.net> <874lr19trw.fsf@users.sourceforge.net> Date: Sat, 21 Oct 2017 19:33:23 -0400 In-Reply-To: <874lr19trw.fsf@users.sourceforge.net> (Noam Postavsky's message of "Sat, 14 Oct 2017 19:47:15 -0400") Message-ID: <87zi8kcbzw.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.90 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control Cc: 28803@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 28803 fixed close 28803 26.1 unarchive 14860 merge 28803 14860 quit Noam Postavsky writes: > John Williams writes: > >> Oops. Is there anything that can be salvaged from my patch? Aside >> from fixing the bug, it also adds a unit test and refactors the logic >> for finding a function's argument list into a separate function >> that's not part of the help system. > > We could add the test, it seems to be passing in emacs-26. I've pushed the test. [1: 237e96bc52]: 2017-10-21 19:20:46 -0400 Test that advice doesn't trigger bytecomp warnings (Bug#28803) https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=237e96bc5259e59ac5623a93a47f64abffab4e0b From unknown Fri Jun 20 07:09:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 20 Nov 2017 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator