From unknown Tue Jun 24 06:58:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27617: 26.0.50; cl--random-state initialized to old-style vector Resent-From: Christopher Wellons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jul 2017 13:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27617 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 27617@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.149952118019528 (code B ref -1); Sat, 08 Jul 2017 13:40:02 +0000 Received: (at submit) by debbugs.gnu.org; 8 Jul 2017 13:39:40 +0000 Received: from localhost ([127.0.0.1]:57421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTpxT-00054u-Ks for submit@debbugs.gnu.org; Sat, 08 Jul 2017 09:39:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTpxS-00054h-NR for submit@debbugs.gnu.org; Sat, 08 Jul 2017 09:39:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTpxM-0000q6-GB for submit@debbugs.gnu.org; Sat, 08 Jul 2017 09:39:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40398) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dTpxM-0000pe-Bh for submit@debbugs.gnu.org; Sat, 08 Jul 2017 09:39:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTpxL-0002a6-92 for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 09:39:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTpxI-0000mH-3Y for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 09:39:31 -0400 Received: from mail.nullprogram.com ([192.241.191.137]:32853) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dTpxH-0000kp-Vn for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 09:39:28 -0400 Received: from nullprogram.com (localhost [127.0.0.1]) by mail.nullprogram.com (Postfix) with ESMTPS id 431ACC3C9F for ; Sat, 8 Jul 2017 09:39:19 -0400 (EDT) Date: Sat, 8 Jul 2017 09:39:18 -0400 From: Christopher Wellons Message-ID: <20170708133918.GD17540@nullprogram.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) The global variable cl--random-state is still being initialized to the old defstruct vector format. See lisp/emacs-lisp/cl-lib.el:296. This breaks all random number functions when the STATE argument isn't supplied: $ emacs -Q --batch -l cl-lib --eval '(cl-random 10)' Wrong type argument: cl--random-state, [cl--random-state-tag -1 30 ...] From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 08 18:37:33 2017 Received: (at control) by debbugs.gnu.org; 8 Jul 2017 22:37:33 +0000 Received: from localhost ([127.0.0.1]:58237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTyM0-0004cf-Sc for submit@debbugs.gnu.org; Sat, 08 Jul 2017 18:37:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53085) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTyLz-0004cT-Oq for control@debbugs.gnu.org; Sat, 08 Jul 2017 18:37:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTyLt-00082L-VP for control@debbugs.gnu.org; Sat, 08 Jul 2017 18:37:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:46746) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTyLt-00082F-Rb for control@debbugs.gnu.org; Sat, 08 Jul 2017 18:37:25 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dTyLt-0005Xp-GY for control@debbugs.gnu.org; Sat, 08 Jul 2017 18:37:25 -0400 Subject: control message for bug 24655 To: X-Mailer: mail (GNU Mailutils 2.99.98) Message-Id: From: Glenn Morris Date: Sat, 08 Jul 2017 18:37:25 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) block 24655 by 27617 From unknown Tue Jun 24 06:58:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27617: [PATCH] Fix cl--random-state initialization. Resent-From: Christopher Wellons Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Jul 2017 18:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27617 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 27617@debbugs.gnu.org Received: via spool by 27617-submit@debbugs.gnu.org id=B27617.14997130164846 (code B ref 27617); Mon, 10 Jul 2017 18:57:02 +0000 Received: (at 27617) by debbugs.gnu.org; 10 Jul 2017 18:56:56 +0000 Received: from localhost ([127.0.0.1]:32975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUdrb-0001G6-NY for submit@debbugs.gnu.org; Mon, 10 Jul 2017 14:56:55 -0400 Received: from mail.nullprogram.com ([192.241.191.137]:58131) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUdrZ-0001Fy-Om for 27617@debbugs.gnu.org; Mon, 10 Jul 2017 14:56:54 -0400 Received: from nullprogram.com (localhost [127.0.0.1]) by mail.nullprogram.com (Postfix) with ESMTPS id 2FF6CC3CAA for <27617@debbugs.gnu.org>; Mon, 10 Jul 2017 14:56:47 -0400 (EDT) Date: Mon, 10 Jul 2017 14:56:46 -0400 From: Christopher Wellons Message-ID: <20170710185646.GH17540@nullprogram.com> References: <20170708133918.GD17540@nullprogram.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170708133918.GD17540@nullprogram.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Here's a trivial patch that fixes this bug. --- lisp/emacs-lisp/cl-lib.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/cl-lib.el b/lisp/emacs-lisp/cl-lib.el index 936c852526c..ea47a0562ee 100644 --- a/lisp/emacs-lisp/cl-lib.el +++ b/lisp/emacs-lisp/cl-lib.el @@ -294,7 +294,7 @@ cl--random-time v)) (defvar cl--random-state - (vector 'cl--random-state-tag -1 30 (cl--random-time))) + (record 'cl--random-state -1 30 (cl--random-time))) (defconst cl-most-positive-float nil "The largest value that a Lisp float can hold. -- 2.11.0 From unknown Tue Jun 24 06:58:00 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Christopher Wellons Subject: bug#27617: closed (Re: 26.0.50; cl--random-state initialized to old-style vector) Message-ID: References: <428a890c-b47b-1321-18de-9c7387468284@cs.ucla.edu> <20170708133918.GD17540@nullprogram.com> X-Gnu-PR-Message: they-closed 27617 X-Gnu-PR-Package: emacs Reply-To: 27617@debbugs.gnu.org Date: Fri, 14 Jul 2017 09:51:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1500025862-6242-1" This is a multi-part message in MIME format... ------------=_1500025862-6242-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #27617: 26.0.50; cl--random-state initialized to old-style vector which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 27617@debbugs.gnu.org. --=20 27617: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D27617 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1500025862-6242-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 27617-done) by debbugs.gnu.org; 14 Jul 2017 09:50:52 +0000 Received: from localhost ([127.0.0.1]:37759 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVxFL-0001cD-Nr for submit@debbugs.gnu.org; Fri, 14 Jul 2017 05:50:51 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:51460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dVxFJ-0001bz-5L for 27617-done@debbugs.gnu.org; Fri, 14 Jul 2017 05:50:49 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0178D1601C6; Fri, 14 Jul 2017 02:50:42 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 7HvR2rzqhbjL; Fri, 14 Jul 2017 02:50:41 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 123D8160168; Fri, 14 Jul 2017 02:50:41 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id l0SVCmrT90on; Fri, 14 Jul 2017 02:50:40 -0700 (PDT) Received: from [192.168.1.9] (unknown [47.153.184.153]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id E3FFD1600D7; Fri, 14 Jul 2017 02:50:40 -0700 (PDT) To: Christopher Wellons From: Paul Eggert Subject: Re: 26.0.50; cl--random-state initialized to old-style vector Organization: UCLA Computer Science Department Message-ID: <428a890c-b47b-1321-18de-9c7387468284@cs.ucla.edu> Date: Fri, 14 Jul 2017 02:50:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------6A4EAAD1445C70BF47BF5B32" Content-Language: en-US X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 27617-done Cc: 27617-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) This is a multi-part message in MIME format. --------------6A4EAAD1445C70BF47BF5B32 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for reporting that. I installed the attached, which differs from what you suggested but should also work. --------------6A4EAAD1445C70BF47BF5B32 Content-Type: text/x-patch; name="0001-Remove-duplicate-cl-random-state-definition.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Remove-duplicate-cl-random-state-definition.patch" >From 6443a95ad74d54b8be5ba85af9b893f3f1d5fa02 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 14 Jul 2017 02:47:30 -0700 Subject: [PATCH] Remove duplicate cl--random-state definition * lisp/emacs-lisp/cl-lib.el (cl--random-state): Remove. This variable is now defined in cl-extra.el (Bug#27617). --- lisp/emacs-lisp/cl-lib.el | 3 --- 1 file changed, 3 deletions(-) diff --git a/lisp/emacs-lisp/cl-lib.el b/lisp/emacs-lisp/cl-lib.el index 936c852..3c9c622 100644 --- a/lisp/emacs-lisp/cl-lib.el +++ b/lisp/emacs-lisp/cl-lib.el @@ -293,9 +293,6 @@ cl--random-time (while (>= (cl-decf i) 0) (setq v (+ (* v 3) (aref time i)))) v)) -(defvar cl--random-state - (vector 'cl--random-state-tag -1 30 (cl--random-time))) - (defconst cl-most-positive-float nil "The largest value that a Lisp float can hold. If your system supports infinities, this is the largest finite value. -- 2.7.4 --------------6A4EAAD1445C70BF47BF5B32-- ------------=_1500025862-6242-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Jul 2017 13:39:40 +0000 Received: from localhost ([127.0.0.1]:57421 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTpxT-00054u-Ks for submit@debbugs.gnu.org; Sat, 08 Jul 2017 09:39:39 -0400 Received: from eggs.gnu.org ([208.118.235.92]:42074) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTpxS-00054h-NR for submit@debbugs.gnu.org; Sat, 08 Jul 2017 09:39:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTpxM-0000q6-GB for submit@debbugs.gnu.org; Sat, 08 Jul 2017 09:39:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40398) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dTpxM-0000pe-Bh for submit@debbugs.gnu.org; Sat, 08 Jul 2017 09:39:32 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:32947) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTpxL-0002a6-92 for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 09:39:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTpxI-0000mH-3Y for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 09:39:31 -0400 Received: from mail.nullprogram.com ([192.241.191.137]:32853) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dTpxH-0000kp-Vn for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 09:39:28 -0400 Received: from nullprogram.com (localhost [127.0.0.1]) by mail.nullprogram.com (Postfix) with ESMTPS id 431ACC3C9F for ; Sat, 8 Jul 2017 09:39:19 -0400 (EDT) Date: Sat, 8 Jul 2017 09:39:18 -0400 From: Christopher Wellons To: bug-gnu-emacs@gnu.org Subject: 26.0.50; cl--random-state initialized to old-style vector Message-ID: <20170708133918.GD17540@nullprogram.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline User-Agent: Mutt/1.5.23 (2014-03-12) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) The global variable cl--random-state is still being initialized to the old defstruct vector format. See lisp/emacs-lisp/cl-lib.el:296. This breaks all random number functions when the STATE argument isn't supplied: $ emacs -Q --batch -l cl-lib --eval '(cl-random 10)' Wrong type argument: cl--random-state, [cl--random-state-tag -1 30 ...] ------------=_1500025862-6242-1--