From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 08 07:54:06 2017 Received: (at submit) by debbugs.gnu.org; 8 Jul 2017 11:54:06 +0000 Received: from localhost ([127.0.0.1]:57390 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dToJK-0002kj-69 for submit@debbugs.gnu.org; Sat, 08 Jul 2017 07:54:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53523) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dToJG-0002kC-RJ for submit@debbugs.gnu.org; Sat, 08 Jul 2017 07:54:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dToJA-0002Sx-JN for submit@debbugs.gnu.org; Sat, 08 Jul 2017 07:53:57 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54318) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dToJA-0002Sp-G0 for submit@debbugs.gnu.org; Sat, 08 Jul 2017 07:53:56 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dToJ9-0004CJ-7U for guix-patches@gnu.org; Sat, 08 Jul 2017 07:53:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dToJ5-0002R2-7t for guix-patches@gnu.org; Sat, 08 Jul 2017 07:53:55 -0400 Received: from m12-16.163.com ([220.181.12.16]:51398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dToJ4-0002PA-Bh for guix-patches@gnu.org; Sat, 08 Jul 2017 07:53:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=q+ElM 4FdHCIC/K9N0I3uKykrKJbfe8zw7/81s7x75p4=; b=EXhGDD2YtrTJi17YuEnAj DwEOFQymLP3EgWIgEcpJOr+fIccMXM+GBtQPwvohtysx9Fhtmuwtqq28PM72SmDw SuRz2PVXbm66GHJAb9yRgB7nF+lohpNs5qFXk5CrCM3cgibKPyT/iZ3zlkjCz9Uv 4w8WuxzmpQ1AVKGGYzLJf4= Received: from tumashu (unknown [36.149.40.48]) by smtp12 (Coremail) with SMTP id EMCowADXLPHGx2BZEGahMA--.45033S2; Sat, 08 Jul 2017 19:53:42 +0800 (CST) From: "Feng Shu" To: guix-patches Subject: [PATCH] gnu: you-get: Update to 0.4.775. Date: Sat, 08 Jul 2017 19:53:42 +0800 Message-ID: <87lgnzdu0p.fsf@163.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-CM-TRANSID: EMCowADXLPHGx2BZEGahMA--.45033S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvj4RAZ2TUUUUU X-Originating-IP: [36.149.40.48] X-CM-SenderInfo: 5wxpt2lkx6il2tof0z/1tbiHQYP1FSIU1bqGAAAsr X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit Cc: Feng Shu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-you-get-Update-to-0.4.775.patch >From 395e96f467038358e86d0e3d970055ed7dfce2ba Mon Sep 17 00:00:00 2001 From: Feng Shu Date: Sat, 8 Jul 2017 19:43:13 +0800 Subject: [PATCH] gnu: you-get: Update to 0.4.775. * gnu/packages/video.scm (you-get): Update to 0.4.775. --- gnu/packages/video.scm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index a98a1aa3c..66fce5847 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -1238,15 +1238,15 @@ other site that youtube-dl supports.") (define-public you-get (package (name "you-get") - (version "0.4.715") + (version "0.4.775") (source (origin (method url-fetch) (uri (string-append - "https://github.com/soimort/you-get/releases/download/v" - version "/you-get-" version ".tar.gz")) + "https://github.com/soimort/you-get/archive/v" + version ".tar.gz")) (sha256 (base32 - "043122hfh56fbbszp1kwd1f65asgyn60j1ijday93hf2dkhvbrnh")))) + "1pjjv42c9bysnj8s3c6v0g6b00lr7b21y8ypibnzd6z0jxlsq7sz")))) (build-system python-build-system) (arguments ;; no tests -- 2.13.2 --=-=-= Content-Type: text/plain -- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 08 08:37:33 2017 Received: (at 27616) by debbugs.gnu.org; 8 Jul 2017 12:37:33 +0000 Received: from localhost ([127.0.0.1]:57407 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTozN-0003iR-EI for submit@debbugs.gnu.org; Sat, 08 Jul 2017 08:37:33 -0400 Received: from mailhub1.soe.uq.edu.au ([130.102.132.208]:33096 helo=newmailhub.uq.edu.au) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTozI-0003iD-9m for 27616@debbugs.gnu.org; Sat, 08 Jul 2017 08:37:30 -0400 Received: from smtp2.soe.uq.edu.au (smtp2.soe.uq.edu.au [10.138.113.41]) by newmailhub.uq.edu.au (8.14.5/8.14.5) with ESMTP id v68CbFJH025211; Sat, 8 Jul 2017 22:37:15 +1000 Received: from [192.168.1.105] (static.customers.nuskope.com.au [103.25.181.216] (may be forged)) (authenticated bits=0) by smtp2.soe.uq.edu.au (8.14.5/8.14.5) with ESMTP id v68CbDXU060294 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sat, 8 Jul 2017 22:37:15 +1000 Subject: Re: [bug#27616] [PATCH] gnu: you-get: Update to 0.4.775. To: Feng Shu , 27616@debbugs.gnu.org References: <87lgnzdu0p.fsf@163.com> From: Ben Woodcroft Message-ID: Date: Sat, 8 Jul 2017 22:37:13 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <87lgnzdu0p.fsf@163.com> Content-Type: multipart/alternative; boundary="------------9FE49DBFBD74DCA6E6EB389B" Content-Language: en-US X-UQ-FilterTime: 1499517438 X-Scanned-By: MIMEDefang 2.73 on UQ Mailhub X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 27616 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------9FE49DBFBD74DCA6E6EB389B Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Hi Feng, thanks for the patch. On 08/07/17 21:53, Feng Shu wrote: > - (version "0.4.715") > + (version "0.4.775") > (source (origin > (method url-fetch) > (uri (string-append > -"https://github.com/soimort/you-get/releases/download/v" > - version "/you-get-" version ".tar.gz")) > +"https://github.com/soimort/you-get/archive/v" > + version ".tar.gz")) Here, the downloaded filename is "v0.4.775.tar.gz", which doesn't contain "you-get" anymore (we prefer it does so the base directory doesn't fill with opaque names, and this is checked by 'guix lint'). We usually fix this by adding (file-name (string-append name "-" version ".tar.gz")) to the package definition. However, is there some reason why the URL scheme should be changed? Alternatively, we could also source this package from PyPI given that is recommended on the you-get website. WDYT? Thanks, ben. --------------9FE49DBFBD74DCA6E6EB389B Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: 7bit

Hi Feng, thanks for the patch.


On 08/07/17 21:53, Feng Shu wrote:
-    (version "0.4.715")
+    (version "0.4.775")
     (source (origin
               (method url-fetch)
               (uri (string-append
-                    "https://github.com/soimort/you-get/releases/download/v"
-                    version "/you-get-" version ".tar.gz"))
+                    "https://github.com/soimort/you-get/archive/v"
+                    version ".tar.gz"))
Here, the downloaded filename is "v0.4.775.tar.gz", which doesn't contain "you-get" anymore (we prefer it does so the base directory doesn't fill with opaque names, and this is checked by 'guix lint'). We usually fix this by adding

(file-name (string-append name "-" version ".tar.gz"))

to the package definition. However, is there some reason why the URL scheme should be changed? Alternatively, we could also source this package from PyPI given that is recommended on the you-get website. WDYT?

Thanks, ben.
--------------9FE49DBFBD74DCA6E6EB389B-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 08 09:13:46 2017 Received: (at 27616) by debbugs.gnu.org; 8 Jul 2017 13:13:46 +0000 Received: from localhost ([127.0.0.1]:57414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTpYQ-0004VC-Dg for submit@debbugs.gnu.org; Sat, 08 Jul 2017 09:13:46 -0400 Received: from m12-15.163.com ([220.181.12.15]:36636) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTpYN-0004Uy-MD for 27616@debbugs.gnu.org; Sat, 08 Jul 2017 09:13:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-ID:MIME-Version; bh=i8I2q 0vOeui0IierNwJ9FfPlnE9mDv3oDhXxfJPxbVM=; b=UEYxYf+u2PDfiYUggJB72 99iLoobZ6M2p8t7AD5ojnoBS9jBVRI6QYMdUDKO0hq4cw+/VSHYHg0iLTU+d6QmP p0A9PohmTJ4tJwsxcky5FuCDkJsWwEyr2Pk3sC4QrHAMtdRvqlzqVbinaVo7af2X 7H45WR+G9MI89f5EXGhpJw= Received: from tumashu (unknown [36.149.40.48]) by smtp11 (Coremail) with SMTP id D8CowACnrlJ12mBZHJBjOw--.54655S2; Sat, 08 Jul 2017 21:13:26 +0800 (CST) From: "Feng Shu" To: 27616@debbugs.gnu.org Subject: Update you-get patch, add file-name Date: Sat, 08 Jul 2017 21:13:25 +0800 Message-ID: <87h8yndqbu.fsf@163.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-CM-TRANSID: D8CowACnrlJ12mBZHJBjOw--.54655S2 X-Coremail-Antispam: 1Uf129KBjDUn29KB7ZKAUJUUUUU529EdanIXcx71UUUUU7v73 VFW2AGmfu7bjvjm3AaLaJ3UbIYCTnIWIevJa73UjIFyTuYvjxUjxhpUUUUU X-Originating-IP: [36.149.40.48] X-CM-SenderInfo: 5wxpt2lkx6il2tof0z/1tbiqwMP1FUMFCj4mwABs0 X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 27616 Cc: Feng Shu X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --=-=-= Content-Type: text/plain Update patch, add file-name --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-gnu-you-get-Update-to-0.4.775.patch >From 544d4b3f8d8f0c5595fba083b6aaf33ebd4d7bda Mon Sep 17 00:00:00 2001 From: Feng Shu Date: Sat, 8 Jul 2017 19:43:13 +0800 Subject: [PATCH] gnu: you-get: Update to 0.4.775. * gnu/packages/video.scm (you-get): Update to 0.4.775. --- gnu/packages/video.scm | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index a98a1aa3c..b90534b4c 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -1238,15 +1238,16 @@ other site that youtube-dl supports.") (define-public you-get (package (name "you-get") - (version "0.4.715") + (version "0.4.775") (source (origin (method url-fetch) (uri (string-append - "https://github.com/soimort/you-get/releases/download/v" - version "/you-get-" version ".tar.gz")) + "https://github.com/soimort/you-get/archive/v" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) (sha256 (base32 - "043122hfh56fbbszp1kwd1f65asgyn60j1ijday93hf2dkhvbrnh")))) + "1pjjv42c9bysnj8s3c6v0g6b00lr7b21y8ypibnzd6z0jxlsq7sz")))) (build-system python-build-system) (arguments ;; no tests -- 2.13.2 --=-=-= Content-Type: text/plain -- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 09 07:32:20 2017 Received: (at 27616-done) by debbugs.gnu.org; 9 Jul 2017 11:32:20 +0000 Received: from localhost ([127.0.0.1]:58458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUARo-0004JK-4Z for submit@debbugs.gnu.org; Sun, 09 Jul 2017 07:32:20 -0400 Received: from mailhub2.soe.uq.edu.au ([130.102.132.209]:60269 helo=newmailhub.uq.edu.au) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUARl-0004J8-Ho for 27616-done@debbugs.gnu.org; Sun, 09 Jul 2017 07:32:18 -0400 Received: from smtp1.soe.uq.edu.au (smtp1.soe.uq.edu.au [10.138.113.40]) by newmailhub.uq.edu.au (8.14.5/8.14.5) with ESMTP id v69BWA90000968; Sun, 9 Jul 2017 21:32:10 +1000 Received: from [192.168.1.105] (static.customers.nuskope.com.au [103.25.181.216] (may be forged)) (authenticated bits=0) by smtp1.soe.uq.edu.au (8.14.5/8.14.5) with ESMTP id v69BW8X0043301 (version=TLSv1.2 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 9 Jul 2017 21:32:10 +1000 Subject: Re: [bug#27616] Update you-get patch, add file-name To: Feng Shu , 27616-done@debbugs.gnu.org References: <87lgnzdu0p.fsf@163.com> <87h8yndqbu.fsf@163.com> From: Ben Woodcroft Message-ID: Date: Sun, 9 Jul 2017 21:32:08 +1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <87h8yndqbu.fsf@163.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-UQ-FilterTime: 1499599931 X-Scanned-By: MIMEDefang 2.73 on UQ Mailhub X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 27616-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 08/07/17 23:13, Feng Shu wrote: > Update patch, add file-name Thanks, pushed as e2155f58c0b670f495da4a3a0308d5054cf060b0. ben From unknown Tue Jun 24 17:28:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 07 Aug 2017 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator