GNU bug report logs - #27597
[PATCH] fix warnings in src/xdisp.c

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alexander Kuleshov <kuleshovmail <at> gmail.com>
Subject: bug#27597: closed (Re: bug#27597: [PATCH] fix warnings in
 src/xdisp.c)
Date: Sat, 08 Jul 2017 08:20:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#27597: [PATCH] fix warnings in src/xdisp.c

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 27597 <at> debbugs.gnu.org.

-- 
27597: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27597
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alexander Kuleshov <kuleshovmail <at> gmail.com>
Cc: 27597-done <at> debbugs.gnu.org
Subject: Re: bug#27597: [PATCH] fix warnings in src/xdisp.c
Date: Sat, 08 Jul 2017 11:19:32 +0300

> From: Alexander Kuleshov <kuleshovmail <at> gmail.com>
> Date: Thu, 6 Jul 2017 17:47:03 +0600
> 
> here is simple fix for following warnings:
> 
> xdisp.c: In function ‘Fdump_glyph_matrix’:
> xdisp.c:19320:20: error: format ‘%lld’ expects argument of type ‘long
> long int’, but argument 3 has type ‘ptrdiff_t {aka long int}’
> [-Werror=format=]
>    fprintf (stderr, "PT = %"pI"d, BEGV = %"pI"d. ZV = %"pI"d\n",
> 
> from src/xdisp.c

Thanks, pushed to master.

In the future, please provide a commit log message that is according
to our coding standards:

 . mention the names of functions in which you make changes
 . start sentences with a capital letter
 . mention the bug number

Here's the log message I used in this case:

	* src/xdisp.c (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
	Use pD directives for ptrdiff_t values instead of pI, to avoid
	compilation warnings on 64-bit hosts.  (Bug#27597)

[Message part 3 (message/rfc822, inline)]

From: Alexander Kuleshov <kuleshovmail <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] fix warnings in src/xdisp.c
Date: Thu, 6 Jul 2017 17:47:03 +0600

[Message part 4 (text/plain, inline)]

Hello,

here is simple fix for following warnings:

xdisp.c: In function ‘Fdump_glyph_matrix’:
xdisp.c:19320:20: error: format ‘%lld’ expects argument of type ‘long
long int’, but argument 3 has type ‘ptrdiff_t {aka long int}’
[-Werror=format=]
   fprintf (stderr, "PT = %"pI"d, BEGV = %"pI"d. ZV = %"pI"d\n",

from src/xdisp.c

[0001-use-pD-directives-for-ptrdiff_t-values-to-get-rid-fr.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.