GNU bug report logs - #27597
[PATCH] fix warnings in src/xdisp.c

Previous Next

Full log

View this message in rfc822 format

From: Alexander Kuleshov <kuleshovmail <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 27597-done <at> debbugs.gnu.org
Subject: bug#27597: [PATCH] fix warnings in src/xdisp.c
Date: Sat, 8 Jul 2017 16:28:48 +0600

On Sat, Jul 8, 2017 at 2:19 PM, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> From: Alexander Kuleshov <kuleshovmail <at> gmail.com>
>> Date: Thu, 6 Jul 2017 17:47:03 +0600
>>
>> here is simple fix for following warnings:
>>
>> xdisp.c: In function ‘Fdump_glyph_matrix’:
>> xdisp.c:19320:20: error: format ‘%lld’ expects argument of type ‘long
>> long int’, but argument 3 has type ‘ptrdiff_t {aka long int}’
>> [-Werror=format=]
>>    fprintf (stderr, "PT = %"pI"d, BEGV = %"pI"d. ZV = %"pI"d\n",
>>
>> from src/xdisp.c
>
> Thanks, pushed to master.
>
> In the future, please provide a commit log message that is according
> to our coding standards:
>
>  . mention the names of functions in which you make changes
>  . start sentences with a capital letter
>  . mention the bug number
>
> Here's the log message I used in this case:
>
>         * src/xdisp.c (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
>         Use pD directives for ptrdiff_t values instead of pI, to avoid
>         compilation warnings on 64-bit hosts.  (Bug#27597)
>

Hello Eli,

Yes, thanks, I'll take into account code style next time.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.