From unknown Mon Aug 18 19:31:32 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#27597 <27597@debbugs.gnu.org> To: bug#27597 <27597@debbugs.gnu.org> Subject: Status: [PATCH] fix warnings in src/xdisp.c Reply-To: bug#27597 <27597@debbugs.gnu.org> Date: Tue, 19 Aug 2025 02:31:32 +0000 retitle 27597 [PATCH] fix warnings in src/xdisp.c reassign 27597 emacs submitter 27597 Alexander Kuleshov severity 27597 minor tag 27597 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Jul 06 07:47:38 2017 Received: (at submit) by debbugs.gnu.org; 6 Jul 2017 11:47:38 +0000 Received: from localhost ([127.0.0.1]:54289 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dT5Fy-0001UK-K3 for submit@debbugs.gnu.org; Thu, 06 Jul 2017 07:47:38 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39619) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dT5Fw-0001U6-Cm for submit@debbugs.gnu.org; Thu, 06 Jul 2017 07:47:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dT5Fq-0005Xl-5Z for submit@debbugs.gnu.org; Thu, 06 Jul 2017 07:47:31 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36194) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dT5Fq-0005Xh-1Z for submit@debbugs.gnu.org; Thu, 06 Jul 2017 07:47:30 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58818) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dT5Fo-000617-O4 for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2017 07:47:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dT5Fn-0005XN-M4 for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2017 07:47:28 -0400 Received: from mail-lf0-x22f.google.com ([2a00:1450:4010:c07::22f]:34872) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dT5Fn-0005X0-92 for bug-gnu-emacs@gnu.org; Thu, 06 Jul 2017 07:47:27 -0400 Received: by mail-lf0-x22f.google.com with SMTP id b207so11584374lfg.2 for ; Thu, 06 Jul 2017 04:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=Kioe8H25NQn0LxRsdC84AIW9hrVmviXg3o1QgQB1Z9o=; b=H6IzbjjUCi1Gfg//vnJ9frk/gWs/tUH6S8ixgpNWhZwyzDl/F9Ww3mrsQBCzpkVsJ9 1tsUd6RXx2bAQAz1I3Lzx0WBAu/quyICTgwGoo2nYSfoZ1IKGuVBoPX4PkmfBtIi+D8N EH8JPKV7XurYhzSZdboNDtYoGM7b9J0pYquxsAOz5hTwpwQU/EhIVLfPsz+UAkLXuBXj ovxUUZoUr1z5uIvtNMCfP+M3AFb4oBLWaz8NNC0N7P8y40IWeQ8Ri3gG3TV9LwRSHeq4 zO4Wq0KexZN+8/nqrLhD5HKkOrQazZYG6IBQkiGJV4uL9iSP52rNd2bjAP9+p8eb2SVH 1vww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Kioe8H25NQn0LxRsdC84AIW9hrVmviXg3o1QgQB1Z9o=; b=f79fDeekT6FzYp31ygCBtXH1J26bLcI55tpk2Jdr9hRYSON6ffc+jq2R4GCa4YI3uP kbqJ5nA7Px1abHZTC4gjhgVVRWSCF9lmQqM8A/kSutOmzskknCR+IZvj15cGwBCg7L1c jXOmyEYZiQGg9yTvsQOS82Y74bSykPMHjKmvqSWfOwrbq/+V1/VwQDCsUOQ3RrWw92si 0W4reO9OqbEiHAh2RxNZqk2rXiSj8h/2zccrxvzWbI9gyD+H0sYpMlJOkk9QeO/M6xWD 5nl7I5hDYk4w5A6gBDaKjJGB1HOZ0IIfmeV/4mc9boipuFpeWAYaXjIT8XFDHxe7AEqc 8PQg== X-Gm-Message-State: AKS2vOyZX9ygyoFp7nLrPOwgGOEhtb6p20RD80qDZXwHX/r2WcjNau78 NWhYs74kYSGI9BO8Xn9xI/N2YKQzqLgq X-Received: by 10.46.84.74 with SMTP id y10mr12924750ljd.77.1499341644064; Thu, 06 Jul 2017 04:47:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.27.131 with HTTP; Thu, 6 Jul 2017 04:47:03 -0700 (PDT) From: Alexander Kuleshov Date: Thu, 6 Jul 2017 17:47:03 +0600 Message-ID: Subject: [PATCH] fix warnings in src/xdisp.c To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="f403045fb4ce178c550553a4ae57" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --f403045fb4ce178c550553a4ae57 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, here is simple fix for following warnings: xdisp.c: In function =E2=80=98Fdump_glyph_matrix=E2=80=99: xdisp.c:19320:20: error: format =E2=80=98%lld=E2=80=99 expects argument of = type =E2=80=98long long int=E2=80=99, but argument 3 has type =E2=80=98ptrdiff_t {aka long int= }=E2=80=99 [-Werror=3Dformat=3D] fprintf (stderr, "PT =3D %"pI"d, BEGV =3D %"pI"d. ZV =3D %"pI"d\n", from src/xdisp.c --f403045fb4ce178c550553a4ae57 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-use-pD-directives-for-ptrdiff_t-values-to-get-rid-fr.patch" Content-Disposition: attachment; filename="0001-use-pD-directives-for-ptrdiff_t-values-to-get-rid-fr.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: f_j4sda68g0 RnJvbSA4MmJlYjk4NGFhNGQ1MDA5ZDA1MzVkNDFmMmRlNDFiZjI5OTJkZWI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbGV4YW5kZXIgS3VsZXNob3YgPGt1bGVzaG92bWFpbEBnbWFp bC5jb20+CkRhdGU6IFRodSwgNiBKdWwgMjAxNyAxNzozOTo1MSArMDYwMApTdWJqZWN0OiBbUEFU Q0hdIHVzZSBwRCBkaXJlY3RpdmVzIGZvciBwdHJkaWZmX3QgdmFsdWVzIHRvIGdldCByaWQgZnJv bQogd2FybmluZ3MKCiAgKiBzcmMveGRpc3AuYzogdXNlIHBEIGRpcmVjdGl2ZXMgZm9yIHB0cmRp ZmZfdCB2YWx1ZXMgaW5zdGVhZCBvZgpwSQotLS0KIHNyYy94ZGlzcC5jIHwgMTQgKysrKysrKy0t LS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKyksIDcgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvc3JjL3hkaXNwLmMgYi9zcmMveGRpc3AuYwppbmRleCA4YmM1ZDgxLi45NWQz Nzg0IDEwMDY0NAotLS0gYS9zcmMveGRpc3AuYworKysgYi9zcmMveGRpc3AuYwpAQCAtMTkwODMs NyArMTkwODMsNyBAQCBkdW1wX2dseXBoIChzdHJ1Y3QgZ2x5cGhfcm93ICpyb3csIHN0cnVjdCBn bHlwaCAqZ2x5cGgsIGludCBhcmVhKQogICAgICAgfHwgZ2x5cGgtPnR5cGUgPT0gR0xZUEhMRVNT X0dMWVBIKQogICAgIHsKICAgICAgIGZwcmludGYgKHN0ZGVyciwKLQkgICAgICAgIiAgJTUicEQi ZCAgICAgJWMgJTkicEkiZCAgICVjICUzZCAweCUwNnggICAgICAlYyAlNGQgJTEuMWQlMS4xZFxu IiwKKwkgICAgICAgIiAgJTUicEQiZCAgICAgJWMgJTkicEQiZCAgICVjICUzZCAweCUwNnggICAg ICAlYyAlNGQgJTEuMWQlMS4xZFxuIiwKIAkgICAgICAgZ2x5cGggLSByb3ctPmdseXBoc1tURVhU X0FSRUFdLAogCSAgICAgICAoZ2x5cGgtPnR5cGUgPT0gQ0hBUl9HTFlQSAogCQk/ICdDJwpAQCAt MTkxMDgsNyArMTkxMDgsNyBAQCBkdW1wX2dseXBoIChzdHJ1Y3QgZ2x5cGhfcm93ICpyb3csIHN0 cnVjdCBnbHlwaCAqZ2x5cGgsIGludCBhcmVhKQogICBlbHNlIGlmIChnbHlwaC0+dHlwZSA9PSBT VFJFVENIX0dMWVBIKQogICAgIHsKICAgICAgIGZwcmludGYgKHN0ZGVyciwKLQkgICAgICAgIiAg JTUicEQiZCAgICAgJWMgJTkicEkiZCAgICVjICUzZCAweCUwNnggICAgICAlYyAlNGQgJTEuMWQl MS4xZFxuIiwKKwkgICAgICAgIiAgJTUicEQiZCAgICAgJWMgJTkicEQiZCAgICVjICUzZCAweCUw NnggICAgICAlYyAlNGQgJTEuMWQlMS4xZFxuIiwKIAkgICAgICAgZ2x5cGggLSByb3ctPmdseXBo c1tURVhUX0FSRUFdLAogCSAgICAgICAnUycsCiAJICAgICAgIGdseXBoLT5jaGFycG9zLApAQCAt MTkxMjksNyArMTkxMjksNyBAQCBkdW1wX2dseXBoIChzdHJ1Y3QgZ2x5cGhfcm93ICpyb3csIHN0 cnVjdCBnbHlwaCAqZ2x5cGgsIGludCBhcmVhKQogICBlbHNlIGlmIChnbHlwaC0+dHlwZSA9PSBJ TUFHRV9HTFlQSCkKICAgICB7CiAgICAgICBmcHJpbnRmIChzdGRlcnIsCi0JICAgICAgICIgICU1 InBEImQgICAgICVjICU5InBJImQgICAlYyAlM2QgMHglMDZ4ICAgICAgJWMgJTRkICUxLjFkJTEu MWRcbiIsCisJICAgICAgICIgICU1InBEImQgICAgICVjICU5InBEImQgICAlYyAlM2QgMHglMDZ4 ICAgICAgJWMgJTRkICUxLjFkJTEuMWRcbiIsCiAJICAgICAgIGdseXBoIC0gcm93LT5nbHlwaHNb VEVYVF9BUkVBXSwKIAkgICAgICAgJ0knLAogCSAgICAgICBnbHlwaC0+Y2hhcnBvcywKQEAgLTE5 MTUwLDcgKzE5MTUwLDcgQEAgZHVtcF9nbHlwaCAoc3RydWN0IGdseXBoX3JvdyAqcm93LCBzdHJ1 Y3QgZ2x5cGggKmdseXBoLCBpbnQgYXJlYSkKICAgZWxzZSBpZiAoZ2x5cGgtPnR5cGUgPT0gQ09N UE9TSVRFX0dMWVBIKQogICAgIHsKICAgICAgIGZwcmludGYgKHN0ZGVyciwKLQkgICAgICAgIiAg JTUicEQiZCAgICAgJWMgJTkicEkiZCAgICVjICUzZCAweCUwNngiLAorCSAgICAgICAiICAlNSJw RCJkICAgICAlYyAlOSJwRCJkICAgJWMgJTNkIDB4JTA2eCIsCiAJICAgICAgIGdseXBoIC0gcm93 LT5nbHlwaHNbVEVYVF9BUkVBXSwKIAkgICAgICAgJysnLAogCSAgICAgICBnbHlwaC0+Y2hhcnBv cywKQEAgLTE5MjExLDcgKzE5MjExLDcgQEAgZHVtcF9nbHlwaF9yb3cgKHN0cnVjdCBnbHlwaF9y b3cgKnJvdywgaW50IHZwb3MsIGludCBnbHlwaHMpCiAgICAgICBmcHJpbnRmIChzdGRlcnIsICJS b3cgICAgIFN0YXJ0ICAgICAgIEVuZCBVc2VkIG9FPjxcXENUWkZlc20gICAgIFggICAgWSAgICBX ICAgIEggICAgViAgICBBICAgIFBcbiIpOwogICAgICAgZnByaW50ZiAoc3RkZXJyLCAiPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09XG4iKTsKIAotICAgICAgZnByaW50ZiAoc3RkZXJyLCAiJTNkICU5InBJ ImQgJTkicEkiZCAlNGQgJTEuMWQlMS4xZCUxLjFkJTEuMWRcCisgICAgICBmcHJpbnRmIChzdGRl cnIsICIlM2QgJTkicEQiZCAlOSJwRCJkICU0ZCAlMS4xZCUxLjFkJTEuMWQlMS4xZFwKICUxLjFk JTEuMWQlMS4xZCUxLjFkJTEuMWQlMS4xZCUxLjFkJTEuMWQgICU0ZCAlNGQgJTRkICU0ZCAlNGQg JTRkICU0ZFxuIiwKIAkgICAgICAgdnBvcywKIAkgICAgICAgTUFUUklYX1JPV19TVEFSVF9DSEFS UE9TIChyb3cpLApAQCAtMTkyNDAsNyArMTkyNDAsNyBAQCBkdW1wX2dseXBoX3JvdyAoc3RydWN0 IGdseXBoX3JvdyAqcm93LCBpbnQgdnBvcywgaW50IGdseXBocykKICAgICAgIGZwcmludGYgKHN0 ZGVyciwgIiAgICAlOSJwRCJkICU5InBEImRcdCU1ZFxuIiwgcm93LT5zdGFydC5vdmVybGF5X3N0 cmluZ19pbmRleCwKIAkgICAgICAgcm93LT5lbmQub3ZlcmxheV9zdHJpbmdfaW5kZXgsCiAJICAg ICAgIHJvdy0+Y29udGludWF0aW9uX2xpbmVzX3dpZHRoKTsKLSAgICAgIGZwcmludGYgKHN0ZGVy ciwgIiAgICAlOSJwSSJkICU5InBJImRcbiIsCisgICAgICBmcHJpbnRmIChzdGRlcnIsICIgICAg JTkicEQiZCAlOSJwRCJkXG4iLAogCSAgICAgICBDSEFSUE9TIChyb3ctPnN0YXJ0LnN0cmluZ19w b3MpLAogCSAgICAgICBDSEFSUE9TIChyb3ctPmVuZC5zdHJpbmdfcG9zKSk7CiAgICAgICBmcHJp bnRmIChzdGRlcnIsICIgICAgJTlkICU5ZFxuIiwgcm93LT5zdGFydC5kcHZlY19pbmRleCwKQEAg LTE5MzE3LDcgKzE5MzE3LDcgQEAgd2l0aCBudW1lcmljIGFyZ3VtZW50LCBpdHMgdmFsdWUgaXMg cGFzc2VkIGFzIHRoZSBHTFlQSFMgZmxhZy4gICovKQogICBzdHJ1Y3Qgd2luZG93ICp3ID0gWFdJ TkRPVyAoc2VsZWN0ZWRfd2luZG93KTsKICAgc3RydWN0IGJ1ZmZlciAqYnVmZmVyID0gWEJVRkZF UiAody0+Y29udGVudHMpOwogCi0gIGZwcmludGYgKHN0ZGVyciwgIlBUID0gJSJwSSJkLCBCRUdW ID0gJSJwSSJkLiBaViA9ICUicEkiZFxuIiwKKyAgZnByaW50ZiAoc3RkZXJyLCAiUFQgPSAlInBE ImQsIEJFR1YgPSAlInBEImQuIFpWID0gJSJwRCJkXG4iLAogCSAgIEJVRl9QVCAoYnVmZmVyKSwg QlVGX0JFR1YgKGJ1ZmZlciksIEJVRl9aViAoYnVmZmVyKSk7CiAgIGZwcmludGYgKHN0ZGVyciwg IkN1cnNvciB4ID0gJWQsIHkgPSAlZCwgaHBvcyA9ICVkLCB2cG9zID0gJWRcbiIsCiAJICAgdy0+ Y3Vyc29yLngsIHctPmN1cnNvci55LCB3LT5jdXJzb3IuaHBvcywgdy0+Y3Vyc29yLnZwb3MpOwot LSAKMi45LjAuR0lUCgo= --f403045fb4ce178c550553a4ae57-- From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 08 04:19:56 2017 Received: (at 27597-done) by debbugs.gnu.org; 8 Jul 2017 08:19:57 +0000 Received: from localhost ([127.0.0.1]:57275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTky4-0004Vd-Ng for submit@debbugs.gnu.org; Sat, 08 Jul 2017 04:19:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:57643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTky2-0004VO-Si for 27597-done@debbugs.gnu.org; Sat, 08 Jul 2017 04:19:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTkxq-00082n-VJ for 27597-done@debbugs.gnu.org; Sat, 08 Jul 2017 04:19:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTkxq-00082h-RY; Sat, 08 Jul 2017 04:19:42 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1610 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dTkxq-0002hW-60; Sat, 08 Jul 2017 04:19:42 -0400 Date: Sat, 08 Jul 2017 11:19:32 +0300 Message-Id: <83h8ynl4rv.fsf@gnu.org> From: Eli Zaretskii To: Alexander Kuleshov In-reply-to: (message from Alexander Kuleshov on Thu, 6 Jul 2017 17:47:03 +0600) Subject: Re: bug#27597: [PATCH] fix warnings in src/xdisp.c References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27597-done Cc: 27597-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Alexander Kuleshov > Date: Thu, 6 Jul 2017 17:47:03 +0600 > > here is simple fix for following warnings: > > xdisp.c: In function ‘Fdump_glyph_matrix’: > xdisp.c:19320:20: error: format ‘%lld’ expects argument of type ‘long > long int’, but argument 3 has type ‘ptrdiff_t {aka long int}’ > [-Werror=format=] > fprintf (stderr, "PT = %"pI"d, BEGV = %"pI"d. ZV = %"pI"d\n", > > from src/xdisp.c Thanks, pushed to master. In the future, please provide a commit log message that is according to our coding standards: . mention the names of functions in which you make changes . start sentences with a capital letter . mention the bug number Here's the log message I used in this case: * src/xdisp.c (dump_glyph, dump_glyph_row, Fdump_glyph_matrix): Use pD directives for ptrdiff_t values instead of pI, to avoid compilation warnings on 64-bit hosts. (Bug#27597) From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 08 06:29:17 2017 Received: (at 27597-done) by debbugs.gnu.org; 8 Jul 2017 10:29:17 +0000 Received: from localhost ([127.0.0.1]:57329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTmzE-0007TC-Rb for submit@debbugs.gnu.org; Sat, 08 Jul 2017 06:29:17 -0400 Received: from mail-lf0-f46.google.com ([209.85.215.46]:36660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTmzC-0007T0-Oh for 27597-done@debbugs.gnu.org; Sat, 08 Jul 2017 06:29:15 -0400 Received: by mail-lf0-f46.google.com with SMTP id h22so36791378lfk.3 for <27597-done@debbugs.gnu.org>; Sat, 08 Jul 2017 03:29:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=kFZuTwRHyHjd9MmnRjr+utust1uduWrx6/C39ia7Kvk=; b=NqoQ9BPxXMkVkiBHc7oliSvoINKchksmSQEA/F0WvVgSzp/75c+DEIidk/TTcjtDxg BFyCkC/9eDxMfp7zEScwb95V0Qotd7b+3EfL58oN20MbZMeTX/cVWZJUiKIgU4vKiULr G64fb78ue0dxrVvNMbwscScU/YV9m2dV3jJlF+2VRVXH/8evnPWB3s7/P4N5Nc8K6VWu IB/8gsOsG9vW1dTt2RVqc1HzWvKo+Jz9zumF5f+aQIa8MrS904+RTGGH/QM1dGAYzfy/ 0chGv0tuK4W7NfZHLJ/k1sTjbGKe2Pui/NoM8WUUnjyXTs1aI0e6kk3Ey5xh+wVe+KJD dD+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=kFZuTwRHyHjd9MmnRjr+utust1uduWrx6/C39ia7Kvk=; b=iNhea9CVMegLl+z1NZ4TYf7j4qK466CI69glYVmbrL+JOXJBU+dRhlc7AeGbuqwPkw kvovtSKRsoCfmWIUAUoIt12MwObtZiejYqt5JP650SsnV/7Oh7qraeMy/ZxWDbqA7Om7 kTpAxbQ3PrK7n2g2UofL9WmPwqLSFL7xa0Yjgu6gm+sr5Gt+Oa/K9sqOYSmSupbtmsXw sCiczDWjfa8R+32e6PS79GDHYMpDdtTwIYMRHVoKESyUEFE4BtiRbNSdTgGNetpkue1i ZKI7Db8HndNYBPdjyqKlPeQ4TWDd5NHkFT0jkJuMaqxvVK71d1WxWso0QtMy/JxUzSZ/ mwJA== X-Gm-Message-State: AKS2vOwqtUa98DzkvvnvfVAJ92O5n/4Qlu0AV43k6O3U3UQLE9LDilRw qNSMCBXJGrLBeEPQvh+yDyCfN98T1A== X-Received: by 10.25.25.65 with SMTP id 62mr21764181lfz.91.1499509748736; Sat, 08 Jul 2017 03:29:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.25.27.131 with HTTP; Sat, 8 Jul 2017 03:28:48 -0700 (PDT) In-Reply-To: <83h8ynl4rv.fsf@gnu.org> References: <83h8ynl4rv.fsf@gnu.org> From: Alexander Kuleshov Date: Sat, 8 Jul 2017 16:28:48 +0600 Message-ID: Subject: Re: bug#27597: [PATCH] fix warnings in src/xdisp.c To: Eli Zaretskii Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 27597-done Cc: 27597-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Sat, Jul 8, 2017 at 2:19 PM, Eli Zaretskii wrote: >> From: Alexander Kuleshov >> Date: Thu, 6 Jul 2017 17:47:03 +0600 >> >> here is simple fix for following warnings: >> >> xdisp.c: In function =E2=80=98Fdump_glyph_matrix=E2=80=99: >> xdisp.c:19320:20: error: format =E2=80=98%lld=E2=80=99 expects argument = of type =E2=80=98long >> long int=E2=80=99, but argument 3 has type =E2=80=98ptrdiff_t {aka long = int}=E2=80=99 >> [-Werror=3Dformat=3D] >> fprintf (stderr, "PT =3D %"pI"d, BEGV =3D %"pI"d. ZV =3D %"pI"d\n", >> >> from src/xdisp.c > > Thanks, pushed to master. > > In the future, please provide a commit log message that is according > to our coding standards: > > . mention the names of functions in which you make changes > . start sentences with a capital letter > . mention the bug number > > Here's the log message I used in this case: > > * src/xdisp.c (dump_glyph, dump_glyph_row, Fdump_glyph_matrix): > Use pD directives for ptrdiff_t values instead of pI, to avoid > compilation warnings on 64-bit hosts. (Bug#27597) > Hello Eli, Yes, thanks, I'll take into account code style next time. From unknown Mon Aug 18 19:31:32 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 05 Aug 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator