Subject: Re: [bug#27588] [PATCH] Add java-commons-cli-1.2.

From: [email-masked] (Ludovic Courtès)
Date: Thu, 20 Jul 2017 11:00:48 +0200

Hi Gábor,

Gábor Boskovits <[email-masked]> skribis:

> * gnu/packages/java.scm(java-commons-cli-1.2): New variable.

I made the cosmetic changes shown below and committed.

Thanks,
Ludo’.

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index fa8bd4be3..de992c649 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -4673,15 +4673,15 @@ transformations and analysis algorithms allow to easily assemble custom
 complex transformations and code analysis tools.")
     (license license:bsd-3)))
 
-;;maven2 bootstrap dependecies
 (define-public java-commons-cli-1.2
-  (package (inherit java-commons-cli)
-    (name "java-commons-cli-1.2")
+  ;; This is a bootstrap dependency for Maven2.
+  (package
+    (inherit java-commons-cli)
     (version "1.2")
     (source (origin
               (method url-fetch)
-              (uri (string-append "http://archive.apache.org/dist/commons/cli/"
-                                  "source/commons-cli-" version "-src.tar.gz"))
+              (uri (string-append "mirror://apache/commons/cli/source/"
+                                  "commons-cli-" version "-src.tar.gz"))
               (sha256
                (base32
                 "0rvfgzgv2pc1m091dfj3ih9ddsjjppr1f1wf0qmc3bk6b1kwv2dm"))))
@@ -4692,7 +4692,8 @@ complex transformations and code analysis tools.")
          (add-before 'check 'fix-build-xml
            (lambda* (#:key inputs #:allow-other-keys)
              (substitute* "build.xml"
-               (("dir=\"\\$\\{test.home\\}/java\"") "dir=\"${test.home}\"")))))))
+               (("dir=\"\\$\\{test.home\\}/java\"")
+                "dir=\"${test.home}\""))
+             #t)))))
     (native-inputs
      `(("java-junit" ,java-junit)))))
-;;end of maven2 bootstrap dependecies