Subject: bug#27588: closed (Re: [bug#27588] [PATCH] Add java-commons-cli-1.2.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 20 Jul 2017 09:02:02 +0000

Your bug report

#27588: [PATCH] Add java-commons-cli-1.2.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
27588: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27588
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#27588] [PATCH] Add java-commons-cli-1.2.
From: [email-masked] (Ludovic Courtès)
To: Gábor Boskovits <[email-masked]>
Cc: [email-masked]
Date: Thu, 20 Jul 2017 11:00:48 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Gábor,

Gábor Boskovits <[email-masked]> skribis:

> * gnu/packages/java.scm(java-commons-cli-1.2): New variable.

I made the cosmetic changes shown below and committed.

Thanks,
Ludo’.

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index fa8bd4be3..de992c649 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -4673,15 +4673,15 @@ transformations and analysis algorithms allow to easily assemble custom
 complex transformations and code analysis tools.")
     (license license:bsd-3)))
 
-;;maven2 bootstrap dependecies
 (define-public java-commons-cli-1.2
-  (package (inherit java-commons-cli)
-    (name "java-commons-cli-1.2")
+  ;; This is a bootstrap dependency for Maven2.
+  (package
+    (inherit java-commons-cli)
     (version "1.2")
     (source (origin
               (method url-fetch)
-              (uri (string-append "http://archive.apache.org/dist/commons/cli/"
-                                  "source/commons-cli-" version "-src.tar.gz"))
+              (uri (string-append "mirror://apache/commons/cli/source/"
+                                  "commons-cli-" version "-src.tar.gz"))
               (sha256
                (base32
                 "0rvfgzgv2pc1m091dfj3ih9ddsjjppr1f1wf0qmc3bk6b1kwv2dm"))))
@@ -4692,7 +4692,8 @@ complex transformations and code analysis tools.")
          (add-before 'check 'fix-build-xml
            (lambda* (#:key inputs #:allow-other-keys)
              (substitute* "build.xml"
-               (("dir=\"\\$\\{test.home\\}/java\"") "dir=\"${test.home}\"")))))))
+               (("dir=\"\\$\\{test.home\\}/java\"")
+                "dir=\"${test.home}\""))
+             #t)))))
     (native-inputs
      `(("java-junit" ,java-junit)))))
-;;end of maven2 bootstrap dependecies

Subject: [PATCH] Add java-commons-cli-1.2.
From: Gábor Boskovits <[email-masked]>
To: [email-masked]
Cc: Gábor Boskovits <[email-masked]>
Date: Wed, 5 Jul 2017 17:48:51 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/java.scm(java-commons-cli-1.2): New variable.
---
 gnu/packages/java.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index e074dab46..c39c85177 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -4570,3 +4570,27 @@ generate classes, directly in binary form.  The provided common
 transformations and analysis algorithms allow to easily assemble custom
 complex transformations and code analysis tools.")
     (license license:bsd-3)))
+
+;;maven2 bootstrap dependecies
+(define-public java-commons-cli-1.2
+  (package (inherit java-commons-cli)
+    (name "java-commons-cli-1.2")
+    (version "1.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "http://archive.apache.org/dist/commons/cli/"
+                                  "source/commons-cli-" version "-src.tar.gz"))
+              (sha256
+               (base32
+                "0rvfgzgv2pc1m091dfj3ih9ddsjjppr1f1wf0qmc3bk6b1kwv2dm"))))
+    (arguments
+     `(#:jar-name "commons-cli.jar"
+       #:phases
+       (modify-phases %standard-phases
+         (add-before 'check 'fix-build-xml
+           (lambda* (#:key inputs #:allow-other-keys)
+             (substitute* "build.xml"
+               (("dir=\"\\$\\{test.home\\}/java\"") "dir=\"${test.home}\"")))))))
+    (native-inputs
+     `(("java-junit",java-junit)))))
+;;end of maven2 bootstrap dependecies
-- 
2.13.1