GNU bug report logs - #27584
26.0.50; alist-get: Add optional arg TESTFN

Previous Next

Full log

View this message in rfc822 format

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: Nicolas Petton <nicolas <at> petton.fr>, Stefan Monnier <monnier <at> iro.umontreal.ca>, 27584 <at> debbugs.gnu.org
Subject: bug#27584: 26.0.50; alist-get: Add optional arg TESTFN
Date: Mon, 10 Jul 2017 15:18:26 +0200

Tino Calancha <tino.calancha <at> gmail.com> writes:

> > Is this a good idea in general?  PRED could also be function-quoted,
> > or a variable bound to `eq'.  And KEY could be an expression that
> > evaluates to a float.  That would fail the `floatp' test.

> Well, this code is now in the 'Limbo', because we are thinking
> to use the Nico solution (`assoc' having an optional arg PRED).
> That said, its fun to discuss about it.
> You know, this compiler macro is inspired in the one used by
> `cl-assoc' i.e., `cl--compiler-macro-assoc'.  If you find a problem
> on it, then the same problem might arise in `cl-assoc' :-S

I was wrong about your handling of KEY, I think it is ok.

For the PRED, `cl--compiler-macro-assoc' uses `cl--const-expr-val' that
DTRT for function quoting.  The compile time optimization is limited but
doesn't look wrong.


Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.