From unknown Mon Aug 18 17:53:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27583: 24.5; `info.el': some test for (eq major-mode 'Info-mode) Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Jul 2017 02:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27583 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 27583@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.149922068422835 (code B ref -1); Wed, 05 Jul 2017 02:12:01 +0000 Received: (at submit) by debbugs.gnu.org; 5 Jul 2017 02:11:24 +0000 Received: from localhost ([127.0.0.1]:52777 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSZmm-0005wE-7v for submit@debbugs.gnu.org; Tue, 04 Jul 2017 22:11:24 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSZmk-0005w2-2H for submit@debbugs.gnu.org; Tue, 04 Jul 2017 22:11:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSZme-0007M9-2Q for submit@debbugs.gnu.org; Tue, 04 Jul 2017 22:11:16 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:50856) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dSZmd-0007M2-VT for submit@debbugs.gnu.org; Tue, 04 Jul 2017 22:11:15 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59841) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dSZmd-0001sM-02 for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 22:11:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dSZmY-0007JC-0e for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 22:11:14 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:35305) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dSZmX-0007IF-MP for bug-gnu-emacs@gnu.org; Tue, 04 Jul 2017 22:11:09 -0400 Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v652B7kX029352 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 5 Jul 2017 02:11:07 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v652B6wc016349 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 5 Jul 2017 02:11:06 GMT Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v652B5XL020249 for ; Wed, 5 Jul 2017 02:11:06 GMT MIME-Version: 1.0 Message-ID: <81c97390-9678-4a2e-9772-f2ba9378ecd0@default> Date: Tue, 4 Jul 2017 19:11:04 -0700 (PDT) From: Drew Adams X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6770.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0022.oracle.com [141.146.126.234] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Most of the places where `major-mode' is tested use a test like this: (derived-mode-p 'Info-mode). But there are still a few places where this is done: (eq major-mode 'Info-mode). I think (but am not positive) that each of the latter tests should be changed to use `derived-mode-p', to let users and libraries define and use modes that are derived from `Info-mode'. It looks like the places that still use (eq major-mode 'Info-mode) constitute code that doesn't get much love. The occurrences are in these 3 things: Info-hide-note-references (in the option's :set function) info-display-manual info--manual-names (used only by info-display-manual) In GNU Emacs 24.5.1 (i686-pc-mingw32) of 2015-04-11 on LEG570 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/usr --host=3Di686-pc-mingw32' From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 17 18:59:59 2018 Received: (at control) by debbugs.gnu.org; 17 Jul 2018 22:59:59 +0000 Received: from localhost ([127.0.0.1]:45944 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffYwm-0005XJ-Pa for submit@debbugs.gnu.org; Tue, 17 Jul 2018 18:59:58 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:33526) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ffYwl-0005X7-IC for control@debbugs.gnu.org; Tue, 17 Jul 2018 18:59:55 -0400 Received: by mail-io0-f180.google.com with SMTP id z20-v6so2461464iol.0 for ; Tue, 17 Jul 2018 15:59:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=WZZAU6BCjUFdadM3Ss8L4QsVUmHwiGvW4hh5BTEOg/A=; b=hTetg+ZCTcbra09BVcXiPvj002WkQkXe9FgyHkAhlf4ratdWZX3p+SErtudO2hFVdw 2KkS3EF4IFBwJbuKlatPWQcUCWltaUe6s3kVxVfVuVDMIfgCMGPEBr1ZyQlOpEczeq8j 0Bii+g1Cz3BdhVMh1aaG/+iSHx1UMvavLLZQ0lKiyf84MqtH6P8bnq4oSEyApFYCHfif ssnRByL/Uvmg0cH2BisACwBWkKeKJUdbRR/G/o2jSm9Ji3JZm/zMNafAqN68UoajIVO7 2om7wx7vqILAC8bLmrn0Wi0B6382h3v9HG58opiTJy+z0k8h8Z+yf3OT4xIN4i9RscSa 01Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=WZZAU6BCjUFdadM3Ss8L4QsVUmHwiGvW4hh5BTEOg/A=; b=coKvezTyBEjcXejlrPFxDb+e0qoGCXqQe2jzEvlpjzz2RtWOxr4Qq9USZnUQck5DqO fdjvcoqARzKvUpWXJJr+88Lz591czuwd2i6tOROK9UBoUIwW9kBOFLG3udu/EEGIMNsD hXqeYJeW/wbZImMKTO8RzFjf8NVA3O13sB7KgYIjQIx0buuaUzbTOHJQfTacqcBLafbA KE5//d6+SFT1jrK8rAMkIbzPpbg4pjPED11yXyIr3fO3zX8SOK4Nt6tPFUr1yoqzjIjf ZTRBb1ZmA5fEBj/BII8aS+XxAhyWlPXaYfX5bgGixGtwJPcOubN4aK+J3UViVaeY5opC K4jQ== X-Gm-Message-State: AOUpUlHxUAtTt9bWEnkhCrPBSajLOn4nJoybyFdF3Qi0Xm5b3AWFH4pj zv4kUBqGmo5jxiVzu6tMLC4kzA== X-Google-Smtp-Source: AA+uWPw7Ce9zWYYy37NXyPb6dA/KxTpcSfsiQPb0DgXGoQvSN1BFgCPyhrvvAJC51WkWdzyfXm8KXg== X-Received: by 2002:a6b:26ca:: with SMTP id m193-v6mr3224598iom.91.1531868390059; Tue, 17 Jul 2018 15:59:50 -0700 (PDT) Received: from zebian (cbl-45-2-119-34.yyz.frontiernetworks.ca. [45.2.119.34]) by smtp.googlemail.com with ESMTPSA id v13-v6sm471980ita.38.2018.07.17.15.59.49 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Jul 2018 15:59:49 -0700 (PDT) From: Noam Postavsky To: control@debbugs.gnu.org Subject: control message for bug #27583 Date: Tue, 17 Jul 2018 18:59:48 -0400 Message-ID: <87h8kx8o4b.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 27583 + easy quit From unknown Mon Aug 18 17:53:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27583: 24.5; `info.el': some test for (eq major-mode 'Info-mode) References: <81c97390-9678-4a2e-9772-f2ba9378ecd0@default> In-Reply-To: <81c97390-9678-4a2e-9772-f2ba9378ecd0@default> Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Aug 2019 01:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27583 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy To: Drew Adams Cc: 27583@debbugs.gnu.org Received: via spool by 27583-submit@debbugs.gnu.org id=B27583.156686999122390 (code B ref 27583); Tue, 27 Aug 2019 01:40:02 +0000 Received: (at 27583) by debbugs.gnu.org; 27 Aug 2019 01:39:51 +0000 Received: from localhost ([127.0.0.1]:47395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2QSc-0005p3-VI for submit@debbugs.gnu.org; Mon, 26 Aug 2019 21:39:51 -0400 Received: from mail-pf1-f172.google.com ([209.85.210.172]:39571) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2QSb-0005og-Ii for 27583@debbugs.gnu.org; Mon, 26 Aug 2019 21:39:49 -0400 Received: by mail-pf1-f172.google.com with SMTP id y200so5309552pfb.6 for <27583@debbugs.gnu.org>; Mon, 26 Aug 2019 18:39:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=AA4641m6N6FChAlblAGO+MwmNir/9oyyq5qo8hMyYEQ=; b=kGcTLAMmbH05oaZEuy9dNArdlMAuqImXTl41AllYn6KAx6fk9lfg5edw4Cl7sK4fKU YV4lVoNF/xF+vmqyACANXDcDW+OYfQdy8nq1Z1TNUXJcSXYHsv8DzVHQgOq+tE+FjjoT W9dmPVt2uUXhVS6TTvMexpoFTsTXskHTShIwY4uthDOX3zPOulbuYYbG21mvZ4d3oZGc z4UrpZOtevj6ivVNra2STANp8VoeFTxPIr94d4B2oCkYtbeKpzf3hHBH9Rf9BH+QFtF+ hikHupUezB2uzyCmFXWJWREJI5Qa3Fbpxva/UXhwq61V/FAaF5V/A+PP1HVQTNfRqnUB V5ww== X-Gm-Message-State: APjAAAXKFQuknGbX3b/Y7OCpYUVZul0ZMmF72BI6teHzJvFwrgtx9ucT HraGIwhNut5907I6GpUqTM3n8J8ka+nLy5gkAA0= X-Google-Smtp-Source: APXvYqxNyQzOZQnPerqfcmsQS7vJLOF8RP+1jV7IScqpWhv+BYWfP4GgmRgeQjVi4agX4Yy/8gP9hdaWgscg5LQUEBE= X-Received: by 2002:a63:69c1:: with SMTP id e184mr18216625pgc.198.1566869983678; Mon, 26 Aug 2019 18:39:43 -0700 (PDT) MIME-Version: 1.0 From: Stefan Kangas Date: Tue, 27 Aug 2019 03:39:32 +0200 Message-ID: Content-Type: multipart/mixed; boundary="000000000000c9b7a505910f58d9" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --000000000000c9b7a505910f58d9 Content-Type: text/plain; charset="UTF-8" tags 27583 + patch quit Drew Adams writes: > Most of the places where `major-mode' is tested use a test like this: > (derived-mode-p 'Info-mode). But there are still a few places where > this is done: (eq major-mode 'Info-mode). > > I think (but am not positive) that each of the latter tests should be > changed to use `derived-mode-p', to let users and libraries define and > use modes that are derived from `Info-mode'. > > It looks like the places that still use (eq major-mode 'Info-mode) > constitute code that doesn't get much love. The occurrences are in > these 3 things: > > Info-hide-note-references (in the option's :set function) > info-display-manual > info--manual-names (used only by info-display-manual) Makes sense. How about the attached patch? Best regards, Stefan Kangas --000000000000c9b7a505910f58d9 Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Use-derived-mode-p-consistently-in-info.el.patch" Content-Disposition: attachment; filename="0001-Use-derived-mode-p-consistently-in-info.el.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jzt5w3fr0 RnJvbSBhZDYzOGNiOTc4N2M0MmQ0YzhhMjUzMzdmYjc4NDNlMGZkZWE2ZTc0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBUdWUsIDI3IEF1ZyAyMDE5IDAzOjM2OjA1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g VXNlIGRlcml2ZWQtbW9kZS1wIGNvbnNpc3RlbnRseSBpbiBpbmZvLmVsCgoqIGxpc3AvaW5mby5l bCAoSW5mby1oaWRlLW5vdGUtcmVmZXJlbmNlcywgaW5mby1kaXNwbGF5LW1hbnVhbCkKKGluZm8t LW1hbnVhbC1uYW1lcyk6IFVzZSBkZXJpdmVkLW1vZGUtcC4gIChCdWcjMjc1ODMpCi0tLQogbGlz cC9pbmZvLmVsIHwgNiArKystLS0KIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDMg ZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9pbmZvLmVsIGIvbGlzcC9pbmZvLmVsCmlu ZGV4IDE3YTJkNjNlNmQuLmJjZmFkZGNmNWEgMTAwNjQ0Ci0tLSBhL2xpc3AvaW5mby5lbAorKysg Yi9saXNwL2luZm8uZWwKQEAgLTMxOCw3ICszMTgsNyBAQCBJbmZvLWhpZGUtbm90ZS1yZWZlcmVu Y2VzCiAJIChzZXQgc3ltIHZhbCkKIAkgKGRvbGlzdCAoYnVmZmVyIChidWZmZXItbGlzdCkpCiAJ ICAgKHdpdGgtY3VycmVudC1idWZmZXIgYnVmZmVyCi0JICAgICAod2hlbiAoZXEgbWFqb3ItbW9k ZSAnSW5mby1tb2RlKQorCSAgICAgKHdoZW4gKGRlcml2ZWQtbW9kZS1wICdJbmZvLW1vZGUpCiAJ ICAgICAgIChyZXZlcnQtYnVmZmVyIHQgdCkpKSkpCiAgIDpncm91cCAnaW5mbykKIApAQCAtNTMw MCw3ICs1MzAwLDcgQEAgaW5mby1kaXNwbGF5LW1hbnVhbAogCWZvdW5kKQogICAgIChkb2xpc3Qg KGJ1ZmZlciBibGlzdCkKICAgICAgICh3aXRoLWN1cnJlbnQtYnVmZmVyIGJ1ZmZlcgotCSh3aGVu IChhbmQgKGVxIG1ham9yLW1vZGUgJ0luZm8tbW9kZSkKKyAgICAgICAgKHdoZW4gKGFuZCAoZGVy aXZlZC1tb2RlLXAgJ0luZm8tbW9kZSkKIAkJICAgKHN0cmluZ3AgSW5mby1jdXJyZW50LWZpbGUp CiAJCSAgIChzdHJpbmctbWF0Y2ggbWFudWFsLXJlIEluZm8tY3VycmVudC1maWxlKSkKIAkgIChz ZXRxIGZvdW5kIGJ1ZmZlcgpAQCAtNTMxNSw3ICs1MzE1LDcgQEAgaW5mby0tbWFudWFsLW5hbWVz CiAgIChsZXQgKG5hbWVzKQogICAgIChkb2xpc3QgKGJ1ZmZlciAoYnVmZmVyLWxpc3QpKQogICAg ICAgKHdpdGgtY3VycmVudC1idWZmZXIgYnVmZmVyCi0JKGFuZCAoZXEgbWFqb3ItbW9kZSAnSW5m by1tb2RlKQorICAgICAgICAoYW5kIChkZXJpdmVkLW1vZGUtcCAnSW5mby1tb2RlKQogCSAgICAg KHN0cmluZ3AgSW5mby1jdXJyZW50LWZpbGUpCiAJICAgICAobm90IChzdHJpbmc9IChzdWJzdHJp bmcgKGJ1ZmZlci1uYW1lKSAwIDEpICIgIikpCiAJICAgICAocHVzaCAoZmlsZS1uYW1lLXNhbnMt ZXh0ZW5zaW9uCi0tIAoyLjIwLjEKCg== --000000000000c9b7a505910f58d9-- From unknown Mon Aug 18 17:53:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27583: 24.5; `info.el': some test for (eq major-mode 'Info-mode) Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Aug 2019 02:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27583 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy patch To: Stefan Kangas Cc: 27583@debbugs.gnu.org Received: via spool by 27583-submit@debbugs.gnu.org id=B27583.15668731963472 (code B ref 27583); Tue, 27 Aug 2019 02:34:01 +0000 Received: (at 27583) by debbugs.gnu.org; 27 Aug 2019 02:33:16 +0000 Received: from localhost ([127.0.0.1]:47434 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2RIJ-0000tw-SO for submit@debbugs.gnu.org; Mon, 26 Aug 2019 22:33:16 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:57702) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i2RIF-0000tf-5t for 27583@debbugs.gnu.org; Mon, 26 Aug 2019 22:33:11 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7R2Sl9R041412; Tue, 27 Aug 2019 02:33:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=8wTcUcctHwbsacTJDyOc4UvhsqxUOj1/vQD49LEZ2sI=; b=mgW0sCnJrIqE13DMW4kKCLfesTrl+a680RJOm35bBiLW6NpnmM3K9vRH1iEtj/JQP7C9 6+ww9+SI2zcawuz5o8LzapKT2oN1PzDjdypffZQ5wpcPc5M2GDxaP+KVl2mR3ZoY/WeS Vpjnzep+tjUUCX+3gqg3xfVjCDSrYidrjGMqwhFDW+o3sflJnzBZaxVmZnq3aWnTQTpp PnVH7lqcF4iHP45QwV8vx6CThjqJh7n1p8D9NSdmHjpu/8PfHamvFvjCa4n1tE848lzc HTEnvEa4qs4bY7ECMU2b9PVHJVrHBm7/LcGrJXlGqHBDg2T/OqUG68x1Igp1WpF7T8kd ew== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by aserp2120.oracle.com with ESMTP id 2umuq1g126-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Aug 2019 02:33:05 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x7R2SVLd019618; Tue, 27 Aug 2019 02:33:04 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserp3030.oracle.com with ESMTP id 2umhu84pt2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 27 Aug 2019 02:33:04 +0000 Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x7R2X2bl023941; Tue, 27 Aug 2019 02:33:03 GMT MIME-Version: 1.0 Message-ID: Date: Mon, 26 Aug 2019 19:33:01 -0700 (PDT) From: Drew Adams References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4873.0 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9361 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=870 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908270025 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9361 signatures=668684 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=939 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1908270025 X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > How about the attached patch? LGTM. I have a tiny doubt that we can be sure that an arbitrary derived mode would call for those things, but that's a problem that's not special to Info, I guess. Thx. From unknown Mon Aug 18 17:53:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27583: 24.5; `info.el': some test for (eq major-mode 'Info-mode) Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Sep 2019 18:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27583 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy patch To: Drew Adams Cc: 27583@debbugs.gnu.org Received: via spool by 27583-submit@debbugs.gnu.org id=B27583.156753506023648 (code B ref 27583); Tue, 03 Sep 2019 18:25:02 +0000 Received: (at 27583) by debbugs.gnu.org; 3 Sep 2019 18:24:20 +0000 Received: from localhost ([127.0.0.1]:60538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i5DTV-00069K-M7 for submit@debbugs.gnu.org; Tue, 03 Sep 2019 14:24:20 -0400 Received: from mail-pf1-f176.google.com ([209.85.210.176]:33068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i5DTT-000694-KM for 27583@debbugs.gnu.org; Tue, 03 Sep 2019 14:24:15 -0400 Received: by mail-pf1-f176.google.com with SMTP id q10so6228636pfl.0 for <27583@debbugs.gnu.org>; Tue, 03 Sep 2019 11:24:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=J31yDjoMlvOQ+QvGWsFXfVbrCRoPgQmoeoZeEDKRzNA=; b=s7hrTLRAr5fSS4+6H0WDk+hFeyQ+BkSoTh1Zohw2l9hCyRNWWan1y4um55xZFWbl5M NgamytQROeTUGhXoEvdR7uyX32pmEBYTMc/oGXJ4BVMHcgRfDl6VE5RlumnryZMXYtq4 Wmg5k2AewEFCEkJTNaAKrRvQQzSSFI6NXnYlY9yR9sjSQ2mr8a4PQGwP+inT0Quuka4t +srj0/fHorYimzYGe3QQiQW2MieX3isJgA2dTHXNtr+WF9rHfY+fSO2cpUX9aNahlREi dLftLIU56kvCOrbq4KgSjopbrBq56CcPwph6+kWboN4XHCBwEDbubSzJMMRMyvq0d0x/ dHqQ== X-Gm-Message-State: APjAAAUmS7ve+6yWSv/3WWU75cUhdNrJTkVYTZL40FFdZSbhqDI76EtE tdmtW24a7Ccien3MS4RBj8HaJntdWEcNC5ukvao= X-Google-Smtp-Source: APXvYqxyjYjbBbxlp+2bj7/zncyDvMLEq/TEi+mrgCo7yel1qnQb5DkXHyAV3vhqJvLIw2nUKsqE2T9Le7J7XgnbPrI= X-Received: by 2002:aa7:8005:: with SMTP id j5mr3251887pfi.50.1567535050038; Tue, 03 Sep 2019 11:24:10 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Stefan Kangas Date: Tue, 3 Sep 2019 20:23:59 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Drew Adams writes: > > How about the attached patch? > > LGTM. Thanks. If no one has any objections, I'll install it in a couple of days. Best regards, Stefan Kangas From unknown Mon Aug 18 17:53:48 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27583: 24.5; `info.el': some test for (eq major-mode 'Info-mode) Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Sep 2019 22:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27583 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: easy patch To: Drew Adams Cc: 27583@debbugs.gnu.org Received: via spool by 27583-submit@debbugs.gnu.org id=B27583.156789483829818 (code B ref 27583); Sat, 07 Sep 2019 22:21:02 +0000 Received: (at 27583) by debbugs.gnu.org; 7 Sep 2019 22:20:38 +0000 Received: from localhost ([127.0.0.1]:38225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6j4Q-0007kn-Gs for submit@debbugs.gnu.org; Sat, 07 Sep 2019 18:20:38 -0400 Received: from mail-pl1-f176.google.com ([209.85.214.176]:39624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1i6j4P-0007kO-6R for 27583@debbugs.gnu.org; Sat, 07 Sep 2019 18:20:37 -0400 Received: by mail-pl1-f176.google.com with SMTP id bd8so4805282plb.6 for <27583@debbugs.gnu.org>; Sat, 07 Sep 2019 15:20:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JjxqFp00nXeqppAh9me8IhUS7qw/vhQ+OlWAlQtV2HE=; b=eJ3CTRu0xeLUwAD9lOakvPDfiJilzA7GC5xemvUQnKT9BrM+bJCXRKLxFc6Z0uAqxd xaTHGo8KUsohlqZoe3IGCtEIc8ZeH3ORD9tFnV1ZtVGub/3BXYnhzj/0jmZJRBbqKKTM Hu49Pe1cFmxzvpjt/MCIqgOrUxC9Pte6RxN8ILsiJwBjlrb8lBH0GgqR+N8E7UH6u/tr Zeyw8vv91KBHsR4fIQo6YPCrVK8ccKXnRg9iPKvnHLkEj4zyk/O/XAU34qTG91ur+skr Ak9bIqjY3AdiPW1nrCQsCdMWCKdkjHjdv1Th53KwANv28DCeH8GZ7c2aortt8QN9pSRR vm3A== X-Gm-Message-State: APjAAAXG6DppQrQEaUfJZLh3MltRxajr//HMMjEKZ8lzZc1ch5b0wArc 7tZebG85sLU0g8D21g7xETNiB8enVZ+0I0R9Blk= X-Google-Smtp-Source: APXvYqyXajNseHsLQercqwxbj/N/0RA+2xF9Amp5zsxCFPdiaOfS88IjeOjq/jtNSKWt7OlgLQlfQfYODpRR1ieNt3A= X-Received: by 2002:a17:902:8b8c:: with SMTP id ay12mr15676576plb.251.1567894831428; Sat, 07 Sep 2019 15:20:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Stefan Kangas Date: Sun, 8 Sep 2019 00:20:19 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) close 27583 27.1 quit Stefan Kangas writes: > If no one has any objections, I'll install it in a couple of days. Now pushed to master as commit 8e93e6da7c. Thanks, Stefan Kangas