GNU bug report logs - #2757
remove vc-file-not-found-hook in 23.2

Package: emacs;

Reported by: Dan Nicolaescu <dann <at> ics.uci.edu>

Date: Mon, 23 Mar 2009 17:45:02 UTC

Severity: wishlist

Done: Dan Nicolaescu <dann <at> ics.uci.edu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 2757 in the body.
You can then email your comments to 2757 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#2757; Package emacs. (Mon, 23 Mar 2009 17:45:03 GMT) Full text and rfc822 format available.

Message #3 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: disable (or deprecate) vc-file-not-found-hook for 23.1
Date: Mon, 23 Mar 2009 10:34:27 -0700 (PDT)

The vc-file-not-found-hook behavior is only used by RCS, and it is a
strange wart anyway.

IMO we should remove vc-file-not-found-hook from file-not-found-hook by
default for 23.1 and even remove the `find-file-not-found-hook' VC
method.
We can put instructions in NEWS that if people want the old behavior,
they can add vc-rcs-file-not-found-hook to find-file-not-found hook.

This hook adds a cost every time when opening a non-VC managed file.

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#2757; Package emacs. (Mon, 23 Mar 2009 19:25:06 GMT) Full text and rfc822 format available.

Acknowledgement sent to Stefan Monnier <monnier <at> IRO.UMontreal.CA>:
Extra info received and forwarded to list. Copy sent to Emacs Bugs <bug-gnu-emacs <at> gnu.org>. (Mon, 23 Mar 2009 19:25:06 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Dan Nicolaescu <dann <at> ics.uci.edu>
Cc: 2757 <at> debbugs.gnu.org, bug-gnu-emacs <bug-gnu-emacs <at> gnu.org>
Subject: Re: bug#2757: disable (or deprecate) vc-file-not-found-hook for 23.1
Date: Mon, 23 Mar 2009 15:18:11 -0400

> IMO we should remove vc-file-not-found-hook from file-not-found-hook by
> default for 23.1 and even remove the `find-file-not-found-hook' VC
> method.

Let's remove it in Emacs-23.2.

> This hook adds a cost every time when opening a non-VC managed file.

Really?  It should only be triggered when opening a non-existent file.


        Stefan

Information forwarded to bug-submit-list <at> lists.donarmstrong.com, Emacs Bugs <bug-gnu-emacs <at> gnu.org>:
bug#2757; Package emacs. (Mon, 23 Mar 2009 22:00:05 GMT) Full text and rfc822 format available.

Message #16 received at 2757 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 2757 <at> debbugs.gnu.org
Subject: Re: bug#2757: disable (or deprecate) vc-file-not-found-hook for 23.1
Date: Mon, 23 Mar 2009 14:54:34 -0700 (PDT)

retitle 2757 remove vc-file-not-found-hook in 23.2
quit

Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

  > > IMO we should remove vc-file-not-found-hook from file-not-found-hook by
  > > default for 23.1 and even remove the `find-file-not-found-hook' VC
  > > method.
  > 
  > Let's remove it in Emacs-23.2.

Fine, adjusted the subject accordingly.

  > > This hook adds a cost every time when opening a non-VC managed file.
  > 
  > Really?  It should only be triggered when opening a non-existent file.

You're right.

Changed bug title to `remove vc-file-not-found-hook in 23.2' from `disable (or deprecate) vc-file-not-found-hook for 23.1'. Request was from Dan Nicolaescu <dann <at> ics.uci.edu> to control <at> emacsbugs.donarmstrong.com. (Mon, 23 Mar 2009 22:00:07 GMT) Full text and rfc822 format available.

Severity set to `wishlist' from `normal' Request was from Juanma Barranquero <lekktu <at> gmail.com> to control <at> emacsbugs.donarmstrong.com. (Wed, 25 Mar 2009 10:15:03 GMT) Full text and rfc822 format available.

Reply sent to Dan Nicolaescu <dann <at> ics.uci.edu>:
You have taken responsibility. (Sat, 27 Jun 2009 00:00:06 GMT) Full text and rfc822 format available.

Notification sent to Dan Nicolaescu <dann <at> ics.uci.edu>:
bug acknowledged by developer. (Sat, 27 Jun 2009 00:00:06 GMT) Full text and rfc822 format available.

Message #25 received at 2757-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Dan Nicolaescu <dann <at> ics.uci.edu>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 2757-done <at> debbugs.gnu.org
Subject: Re: bug#2757: disable (or deprecate) vc-file-not-found-hook for 23.1
Date: Fri, 26 Jun 2009 16:53:59 -0700 (PDT)

Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

  > > IMO we should remove vc-file-not-found-hook from file-not-found-hook by
  > > default for 23.1 and even remove the `find-file-not-found-hook' VC
  > > method.
  > 
  > Let's remove it in Emacs-23.2.

Thanks.
Done.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> emacsbugs.donarmstrong.com. (Thu, 06 Aug 2009 14:24:11 GMT) Full text and rfc822 format available.

This bug report was last modified 15 years and 189 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.

GNU bug report logs - #2757 remove vc-file-not-found-hook in 23.2

GNU bug report logs - #2757
remove vc-file-not-found-hook in 23.2