GNU bug report logs - #27555
cygwin surrogate-pair test now fails (since grep-2.22, and no one noticed)

Previous Next

Package: grep;

Reported by: Jim Meyering <jim <at> meyering.net>

Date: Sun, 2 Jul 2017 15:58:01 UTC

Severity: minor

Merged with 49983, 51698

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#27555: closed (cygwin surrogate-pair test now fails (since
 grep-2.22, and no one noticed))
Date: Wed, 24 Nov 2021 02:36:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Tue, 23 Nov 2021 18:34:51 -0800
with message-id <32d817a3-4dd3-113a-addd-69f56174ef2f <at> cs.ucla.edu>
and subject line Re: [PATCH 1/1] tests: make surrogate-pair pass under Cygwin
has caused the debbugs.gnu.org bug report #27555,
regarding cygwin surrogate-pair test now fails (since grep-2.22, and no one noticed)
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
27555: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27555
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Jim Meyering <jim <at> meyering.net>
To: Aharon Robbins <arnold <at> skeeve.com>, bug-grep <at> gnu.org
Cc: Paul Eggert <eggert <at> cs.ucla.edu>
Subject: cygwin surrogate-pair test now fails (since grep-2.22,
 and no one noticed)
Date: Sun, 2 Jul 2017 08:57:00 -0700
On Sun, Jul 2, 2017 at 12:11 AM,  <arnold <at> skeeve.com> wrote:
> Jim Meyering <jim <at> meyering.net> wrote:
>
>> On Fri, Jun 30, 2017 at 12:55 AM,  <arnold <at> skeeve.com> wrote:
>> > Jim Meyering <jim <at> meyering.net> wrote:
>> >
>> >> > Do you still want the log? If so I'll send it...
>> >>
>> >> Yes, please, in case it's easy to fix.
>> >
>> > Attached. Thanks!
>>
>> Thanks.
>> I've determined the cause, at least. The sole caller of mbstoupper
>> (which contained the relevant __CYGWIN__-specific
>> surrogate-pair-handling code) was removed by the improvements of
>> v2.21-63-g8a33cde, and not long after, I noticed that mbstoupper was
>> no longer used, so removed it altogether.
>>
>> Since this affects surrogate-pairs only on cygwin, I'm not going to do
>> anything about this prior to release. After release, I'll make that
>> test skip or maybe even remove it altogether.
>
> OK, glad the log was helpful. In the future I will try to remember to
> send it along if I see failures.
>
> Do you want to document this cygwin issue as a known issue somewhere? :-)

Sure. I've adjusted the subject and added bug-grep@ so we get an
auto-assigned issue number in the tracker.


[Message part 3 (message/rfc822, inline)]
From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Duncan Roe <duncan_roe <at> optusnet.com.au>
Cc: 27555-done <at> debbugs.gnu.org
Subject: Re: [PATCH 1/1] tests: make surrogate-pair pass under Cygwin
Date: Tue, 23 Nov 2021 18:34:51 -0800
[Message part 4 (text/plain, inline)]
I installed the attached fancier patch instead; please give it a try.

I'm boldly marking the bug as fixed; we can unmark it later if I'm wrong.
[0001-tests-skip-surrogate-search-test-on-Cygwin.patch (text/x-patch, attachment)]

This bug report was last modified 3 years and 179 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.