From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: James Nguyen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Jun 2017 05:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 27503@debbugs.gnu.org Cc: james@jojojames.com X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.149854165029536 (code B ref -1); Tue, 27 Jun 2017 05:35:01 +0000 Received: (at submit) by debbugs.gnu.org; 27 Jun 2017 05:34:10 +0000 Received: from localhost ([127.0.0.1]:39848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPj8b-0007gJ-Tk for submit@debbugs.gnu.org; Tue, 27 Jun 2017 01:34:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPfdx-00025T-Ei for submit@debbugs.gnu.org; Mon, 26 Jun 2017 21:50:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dPfdq-0002Oj-8N for submit@debbugs.gnu.org; Mon, 26 Jun 2017 21:50:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37633) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dPfdq-0002Oc-4W for submit@debbugs.gnu.org; Mon, 26 Jun 2017 21:50:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dPfdn-0001gp-Iz for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2017 21:50:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dPfdk-0002Iy-CF for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2017 21:50:07 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:41867) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dPfdj-0002Hk-L1 for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2017 21:50:04 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9661721111; Mon, 26 Jun 2017 21:50:01 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 26 Jun 2017 21:50:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=/qlz5s/nmHg14QDSaLN9x9ExlwZLap0/Byca323SG dE=; b=Fu4gHjKfX/ibceYZPnX6ZrbIehc91GxsSkbkafPKTWM2DLQJrGzmQxW6C jaHJlA4dzPnHdjo9IYDz4yL5xT8Ig9pFTRylQQgiegdcusVDcuprwfv/rh/Vche3 mjN89npEUivIteLu/F9NDSwZZP99kO65lYcO+KVqIHcXxsgGc3paLFqQEBVAxtlX 4l+hNhFPjsXgNxV1UonMFgMy2VRznOzefQlnvr4oTODPpi3rJsvmH11tVRkoqRKC Pevdalyf8XS1PRQLO2+1i95rtCFx/CgyC32Ne86JgneHpWuOb2DU8WokSLFVpl5/ TEfk/i9nwh6UoMsABueYgcc8WQzuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=/qlz5s/nmHg14QDSaL N9x9ExlwZLap0/Byca323SGdE=; b=OwGxdiga1RtMu/XPWSuAHxnpK8dpmk2iB5 If2NbzzvEUyjwEijQj0GxF4L8wwXLl66wKWDFIuonW+xkKgDIdvP1/1ZXi0ebbMp Ff2hu5P85smnDmWBhCICeWGXzVoSMEaWpXSHb0qnlsEfG0aM0OjPJmjw00/GQqkw qNm0BhPweuyr0xi3FSKoJG13w773bWm4f0JiidOlZ+Hk1iB9tih82qTQzTISoqr6 5k/UKC3AXkqwygvYu1INzAxZ5SQWhodjnyH9eRCdtORKRlHf7ZNuAf7SL8wcyjDm 9Jk1TviMG7m+nj8AaAlfewcOFL5/NRMtzmMiBhOgaub+Zqe/SisA== X-ME-Sender: X-Sasl-enc: sVQWBl3Lo3aORwhlRyId1NnA8eKL8kvne/8J/efF7yi5 1498528201 Received: from [10.0.1.47] (c-73-231-191-86.hsd1.ca.comcast.net [73.231.191.86]) by mail.messagingengine.com (Postfix) with ESMTPA id DB1237E766; Mon, 26 Jun 2017 21:50:00 -0400 (EDT) From: James Nguyen Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Message-Id: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> Date: Mon, 26 Jun 2017 18:49:59 -0700 X-Mailer: Apple Mail (2.3273) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Mailman-Approved-At: Tue, 27 Jun 2017 01:34:08 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) I'd like to have js-mode line up arguments normally instead of lining up arg-wise. For example: function functionName(arg1, arg2) {} vs function functionName(arg1, arg2) I think js-mode only support the former at this point. The latter seems to be fairly common so it'd be great if we could support it. Following this: = https://emacs.stackexchange.com/questions/29973/stop-javascript-mode-from-= lining-up-function-parameters-after-newline/29975#29975 seems to give accurate indentation similar to other editors. (defun javascript/indent-args (parse-status) "Return the proper indentation for the current line." (save-excursion (back-to-indentation) (cond ((nth 4 parse-status) ; inside comment (js--get-c-offset 'c (nth 8 parse-status))) ((nth 3 parse-status) 0) ; inside string ((eq (char-after) ?#) 0) ((save-excursion (js--beginning-of-macro)) 4) ;; Indent array comprehension continuation lines specially. ((let ((bracket (nth 1 parse-status)) beg) (and bracket (not (js--same-line bracket)) (setq beg (js--indent-in-array-comp bracket)) ;; At or after the first loop? (>=3D (point) beg) (js--array-comp-indentation bracket beg)))) ((js--chained-expression-p)) ((js--ctrl-statement-indentation)) ((js--multi-line-declaration-indentation)) ((nth 1 parse-status) ;; A single closing paren/bracket should be indented at the ;; same level as the opening statement. Same goes for ;; "case" and "default". (let ((same-indent-p (looking-at "[]})]")) (switch-keyword-p (looking-at = "default\\_>\\|case\\_>[^:]")) (continued-expr-p (js--continued-expression-p))) (goto-char (nth 1 parse-status)) ; go to the opening char (progn ; nothing following the opening paren/bracket (skip-syntax-backward " ") (when (eq (char-before) ?\)) (backward-list)) (back-to-indentation) (js--maybe-goto-declaration-keyword-end parse-status) (let* ((in-switch-p (unless same-indent-p (looking-at "\\_"))) (same-indent-p (or same-indent-p (and switch-keyword-p in-switch-p))) (indent (cond (same-indent-p (current-column)) (continued-expr-p (+ (current-column) (* 2 = js-indent-level) js-expr-indent-offset)) (t (+ (current-column) js-indent-level (pcase (char-after (nth 1 = parse-status)) (?\( js-paren-indent-offset) (?\[ js-square-indent-offset) (?\{ js-curly-indent-offset))))))) (if in-switch-p (+ indent js-switch-indent-offset) indent))))) ((js--continued-expression-p) (+ js-indent-level js-expr-indent-offset)) (t (prog-first-column))))) (advice-add 'js--proper-indentation :override 'javascript/indent-args) =20 1. This removes an entire if block check. That is probably doing something I'm not aware of. 2. We probably want to make it configuration either way (something similar to js-comment-lineup-func (but that seems to only be for = comments.)) Some source code to play with is: #+begin_src mhtml :tangle yes Lifecycle
#+end_src =20 More specifically: #+begin_src mhtml :tangle yes render: function() { return React.DOM.div(null, React.DOM.textarea({ value: this.state.text, onChange: this._textChange, }), React.DOM.h3(null, this.state.text.length) ); } #+end_src =20 With the current indent settings, we get: #+begin_src mhtml :tangle yes render: function() { return React.DOM.div(null, React.DOM.textarea({ value: this.state.text, onChange: this._textChange, }), React.DOM.h3(null, = this.state.text.length) ); } #+end_src =20 With the above advice: #+begin_src mhtml :tangle yes render: function() { return React.DOM.div(null, React.DOM.textarea({ value: this.state.text, onChange: this._textChange, }), React.DOM.h3(null, this.state.text.length) ); } #+end_src In GNU Emacs 26.0.50 (build 4, x86_64-apple-darwin16.5.0, NS = appkit-1504.82 Version 10.12.4 (Build 16E195)) of 2017-06-24 built on jamesretina.local Repository revision: 16d2695674a4c8abbec846c427fe8abef97e07ef Windowing system distributor 'Apple', version 10.3.1504 Recent messages: The following feature was found in load-path, please check if that=E2=80=99= s correct: (obarray) Successfully reloaded Org Org-mode version 8.2.10 (release_8.2.10 @ = /Users/james/Code/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/) Mark set Configuring package helm... Configuring package tramp...done Configuring package helm...done (0.310s) Configuring package helm-flx...done Configuring package helm-fuzzier...done Configured using: 'configure --with-ns' Configured features: JPEG RSVG NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Org Minor modes in effect: helm-fuzzier-mode: t helm-flx-mode: t helm-mode: t helm-autoresize-mode: t helm--remap-mouse-mode: t shell-dirtrack-mode: t focus-autosave-mode: t company-quickhelp-mode: t company-quickhelp-local-mode: t eval-sexp-fu-flash-mode: t flycheck-pos-tip-mode: t shackle-mode: t yas-global-mode: t yas-minor-mode: t global-company-mode: t company-mode: t global-evil-surround-mode: t evil-surround-mode: t global-evil-visualstar-mode: t evil-visualstar-mode: t global-evil-matchit-mode: t evil-matchit-mode: t evil-mode: t evil-local-mode: t global-undo-tree-mode: t undo-tree-mode: t recentf-mode: t ivy-mode: t smartparens-global-mode: t smartparens-mode: t global-hungry-delete-mode: t hungry-delete-mode: t ws-butler-global-mode: t ws-butler-mode: t show-paren-mode: t global-auto-revert-mode: t winner-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: = /Users/james/.emacs.d/elpa/26/color-theme-solarized-20160626.743/solarized= -theme hides = /Users/james/.emacs.d/elpa/26/solarized-theme-20170430.800/solarized-theme= ~/.emacs.d/fork/evil/evil hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil ~/.emacs.d/fork/evil/evil-vars hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-vars ~/.emacs.d/fork/evil/evil-types hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-types ~/.emacs.d/fork/evil/evil-states hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-states ~/.emacs.d/fork/evil/evil-search hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-search ~/.emacs.d/fork/evil/evil-repeat hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-repeat ~/.emacs.d/fork/evil/evil-pkg hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-pkg ~/.emacs.d/fork/evil/evil-maps hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-maps ~/.emacs.d/fork/evil/evil-macros hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-macros ~/.emacs.d/fork/evil/evil-jumps hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-jumps ~/.emacs.d/fork/evil/evil-integration hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-integration ~/.emacs.d/fork/evil/evil-ex hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-ex ~/.emacs.d/fork/evil/evil-digraphs hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-digraphs ~/.emacs.d/fork/evil/evil-core hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-core ~/.emacs.d/fork/evil/evil-common hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-common ~/.emacs.d/fork/evil/evil-commands hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-commands ~/.emacs.d/fork/evil/evil-command-window hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-command-window Features: (shadow sort mail-extr emacsbug message rfc822 mml mml-sec epa epg mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail helm-fuzzier helm-flx helm-smex helm-command helm-elisp helm-eval helm-mode helm-files image-dired tramp tramp-compat tramp-loaddefs trampver parse-time dired-x dired-aux helm-buffers helm-tags helm-bookmark helm-adaptive helm-info bookmark pp helm-locate helm-grep helm-regexp helm-external helm-net helm-utils compile helm-help helm-types helm helm-source eieio-compat helm-multi-match helm-lib async smex ido loadhist solarized-light-theme solarized add-log server pulse shell tabify org-element org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view image-mode dired dired-loaddefs org-bibtex bibtex org-bbdb org-w3m org org-macro org-footnote org-pcomplete pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint comint ansi-color ob-core ob-eval org-compat org-macs org-loaddefs JJ-org cursor-sensor mhtml-mode rainbow-mode xterm-color css-mode smie eww puny mm-url gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mail-utils mm-util mail-prsvr url-queue url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap shr svg xml browse-url format-spec js cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs smartparens-html sgml-mode dom JJ-web focus-autosave-mode JJ-security colir color counsel jka-compr esh-util rainbow-delimiters evil-cleverparens evil-cleverparens-text-objects evil-cleverparens-util paredit lispyville lispy swiper iedit iedit-lib multiple-cursors-core lispy-inline avy semantic/db eieio-base semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet ediff-merg ediff-wind ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff help-fns radix-tree lispy-tags elisp-slime-nav eval-sexp-fu company-quickhelp warnings highlight font-lock+ flycheck-pos-tip pos-tip flycheck json map find-func shackle JJ-extra-lang make-mode JJ-elisp edebug-x edebug which-func imenu JJ-autocomplete elixir-yasnippets yasnippet company-oddmuse company-keywords company-etags etags xref project company-gtags company-files company-capf company-cmake company-xcode company-clang company-semantic company-eclim company-template company-css company-nxml company-dabbrev-code company-dabbrev company-yasnippet company-bbdb company JJ-evil evil-surround evil-visualstar evil-matchit evil evil-integration evil-maps evil-commands flyspell ispell evil-jumps evil-command-window evil-types evil-search evil-ex evil-macros evil-repeat evil-states evil-core evil-common derived rect evil-digraphs evil-vars undo-tree diff JJ-project recentf tree-widget wid-edit ivy flx delsel ivy-overlay ffap JJ-pair-editing smartparens-config smartparens thingatpt JJ-misc fold-dwim-org fold-dwim hideshow noutline outline windmove hungry-delete ws-butler JJ-platform exec-path-from-shell ls-lisp JJ-defaults paren whitespace autorevert filenotify winner JJ-theme foggy-night-theme cl-extra help-mode theme-changer solar cal-dst cal-menu calendar cal-loaddefs cl JJ-dependencies hydra ring lv s dash JJ-funcs subr-x use-package diminish bind-key easy-mmode finder-inf edmacro kmacro rx advice slime-autoloads info package easymenu epg-config url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs pcase cl-lib time-date tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 892577 534002) (symbols 48 60548 281) (miscs 40 882 3402) (strings 32 161034 279476) (string-bytes 1 5481778) (vectors 16 98335) (vector-slots 8 2434861 513384) (floats 8 884 2213) (intervals 56 6906 1373) (buffers 976 24)) From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: Ingo Lohmar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Jun 2017 18:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: James Nguyen , 27503@debbugs.gnu.org Cc: james@jojojames.com Received: via spool by 27503-submit@debbugs.gnu.org id=B27503.149858738420299 (code B ref 27503); Tue, 27 Jun 2017 18:17:02 +0000 Received: (at 27503) by debbugs.gnu.org; 27 Jun 2017 18:16:24 +0000 Received: from localhost ([127.0.0.1]:41140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPv2F-0005HL-MJ for submit@debbugs.gnu.org; Tue, 27 Jun 2017 14:16:23 -0400 Received: from mail-wm0-f67.google.com ([74.125.82.67]:32898) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPv2E-0005H8-2T for 27503@debbugs.gnu.org; Tue, 27 Jun 2017 14:16:22 -0400 Received: by mail-wm0-f67.google.com with SMTP id j85so7297150wmj.0 for <27503@debbugs.gnu.org>; Tue, 27 Jun 2017 11:16:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=3N9lNyJ5Ntdoy+S4Z7NA5gj2oS/xps/1QxVXhFey/Js=; b=MF7wWuVqNnNGq/2LVroAmiDRtkbwj9xJBsH1D22+1voo57SB9CYwr7R3NG8RjsbbnV Tb0QjuVc9B6jjl8FA9wqBEwwhf+OuEl3LB4BVq3T5/WEf0JhnUDBgfelodM1T0I5C+Ox GSkhnPHqFVMXNBERUeett9eVtJsvoMvYzQeboSRGyQusyAxg1gkQZEwaxHoceSssP39i t1guKw0AQ2nGTSVrqfN7PhrsRa0zhOLHNLjSMguPqjE/Bn0C2hebPWjd1AbcOkCIrw1k AzKd06PmcfBh5XgZcP8W2XYaOho8Jh0yKbcS0X2BhNj8EYbFvXJI3nNXKjWilK4VBHol OeWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=3N9lNyJ5Ntdoy+S4Z7NA5gj2oS/xps/1QxVXhFey/Js=; b=Bu1cYgm9dvKP5uax8AaX3LFhyKgVsxahBsNp00fGUhfWqhz0WCuqpa9D1MTWH8vjCx +vebju9vU7M0ZJP9LWMeJJE2YoZLRmgPBdUVN9hCh7/rx/j4mhIyqhZvZdYPRiRu76GT A5+nYqons0pCjX9AP5GDNJk0LDM/5ajxG//9NWWQwild1M8xRnOF5fW7M8s1CJ6r9d+d djucI5p+zeFzCsLw2hw1ukn0E7ykOJBoOpkNmPnoh8XEsct0joP4n219OuDTB8QUSOQJ 0g9Xgr295CUECmm35qF4E4b91KZ7PbVs5wdIv8VBFlnQl4PiOYL7kYJOYVt6k0B1nHRs CmaA== X-Gm-Message-State: AKS2vOzhnhTyG2H0LT15UXJ95lV5tbgpLwprNEiURFSKX/jPAufgUBIA 1oXegMo5X/EO+w== X-Received: by 10.80.165.229 with SMTP id b34mr4772714edc.29.1498587376288; Tue, 27 Jun 2017 11:16:16 -0700 (PDT) Received: from localhost (xdsl-213-168-118-85.netcologne.de. [213.168.118.85]) by smtp.gmail.com with ESMTPSA id l4sm1706231edb.35.2017.06.27.11.16.15 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Jun 2017 11:16:15 -0700 (PDT) From: Ingo Lohmar In-Reply-To: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> Date: Tue, 27 Jun 2017 20:16:14 +0200 Message-ID: <87fuel70up.fsf@acer.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) I've been meaning to post this for months, guess now is as good a time as any. Here's an alternative take that I've been using for a long time without noticing any bugs. It is a less intrusive change to achieve the desired effect AFAICT: diff --git i/lisp/progmodes/js.el w/lisp/progmodes/js.el index bae9e52bf0..a27db82eb0 100644 --- i/lisp/progmodes/js.el +++ w/lisp/progmodes/js.el @@ -475,6 +475,11 @@ js-flat-functions :type 'boolean :group 'js) +(defcustom js-cont-nonempty-list-indent-rigidly nil + "Indent continuation of non-empty ([{ lines in `js-mode' rigidly." + :type 'boolean + :group 'js) + (defcustom js-comment-lineup-func #'c-lineup-C-comments "Lineup function for `cc-mode-style', for C comments in `js-mode'." :type 'function @@ -2092,7 +2097,8 @@ js--proper-indentation (switch-keyword-p (looking-at "default\\_>\\|case\\_>[^:]")) (continued-expr-p (js--continued-expression-p))) (goto-char (nth 1 parse-status)) ; go to the opening char - (if (looking-at "[({[]\\s-*\\(/[/*]\\|$\\)") + (if (or js-cont-nonempty-list-indent-rigidly + (looking-at "[({[]\\s-*\\(/[/*]\\|$\\)")) (progn ; nothing following the opening paren/bracket (skip-syntax-backward " ") (when (eq (char-before) ?\)) (backward-list)) From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: James Nguyen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Jun 2017 20:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ingo Lohmar , James Nguyen , 27503@debbugs.gnu.org Received: via spool by 27503-submit@debbugs.gnu.org id=B27503.149859572432754 (code B ref 27503); Tue, 27 Jun 2017 20:36:02 +0000 Received: (at 27503) by debbugs.gnu.org; 27 Jun 2017 20:35:24 +0000 Received: from localhost ([127.0.0.1]:41205 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPxCl-0008WE-VP for submit@debbugs.gnu.org; Tue, 27 Jun 2017 16:35:24 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:41479) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPwNf-0007Ez-37 for 27503@debbugs.gnu.org; Tue, 27 Jun 2017 15:42:36 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 4D86922E44; Tue, 27 Jun 2017 15:42:34 -0400 (EDT) Received: from web3 ([10.202.2.213]) by compute1.internal (MEProxy); Tue, 27 Jun 2017 15:42:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=fm1; bh=f4z0vUoMxmafM7ApbXUlaVe/Hn4wK mwNeqfO2t4cyPo=; b=X8DxMYYNxFIoXf3gepj7aOsH728Mnf05u0Cs1S6U2mtk9 zSlmP15MO91ziIXtbjg0o5LGNUXE+FPbbcPI9pOv7kGR8dOi44gi9zH9Idbx0xaG pXDt+UX5OWktCDrZA4Ja239kurEWhNI6VZgDom56gcf0hY9GmGcXfypK1gE4bnzM GsfVfY3cYf5DblBqUDbNkTjpjm+2o/CPayUGu42XSCKhU3u7fQXxmnHDQXKMfyzx 9zwrMG9TbDXCC+cJ51cYAc3h2weWsEquRHARUM3fz5C6CjaQfj25YEEWG+t6j+mt b2KCNLXnoSCpG7Gc1NNSYpvYc36+VG26t4KQhBa6A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=f4z0vU oMxmafM7ApbXUlaVe/Hn4wKmwNeqfO2t4cyPo=; b=Fp1V0XHBGQqFFhLkEUN8c5 vhIUJMmpmfh8gPSrwBCU9QM1pAUpaFQ6cHZo6Cz2fwlWb8oFuSQpyRatWcoubT3B 7IHQ/Nf/+hOj7kRxSMPVJJXGtHAY9biHPkbPOmDnlXdN4b9207h5PBY1jftkm34T Bxdidysug167u58E8Iq4+9FKhdBGQN6nLjONGzByf0Wscy1UX3ejhfIxItLHvIDA C7YiUQ6rxblsqWdXUJ3xrNFDhs/r/dEeLExODvwZtzIJw5BhevbUZY5CIBGFr8U3 g4S6UPT4lqS8JpZakGaFITbnxYqrNvB/n0bo3cvZIYBrzc0TPjBjj2O14b32wzzg == X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id 21E0D9EB8C; Tue, 27 Jun 2017 15:42:34 -0400 (EDT) Message-Id: <1498592554.2776738.1023241160.654C742F@webmail.messagingengine.com> From: James Nguyen MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-07d9e719 Date: Tue, 27 Jun 2017 12:42:34 -0700 In-Reply-To: <87fuel70up.fsf@acer.localhost.com> References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> X-Spam-Score: -0.7 (/) X-Mailman-Approved-At: Tue, 27 Jun 2017 16:35:22 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This would effectively be the same as my snippet right? I removed the if check and the else block to always go into the progn. This looks good to me unless there are other gotchas. Making it configurable is ideal. -- James Nguyen jamesn@fastmail.com On Tue, Jun 27, 2017, at 11:16 AM, Ingo Lohmar wrote: > I've been meaning to post this for months, guess now is as good a time > as any. Here's an alternative take that I've been using for a long time > without noticing any bugs. It is a less intrusive change to achieve the > desired effect AFAICT: > > > > diff --git i/lisp/progmodes/js.el w/lisp/progmodes/js.el > index bae9e52bf0..a27db82eb0 100644 > --- i/lisp/progmodes/js.el > +++ w/lisp/progmodes/js.el > @@ -475,6 +475,11 @@ js-flat-functions > :type 'boolean > :group 'js) > > +(defcustom js-cont-nonempty-list-indent-rigidly nil > + "Indent continuation of non-empty ([{ lines in `js-mode' rigidly." > + :type 'boolean > + :group 'js) > + > (defcustom js-comment-lineup-func #'c-lineup-C-comments > "Lineup function for `cc-mode-style', for C comments in `js-mode'." > :type 'function > @@ -2092,7 +2097,8 @@ js--proper-indentation > (switch-keyword-p (looking-at > "default\\_>\\|case\\_>[^:]")) > (continued-expr-p (js--continued-expression-p))) > (goto-char (nth 1 parse-status)) ; go to the opening char > - (if (looking-at "[({[]\\s-*\\(/[/*]\\|$\\)") > + (if (or js-cont-nonempty-list-indent-rigidly > + (looking-at "[({[]\\s-*\\(/[/*]\\|$\\)")) > (progn ; nothing following the opening paren/bracket > (skip-syntax-backward " ") > (when (eq (char-before) ?\)) (backward-list)) From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: Ingo Lohmar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Jun 2017 20:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: James Nguyen , James Nguyen , 27503@debbugs.gnu.org Received: via spool by 27503-submit@debbugs.gnu.org id=B27503.14985962991169 (code B ref 27503); Tue, 27 Jun 2017 20:45:01 +0000 Received: (at 27503) by debbugs.gnu.org; 27 Jun 2017 20:44:59 +0000 Received: from localhost ([127.0.0.1]:41217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPxM3-0000Im-Bk for submit@debbugs.gnu.org; Tue, 27 Jun 2017 16:44:59 -0400 Received: from mail-wr0-f174.google.com ([209.85.128.174]:35675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPxM1-0000Ia-Sj for 27503@debbugs.gnu.org; Tue, 27 Jun 2017 16:44:58 -0400 Received: by mail-wr0-f174.google.com with SMTP id k67so164386762wrc.2 for <27503@debbugs.gnu.org>; Tue, 27 Jun 2017 13:44:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:in-reply-to:references:date:message-id:mime-version; bh=hDqLiv4pf72kmEdvG4ZiVW5hiGdvRevXDuRusdnnmHM=; b=XDVBnfAEO+1AeMd5OKeovfHucQhLAU4RWZFtPzqznzQuXT62bbNZh5QGJ1wmZVYlXR dNfKGQnPYRNamuZXQMW8OPIcijF9ETFecGcpT3cmDDJfnBaiwtY1MobZp9JZl0qObvlV aaO006htvB8IhoJ9WltkQfBtVsoEutLnWhWTk+wK3dpg88yyLvnOHOURqEYkZ8Tsqy2t jaVOCJ1Xeb6hvFQqdgCOvPav9huLFlibQgWNrq4f6Dg2AVA4mE/Ai9HmjcU26C2W+w/h sSNnww/lqX3mfQzBgKFbNkSPuC2jPwSzxpew5WmvIsOrDA36Z1R6GRP8ePlzjlayf2a+ lC9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:in-reply-to:references:date :message-id:mime-version; bh=hDqLiv4pf72kmEdvG4ZiVW5hiGdvRevXDuRusdnnmHM=; b=s/lY3uLayl5ajdChOtOzhtM1UwfeFb9kabAqKH+mfmDwQGx2/72Cc1KZ/temWOBKhr 0J2cchojDBXwNUWLhIqZ/MFUGM21KqARwpnQ10mFzRvmPJdvpuX2cyzVFtydS5ElMwMF cbQxN/T2UpDZEzk5sjGf3eRJ+tmSZT6NkJpqgU4jDxaz3wFZqwBXgPRxSU6lYMW1yN/8 HkOrr9ZTcQ8LJii8CAt5+IWP0f8h/UHZPziuCdtGnnO4AWpArCV/6tO7WlgpdZeZqaB7 jD1dXQsIagR609T2V+mukN3Sd8OrVD7jEDvLYFw9pwAnyPSL/sB9n9kyDgFqBth2zTae 388g== X-Gm-Message-State: AKS2vOwuXoYl/KnVmqUqAbrSphLBsMIYu6mBfP7ISPijeEYBbN897wkP V5aQgCYfBMhjJA== X-Received: by 10.223.160.174 with SMTP id m43mr6942913wrm.194.1498596291987; Tue, 27 Jun 2017 13:44:51 -0700 (PDT) Received: from localhost (xdsl-213-168-118-85.netcologne.de. [213.168.118.85]) by smtp.gmail.com with ESMTPSA id u17sm3640453wma.8.2017.06.27.13.44.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 27 Jun 2017 13:44:51 -0700 (PDT) From: Ingo Lohmar In-Reply-To: <1498592554.2776738.1023241160.654C742F@webmail.messagingengine.com> References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> <1498592554.2776738.1023241160.654C742F@webmail.messagingengine.com> Date: Tue, 27 Jun 2017 22:44:50 +0200 Message-ID: <87d19p6tz1.fsf@acer.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.8 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On Tue, Jun 27 2017 12:42 (-0700), James Nguyen wrote: > This would effectively be the same as my snippet right? I removed the if > check and the else block to always go into the progn. You're right, and I am sorry for my bad choice of words, I did not mean to imply otherwise. In fact I have to admit I did not check your code in detail, I just noticed that the behavior was fixed (like you stated). Thanks for starting the bug report, I would be happy if that change would land in Emacs. From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: James Nguyen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jun 2017 00:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ingo Lohmar Cc: 27503@debbugs.gnu.org Received: via spool by 27503-submit@debbugs.gnu.org id=B27503.1498610732328 (code B ref 27503); Wed, 28 Jun 2017 00:46:01 +0000 Received: (at 27503) by debbugs.gnu.org; 28 Jun 2017 00:45:32 +0000 Received: from localhost ([127.0.0.1]:41333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQ16p-00004y-UM for submit@debbugs.gnu.org; Tue, 27 Jun 2017 20:45:32 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:58177) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQ16o-0008Tp-2s for 27503@debbugs.gnu.org; Tue, 27 Jun 2017 20:45:30 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1297E20983; Tue, 27 Jun 2017 20:45:29 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Tue, 27 Jun 2017 20:45:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=pWInHDRHQbQKhuqFA3 F8NtZBes1GTqnGMadVkT3j8WU=; b=AbJe6vwORLhYh3PIbJoe83LHwjleSaxexn 4OOMOze2mTxy118xnmgl+TKbb1f4bMej1fjlaFWw5+kJOVZ3a2R4L1yv08teomBV ng4X/1r8JXfVqau2yaTV2oKNLItN6U9mv/1fu5SDVxwGDnfwaEr93OndCK+rGYhQ ozn5Nonsl2mdRaRYZJ8c90df+ZgESQxVE9UjrCuFES5dBQVoyerJG81gLwM1kSVM MK9F/qVZ4rOE2GN8hzn5NPIMFdTLXFHd8B7HyPACgsZv/ToUlujO5prcV4tEQLAN X7XV+DH0AkabnWzOncoiMug7BIyAIIzKl6a3Z9thJe7ETJvRqYHA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=pWInHDRHQbQKhuqFA3F8NtZBes1GTqnGMadVkT3j8WU=; b=gYPKEvyG +N9Nis2DcmlcDjS2BH+OhL30auo5zUW3XxDRC1Xb/QqBK5d+tr+RLk2TaApiotCe RJi7veV5I7bAtMYQ36xStBcUKRoddKELC2fr4DC4xQpbvLabsJlWJIf+Ph6i0GTv C9tUoWIbeUSbgDAlw+MA6DeXP05Lsab7jeCa5TJTIi2NPQlpR2VfUZP7sefnl+nC AVmSiOBYX0bX8eHXIDdI/RFcXauzBbTRxAqPepPLWPnJCaaDwxa9d1QL+bfRgsEV RVJQ/KFlK+Xa56QbwO6iKzTu/pGxhRJz0vKs10ILQNpXbbFRmcjAkbEeCzlPPbF6 aJ0AE1eDYYUehQ== X-ME-Sender: X-Sasl-enc: Grac6TTVL6NmIMhanFd/w1ajm6d4d+pBmthheI7zqkzj 1498610728 Received: from [10.0.1.47] (c-73-231-191-86.hsd1.ca.comcast.net [73.231.191.86]) by mail.messagingengine.com (Postfix) with ESMTPA id 2A12C7E71B; Tue, 27 Jun 2017 20:45:28 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) From: James Nguyen In-Reply-To: <87d19p6tz1.fsf@acer.localhost.com> Date: Tue, 27 Jun 2017 17:45:30 -0700 Content-Transfer-Encoding: 7bit Message-Id: References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> <1498592554.2776738.1023241160.654C742F@webmail.messagingengine.com> <87d19p6tz1.fsf@acer.localhost.com> X-Mailer: Apple Mail (2.3273) X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) No problem, I was just confirming. I prefer your snippet anyhow. > On Jun 27, 2017, at 1:44 PM, Ingo Lohmar wrote: > > On Tue, Jun 27 2017 12:42 (-0700), James Nguyen wrote: > >> This would effectively be the same as my snippet right? I removed the if >> check and the else block to always go into the progn. > > You're right, and I am sorry for my bad choice of words, I did not mean > to imply otherwise. In fact I have to admit I did not check your code > in detail, I just noticed that the behavior was fixed (like you stated). > > Thanks for starting the bug report, I would be happy if that change > would land in Emacs. From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jun 2017 10:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ingo Lohmar , James Nguyen , 27503@debbugs.gnu.org Cc: james@jojojames.com Received: via spool by 27503-submit@debbugs.gnu.org id=B27503.14986461307827 (code B ref 27503); Wed, 28 Jun 2017 10:36:02 +0000 Received: (at 27503) by debbugs.gnu.org; 28 Jun 2017 10:35:30 +0000 Received: from localhost ([127.0.0.1]:41626 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQAJl-00022B-Mm for submit@debbugs.gnu.org; Wed, 28 Jun 2017 06:35:29 -0400 Received: from mail-wm0-f45.google.com ([74.125.82.45]:37882) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQAJj-00021z-Fv for 27503@debbugs.gnu.org; Wed, 28 Jun 2017 06:35:27 -0400 Received: by mail-wm0-f45.google.com with SMTP id i127so53959568wma.0 for <27503@debbugs.gnu.org>; Wed, 28 Jun 2017 03:35:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=r9r2tTqNHfVRCb9Uhdh/28S64KB9J6Bfc+65swKl2NY=; b=RK7yeyI+xNyK5LVm6InsQ8muz8henLpsSIH3LhuFguOYisENd6WDT8omBZ3miBvmpt RzNPS/5dYkZxugFD+l9orqQdxVRkw8P76z8rzQ7lvy5usHDv+XejUVBRAkY5VLn/2f4W ZWZ1OJM4UzjL6IxRmPiVZKIV72ko6z0GVoOTgx0SfmsrNEtUQpTbSfKgFoVeektRJoAE SZnydIq5F2ioXbVatpP0djZGSZS9l0wssYTKpwJ9Mu/bkCLXooi0HHwl399MNZdO+WRO aH5+qBdLKIjuTZTzLPjV8wJp7cpPW6Ewv6C4vBaS8yHmwTrBJuGsBtV/8NQ3+PfNNPfb +AmA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=r9r2tTqNHfVRCb9Uhdh/28S64KB9J6Bfc+65swKl2NY=; b=r/swyL/dRz7cNu6oeo7vflip5VBwMGRC2EDDbqWYfgGv1sXSoycpwKahdirQ07jt6m WedHvWPBO5/04QXf3ZvEe9z5/rEwAwb7bzmfFaubyMiEx4RLYU4Esxn0KSE8zmgI5M48 bkSWZNLCBYtCYOGxqV73xzACEPfTfg/rSikQ6zqHvO90/Gp2kENZp05hjC8uIWxpzuXZ nFFKEeZO0QydfR9cZKT9LA4amFKwHhLDeQQuTxEAS0RWLZmqh7E1N4YA00qB+ucZLQ/F a7HV80wCJ1nAp1dxdvny+INAZSvbU1egjX6rSliwxp2QR4ksWHZ8IOsUAeCphfESkM+n Wr6g== X-Gm-Message-State: AKS2vOxLHUw31xiSUN0zZagHZaENG4Ac1eHv7NnjBJ7k2SVrHP1fyrsq S4bfu9Y6tuGbmA== X-Received: by 10.80.165.164 with SMTP id a33mr7165663edc.53.1498646121621; Wed, 28 Jun 2017 03:35:21 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id x13sm1012259edb.12.2017.06.28.03.35.19 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jun 2017 03:35:20 -0700 (PDT) References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> From: Dmitry Gutov Message-ID: Date: Wed, 28 Jun 2017 13:35:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 In-Reply-To: <87fuel70up.fsf@acer.localhost.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Hey Ingo, On 6/27/17 9:16 PM, Ingo Lohmar wrote: > diff --git i/lisp/progmodes/js.el w/lisp/progmodes/js.el > index bae9e52bf0..a27db82eb0 100644 > --- i/lisp/progmodes/js.el > +++ w/lisp/progmodes/js.el > @@ -475,6 +475,11 @@ js-flat-functions > :type 'boolean > :group 'js) > > +(defcustom js-cont-nonempty-list-indent-rigidly nil > + "Indent continuation of non-empty ([{ lines in `js-mode' rigidly." > + :type 'boolean > + :group 'js) The code looks okay to me. Any particular reason to call this variable "-rigidly"? What does that mean? From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jun 2017 10:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: James Nguyen , Ingo Lohmar , 27503@debbugs.gnu.org Received: via spool by 27503-submit@debbugs.gnu.org id=B27503.14986462118022 (code B ref 27503); Wed, 28 Jun 2017 10:37:01 +0000 Received: (at 27503) by debbugs.gnu.org; 28 Jun 2017 10:36:51 +0000 Received: from localhost ([127.0.0.1]:41648 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQAL5-00025J-Ky for submit@debbugs.gnu.org; Wed, 28 Jun 2017 06:36:51 -0400 Received: from mail-wm0-f44.google.com ([74.125.82.44]:37722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQAL3-000256-Jx for 27503@debbugs.gnu.org; Wed, 28 Jun 2017 06:36:49 -0400 Received: by mail-wm0-f44.google.com with SMTP id i127so53996622wma.0 for <27503@debbugs.gnu.org>; Wed, 28 Jun 2017 03:36:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=UbiEWJSwfeyYqSUUGORSbwrfY9DdlSBQ8lBCakDaGrw=; b=e3p1HIRIWZ9/xX3Acf7vO/EDI7ooJcZw+0L5qCESgamuGeHdF0bcCAnK/aEL0nNZ6/ GYzaVHVtYUomROCKXq8Pqsu8Pf5vHJFW0LuT9+YtwD+aC+LNTmKPbbyvbNF3t8uYSEIB K+zlJTScnF7if1z2nO+ANc0HwcjRnLce9k6mqftWD6Phl+C0aQh1l8Fr0RcfJRmhQvVG WMCZdRvY6Tu5hQzXnAIPJXti29zg9wLVi5FUxfht9EQ/jjhA/0PhHZDIxrFvA9qHpaCP mcYceQlvOpQO/9V5wLimHvncxTWRbdZeI4xPFY1ZIBccB6+5tf/BdJLeY+Vdot1LZrr3 a/+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UbiEWJSwfeyYqSUUGORSbwrfY9DdlSBQ8lBCakDaGrw=; b=pLx+93nxw2gehkLcwq52JTsMH7L8oN3xlPfBNHoKz9h2/JVVq6wThjTvPoXB8ctZwt HPy398dl2TCt16VSytivWkCjL6cOqxnXk0lLtv2B+0LR2PNG7bcuR+0baTHf64KBJfwH 212eyMepu45xnQB5jUjfWqRR8cUJtkcNEUKXu/GMg7YSz1jKFEG1gbWPIpIIRqNFRdOt 0dSj7dK+ukHrsXo4fVc/CLjqgJXzI2okbrbkVtxLq62xl+D0/v3UR1W22lbD3OD0WpMF ytGMIIXBWqF1mm7jsr2eIrkQh3kOeExUA5ciH+D8temsvqBRHAeHa2EArpjIA8vtbWoC 8Xrg== X-Gm-Message-State: AKS2vOznDKz1AeEddxjpTPiYLR2vydaANxLzQgv6It49tEW7i927Yy8r k22lzp9E12nBhAuow08= X-Received: by 10.80.152.22 with SMTP id g22mr7522959edb.38.1498646203761; Wed, 28 Jun 2017 03:36:43 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id k49sm1581340eda.45.2017.06.28.03.36.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jun 2017 03:36:43 -0700 (PDT) References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> <1498592554.2776738.1023241160.654C742F@webmail.messagingengine.com> From: Dmitry Gutov Message-ID: <3dc0b3be-30d0-0163-e868-c87f6548a05f@yandex.ru> Date: Wed, 28 Jun 2017 13:36:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 In-Reply-To: <1498592554.2776738.1023241160.654C742F@webmail.messagingengine.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On 6/27/17 10:42 PM, James Nguyen wrote: > This would effectively be the same as my snippet right? You are comparing a wall of "this works for me" code with a proper patch submission. From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: Nicolas Petton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jun 2017 10:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: James Nguyen , Ingo Lohmar , James Nguyen , 27503@debbugs.gnu.org Received: via spool by 27503-submit@debbugs.gnu.org id=B27503.14986474849982 (code B ref 27503); Wed, 28 Jun 2017 10:59:02 +0000 Received: (at 27503) by debbugs.gnu.org; 28 Jun 2017 10:58:04 +0000 Received: from localhost ([127.0.0.1]:41686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQAfb-0002av-PC for submit@debbugs.gnu.org; Wed, 28 Jun 2017 06:58:03 -0400 Received: from petton.fr ([89.234.186.68]:59854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQAfa-0002aO-K7 for 27503@debbugs.gnu.org; Wed, 28 Jun 2017 06:58:03 -0400 From: Nicolas Petton In-Reply-To: <1498592554.2776738.1023241160.654C742F@webmail.messagingengine.com> References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> <1498592554.2776738.1023241160.654C742F@webmail.messagingengine.com> Date: Wed, 28 Jun 2017 12:57:54 +0200 Message-ID: <87d19oxtu5.fsf@petton.fr> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=petton.fr; s=mail; t=1498647475; bh=OGxY43VNS7G5D7YEwSA0hgaskpkqp9DgmbW/C8GLUQ8=; h=From:To:Subject:In-Reply-To:References:Date:Message-ID:MIME-Version:Content-Type; b=HeBOhJhzZayWlESYlRhD37Nux/5Iv7ikUf1ZccGPkJOW8rkItbF5CO+JVtcZT4S2Eq8KnyKpPbQ/yOl3UCWsnBDvwD0+/9ZdoW+3Vyaqe3uyCm9R6k5sohLx57fuJzCWne6gl/xz/1dAjxVTOkFXrE0LxDR1AGSEyavHkD9kmUc= X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) --=-=-= Content-Type: text/plain James Nguyen writes: > This would effectively be the same as my snippet right? I removed the if > check and the else block to always go into the progn. > > This looks good to me unless there are other gotchas. Making it > configurable is ideal. The patch looks good to me. I have been using a similar one for quite some time. Cheers, Nico --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJZU4uyAAoJECM1h6R8IHkQXEgIANJKZsoi238ciEYfdEEbuBOi T2AkzidQP1rhCO2ZU4BuIcCkIOH70V3cCs1DXNacAhHZVCapZABMSmTKyf7GBh4+ EJL0EF0EW8ZXjYTYpbo/IxU191Fkr4FTD5MmRJiVcjGrZrdllTiBsh3/JVWUuzgj yqNgB/F9tEjeP4TdFm8VwgysDXZTI4J50OPDPTpdrpeSIWqwBMs52Bdwh5w/LKzK saWIef3La7xDjR9uVZ74IAGZ1LFavDSAaukzzZddXXQnFacMF9/1Ecscyhc3ran2 2VB6biYcp5fC3yOiXiIjDamktPvb7aYp1JET3XL2w2M6RoNjJqtbX1hSMSFxfiw= =gfIR -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: Ingo Lohmar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Jun 2017 14:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 27503@debbugs.gnu.org, James Nguyen , james@jojojames.com Received: via spool by 27503-submit@debbugs.gnu.org id=B27503.149866179921578 (code B ref 27503); Wed, 28 Jun 2017 14:57:02 +0000 Received: (at 27503) by debbugs.gnu.org; 28 Jun 2017 14:56:39 +0000 Received: from localhost ([127.0.0.1]:42785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQEOV-0005by-Eb for submit@debbugs.gnu.org; Wed, 28 Jun 2017 10:56:39 -0400 Received: from mail-ua0-f170.google.com ([209.85.217.170]:35729) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQEOU-0005bn-Ih for 27503@debbugs.gnu.org; Wed, 28 Jun 2017 10:56:38 -0400 Received: by mail-ua0-f170.google.com with SMTP id j53so39421061uaa.2 for <27503@debbugs.gnu.org>; Wed, 28 Jun 2017 07:56:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=T9U0mt9dqzVxh4L6Jcq3AqcVESAxzERGs+XfDsP7gio=; b=UWjLI0gPF++TZOBeptjLIWt9G8kGfLA9BSn9p8ezdZ9vL7XLb69EOP16tYw9QJ43pd elmJ4fLT9aTq8T3WehFQ57ckQPKTfxUBofosgszQnpgwUrvu6hpwXdInLjXYP9Dey5mH XQZZuT4XJ47zeu9MM2NDpUbg4gX3KyoGkKF6w4YvSrhzN6tjELBLQLWH4u5SS8zXkYHS Zz6b7JO3ImedIbw/z23PGuq4hKUVU4seY5jgrVj2BmBOo7NnMBucmhXO6VKemhVLn+4f r2hby3A6X6tc1YKwDe4WRxOxNx7u7I/qc0rsN2muW28g3omWYIOzv2xbufSoKD37bAm7 /svg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=T9U0mt9dqzVxh4L6Jcq3AqcVESAxzERGs+XfDsP7gio=; b=GJ27PjEvcgHeEUte8tBtkMEuHL5H7Q0Y9vQYmMu2GCb7/7umA+fhfRpc/APXVusvZN FgGcTHOv1En42h4pE3VBtC2HaisK2T2ye0zTSeZQ7t0WGh1PEWecgUl4UYuNVuqrE+hY RbxwxKsCizSfydKp8BdrENAp9dzVR6y5V2HFWnvN8JW/UlGZArJZoOBnSX/DXuL3KXN9 G/KirOLIzt/tWl42q/Acetm+OPloGmEiWlAxZL7Ch5JZrmcnw2qfeIUcBgoSuR949CaX rzKwJ/nP/nmpgyHpmdOolBanAvfyKRFRL9gSxLACSkXNXddOcRKb2GfETQiOxqfZWuVg pNkw== X-Gm-Message-State: AKS2vOw7YDArtGxCLH9Hu+JgXMbsswEUvvWz1ppB8sjS3XCaS/hQNBLq 7xy2TN7zjIhb03tlc0jVXWRB6RfAoQ== X-Received: by 10.176.23.3 with SMTP id j3mr6812474uaf.128.1498661792878; Wed, 28 Jun 2017 07:56:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.31.99.129 with HTTP; Wed, 28 Jun 2017 07:56:32 -0700 (PDT) Received: by 10.31.99.129 with HTTP; Wed, 28 Jun 2017 07:56:32 -0700 (PDT) In-Reply-To: References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> From: Ingo Lohmar Date: Wed, 28 Jun 2017 16:56:32 +0200 Message-ID: Content-Type: multipart/alternative; boundary="f40304361f38cdc50e0553066338" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) --f40304361f38cdc50e0553066338 Content-Type: text/plain; charset="UTF-8" Rigidly was just meant as the opposite of the default "aligned" indentation, I am not attached to the variable name *at all*. Maybe ...-indent-aligned and change the default to t? On Jun 28, 2017 12:35, "Dmitry Gutov" wrote: The code looks okay to me. Any particular reason to call this variable "-rigidly"? What does that mean? --f40304361f38cdc50e0553066338 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Rigidly was just meant as the opposite of the defaul= t "aligned" indentation, I am not attached to the variable name *= at all*. Maybe ...-indent-aligned and change the default to t?

On Jun 28, 2017 12:35, &qu= ot;Dmitry Gutov" <dgutov@yandex= .ru> wrote:
The code looks okay to me. Any particular reason to call this variable
"-rigidly"? What does that mean?

--f40304361f38cdc50e0553066338-- From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Jun 2017 00:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ingo Lohmar Cc: 27503@debbugs.gnu.org, James Nguyen , james@jojojames.com Received: via spool by 27503-submit@debbugs.gnu.org id=B27503.14986975639996 (code B ref 27503); Thu, 29 Jun 2017 00:53:02 +0000 Received: (at 27503) by debbugs.gnu.org; 29 Jun 2017 00:52:43 +0000 Received: from localhost ([127.0.0.1]:43152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQNhK-0002bA-Rj for submit@debbugs.gnu.org; Wed, 28 Jun 2017 20:52:43 -0400 Received: from mail-wr0-f179.google.com ([209.85.128.179]:34667) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dQNhI-0002au-Cf for 27503@debbugs.gnu.org; Wed, 28 Jun 2017 20:52:40 -0400 Received: by mail-wr0-f179.google.com with SMTP id 77so181996177wrb.1 for <27503@debbugs.gnu.org>; Wed, 28 Jun 2017 17:52:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FdjHObCEEMBXA2AND7n+8dQoGNhefhgBA23IUxDRZzA=; b=BjyOd40VGvyCU/McoV9Hbkf9SxqrgAw+dW/Lo6YiYxWysauMzs/RB5pB+XHQqtHYj8 DHejhj4BvaWwz4coioYDIRQLWDgyZU0NgALq73kBx/RYyKM6rVQG3NShrGr08dx7/PX2 zdMqGLC3Z5F3zjrFOw70k8lkIL7Cs0V3L+NdPa8mVHLi68MePv+6sbJrVQeNEN+jtm7i pH98TIdI4nzVDhzFX0URC4rwxakJC0NEdRTVRpdEbBo2FHeHU2dzWIie6Q1qyzIDnTL1 GkWRoU5YjgMMq6iX5rr/wDc09dhJpqeEaKXdHa1ZV1+kh/zgYJBEHoq5LOOLMAziAkxD PDwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FdjHObCEEMBXA2AND7n+8dQoGNhefhgBA23IUxDRZzA=; b=cNeE7deFG/kvxQPur+BKRpWTVtulEY8E1HlR0/b48oJXvb2wd50mbtb0jwyRKeu6Jj hoCWaEVik1DsgYHT1d/bHRoxtwEZ2NsqZ90mhkzCDJm52hjktU53qdnhDs1eWG/OhyfG JTptRvQ/lpUkTY7m9umZ4CjbCVwvlbfCo9coFYytpR+P7nBbMSBxUpDvXr5jMtaffNl5 B+KJOddIbMV7x/wVmmF23Scf2M4ZVWPeuN92NlAVBRWE+/B8r2COTumQ1MEFs6Wyiu6U //Sc2yYmfTNZZ2ClSXlWnOU1vGhDoTj2NifwtfH/yNYLcRApnuCMVK1CAkuyacBi9Nyz ZcwQ== X-Gm-Message-State: AKS2vOzzo7X2yIzartCKVnhH58uN1504ncB7tpdycHJuyvIBDtAFZtbN TnbxoLAid/rZGQ== X-Received: by 10.223.163.12 with SMTP id c12mr20636921wrb.85.1498697554521; Wed, 28 Jun 2017 17:52:34 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id r142sm8489976wmg.24.2017.06.28.17.52.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 28 Jun 2017 17:52:33 -0700 (PDT) References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> From: Dmitry Gutov Message-ID: Date: Thu, 29 Jun 2017 03:52:31 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) On 6/28/17 5:56 PM, Ingo Lohmar wrote: > Rigidly was just meant as the opposite of the default "aligned" > indentation, I am not attached to the variable name *at all*. Maybe > ...-indent-aligned and change the default to t? Sounds good to me. Maybe also add an example file in test/manual/indent? From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: Ingo Lohmar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Jul 2017 11:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 27503@debbugs.gnu.org, James Nguyen , james@jojojames.com Received: via spool by 27503-submit@debbugs.gnu.org id=B27503.149890821016659 (code B ref 27503); Sat, 01 Jul 2017 11:24:02 +0000 Received: (at 27503) by debbugs.gnu.org; 1 Jul 2017 11:23:30 +0000 Received: from localhost ([127.0.0.1]:46949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRGUs-0004Kc-89 for submit@debbugs.gnu.org; Sat, 01 Jul 2017 07:23:30 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34240) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRGUp-0004KP-Sf for 27503@debbugs.gnu.org; Sat, 01 Jul 2017 07:23:28 -0400 Received: by mail-wm0-f68.google.com with SMTP id p204so12095613wmg.1 for <27503@debbugs.gnu.org>; Sat, 01 Jul 2017 04:23:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=YICGvbNetsaoItDau+5T+/RZW3p43yXpp2QFGr1pa7U=; b=cgab5/VnhQEeQWl5jJkgW4oVWwUgVcRN7ch4mVMaIYr9SRilE1wgWwreHLyzUIrncm vz3jxot9XO4Gz5cw4+taVsTgegdG1ZA757JrKm7npXo9h5vRTwQeDuULNQyOxbjuefpW X/431tk4csJw/+LNemC0pkiv6N5HNs2E+0tS30E/N6UQFvEMuD86+oaxLr7Sx2E1/XSr PBl/sfaNFLjMJqWds961ndD9x2wh2ICK+e6lOefqBdZbgZarC34YAoHRCzlsYUtncgEA 0WrpnkUtGGLTYFKE3ZvxqTKCqQe0VPWp/W0RkZ5G8ieNF2IDvhhPyzS/JQuussMbvZUU OMgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=YICGvbNetsaoItDau+5T+/RZW3p43yXpp2QFGr1pa7U=; b=U/HgLp36lzMdt4VD5YFzmJJPocKCpj6adqAWg8D6wDY6oPvR4+Ll4kUkjg8kpwF56d HUioeR32I/DJF5vSrx32/ZdaxlSpsBNVS5LoJCLdqe7pp++SsH+8nKTxmM5llB5u3BkG 6Tp7zGp0RKVRKWVso9z7Fiwj9IUfmyciWmTjSepUEVG3UxyYn5Ltk0zkXFmOLQOgMUHR W+bqiWd4WcVExd9NtcH62FeLEExnGFDIVDDwZnLwciWPYXpTbLI5Yr1vh4O2ekALf0a2 9ywg3PZMH4nRGjfZ/HeQALEsJpy1diPu08oxSYqqk+rH/k7uoe/9db/FxusJ12dWrqEa GwFg== X-Gm-Message-State: AKS2vOz+pxrjnuDMxsdkENEFT3zybHvIrlII9aghkNwOO8As2BWuACeN JGUaWOdGDpP91w== X-Received: by 10.80.224.2 with SMTP id e2mr8661207edl.21.1498908201870; Sat, 01 Jul 2017 04:23:21 -0700 (PDT) Received: from localhost (xdsl-87-79-227-74.netcologne.de. [87.79.227.74]) by smtp.gmail.com with ESMTPSA id g38sm4098039edc.7.2017.07.01.04.23.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 01 Jul 2017 04:23:21 -0700 (PDT) From: Ingo Lohmar In-Reply-To: References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> Date: Sat, 01 Jul 2017 13:23:20 +0200 Message-ID: <877ezs7653.fsf@acer.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Thu, Jun 29 2017 03:52 (+0300), Dmitry Gutov wrote: > On 6/28/17 5:56 PM, Ingo Lohmar wrote: >> Rigidly was just meant as the opposite of the default "aligned" >> indentation, I am not attached to the variable name *at all*. Maybe >> ...-indent-aligned and change the default to t? > > Sounds good to me. Maybe also add an example file in test/manual/indent? Hi Dmitry, I hope I understood the manual/indent idea correctly. Below is the updated patch including a test file. I changed the variable name to `js-indent-cont-nonempty-aligned' now (with "flipped" boolean meaning, as discussed before). This is more succinct and starts with `js-indent-...' to convey the feature area to which this setting belongs. What's the procedure for patches arising from a bug report --- should I add a NEWS entry (for 26.1, marked +++) and just commit this to master myself? >From f0ec15d5fa82b0ca9b4c6aa7032262252ab63e40 Mon Sep 17 00:00:00 2001 From: Ingo Lohmar Date: Sat, 1 Jul 2017 13:09:20 +0200 Subject: [PATCH] Offer non-aligned indentation in lists in js-mode (Bug#27503) * lisp/progmodes/js.el (js--proper-indentation): New customization option 'js-indent-cont-nonempty-aligned'. Affects argument lists as well as arrays and object properties. * test/manual/indent/js-indent-cont-nonempty-aligned-nil.js: Test the change. --- lisp/progmodes/js.el | 8 +++++++- .../indent/js-indent-cont-nonempty-aligned-nil.js | 20 ++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) create mode 100644 test/manual/indent/js-indent-cont-nonempty-aligned-nil.js diff --git a/lisp/progmodes/js.el b/lisp/progmodes/js.el index bae9e52bf0..d284ddae4d 100644 --- a/lisp/progmodes/js.el +++ b/lisp/progmodes/js.el @@ -475,6 +475,11 @@ js-flat-functions :type 'boolean :group 'js) +(defcustom js-indent-cont-nonempty-aligned t + "Align continuation of non-empty ([{ lines in `js-mode'." + :type 'boolean + :group 'js) + (defcustom js-comment-lineup-func #'c-lineup-C-comments "Lineup function for `cc-mode-style', for C comments in `js-mode'." :type 'function @@ -2092,7 +2097,8 @@ js--proper-indentation (switch-keyword-p (looking-at "default\\_>\\|case\\_>[^:]")) (continued-expr-p (js--continued-expression-p))) (goto-char (nth 1 parse-status)) ; go to the opening char - (if (looking-at "[({[]\\s-*\\(/[/*]\\|$\\)") + (if (or (not js-indent-cont-nonempty-aligned) + (looking-at "[({[]\\s-*\\(/[/*]\\|$\\)")) (progn ; nothing following the opening paren/bracket (skip-syntax-backward " ") (when (eq (char-before) ?\)) (backward-list)) diff --git a/test/manual/indent/js-indent-cont-nonempty-aligned-nil.js b/test/manual/indent/js-indent-cont-nonempty-aligned-nil.js new file mode 100644 index 0000000000..428e922fbb --- /dev/null +++ b/test/manual/indent/js-indent-cont-nonempty-aligned-nil.js @@ -0,0 +1,20 @@ +const funcAssignment = function (arg1, + arg2, + arg3) { + return { test: this, + which: "would", + align: "as well with the default setting" + }; +} + +function funcDeclaration(arg1, + arg2 +) { + return [arg1, + arg2]; +} + +// Local Variables: +// indent-tabs-mode: nil +// js-indent-cont-nonempty-aligned: nil +// End: -- 2.11.0 From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jul 2017 02:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ingo Lohmar Cc: 27503@debbugs.gnu.org, James Nguyen , james@jojojames.com Received: via spool by 27503-submit@debbugs.gnu.org id=B27503.149904790127378 (code B ref 27503); Mon, 03 Jul 2017 02:12:02 +0000 Received: (at 27503) by debbugs.gnu.org; 3 Jul 2017 02:11:41 +0000 Received: from localhost ([127.0.0.1]:49271 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRqpx-00077W-Da for submit@debbugs.gnu.org; Sun, 02 Jul 2017 22:11:41 -0400 Received: from mail-wr0-f178.google.com ([209.85.128.178]:34983) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRqpu-00077H-R5 for 27503@debbugs.gnu.org; Sun, 02 Jul 2017 22:11:39 -0400 Received: by mail-wr0-f178.google.com with SMTP id k67so226416001wrc.2 for <27503@debbugs.gnu.org>; Sun, 02 Jul 2017 19:11:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=LbL1VPC3COXzIgLe/uqV253OkfGm5Wks+6mRKuWa/gY=; b=oxWYJ15oj5tJAJ//3QI6ior7055xOn+zC9Q2b8x6SLKqjPL7XA1SkmXPzkX85D4OBF VcQKBSxM/65T9WMpewkUK5IIJBfxkcLt9zq2FJFx/u0OXsTpK0xmJojPSCkPW9fpr38Z +PBlO50V4CZ5q5tv1WIooQ8hNg5WdkaOdcuJFurkLEPGQsnvLaNcdJteonYdHKkdSP8i oveu00hAlh1KdzgoXH/RFW601luu33hJqDUfBPBjjarX/oQBU87RSKy1WpMlovEf4eUb 2mhaIwgkgY4p1MDyHL3Qb8vwTjqAFXhrrfaKpc9VSyB8QKE0PMoRvXY6ujSy/EfaAi0b Dyiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LbL1VPC3COXzIgLe/uqV253OkfGm5Wks+6mRKuWa/gY=; b=KOZZQa/tCqeiIDX+9qfUt7KHNAqB1lbKdOpYKn970JUslEHImGVoSn+9pg9cwDHwnP YFwX2r/sdayOLvb0lyKX5ugei38pc3N0b084rj1gvseR0fGr9MJzwMB2X/tjX7B22Lx2 7pUm/ocoRHqApAsjDM44kNr4JkSdj61LEANa2lbIS09Hw0Ejs32LjURs+3M9CYfpOJ+G NO2c39eZqCegabp/plWdEoFxBuj6hUgMy8QtAWuu4fDoCLxzxwnsaxLOlM2nvt/yVgYf woA8dE0e0H5DuMuI2T+naYoy9BYojOGbVbdyirNa/cHIDLWfjr3xdfZESRqDFbBnr9X2 qdbA== X-Gm-Message-State: AKS2vOw4IjxKypAK4jU6e8j6vSRc+HUHFcvMnwzgOUswo1q68jcZ1+oX kgjVkDi+053zPg== X-Received: by 10.223.135.68 with SMTP id 4mr23647238wrz.141.1499047892910; Sun, 02 Jul 2017 19:11:32 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id n71sm16695176wrb.62.2017.07.02.19.11.31 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Jul 2017 19:11:32 -0700 (PDT) References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> <877ezs7653.fsf@acer.localhost.com> From: Dmitry Gutov Message-ID: <5f045d58-fff7-446a-44d3-33d093285ef5@yandex.ru> Date: Mon, 3 Jul 2017 05:11:30 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 In-Reply-To: <877ezs7653.fsf@acer.localhost.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.6 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) On 7/1/17 2:23 PM, Ingo Lohmar wrote: > I hope I understood the manual/indent idea correctly. Below is the > updated patch including a test file. Looks good, thanks. > I changed the variable name to `js-indent-cont-nonempty-aligned' now > (with "flipped" boolean meaning, as discussed before). This is more > succinct and starts with `js-indent-...' to convey the feature area to > which this setting belongs. OK, it seems better. Still requires effort to decipher the meaning, though. I don't have any better suggestions, so might as well commit this name. > What's the procedure for patches arising from a bug report --- should I > add a NEWS entry (for 26.1, marked +++) and just commit this to master > myself? When a reviewer says "Looks good, please install", or you're feeling confident yourself, yes. On that note, LGTM, please install. :) A NEWS entry for the new variable is a good idea. But "+++" means "all necessary documentation updates are complete". "---", meaning "no change in the manuals is needed", seems more appropriate. From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: Ingo Lohmar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jul 2017 18:06:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 27503@debbugs.gnu.org, James Nguyen , james@jojojames.com Received: via spool by 27503-submit@debbugs.gnu.org id=B27503.149910512925169 (code B ref 27503); Mon, 03 Jul 2017 18:06:02 +0000 Received: (at 27503) by debbugs.gnu.org; 3 Jul 2017 18:05:29 +0000 Received: from localhost ([127.0.0.1]:50593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dS5iz-0006Xt-0T for submit@debbugs.gnu.org; Mon, 03 Jul 2017 14:05:29 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:33433) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dS5iy-0006Xh-1j for 27503@debbugs.gnu.org; Mon, 03 Jul 2017 14:05:28 -0400 Received: by mail-wm0-f65.google.com with SMTP id j85so21925004wmj.0 for <27503@debbugs.gnu.org>; Mon, 03 Jul 2017 11:05:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=WYrWcRCGTQEQzTtCZ6WNGiIS9K8qqSgZQsnfogzHWzc=; b=C4wiMnVEl/fH6hATpIhJB1QK2GpCiAgR2e9m/lc8QijyUZNRgnyqejTlRMXbl7xI7b IidhoZ7dRiI+gW7XuIp9h5JLyjOjth6EOPSNlZVqKRiviJW/Zzz4E9Qrlbd1BUQ4y5dC YTXklKuB8AD7/NzhA3LJedrkROBfCF/YZaPnsEnPWYg+jB/nOm1dGV5ZPgH6QB1sQm4U gRCpMbVPEgfxay97ZnPkAS+kZR0DLMEeDyoD5UI4l2rOjW9/I3FfUU5IU3irLSHSHLcC duOEexOu8oVlSDbbeDLZq313uAoeoRSZ8WAmQZJjAjtTsYxiCYnZZ2h142yFDnkyDgJs q6lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=WYrWcRCGTQEQzTtCZ6WNGiIS9K8qqSgZQsnfogzHWzc=; b=O84tIADDwjPYpw46klqGI/Rr1SzMGZ3QDV12PcBUXSeIlko6CnA96QHxqaW1oFfiZ7 XdkkdWyrBfSoy18xyG7z+529bDHTH9DH8O3phavXxRRrJqimxp0pWknexCWmj7x7/G8U 5i+MdAbsljldWyO1qE8btwAbFpBYRM+GVDlOZA44cw1vZscTSZo0cJnR5+cv2i3dMjAA nyskQjDcfBSCyNFpgo23rllGEfrwcsqJRV0s92P9zPiV+kgLV6oleS9cfMYpyh0EO/mK IOkY+TJdtO8KhuUeGcV33I3OsFG+O4OBziWaTzoxkm5nFjanQMbWSDZOKb1CSZwumkDF 2TLg== X-Gm-Message-State: AKS2vOxE1gPfejkuqcNTqv20+thJ1WP8XILg1UorVx9XkmxE4JMJrUbm xACiHw+362k40Q== X-Received: by 10.80.154.98 with SMTP id o89mr15881688edb.137.1499105122197; Mon, 03 Jul 2017 11:05:22 -0700 (PDT) Received: from localhost (xdsl-87-79-227-74.netcologne.de. [87.79.227.74]) by smtp.gmail.com with ESMTPSA id b30sm7904194edd.6.2017.07.03.11.05.20 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Jul 2017 11:05:21 -0700 (PDT) From: Ingo Lohmar In-Reply-To: <5f045d58-fff7-446a-44d3-33d093285ef5@yandex.ru> References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> <877ezs7653.fsf@acer.localhost.com> <5f045d58-fff7-446a-44d3-33d093285ef5@yandex.ru> Date: Mon, 03 Jul 2017 20:05:20 +0200 Message-ID: <874lut75wf.fsf@acer.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) On Mon, Jul 03 2017 05:11 (+0300), Dmitry Gutov wrote: >> I changed the variable name to `js-indent-cont-nonempty-aligned' now >> (with "flipped" boolean meaning, as discussed before). This is more >> succinct and starts with `js-indent-...' to convey the feature area to >> which this setting belongs. > > OK, it seems better. Still requires effort to decipher the meaning, > though. I don't have any better suggestions, so might as well commit > this name. Changed to the better 'js-indent-align-list-continuations', I think that's reasonably clear. :) > A NEWS entry for the new variable is a good idea. But "+++" means "all > necessary documentation updates are complete". "---", meaning "no change > in the manuals is needed", seems more appropriate. You're right, done. I think that the changed variable name is not contentious (and an improvement), so I'll just go ahead and commit this. Thanks for the feedback! From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: Ingo Lohmar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jul 2017 18:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov Cc: 27503@debbugs.gnu.org, James Nguyen , james@jojojames.com Received: via spool by 27503-submit@debbugs.gnu.org id=B27503.149910610426591 (code B ref 27503); Mon, 03 Jul 2017 18:22:02 +0000 Received: (at 27503) by debbugs.gnu.org; 3 Jul 2017 18:21:44 +0000 Received: from localhost ([127.0.0.1]:50603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dS5yh-0006uo-Mv for submit@debbugs.gnu.org; Mon, 03 Jul 2017 14:21:43 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:35461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dS5yg-0006uc-95 for 27503@debbugs.gnu.org; Mon, 03 Jul 2017 14:21:42 -0400 Received: by mail-wm0-f65.google.com with SMTP id u23so22024016wma.2 for <27503@debbugs.gnu.org>; Mon, 03 Jul 2017 11:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=H3WonOFam5D7+MdWgt2ojyGKoi08pDXQpmYfRbrc9+s=; b=R4FLRFint2DDI+kIq0HF75jH7Bx9ec7JzWuC5yvcrEUtq7W7FbzIEJAdeviQDk7uCU ZtG2vPDa0A1bXIOLworB49YqJ69TtzXEV+E+NNVHCyUMNM1b7/tiI0MKKoNj717Ey+zT xB+qabCaFMWr62FDZDkWCoXB9twH05GIWle1y8cYajMxyaIMDpfbE9R41brVPRJ/fU39 UR06UgK2NTWIn9F6wxuVJSpu7ZgamlO2GFzF4X9btySdGVIKgb8alPPG6S8C/WLmMtH/ 93pkXesycSf0Gv/8jeB3lHmDAHyDECd7EjMisFd0egUm58JDMBiLcp+klR1eK7vrCsiP DVBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=H3WonOFam5D7+MdWgt2ojyGKoi08pDXQpmYfRbrc9+s=; b=IbDpnNoz4RaZdElkJnG8zNpGatlfqaX1DkxOF0TrrdzhSOD+O0Nkx/lfswJI55Ojc/ Mq5H6+xzgtCW+EUfDYpOaZ+8a+jFsld1tY0tWiVAl/ulqGDtfzct9Cd2aPtKaz2YItJP T8p6nqGUy5VR+LEQin7JbDxOnV1xA7rQPTS6VsaQm0D3unkAcw/zkg1RZMVjNJyzQmet C8rwC3mocGgl27QpEW5EPYlUYq2J+nFhtVKZUcnN+c5t0r7LfHKwY+UYth9fxF4G1lGP EUz3XK1N9WNID3hrvN6wMfAxFpssOatxEhsnJdNKncwQYxJ1AkYZ7VwAmIlMxkMJo71b cfvg== X-Gm-Message-State: AIVw111rmS1MHvabFv15JFCcp5bQ7QiTQMe7F+iIcd8CNIryhT+ANLB8 486AcJvKb9gQ6A== X-Received: by 10.80.169.193 with SMTP id n59mr4109edc.88.1499106096715; Mon, 03 Jul 2017 11:21:36 -0700 (PDT) Received: from localhost (xdsl-87-79-227-74.netcologne.de. [87.79.227.74]) by smtp.gmail.com with ESMTPSA id f40sm8039274edb.2.2017.07.03.11.21.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 03 Jul 2017 11:21:36 -0700 (PDT) From: Ingo Lohmar In-Reply-To: <874lut75wf.fsf@acer.localhost.com> References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> <877ezs7653.fsf@acer.localhost.com> <5f045d58-fff7-446a-44d3-33d093285ef5@yandex.ru> <874lut75wf.fsf@acer.localhost.com> Date: Mon, 03 Jul 2017 20:21:35 +0200 Message-ID: <871spx755c.fsf@acer.localhost.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) tags 27503 fixed close 27503 26.1 quit Pushed to master: http://git.savannah.gnu.org/cgit/emacs.git/commit/?id=9ac7dccc51ee834b06cdabf6a5746eb375f984f0. From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jul 2017 20:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Ingo Lohmar Cc: 27503@debbugs.gnu.org, James Nguyen , james@jojojames.com Received: via spool by 27503-submit@debbugs.gnu.org id=B27503.149911306911924 (code B ref 27503); Mon, 03 Jul 2017 20:18:02 +0000 Received: (at 27503) by debbugs.gnu.org; 3 Jul 2017 20:17:49 +0000 Received: from localhost ([127.0.0.1]:50797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dS7n3-00036G-0k for submit@debbugs.gnu.org; Mon, 03 Jul 2017 16:17:49 -0400 Received: from mail-wm0-f50.google.com ([74.125.82.50]:38370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dS7n1-000364-JI for 27503@debbugs.gnu.org; Mon, 03 Jul 2017 16:17:47 -0400 Received: by mail-wm0-f50.google.com with SMTP id f67so65240639wmh.1 for <27503@debbugs.gnu.org>; Mon, 03 Jul 2017 13:17:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Gr34HiwQSk+7ENP9mcgNNwX391fG7MMq0Hp8BsbLn8Y=; b=oz3CHaK6TufqmYIs/n1yvsBrH+6Alqs/JENEh4tJEH2opFyMdIOT0s05ug2g3n9/TG C5ATAXZ5Pc+jUGLchMLi8Hf+a6A011RMXGPPXnDqauxWDqG81ImeKPug51RVyosJ272S HlR4lEqvdDno/X6qeD0c2zz79XLQZ0qXSWQ2a5ufgB/QFaggtSOtOReS8jKxqoTI0+Qv 742cy/d9a2qzJSR3Ub7B9MRoKsVSBBsCVPVRecXVCq2aRAcLh/pC5Co+rxocKhrwwo8w SIQaVh3sGVQGN4heJ7bHsT8x7zNrwd9UOhss7rvwNlQbHbl06m1MqEfWgfDI0Tdcq7DD gukw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Gr34HiwQSk+7ENP9mcgNNwX391fG7MMq0Hp8BsbLn8Y=; b=Ud7EOE56wBDyTWItfdp0dHH5lEuFbppr6Z76BXDu9sAVL96ic6IiC4sKwPIJ6jXBoO MhdFIHjkXxGP+pU19fv3/UvZkB7/hcEZfP3I0jtBL+ij1lfv8hB8tHknM7zMFA9NCkuH ZkC+Ee9S/Er1lHG+8JHvw4qyzSs0fW77jYC4WT2Gl8/5VRLx9ILHDVUBpcdrOULjsi/0 ecUKHntaORdz3Q0x1feNd5fQW8ZJEP7ZIqbvHpzFaSiOZ/jF0G/0QPpJIQUCbroGx3Jh d/iyTw1YSf6XY1PO4O4Nqz/hk/46D2G6UGlYUWnIoqvrdExflLtUZM16oFxeyvOyZ2pm pwwQ== X-Gm-Message-State: AIVw111ZA2UC6+0LCb9QuUGdXigq1oNOxem8Dn/yooHKtbbqv0/vRhqR VyyyeMYt8Uzd3w== X-Received: by 10.28.178.203 with SMTP id b194mr12727838wmf.36.1499113061650; Mon, 03 Jul 2017 13:17:41 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id c55sm17626344wrc.7.2017.07.03.13.17.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jul 2017 13:17:40 -0700 (PDT) References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> <877ezs7653.fsf@acer.localhost.com> <5f045d58-fff7-446a-44d3-33d093285ef5@yandex.ru> <874lut75wf.fsf@acer.localhost.com> From: Dmitry Gutov Message-ID: Date: Mon, 3 Jul 2017 23:17:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 In-Reply-To: <874lut75wf.fsf@acer.localhost.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.2 (/) On 7/3/17 9:05 PM, Ingo Lohmar wrote: > I think that the changed variable name is not contentious (and an > improvement), so I'll just go ahead and commit this. Thanks for the > feedback! Very good, thanks! From unknown Mon Jun 23 07:51:24 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: James Nguyen Subject: bug#27503: closed (Re: bug#27503: 26.0.50; Not lining up Javascript arguments) Message-ID: References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> X-Gnu-PR-Message: they-closed 27503 X-Gnu-PR-Package: emacs Reply-To: 27503@debbugs.gnu.org Date: Mon, 03 Jul 2017 21:02:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1499115722-16029-1" This is a multi-part message in MIME format... ------------=_1499115722-16029-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #27503: 26.0.50; Not lining up Javascript arguments which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 27503@debbugs.gnu.org. --=20 27503: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D27503 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1499115722-16029-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 27503-done) by debbugs.gnu.org; 3 Jul 2017 21:01:18 +0000 Received: from localhost ([127.0.0.1]:50841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dS8T8-00049Y-FN for submit@debbugs.gnu.org; Mon, 03 Jul 2017 17:01:18 -0400 Received: from mail-wm0-f52.google.com ([74.125.82.52]:38710) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dS8T6-00049J-GA for 27503-done@debbugs.gnu.org; Mon, 03 Jul 2017 17:01:16 -0400 Received: by mail-wm0-f52.google.com with SMTP id f67so66040234wmh.1 for <27503-done@debbugs.gnu.org>; Mon, 03 Jul 2017 14:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=EpU1dKPQWarKLXgGRtQFDrzJ2SYD41ietHA6yFDo36Y=; b=h8AnFvcMQLBmo3p+ttRO56RkHxvakw5LJy9DnCXeDo8twEa5l6DDN5e+zLloFw0X3T UR/L0iC0KHU2qFH84nKOXla4UHmKKdv7b4ze2h4qLF8rRMi6Qd+qY2rCf1uAP8HEQd6A gg/HEp3qafIC01IikYIR4LW6MSlxPSjgoYym37VoG74ItRWmnULi2AmMSgO7CzcagVqj 7xM0d/spG6zIGpuaelRqSEl9ImLnsRef533aGkTCR/G5Vh2kHm5C5n+IGXn1gYg9WEUm iChu2JjxrGTwOiYwWfF4cBSiEoMp0zAkvqeTX9ko+b6jqibMvnVt54du82LsEECsg9q/ +c+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=EpU1dKPQWarKLXgGRtQFDrzJ2SYD41ietHA6yFDo36Y=; b=njlo57+i2xvG1hkaN0YncWcWwnDw0FYEfJ4xOC8lUrmkRvJI0HTLz4N7FCEGy7EUgm oTUDJYMZB60bIHXm/eOQImCxsxpkB2DbUVHiZpTrcV9c4yf1IjwlWmiZsu5hDVNv9Q12 L2qxhAk+TAUB1+8SwVo2MhzorRL/XnjvJmpsedZPXQmJDI+Rxc9iCHV2B1IyO4axKFbX YXgeD1Njw/H6QpPAX1psUWmVFZPBIwNYubkHhkQbmVADBnAdMBTKqMWbdA/38w77dmYu kvDxw+bDK0tI3SgIk2Rz16CZ+oQ4+VhfKhpnPdhkSLiVQHkIMRqvQjfP941p8GV2Pj8h JNtw== X-Gm-Message-State: AKS2vOzVujKouvG8HjOVnhdNyiV0c/0PYvyquas9FsxEX12Tvp7uVoMt 079zv6F4YhmJIQ== X-Received: by 10.28.62.149 with SMTP id l143mr15892312wma.83.1499115670723; Mon, 03 Jul 2017 14:01:10 -0700 (PDT) Received: from [192.168.1.3] ([185.105.174.193]) by smtp.googlemail.com with ESMTPSA id 143sm8102760wmo.11.2017.07.03.14.01.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Jul 2017 14:01:09 -0700 (PDT) Subject: Re: bug#27503: 26.0.50; Not lining up Javascript arguments To: Ingo Lohmar References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> <877ezs7653.fsf@acer.localhost.com> <5f045d58-fff7-446a-44d3-33d093285ef5@yandex.ru> <874lut75wf.fsf@acer.localhost.com> <871spx755c.fsf@acer.localhost.com> From: Dmitry Gutov Message-ID: Date: Tue, 4 Jul 2017 00:01:07 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Thunderbird/54.0 MIME-Version: 1.0 In-Reply-To: <871spx755c.fsf@acer.localhost.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 27503-done Cc: 27503-done@debbugs.gnu.org, James Nguyen , james@jojojames.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Version: 26.1 On 7/3/17 9:21 PM, Ingo Lohmar wrote: > tags 27503 fixed > close 27503 26.1 > quit The capricious bug tracker doesn't want to understand this: the bug was still open. Should be closed now (see the first Cc: address). ------------=_1499115722-16029-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Jun 2017 05:34:10 +0000 Received: from localhost ([127.0.0.1]:39848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPj8b-0007gJ-Tk for submit@debbugs.gnu.org; Tue, 27 Jun 2017 01:34:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPfdx-00025T-Ei for submit@debbugs.gnu.org; Mon, 26 Jun 2017 21:50:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dPfdq-0002Oj-8N for submit@debbugs.gnu.org; Mon, 26 Jun 2017 21:50:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37633) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dPfdq-0002Oc-4W for submit@debbugs.gnu.org; Mon, 26 Jun 2017 21:50:10 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46749) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dPfdn-0001gp-Iz for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2017 21:50:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dPfdk-0002Iy-CF for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2017 21:50:07 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:41867) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dPfdj-0002Hk-L1 for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2017 21:50:04 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 9661721111; Mon, 26 Jun 2017 21:50:01 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute1.internal (MEProxy); Mon, 26 Jun 2017 21:50:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=/qlz5s/nmHg14QDSaLN9x9ExlwZLap0/Byca323SG dE=; b=Fu4gHjKfX/ibceYZPnX6ZrbIehc91GxsSkbkafPKTWM2DLQJrGzmQxW6C jaHJlA4dzPnHdjo9IYDz4yL5xT8Ig9pFTRylQQgiegdcusVDcuprwfv/rh/Vche3 mjN89npEUivIteLu/F9NDSwZZP99kO65lYcO+KVqIHcXxsgGc3paLFqQEBVAxtlX 4l+hNhFPjsXgNxV1UonMFgMy2VRznOzefQlnvr4oTODPpi3rJsvmH11tVRkoqRKC Pevdalyf8XS1PRQLO2+1i95rtCFx/CgyC32Ne86JgneHpWuOb2DU8WokSLFVpl5/ TEfk/i9nwh6UoMsABueYgcc8WQzuQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=/qlz5s/nmHg14QDSaL N9x9ExlwZLap0/Byca323SGdE=; b=OwGxdiga1RtMu/XPWSuAHxnpK8dpmk2iB5 If2NbzzvEUyjwEijQj0GxF4L8wwXLl66wKWDFIuonW+xkKgDIdvP1/1ZXi0ebbMp Ff2hu5P85smnDmWBhCICeWGXzVoSMEaWpXSHb0qnlsEfG0aM0OjPJmjw00/GQqkw qNm0BhPweuyr0xi3FSKoJG13w773bWm4f0JiidOlZ+Hk1iB9tih82qTQzTISoqr6 5k/UKC3AXkqwygvYu1INzAxZ5SQWhodjnyH9eRCdtORKRlHf7ZNuAf7SL8wcyjDm 9Jk1TviMG7m+nj8AaAlfewcOFL5/NRMtzmMiBhOgaub+Zqe/SisA== X-ME-Sender: X-Sasl-enc: sVQWBl3Lo3aORwhlRyId1NnA8eKL8kvne/8J/efF7yi5 1498528201 Received: from [10.0.1.47] (c-73-231-191-86.hsd1.ca.comcast.net [73.231.191.86]) by mail.messagingengine.com (Postfix) with ESMTPA id DB1237E766; Mon, 26 Jun 2017 21:50:00 -0400 (EDT) From: James Nguyen Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: 26.0.50; Not lining up Javascript arguments Message-Id: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> Date: Mon, 26 Jun 2017 18:49:59 -0700 To: bug-gnu-emacs@gnu.org X-Mailer: Apple Mail (2.3273) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 27 Jun 2017 01:34:08 -0400 Cc: james@jojojames.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) I'd like to have js-mode line up arguments normally instead of lining up arg-wise. For example: function functionName(arg1, arg2) {} vs function functionName(arg1, arg2) I think js-mode only support the former at this point. The latter seems to be fairly common so it'd be great if we could support it. Following this: = https://emacs.stackexchange.com/questions/29973/stop-javascript-mode-from-= lining-up-function-parameters-after-newline/29975#29975 seems to give accurate indentation similar to other editors. (defun javascript/indent-args (parse-status) "Return the proper indentation for the current line." (save-excursion (back-to-indentation) (cond ((nth 4 parse-status) ; inside comment (js--get-c-offset 'c (nth 8 parse-status))) ((nth 3 parse-status) 0) ; inside string ((eq (char-after) ?#) 0) ((save-excursion (js--beginning-of-macro)) 4) ;; Indent array comprehension continuation lines specially. ((let ((bracket (nth 1 parse-status)) beg) (and bracket (not (js--same-line bracket)) (setq beg (js--indent-in-array-comp bracket)) ;; At or after the first loop? (>=3D (point) beg) (js--array-comp-indentation bracket beg)))) ((js--chained-expression-p)) ((js--ctrl-statement-indentation)) ((js--multi-line-declaration-indentation)) ((nth 1 parse-status) ;; A single closing paren/bracket should be indented at the ;; same level as the opening statement. Same goes for ;; "case" and "default". (let ((same-indent-p (looking-at "[]})]")) (switch-keyword-p (looking-at = "default\\_>\\|case\\_>[^:]")) (continued-expr-p (js--continued-expression-p))) (goto-char (nth 1 parse-status)) ; go to the opening char (progn ; nothing following the opening paren/bracket (skip-syntax-backward " ") (when (eq (char-before) ?\)) (backward-list)) (back-to-indentation) (js--maybe-goto-declaration-keyword-end parse-status) (let* ((in-switch-p (unless same-indent-p (looking-at "\\_"))) (same-indent-p (or same-indent-p (and switch-keyword-p in-switch-p))) (indent (cond (same-indent-p (current-column)) (continued-expr-p (+ (current-column) (* 2 = js-indent-level) js-expr-indent-offset)) (t (+ (current-column) js-indent-level (pcase (char-after (nth 1 = parse-status)) (?\( js-paren-indent-offset) (?\[ js-square-indent-offset) (?\{ js-curly-indent-offset))))))) (if in-switch-p (+ indent js-switch-indent-offset) indent))))) ((js--continued-expression-p) (+ js-indent-level js-expr-indent-offset)) (t (prog-first-column))))) (advice-add 'js--proper-indentation :override 'javascript/indent-args) =20 1. This removes an entire if block check. That is probably doing something I'm not aware of. 2. We probably want to make it configuration either way (something similar to js-comment-lineup-func (but that seems to only be for = comments.)) Some source code to play with is: #+begin_src mhtml :tangle yes Lifecycle
#+end_src =20 More specifically: #+begin_src mhtml :tangle yes render: function() { return React.DOM.div(null, React.DOM.textarea({ value: this.state.text, onChange: this._textChange, }), React.DOM.h3(null, this.state.text.length) ); } #+end_src =20 With the current indent settings, we get: #+begin_src mhtml :tangle yes render: function() { return React.DOM.div(null, React.DOM.textarea({ value: this.state.text, onChange: this._textChange, }), React.DOM.h3(null, = this.state.text.length) ); } #+end_src =20 With the above advice: #+begin_src mhtml :tangle yes render: function() { return React.DOM.div(null, React.DOM.textarea({ value: this.state.text, onChange: this._textChange, }), React.DOM.h3(null, this.state.text.length) ); } #+end_src In GNU Emacs 26.0.50 (build 4, x86_64-apple-darwin16.5.0, NS = appkit-1504.82 Version 10.12.4 (Build 16E195)) of 2017-06-24 built on jamesretina.local Repository revision: 16d2695674a4c8abbec846c427fe8abef97e07ef Windowing system distributor 'Apple', version 10.3.1504 Recent messages: The following feature was found in load-path, please check if that=E2=80=99= s correct: (obarray) Successfully reloaded Org Org-mode version 8.2.10 (release_8.2.10 @ = /Users/james/Code/emacs/nextstep/Emacs.app/Contents/Resources/lisp/org/) Mark set Configuring package helm... Configuring package tramp...done Configuring package helm...done (0.310s) Configuring package helm-flx...done Configuring package helm-fuzzier...done Configured using: 'configure --with-ns' Configured features: JPEG RSVG NOTIFY ACL GNUTLS LIBXML2 ZLIB TOOLKIT_SCROLL_BARS NS Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Org Minor modes in effect: helm-fuzzier-mode: t helm-flx-mode: t helm-mode: t helm-autoresize-mode: t helm--remap-mouse-mode: t shell-dirtrack-mode: t focus-autosave-mode: t company-quickhelp-mode: t company-quickhelp-local-mode: t eval-sexp-fu-flash-mode: t flycheck-pos-tip-mode: t shackle-mode: t yas-global-mode: t yas-minor-mode: t global-company-mode: t company-mode: t global-evil-surround-mode: t evil-surround-mode: t global-evil-visualstar-mode: t evil-visualstar-mode: t global-evil-matchit-mode: t evil-matchit-mode: t evil-mode: t evil-local-mode: t global-undo-tree-mode: t undo-tree-mode: t recentf-mode: t ivy-mode: t smartparens-global-mode: t smartparens-mode: t global-hungry-delete-mode: t hungry-delete-mode: t ws-butler-global-mode: t ws-butler-mode: t show-paren-mode: t global-auto-revert-mode: t winner-mode: t override-global-mode: t tooltip-mode: t global-eldoc-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: = /Users/james/.emacs.d/elpa/26/color-theme-solarized-20160626.743/solarized= -theme hides = /Users/james/.emacs.d/elpa/26/solarized-theme-20170430.800/solarized-theme= ~/.emacs.d/fork/evil/evil hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil ~/.emacs.d/fork/evil/evil-vars hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-vars ~/.emacs.d/fork/evil/evil-types hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-types ~/.emacs.d/fork/evil/evil-states hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-states ~/.emacs.d/fork/evil/evil-search hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-search ~/.emacs.d/fork/evil/evil-repeat hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-repeat ~/.emacs.d/fork/evil/evil-pkg hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-pkg ~/.emacs.d/fork/evil/evil-maps hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-maps ~/.emacs.d/fork/evil/evil-macros hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-macros ~/.emacs.d/fork/evil/evil-jumps hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-jumps ~/.emacs.d/fork/evil/evil-integration hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-integration ~/.emacs.d/fork/evil/evil-ex hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-ex ~/.emacs.d/fork/evil/evil-digraphs hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-digraphs ~/.emacs.d/fork/evil/evil-core hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-core ~/.emacs.d/fork/evil/evil-common hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-common ~/.emacs.d/fork/evil/evil-commands hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-commands ~/.emacs.d/fork/evil/evil-command-window hides = /Users/james/.emacs.d/elpa/26/evil-20170615.1320/evil-command-window Features: (shadow sort mail-extr emacsbug message rfc822 mml mml-sec epa epg mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail helm-fuzzier helm-flx helm-smex helm-command helm-elisp helm-eval helm-mode helm-files image-dired tramp tramp-compat tramp-loaddefs trampver parse-time dired-x dired-aux helm-buffers helm-tags helm-bookmark helm-adaptive helm-info bookmark pp helm-locate helm-grep helm-regexp helm-external helm-net helm-utils compile helm-help helm-types helm helm-source eieio-compat helm-multi-match helm-lib async smex ido loadhist solarized-light-theme solarized add-log server pulse shell tabify org-element org-rmail org-mhe org-irc org-info org-gnus org-docview doc-view image-mode dired dired-loaddefs org-bibtex bibtex org-bbdb org-w3m org org-macro org-footnote org-pcomplete pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob ob-tangle ob-ref ob-lob ob-table ob-exp org-src ob-keys ob-comint comint ansi-color ob-core ob-eval org-compat org-macs org-loaddefs JJ-org cursor-sensor mhtml-mode rainbow-mode xterm-color css-mode smie eww puny mm-url gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mail-utils mm-util mail-prsvr url-queue url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap shr svg xml browse-url format-spec js cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs smartparens-html sgml-mode dom JJ-web focus-autosave-mode JJ-security colir color counsel jka-compr esh-util rainbow-delimiters evil-cleverparens evil-cleverparens-text-objects evil-cleverparens-util paredit lispyville lispy swiper iedit iedit-lib multiple-cursors-core lispy-inline avy semantic/db eieio-base semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet ediff-merg ediff-wind ediff-diff ediff-mult ediff-help ediff-init ediff-util ediff help-fns radix-tree lispy-tags elisp-slime-nav eval-sexp-fu company-quickhelp warnings highlight font-lock+ flycheck-pos-tip pos-tip flycheck json map find-func shackle JJ-extra-lang make-mode JJ-elisp edebug-x edebug which-func imenu JJ-autocomplete elixir-yasnippets yasnippet company-oddmuse company-keywords company-etags etags xref project company-gtags company-files company-capf company-cmake company-xcode company-clang company-semantic company-eclim company-template company-css company-nxml company-dabbrev-code company-dabbrev company-yasnippet company-bbdb company JJ-evil evil-surround evil-visualstar evil-matchit evil evil-integration evil-maps evil-commands flyspell ispell evil-jumps evil-command-window evil-types evil-search evil-ex evil-macros evil-repeat evil-states evil-core evil-common derived rect evil-digraphs evil-vars undo-tree diff JJ-project recentf tree-widget wid-edit ivy flx delsel ivy-overlay ffap JJ-pair-editing smartparens-config smartparens thingatpt JJ-misc fold-dwim-org fold-dwim hideshow noutline outline windmove hungry-delete ws-butler JJ-platform exec-path-from-shell ls-lisp JJ-defaults paren whitespace autorevert filenotify winner JJ-theme foggy-night-theme cl-extra help-mode theme-changer solar cal-dst cal-menu calendar cal-loaddefs cl JJ-dependencies hydra ring lv s dash JJ-funcs subr-x use-package diminish bind-key easy-mmode finder-inf edmacro kmacro rx advice slime-autoloads info package easymenu epg-config url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs pcase cl-lib time-date tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote kqueue cocoa ns multi-tty make-network-process emacs) Memory information: ((conses 16 892577 534002) (symbols 48 60548 281) (miscs 40 882 3402) (strings 32 161034 279476) (string-bytes 1 5481778) (vectors 16 98335) (vector-slots 8 2434861 513384) (floats 8 884 2213) (intervals 56 6906 1373) (buffers 976 24)) ------------=_1499115722-16029-1-- From unknown Mon Jun 23 07:51:24 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27503: 26.0.50; Not lining up Javascript arguments Resent-From: James Nguyen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Jul 2017 23:15:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27503 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Dmitry Gutov , Ingo Lohmar Cc: , 27503-done@debbugs.gnu.org, James Nguyen Received: via spool by 27503-done@debbugs.gnu.org id=D27503.14991236712373 (code D ref 27503); Mon, 03 Jul 2017 23:15:01 +0000 Received: (at 27503-done) by debbugs.gnu.org; 3 Jul 2017 23:14:31 +0000 Received: from localhost ([127.0.0.1]:50930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSAY3-0000cD-5j for submit@debbugs.gnu.org; Mon, 03 Jul 2017 19:14:31 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:44373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dSAY1-0000c6-Rt for 27503-done@debbugs.gnu.org; Mon, 03 Jul 2017 19:14:30 -0400 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id BC83320BE4; Mon, 3 Jul 2017 19:14:29 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Mon, 03 Jul 2017 19:14:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jojojames.com; h=cc:cc:content-type:date:from:in-reply-to:message-id :mime-version:references:subject:to:x-me-sender:x-me-sender :x-sasl-enc:x-sasl-enc; s=fm1; bh=ZGDt56Nv6jy2OlF2qqYCBu1CNP5SUt nlE9gVPbTNRfo=; b=wmmGEI2ubFDzucq+SYSMmeYNPBl49lUxxcKZc6bIVnShT8 nybP7/lB6qT7b+4VaO2KH1YqNgxuQ3W+5kAuZKUyTSAbO5cA7GtpqnWkhrQ96Fue v7/6fi7b5fYZ78/bAl8XWagyMRoMAohwDTStvfBqXBohgSYtQ+bJGxxmqIHxtCn3 F4wQHqxzbEw2qLhC9MRgdu1rNCA90mPUWPqYBl6Stf2mvrdSzlJHT6B5mh6GV0h4 hCDiW/iwjBl5gSdPdZCNeSDH0GwKbY0G4GdrGLZprJDiR3vZWEng/Zh/m7Yggurq FYU+RKibcxlAXyQIc6ktmqJmaSluFhhBCxge4obw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=ZGDt56Nv6jy2OlF2qq YCBu1CNP5SUtnlE9gVPbTNRfo=; b=AbtfHEOdWELcyYiSCBXBIXT6ePU7UF3LR3 abRv4HqAvWJhVOq1t4C5K0LUAwmXCn8atefXJjO1sj/0aQCTOl4yaw1H0yj/P90y 9TBY7cpmQtxzzzlEaqEH9iiLXrUEhbrrZVfg1vmg1Q3vTuA+SHYkNXYGBDAo0WVO Kp13F0JOcRe3wjXnIPdmVUnkGCs339AlLi1VyRnfBl1yhZXEr7gCOaJavAFcrKb0 M032VA8LQS/DKhjtnF06AnlJS1/4vbnqXJwUmgqEVdhCSb4q8UHdE5AtK4Ggncr2 zcxD+aa1/rt+/vzzRPFcN3EWugVjtfHUvY1hYNBPMT0YH0+yGPTw== X-ME-Sender: X-Sasl-enc: rHGyVHHm2x3ox3yuFLrwr5cHTDgssxKeSpXD1OAG6PzF 1499123668 Received: from localhost (c-73-231-191-86.hsd1.ca.comcast.net [73.231.191.86]) by mail.messagingengine.com (Postfix) with ESMTPA id 8C3532474F; Mon, 3 Jul 2017 19:14:28 -0400 (EDT) From: James Nguyen In-Reply-To: References: <87FF3D96-DBCF-4EBD-8E72-3F796AB89FF1@fastmail.com> <87fuel70up.fsf@acer.localhost.com> <877ezs7653.fsf@acer.localhost.com> <5f045d58-fff7-446a-44d3-33d093285ef5@yandex.ru> <874lut75wf.fsf@acer.localhost.com> <871spx755c.fsf@acer.localhost.com> Date: Mon, 03 Jul 2017 16:14:32 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: > Version: 26.1 > > On 7/3/17 9:21 PM, Ingo Lohmar wrote: >> tags 27503 fixed >> close 27503 26.1 >> quit > > The capricious bug tracker doesn't want to understand this: the bug was > still open. Should be closed now (see the first Cc: address). Thanks Dmity and Ingo for working on this!