GNU bug report logs - #27502
25.2; auto-revert adds lambda to find-file-hook

Previous Next

Package: emacs;

Reported by: Pierre Neidhardt <ambrevar <at> gmail.com>

Date: Mon, 26 Jun 2017 19:54:01 UTC

Severity: minor

Found in version 25.2

Fixed in version 26.1

Done: Michael Albinus <michael.albinus <at> gmx.de>

Bug is archived. No further changes may be made.

Full log

Message #10 received at 27502-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 27502-done <at> debbugs.gnu.org
Subject: Re: bug#27502: 25.2; auto-revert adds lambda to find-file-hook
Date: Sun, 02 Jul 2017 11:45:17 +0200

Version: 26.1 
Pierre Neidhardt <ambrevar <at> gmail.com> writes:

Hi Pierre,

> It seems that autorevert.el:316 adds a lambda to `find-file-hook':
>
> (add-hook 'find-file-hook
> 	  (lambda ()
> 	    (setq-local auto-revert-tail-pos
>                         (nth 7 (file-attributes buffer-file-name)))))
>
> It's bad practice to add lambdas to hooks as it makes it harder to remove them.
> We should use a named function instead.

I've fixed this (and a similar problem with `kill-buffer-hook') in the trunk.

Best regards, Michael.
This bug report was last modified 7 years and 329 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.