From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 26 15:53:36 2017 Received: (at submit) by debbugs.gnu.org; 26 Jun 2017 19:53:36 +0000 Received: from localhost ([127.0.0.1]:39492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPa4m-0000QH-2d for submit@debbugs.gnu.org; Mon, 26 Jun 2017 15:53:36 -0400 Received: from eggs.gnu.org ([208.118.235.92]:55880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPa4l-0000Q5-5G for submit@debbugs.gnu.org; Mon, 26 Jun 2017 15:53:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dPa4e-0004G9-TN for submit@debbugs.gnu.org; Mon, 26 Jun 2017 15:53:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58712) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dPa4e-0004G1-Pg for submit@debbugs.gnu.org; Mon, 26 Jun 2017 15:53:28 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dPa4d-0005CB-FM for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2017 15:53:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dPa4a-00049a-F8 for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2017 15:53:27 -0400 Received: from mail-wr0-x233.google.com ([2a00:1450:400c:c0c::233]:36307) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dPa4a-00048y-8D for bug-gnu-emacs@gnu.org; Mon, 26 Jun 2017 15:53:24 -0400 Received: by mail-wr0-x233.google.com with SMTP id c11so149539776wrc.3 for ; Mon, 26 Jun 2017 12:53:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mime-version:content-disposition :user-agent; bh=qTWoUf/RfAa+EAB+fBm8cZdxkJ2fpKQF9ivb4hrjVUc=; b=nAnGjyhFsWw4ph9Js9GvMW88uD5GcDT2tQfR+Oms9pKFpTKSidJ3v3PYfHiLa2tpk7 BKMmgSBdeXwZvwTW2QF2eJKcxa2D5Snfi7S2iQJnZjKWQsHtlm09iPh2lUA3lKOpgMHK iCnISzcFA4kQS+ngKFwg1IJSmBeu4foxywtdOX0zd2CECBLOYVxz8YEXAl3t94RA1u1I i0uwXVv9IdlGviFmc44E9yScm0rUFcjNmwaJ9c/qChtdQ91dhx1iml3ra0P9l/vTm4Fn mrD6i9jYcazw9YrktZUoVvuAa1J5/MyjXZ4z6nLEU6RpIBpCI3wByg+iikvyMDwXj25X xKWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition:user-agent; bh=qTWoUf/RfAa+EAB+fBm8cZdxkJ2fpKQF9ivb4hrjVUc=; b=qGdwhO1vRmwA6caoYRvTytl3jpNL3R1n+nZRUwl45y9My6rq1CoPlFxJqMCQkikv0l l+rCVq8YnFL2u6TrT/M379QybZ2+IxIwgegVFMmw3KBrMQrAFhyPdaI7itpqxnIFMHAJ yrtfMpmTRAMtho4NZer2ZDTIyI6uugjMwV0GRfi2GYrta7HFHw3sCOWECjmyrq8/llJo KjSmolTd37KYSElJHGx+vYI9cm271domOU2xsYdDbZTEwY9zWHASrGqwuWraZJh8rcar r109DEB0QmVVHCP7HTghxDeLpjrb3XBSVbR1hMGkDBEanswCfxWYkNpLmILx5afIqHaK dTNw== X-Gm-Message-State: AKS2vOz2KnSAU3IwgAbVun8B8MJS+aWA0VKWRjoREnFsYnmIND8co8d9 IliiMEOt5Ubzc1Ef X-Received: by 10.223.153.114 with SMTP id x105mr15585647wrb.18.1498506801241; Mon, 26 Jun 2017 12:53:21 -0700 (PDT) Received: from gmail.com ([196.203.31.130]) by smtp.gmail.com with ESMTPSA id t136sm430354wmt.12.2017.06.26.12.53.20 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 26 Jun 2017 12:53:20 -0700 (PDT) Date: Mon, 26 Jun 2017 20:53:19 +0100 From: Pierre Neidhardt To: GNU Emacs bug Tracking System Subject: 25.2; auto-revert adds lambda to find-file-hook Message-ID: <20170626195319.GA868@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Info: Simplicity is the ultimate sophistication. User-Agent: Mutt/1.8.3 (2017-05-23) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) It seems that autorevert.el:316 adds a lambda to `find-file-hook': (add-hook 'find-file-hook (lambda () (setq-local auto-revert-tail-pos (nth 7 (file-attributes buffer-file-name))))) It's bad practice to add lambdas to hooks as it makes it harder to remove them. We should use a named function instead. In GNU Emacs 25.2.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.10) of 2017-04-22 built on juergen Windowing system distributor 'The X.Org Foundation', version 11.0.11903000 System Description: Arch Linux From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 02 05:45:27 2017 Received: (at 27502-done) by debbugs.gnu.org; 2 Jul 2017 09:45:27 +0000 Received: from localhost ([127.0.0.1]:48165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRbRX-0004Hv-Ey for submit@debbugs.gnu.org; Sun, 02 Jul 2017 05:45:27 -0400 Received: from mout.gmx.net ([212.227.15.18]:54864) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dRbRV-0004Hh-E6 for 27502-done@debbugs.gnu.org; Sun, 02 Jul 2017 05:45:25 -0400 Received: from detlef.gmx.de ([79.140.123.253]) by mail.gmx.com (mrgmx002 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MUI8w-1dJJz21Q02-00R14h; Sun, 02 Jul 2017 11:45:18 +0200 From: Michael Albinus To: Pierre Neidhardt Subject: Re: bug#27502: 25.2; auto-revert adds lambda to find-file-hook References: <20170626195319.GA868@gmail.com> Date: Sun, 02 Jul 2017 11:45:17 +0200 In-Reply-To: <20170626195319.GA868@gmail.com> (Pierre Neidhardt's message of "Mon, 26 Jun 2017 20:53:19 +0100") Message-ID: <87tw2vw4sy.fsf@detlef> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:ATChNbL49Py30Ln6SFJfcPMGO3r4EetDPjG6T+8N84Fbs3D01kY hv+Cz0Ib/70Xud9s9Jtb1YswHXMhGGGm1ywOvcLhAHxXYQGUJ0DiqGKziZ9RS5kXZM6TRob Y15pYA3fDinWIuFCFqTn3DEV9us/QDYyUp7eyy7JCToeR354KWvHv0qxqzI98HaNSq9bv8g ZJ6E/3FrIzf6/C0//GY0w== X-UI-Out-Filterresults: notjunk:1;V01:K0:a5EVoRcd8+o=:iANVFb3AkROYvOCSUWJ05p eyWGYoIfzGf22ZsBfXTypLy0xVZ0OaxG4HPYP4H/oMm7zEX74E0pH1gVZTEMFe06yWUTOrZtq vEwNwB0kcGfBNhDfvfqufMpQn8ZqWzRic2AwCf1Ru2C847yLywi7Kc2f6cTgJDpebjaW+YUbF UYuoap2UZQIdG/w7PYixC7G5KUI7rXddSpxNBOSVY0vUijyRsbEElcZTV2tdFe59JXL+1O1id OQYFF0vEiO3N/qrQ1476CxPivBCWTDDS2e4zwJ6E2GL+cpt+yG5ins8oU6cB/yP6mp6Etepsy XGhEoUzRy6LnC1pBxfmhCFfMdcptGB8q5ZPu+zvnBlqR1Pz2vkgB++Ub8ZZhPnM4aLB+2DjAt 0sDBBuWp6Wc6lcO4nXLcBxTlSjZN8VDys+4NyYa5qlhm+dtWEu7MtuL5qLZ3WROmP0Jr1t2mw +P18mOY+Fm38Rv0ffRZgT6JbS8lZWA4le3gvs4BaG0j9OIX0PC+pfzwZyMEy8oYs2+bjFzmS/ x6gmjyjvSE8BDh3XmKY1IKdltNT3KCeUjGiZI5K+jr8BaIKqsrPJGhiZpteWoUK2sIt47BuOA 9aWpbhH7pwvhiSh43wpDBM0i+gvYFgFsPaGzfKQtBQ43umJ2PNAs7Ly+0MhNf4krn93EnLfT1 H2h8Br5FJGA5PlCBp4TT2OJCxlSAcHMXQ/QvpBE/H4a9o7SFJLEy/ABKNw11Qaf/1h7VJj0XM FDbQkHcaG5ZlFGMIrAQKHoEfwDWu8fXCgw/kbqzM8e+l3HI8lcjdupknnhRTXY9eI+HEIijs+ nT2W27P X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 27502-done Cc: 27502-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Version: 26.1 Pierre Neidhardt writes: Hi Pierre, > It seems that autorevert.el:316 adds a lambda to `find-file-hook': > > (add-hook 'find-file-hook > (lambda () > (setq-local auto-revert-tail-pos > (nth 7 (file-attributes buffer-file-name))))) > > It's bad practice to add lambdas to hooks as it makes it harder to remove them. > We should use a named function instead. I've fixed this (and a similar problem with `kill-buffer-hook') in the trunk. Best regards, Michael. From unknown Mon Jun 23 04:10:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 30 Jul 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator