GNU bug report logs - #27497
[PATCH] gnu: Add emacs-org-edit-latex.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27497 in the body.
You can then email your comments to 27497 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-org-edit-latex.
Date: Mon, 26 Jun 2017 13:52:52 +0300

---
 gnu/packages/emacs.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index a98278875..1261979be 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4997,3 +4997,33 @@ enter C-x and wait for the default of 1 second, the minibuffer will expand
 with all of the available key bindings that follow C-x (or as many as space
 allows given your settings).")
     (license license:gpl3+)))
+
+(define-public emacs-org-edit-latex
+  (let ((commit "323d0b39d0284cef730b706dce7c0e58ed35530f")
+        (revision "1"))
+    (package
+      (name "emacs-org-edit-latex")
+      (version (string-append "0.0.1-" revision "."
+                              (string-take commit 7)))
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "https://github.com/et2010/org-edit-latex.git")
+                      (commit commit)))
+                (file-name (string-append name "-" version "-checkout"))
+                (sha256
+                 (base32
+                  "0zcllyhx9n9vcr5w87h0hfz25v52lvh5fi717cb7mf3jh89zh842"))))
+      (build-system emacs-build-system)
+      (propagated-inputs
+       `(("emacs-auctex" ,emacs-auctex)
+         ;; The version of org in Emacs 25.2 is not sufficient,
+         ;; because requires org-latex-make-preamble function.
+         ("emacs-org" ,emacs-org)))
+      (home-page "https://github.com/et2010/org-edit-latex")
+      (synopsis
+       "Edit a latex fragment/environment just like editing a src block")
+      (description
+       "@code{emacs-org-edit-latex} is an extension for org-mode.  It let you
+edit a latex fragment/environment just like editing a src block.")
+      (license license:gpl3+))))
-- 
2.13.1

Message #8 received at 27497 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 27497 <at> debbugs.gnu.org
Subject: Re: [bug#27497] [PATCH] gnu: Add emacs-org-edit-latex.
Date: Mon, 26 Jun 2017 18:53:24 +0530

Thanks for the patch!

Could you request upstream to provide a release tarball? That would
simplify our life. Commits have been made in the upstream git repo very
recently. So, I'm hoping the developer will reply soon. If upstream does
not respond in a couple of days, we'll go with the git repo.

> +(define-public emacs-org-edit-latex
> +  (let ((commit "323d0b39d0284cef730b706dce7c0e58ed35530f")
> +        (revision "1"))
> +    (package
> +      (name "emacs-org-edit-latex")
> +      (version (string-append "0.0.1-" revision "."
> +                              (string-take commit 7)))

I think version should be 0.8.0. Look at line 8 of org-edit-latex.el.

The patch LGTM, otherwise!

Message #11 received at 27497 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 27497 <at> debbugs.gnu.org
Subject: Re: [bug#27497] [PATCH] gnu: Add emacs-org-edit-latex.
Date: Mon, 26 Jun 2017 20:36:59 +0300

Hi,

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> Thanks for the patch!
>
> Could you request upstream to provide a release tarball? That would
> simplify our life. Commits have been made in the upstream git repo very
> recently. So, I'm hoping the developer will reply soon. If upstream does
> not respond in a couple of days, we'll go with the git repo.

Sure, I send a request https://github.com/et2010/org-edit-latex/issues/8

>> +(define-public emacs-org-edit-latex
>> +  (let ((commit "323d0b39d0284cef730b706dce7c0e58ed35530f")
>> +        (revision "1"))
>> +    (package
>> +      (name "emacs-org-edit-latex")
>> +      (version (string-append "0.0.1-" revision "."
>> +                              (string-take commit 7)))
>
> I think version should be 0.8.0. Look at line 8 of org-edit-latex.el.
>
> The patch LGTM, otherwise!

Message #14 received at 27497 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: 27497 <at> debbugs.gnu.org
Cc: Oleg Pykhalov <go.wigust <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-org-edit-latex.
Date: Thu, 29 Jun 2017 00:46:33 +0300

---
 gnu/packages/emacs.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index feff22a1b..9457c878e 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -4998,3 +4998,30 @@ for the default of 1 second, the minibuffer will expand with all of the
 available key bindings that follow C-x (or as many as space allows given your
 settings).")
     (license license:gpl3+)))
+
+(define-public emacs-org-edit-latex
+  (package
+    (name "emacs-org-edit-latex")
+    (version "0.8.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/et2010/org-edit-latex/archive/v"
+                    version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "1y4h6wrs8286h9pbsv4d8fr67a885vz8b2k80qgv5qddipi2i78p"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-auctex" ,emacs-auctex)
+       ;; The version of org in Emacs 25.2 is not sufficient,
+       ;; because requires org-latex-make-preamble function.
+       ("emacs-org" ,emacs-org)))
+    (home-page "https://github.com/et2010/org-edit-latex")
+    (synopsis
+     "Edit a latex fragment/environment just like editing a src block")
+    (description
+     "@code{emacs-org-edit-latex} is an extension for org-mode.  It let you
+edit a latex fragment/environment just like editing a src block.")
+    (license license:gpl3+)))
-- 
2.13.2

Message #17 received at 27497 <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 27497 <at> debbugs.gnu.org
Subject: Re: [bug#27497] [PATCH] gnu: Add emacs-org-edit-latex.
Date: Thu, 29 Jun 2017 11:25:50 +0530

Before pushing, I'm slightly modifying the synopsis and description as
follows. I use org-mode and latex regularly, but haven't actually used
this package. So, please let me know if my modification has not altered
the meaning, and the text is still accurate. Once you confirm, I will
push.

    (synopsis "Edit a latex fragment just like editing a src block")
    (description "@code{emacs-org-edit-latex} is an extension for org-mode.
It lets you edit a latex fragment in a dedicated buffer just like editing a
src block.")

Message #20 received at 27497 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Arun Isaac <arunisaac <at> systemreboot.net>
Cc: 27497 <at> debbugs.gnu.org
Subject: Re: [bug#27497] [PATCH] gnu: Add emacs-org-edit-latex.
Date: Thu, 29 Jun 2017 15:31:31 +0300

Arun Isaac <arunisaac <at> systemreboot.net> writes:

> Before pushing, I'm slightly modifying the synopsis and description as
> follows. I use org-mode and latex regularly, but haven't actually used
> this package. So, please let me know if my modification has not altered
> the meaning, and the text is still accurate. Once you confirm, I will
> push.
>
>     (synopsis "Edit a latex fragment just like editing a src block")
>     (description "@code{emacs-org-edit-latex} is an extension for org-mode.
> It lets you edit a latex fragment in a dedicated buffer just like editing a
> src block.")

Yes, it's meaningful.

But, "(description" must be on separate line, doesn't it?
Like in 2482c02f3b23b2490a6647e0717cf8a4ccf3f6a8

Message #25 received at 27497-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 27497-done <at> debbugs.gnu.org
Subject: Re: [bug#27497] [PATCH] gnu: Add emacs-org-edit-latex.
Date: Fri, 30 Jun 2017 20:01:29 +0530

Pushed, thanks! :-)

> But, "(description" must be on separate line, doesn't it?
> Like in 2482c02f3b23b2490a6647e0717cf8a4ccf3f6a8

I don't know if there is a Guix coding standard for this. Some packages
have description on a separate line. Others have it on the same
line. For whatever arbitrary reason I started out with putting it on the
same line, and have kept up the practice.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.