From unknown Mon Jun 23 07:47:38 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#2749 <2749@debbugs.gnu.org> To: bug#2749 <2749@debbugs.gnu.org> Subject: Status: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case Reply-To: bug#2749 <2749@debbugs.gnu.org> Date: Mon, 23 Jun 2025 14:47:38 +0000 retitle 2749 23.0.91; Visual Line Mode: incorrect line wrapping in corner c= ase reassign 2749 emacs submitter 2749 pent severity 2749 minor thanks From pent@aparamon.msk.ru Sun Mar 22 12:13:57 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 22 Mar 2009 19:13:57 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.9 required=4.0 tests=FOURLA,X_DEBBUGS_CC autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2MJDrbP018180 for ; Sun, 22 Mar 2009 12:13:55 -0700 Received: from mx10.gnu.org ([199.232.76.166]:35001) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1LlT7I-000353-VL for emacs-pretest-bug@gnu.org; Sun, 22 Mar 2009 15:13:52 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1LlT7F-0006z4-Jh for emacs-pretest-bug@gnu.org; Sun, 22 Mar 2009 15:13:51 -0400 Received: from aparamon.static.corbina.ru ([89.179.245.94]:55545 helo=neo.paramonovs) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LlT7F-0006yS-86 for emacs-pretest-bug@gnu.org; Sun, 22 Mar 2009 15:13:49 -0400 Received: from pent by neo.paramonovs with local (Exim 4.69) (envelope-from ) id 1LlT79-0005aK-Jv; Sun, 22 Mar 2009 22:13:43 +0300 To: emacs-pretest-bug@gnu.org CC: rfrancoise@debian.org X-Debbugs-CC: Andrey Subject: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case Message-Id: From: pent Date: Sun, 22 Mar 2009 22:13:43 +0300 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) Hello! I've discovered a minor problem with the new Visual Line Mode. To reproduce: 0) emacs -Q 1) Switch to the *scratch* buffer. 2) Select menu item Options/Line Wrapping in this Buffer/Wrap at Window Edge. 3) Type '-' symbol. Keep typing '-' until the the line is wrapped. Delete the last symbol (the one which caused wrapping). The line should now be fully filled with '-'s, and there should be no wrapping. 4) Hit Enter and repeat 3). There are now 2 fully filled lines one after another, with no space between them (expected). 5) Select menu item Options/Line Wrapping in this Buffer/Word Wrap (Visual Line Mode). An empty line between 2 lines has appeared (unexpected). I've found the inconsistency while working with horizontally split Ediff windows, where the probability of wrapping exactly at the line width is high. Hope the fix is trivial. I'm ready to provide any additional info, Andrey Paramonov In GNU Emacs 23.0.91.1 (i486-pc-linux-gnu, GTK+ Version 2.14.7) of 2009-03-20 on elegiac, modified by Debian (emacs-snapshot package, version 1:20090320-1) Windowing system distributor `The X.Org Foundation', version 11.0.10402000 configured using `configure '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.91/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.91/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: ru_RU.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: svn-status Minor modes in effect: TeX-PDF-mode: t diff-auto-refine-mode: t delete-selection-mode: t show-paren-mode: t pc-selection-mode: t pretty-control-l-mode: t shell-dirtrack-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t column-number-mode: t line-number-mode: t global-visual-line-mode: t visual-line-mode: t transient-mark-mode: t From cyd@stupidchicken.com Tue Mar 24 11:03:08 2009 Received: (at 2749) by emacsbugs.donarmstrong.com; 24 Mar 2009 18:03:09 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from cyd.mit.edu (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2OI36jG028605 for <2749@emacsbugs.donarmstrong.com>; Tue, 24 Mar 2009 11:03:07 -0700 Received: by cyd.mit.edu (Postfix, from userid 1000) id B841557E205; Tue, 24 Mar 2009 14:04:33 -0400 (EDT) From: Chong Yidong To: pent Cc: 2749@debbugs.gnu.org Subject: Re: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case Date: Tue, 24 Mar 2009 14:04:33 -0400 Message-ID: <87d4c694r2.fsf@cyd.mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > 3) Type '-' symbol. Keep typing '-' until the the line is > wrapped. Delete the last symbol (the one which caused > wrapping). The line should now be fully filled with '-'s, and there > should be no wrapping. > 4) Hit Enter and repeat 3). There are now 2 fully filled lines one > after another, with no space between them (expected). > 5) Select menu item Options/Line Wrapping in this Buffer/Word Wrap > (Visual Line Mode). An empty line between 2 lines has appeared > (unexpected). This behavior is expected. The word wrap algorithm treats lines that are too long to wrap using the ordinary line-wrapping rules, and since overflow-newline-into-fringe is disabled in Visual Line mode, the extra empty line is used to show the non-overflowed newline character. After the release, I might look into letting word wrap handle overflow-newline-into-fringe behavior. I suspect, however, that this may lead to confusing results in some circumstances. From monnier@iro.umontreal.ca Tue Mar 24 18:35:13 2009 Received: (at 2749) by emacsbugs.donarmstrong.com; 25 Mar 2009 01:35:13 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-0.5 required=4.0 tests=HAS_BUG_NUMBER,XIRONPORT autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from ironport2-out.teksavvy.com (ironport2-out.pppoe.ca [206.248.154.182]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id n2P1Z8uq020943 for <2749@emacsbugs.donarmstrong.com>; Tue, 24 Mar 2009 18:35:10 -0700 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqMFAPMmyUlFxIZP/2dsb2JhbACBUNBzg3YGhGc X-IronPort-AV: E=Sophos;i="4.38,416,1233550800"; d="scan'208";a="35609222" Received: from 69-196-134-79.dsl.teksavvy.com (HELO pastel.home) ([69.196.134.79]) by ironport2-out.teksavvy.com with ESMTP; 24 Mar 2009 21:35:03 -0400 Received: by pastel.home (Postfix, from userid 20848) id C93777F74; Tue, 24 Mar 2009 21:35:02 -0400 (EDT) From: Stefan Monnier To: Chong Yidong Cc: 2749@debbugs.gnu.org, pent Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case Message-ID: References: <87d4c694r2.fsf@cyd.mit.edu> Date: Tue, 24 Mar 2009 21:35:02 -0400 In-Reply-To: <87d4c694r2.fsf@cyd.mit.edu> (Chong Yidong's message of "Tue, 24 Mar 2009 14:04:33 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > This behavior is expected. The word wrap algorithm treats lines that > are too long to wrap using the ordinary line-wrapping rules, and since > overflow-newline-into-fringe is disabled in Visual Line mode, the extra > empty line is used to show the non-overflowed newline character. > After the release, I might look into letting word wrap handle > overflow-newline-into-fringe behavior. I suspect, however, that this > may lead to confusing results in some circumstances. BTW: why is overflow-newline-into-fringe ignored when word-wrap is non-nil? What kind of confusing results are you thinking of? Stefan From debbugs-submit-bounces@debbugs.gnu.org Mon Feb 18 07:04:24 2013 Received: (at 2749) by debbugs.gnu.org; 18 Feb 2013 12:04:24 +0000 Received: from localhost ([127.0.0.1]:33960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7PSJ-0008EX-LW for submit@debbugs.gnu.org; Mon, 18 Feb 2013 07:04:24 -0500 Received: from mout.gmx.net ([212.227.17.20]:64692) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1U7PSC-0008EK-TZ for 2749@debbugs.gnu.org; Mon, 18 Feb 2013 07:04:21 -0500 Received: from mailout-de.gmx.net ([10.1.76.24]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0M1TnD-1V0sZh2FZZ-00tXm6 for <2749@debbugs.gnu.org>; Mon, 18 Feb 2013 13:03:16 +0100 Received: (qmail invoked by alias); 18 Feb 2013 12:03:16 -0000 Received: from i59F571A5.versanet.de (EHLO rosalinde.fritz.box) [89.245.113.165] by mail.gmx.net (mp024) with SMTP; 18 Feb 2013 13:03:16 +0100 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX1+UfkQRM22UBvo6KuDWHKZY2W8SADUg5t3CFNJAtk /XMwN74D6rYhn2 From: Stephen Berman To: Stefan Monnier Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case Message-ID: <87obfhhn9d.fsf@rosalinde.fritz.box> References: <87d4c694r2.fsf@cyd.mit.edu> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Date: Mon, 18 Feb 2013 13:03:12 +0100 MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 2749 Cc: pent , Chong Yidong , 2749@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) On Tue, 24 Mar 2009 21:35:02 -0400 Stefan Monnier wrote: >> This behavior is expected. The word wrap algorithm treats lines that >> are too long to wrap using the ordinary line-wrapping rules, and since >> overflow-newline-into-fringe is disabled in Visual Line mode, the extra >> empty line is used to show the non-overflowed newline character. > >> After the release, I might look into letting word wrap handle >> overflow-newline-into-fringe behavior. I suspect, however, that this >> may lead to confusing results in some circumstances. > > BTW: why is overflow-newline-into-fringe ignored when word-wrap is > non-nil? What kind of confusing results are you thinking of? I would like to use a string of length window-width in a display overlay together with word-wrap and a non-nil wrap-prefix. Currently this results in a following empty line with indentation, which is rather disconcerting. But after removing `&& (IT)->line_wrap != WORD_WRAP' from the definition of IT_OVERFLOW_NEWLINE_INTO_FRINGE and rebuilding Emacs, the empty indented line is gone and I have just what I want. I haven't yet seen anything confusing. So I too would be very interested to know if there are known or suspected problems with allowing non-nil overflow-newline-into-fringe with word-wrap. If it's not clear there are any, could we allow it and then see if anyone screams bloody murder? Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 10:01:46 2013 Received: (at 2749) by debbugs.gnu.org; 10 May 2013 14:01:46 +0000 Received: from localhost ([127.0.0.1]:35703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UantH-0004YK-Pl for submit@debbugs.gnu.org; Fri, 10 May 2013 10:01:45 -0400 Received: from mout.gmx.net ([212.227.15.18]:57412) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UantB-0004Xe-Fi for 2749@debbugs.gnu.org; Fri, 10 May 2013 10:01:39 -0400 Received: from mailout-de.gmx.net ([10.1.76.29]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0LosgX-1U4T4Y41Rj-00gm8o for <2749@debbugs.gnu.org>; Fri, 10 May 2013 16:01:25 +0200 Received: (qmail invoked by alias); 10 May 2013 14:01:25 -0000 Received: from i59F57249.versanet.de (EHLO rosalinde.fritz.box) [89.245.114.73] by mail.gmx.net (mp029) with SMTP; 10 May 2013 16:01:25 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX19lZzdV2HRlO8RN0xxVuEEmUZkw1kKQoMNg4fz6Am 0jjrzlknwYs2gs From: Stephen Berman To: Stefan Monnier Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> Date: Fri, 10 May 2013 16:01:22 +0200 In-Reply-To: <87obfhhn9d.fsf@rosalinde.fritz.box> (Stephen Berman's message of "Mon, 18 Feb 2013 12:31:10 +0100") Message-ID: <871u9f6ij1.fsf@rosalinde.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 2749 Cc: pent , Chong Yidong , 2749@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.2 (---) On Mon, 18 Feb 2013 12:31:10 +0100 Stephen Berman wrote: > On Tue, 24 Mar 2009 21:35:02 -0400 Stefan Monnier wrote: > >>> This behavior is expected. The word wrap algorithm treats lines that >>> are too long to wrap using the ordinary line-wrapping rules, and since >>> overflow-newline-into-fringe is disabled in Visual Line mode, the extra >>> empty line is used to show the non-overflowed newline character. >> >>> After the release, I might look into letting word wrap handle >>> overflow-newline-into-fringe behavior. I suspect, however, that this >>> may lead to confusing results in some circumstances. >> >> BTW: why is overflow-newline-into-fringe ignored when word-wrap is >> non-nil? What kind of confusing results are you thinking of? > > I would like to use a string of length window-width in a display overlay > together with word-wrap and a non-nil wrap-prefix. Currently this > results in a following empty line with indentation, which is rather > disconcerting. But after removing `&& (IT)->line_wrap != WORD_WRAP' > from the definition of IT_OVERFLOW_NEWLINE_INTO_FRINGE and rebuilding > Emacs, the empty indented line is gone and I have just what I want. I > haven't yet seen anything confusing. So I too would be very interested > to know if there are known or suspected problems with allowing non-nil > overflow-newline-into-fringe with word-wrap. If it's not clear there > are any, could we allow it and then see if anyone screams bloody murder? I've been using Emacs as described above (i.e., with the patch below) and till today have had no problems, but I just bumped into one, which is indeed confusing, even pretty nasty. I've reproduced it with -Q on a fresh build from the latest trunk (with the patch added). I don't know how to debug it, but I will describe how to reproduce it, in the hope that someone can fix it (or at least give me some help in trying to debug it) and then hopefully overflow-newline-into-fringe can be allowed in Visual Line mode. Here's the recipe: -1. Apply the following patch and rebuild Emacs: *** /home/steve/bzr/emacs/trunk/src/xdisp.c 2013-05-10 12:51:51.000000000 +0200 --- /home/steve/bzr/emacs/quickfixes/src/xdisp.c 2013-05-10 14:56:22.000000000 +0200 *************** *** 378,385 **** && ((IT)->bidi_it.paragraph_dir == R2L \ ? (WINDOW_LEFT_FRINGE_WIDTH ((IT)->w) > 0) \ : (WINDOW_RIGHT_FRINGE_WIDTH ((IT)->w) > 0)) \ ! && (IT)->current_x == (IT)->last_visible_x \ ! && (IT)->line_wrap != WORD_WRAP) #else /* !HAVE_WINDOW_SYSTEM */ #define IT_OVERFLOW_NEWLINE_INTO_FRINGE(it) 0 --- 378,384 ---- && ((IT)->bidi_it.paragraph_dir == R2L \ ? (WINDOW_LEFT_FRINGE_WIDTH ((IT)->w) > 0) \ : (WINDOW_RIGHT_FRINGE_WIDTH ((IT)->w) > 0)) \ ! && (IT)->current_x == (IT)->last_visible_x) #else /* !HAVE_WINDOW_SYSTEM */ #define IT_OVERFLOW_NEWLINE_INTO_FRINGE(it) 0 0. emacs -Q 1. Type `C-u 69 x SPC C-u 10 x' to make a string of 69 x's followed by a space followed by a string of 10 x's; point should be in the fringe. 2. Type `RET C-u 69 x RET C-u 69 x' to add two more lines 69 x's long (this is not essential to show the bug but helps in describing its effects). 3. M-x visual-line-mode; now the string of 10 x's in the first line has wrapped to occupy its own visual line below the first string of x's, i.e., you see a line of 69 x's followed by a line of 10 x's followed by two more lines of 69 x's. 4. If you click with the mouse (which button doesn't matter, but mouse-1 is least intrusive) anywhere in the buffer up to and including the space following the last x in the first line of x's, point is set where you click, as usual. Now come the confusing results. 5. If you click with the mouse on the first column after the space at the end of the first line of x's, point is set on the first x of the following word-wrap line; if you click on the second column after the space, point is set on the second x below, and so on up to the fringe in the first line of x's. 6. If you click with the mouse on any position starting with the first x in the second, visual, line (the word-wrapped line), point is set one line below in the same column. The goes for all following lines in the buffer, even if not word-wrapped (actually, with further word-wrapping below the first word-wrapped line, I've seen point being set two lines below, but it's harder to reproduce that). 7. If you put point (using the keyboard, whose events are not effected by this bug) somewhere on the second line of 69 x's (the one just below the word-wrapped line of 10 x's) and then type `C-l' twice to move that line to the top of the window, now clicking with the mouse anywhere on this line or lower again correctly sets point where you click. If you scroll vertically so that the word-wrapped line is again visible in the window, the point setting problem happens again. 8. If you add one character to the first line of x's, thus making its (unwrapped) length longer than window-width, the point setting problem does not happen. From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 11:00:40 2013 Received: (at 2749) by debbugs.gnu.org; 10 May 2013 15:00:40 +0000 Received: from localhost ([127.0.0.1]:35765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UaooJ-0007tr-BW for submit@debbugs.gnu.org; Fri, 10 May 2013 11:00:39 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:46489) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UaooG-0007tZ-3k for 2749@debbugs.gnu.org; Fri, 10 May 2013 11:00:37 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MML0090087EWH00@a-mtaout22.012.net.il> for 2749@debbugs.gnu.org; Fri, 10 May 2013 18:00:00 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MML0094Y8BZWT00@a-mtaout22.012.net.il>; Fri, 10 May 2013 18:00:00 +0300 (IDT) Date: Fri, 10 May 2013 17:59:43 +0300 From: Eli Zaretskii Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case In-reply-to: <871u9f6ij1.fsf@rosalinde.fritz.box> X-012-Sender: halo1@inter.net.il To: Stephen Berman Message-id: <83ip2qc23k.fsf@gnu.org> References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> <871u9f6ij1.fsf@rosalinde.fritz.box> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 2749 Cc: pent@aparamon.msk.ru, 2749@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > From: Stephen Berman > Date: Fri, 10 May 2013 16:01:22 +0200 > Cc: pent , 2749@debbugs.gnu.org > > I've been using Emacs as described above (i.e., with the patch below) > and till today have had no problems, but I just bumped into one, which > is indeed confusing, even pretty nasty. I've reproduced it with -Q on a > fresh build from the latest trunk (with the patch added). I don't know > how to debug it, but I will describe how to reproduce it, in the hope > that someone can fix it (or at least give me some help in trying to > debug it) and then hopefully overflow-newline-into-fringe can be allowed > in Visual Line mode. Does the patch below fix the problem (and whatever original problem that led you to this recipe)? --- src/xdisp.c~0 2013-05-10 17:56:44.338000000 +0300 +++ src/xdisp.c 2013-05-10 17:57:07.197375000 +0300 @@ -8466,7 +8466,8 @@ && it->bidi_it.paragraph_dir == R2L) ? WINDOW_LEFT_FRINGE_WIDTH (it->w) : WINDOW_RIGHT_FRINGE_WIDTH (it->w)) == 0 - || IT_OVERFLOW_NEWLINE_INTO_FRINGE (it)) + || (IT_OVERFLOW_NEWLINE_INTO_FRINGE (it) + && it->line_wrap != WORD_WRAP)) { if (!get_next_display_element (it)) { From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 11:49:59 2013 Received: (at 2749) by debbugs.gnu.org; 10 May 2013 15:49:59 +0000 Received: from localhost ([127.0.0.1]:35803 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uapa2-0001hl-B1 for submit@debbugs.gnu.org; Fri, 10 May 2013 11:49:59 -0400 Received: from mout.gmx.net ([212.227.17.22]:63188) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UapZz-0001hO-TM for 2749@debbugs.gnu.org; Fri, 10 May 2013 11:49:57 -0400 Received: from mailout-de.gmx.net ([10.1.76.31]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0LtC7R-1UQLym2h9X-012tVo for <2749@debbugs.gnu.org>; Fri, 10 May 2013 17:49:43 +0200 Received: (qmail invoked by alias); 10 May 2013 15:49:43 -0000 Received: from i59F57249.versanet.de (EHLO rosalinde.fritz.box) [89.245.114.73] by mail.gmx.net (mp031) with SMTP; 10 May 2013 17:49:43 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX1/1smQOIl/1shE9IpJATlHjEG67dCLXfIJN4H5ZYd j0G5ggCVPlqh6Q From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> <871u9f6ij1.fsf@rosalinde.fritz.box> <83ip2qc23k.fsf@gnu.org> Date: Fri, 10 May 2013 17:49:40 +0200 In-Reply-To: <83ip2qc23k.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 May 2013 17:59:43 +0300") Message-ID: <87wqr66dij.fsf@rosalinde.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 2749 Cc: pent@aparamon.msk.ru, 2749@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.2 (---) On Fri, 10 May 2013 17:59:43 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Date: Fri, 10 May 2013 16:01:22 +0200 >> Cc: pent , 2749@debbugs.gnu.org >> >> I've been using Emacs as described above (i.e., with the patch below) >> and till today have had no problems, but I just bumped into one, which >> is indeed confusing, even pretty nasty. I've reproduced it with -Q on a >> fresh build from the latest trunk (with the patch added). I don't know >> how to debug it, but I will describe how to reproduce it, in the hope >> that someone can fix it (or at least give me some help in trying to >> debug it) and then hopefully overflow-newline-into-fringe can be allowed >> in Visual Line mode. > > Does the patch below fix the problem (and whatever original problem > that led you to this recipe)? > > --- src/xdisp.c~0 2013-05-10 17:56:44.338000000 +0300 > +++ src/xdisp.c 2013-05-10 17:57:07.197375000 +0300 > @@ -8466,7 +8466,8 @@ > && it->bidi_it.paragraph_dir == R2L) > ? WINDOW_LEFT_FRINGE_WIDTH (it->w) > : WINDOW_RIGHT_FRINGE_WIDTH (it->w)) == 0 > - || IT_OVERFLOW_NEWLINE_INTO_FRINGE (it)) > + || (IT_OVERFLOW_NEWLINE_INTO_FRINGE (it) > + && it->line_wrap != WORD_WRAP)) > { > if (!get_next_display_element (it)) > { Yes, it fixes the "confusing results" with the patch in my previous mail. Thanks very much! (I wish I understood why this problem occurred and how your patch fixes it...) Unless someone knows of another problem with allowing overflow-newline-into-fringe in Visual Line mode, I would like to request that both my patch and yours be committed to the trunk; I can do that if I'm given the go-ahead. Then I think this bug could be closed. Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 13:37:41 2013 Received: (at 2749) by debbugs.gnu.org; 10 May 2013 17:37:41 +0000 Received: from localhost ([127.0.0.1]:35867 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UarGH-0008DX-1J for submit@debbugs.gnu.org; Fri, 10 May 2013 13:37:41 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]:42975) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UarGE-0008DN-HH for 2749@debbugs.gnu.org; Fri, 10 May 2013 13:37:39 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0MML00500FBSYX00@a-mtaout21.012.net.il> for 2749@debbugs.gnu.org; Fri, 10 May 2013 20:37:26 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MML006X2FMD1O00@a-mtaout21.012.net.il>; Fri, 10 May 2013 20:37:26 +0300 (IDT) Date: Fri, 10 May 2013 20:37:08 +0300 From: Eli Zaretskii Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case In-reply-to: <87wqr66dij.fsf@rosalinde.fritz.box> X-012-Sender: halo1@inter.net.il To: Stephen Berman Message-id: <83ehdebut7.fsf@gnu.org> References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> <871u9f6ij1.fsf@rosalinde.fritz.box> <83ip2qc23k.fsf@gnu.org> <87wqr66dij.fsf@rosalinde.fritz.box> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 2749 Cc: pent@aparamon.msk.ru, 2749@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > From: Stephen Berman > Cc: monnier@iro.umontreal.ca, pent@aparamon.msk.ru, 2749@debbugs.gnu.org > Date: Fri, 10 May 2013 17:49:40 +0200 > > > Does the patch below fix the problem (and whatever original problem > > that led you to this recipe)? > > > > --- src/xdisp.c~0 2013-05-10 17:56:44.338000000 +0300 > > +++ src/xdisp.c 2013-05-10 17:57:07.197375000 +0300 > > @@ -8466,7 +8466,8 @@ > > && it->bidi_it.paragraph_dir == R2L) > > ? WINDOW_LEFT_FRINGE_WIDTH (it->w) > > : WINDOW_RIGHT_FRINGE_WIDTH (it->w)) == 0 > > - || IT_OVERFLOW_NEWLINE_INTO_FRINGE (it)) > > + || (IT_OVERFLOW_NEWLINE_INTO_FRINGE (it) > > + && it->line_wrap != WORD_WRAP)) > > { > > if (!get_next_display_element (it)) > > { > > Yes, it fixes the "confusing results" with the patch in my previous > mail. Thanks very much! You are welcome. > (I wish I understood why this problem occurred and how your patch > fixes it...) I didn't really debug it, I just applied Sherlock Holmes's principle: when you have eliminated all the other possible explanations, the one that stays is the correct one. IT_OVERFLOW_NEWLINE_INTO_FRINGE is used in a small number of places. Most of them are related to actually displaying text, which couldn't be the reason here, because no text was displayed, only the cursor. Of the 2 that are left, one was conditioned by it->line_wrap == TRUNCATE, so again couldn't be the reason. What's left was the one I fixed, and the fix just added back the condition you removed from IT_OVERFLOW_NEWLINE_INTO_FRINGE. I can give you a vague idea of why the problem occurred. When you click the mouse, Emacs needs to determine what buffer position is at that place, so it could move point there. The code which determines buffer position from pixel coordinates simulates the display, starting at the window beginning and producing glyphs for display (and discarding them) until it gets to the desired pixel coordinates. The code where I made the change is part of that display simulation. It assumed without testing that word-wrap can never be on when IT_OVERFLOW_NEWLINE_INTO_FRINGE is true, which means that you cannot click outside of text, because text goes to the very end of the window. But with the change in IT_OVERFLOW_NEWLINE_INTO_FRINGE, that assumption was no longer true. > Unless someone knows of another problem with allowing > overflow-newline-into-fringe in Visual Line mode, I would like to > request that both my patch and yours be committed to the trunk Do you use Org mode or any other modes (e.g., magit) that are heavy users of display strings? If not, then I'm not prepared to believe that the above is the only problem with this change. I'd like to see much more reports from users of those modes that this change doesn't cause any trouble, before I'd agree to installing it. Just look how much time it took until this problem popped up. Since I knew the only change was in a single macro that is used in a small number of places, fixing it was a 5-min job. But imagine that the same would happen 3 years after committing this change, with gazillions of unrelated changes in the display code since then. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 15:06:37 2013 Received: (at 2749) by debbugs.gnu.org; 10 May 2013 19:06:37 +0000 Received: from localhost ([127.0.0.1]:35892 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UaseK-0003Rq-RO for submit@debbugs.gnu.org; Fri, 10 May 2013 15:06:37 -0400 Received: from mout.gmx.net ([212.227.17.21]:51564) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UaseH-0003Rg-Se for 2749@debbugs.gnu.org; Fri, 10 May 2013 15:06:35 -0400 Received: from mailout-de.gmx.net ([10.1.76.33]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0Lx1bL-1UU8OL3VZR-016j3c for <2749@debbugs.gnu.org>; Fri, 10 May 2013 21:06:20 +0200 Received: (qmail invoked by alias); 10 May 2013 19:06:20 -0000 Received: from i59F57249.versanet.de (EHLO rosalinde.fritz.box) [89.245.114.73] by mail.gmx.net (mp033) with SMTP; 10 May 2013 21:06:20 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX18uBSEE+18u1ZQhejyTw35BghsJ5toF5y2Ouxp6DB pVh/JCvpNxBkoO From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> <871u9f6ij1.fsf@rosalinde.fritz.box> <83ip2qc23k.fsf@gnu.org> <87wqr66dij.fsf@rosalinde.fritz.box> <83ehdebut7.fsf@gnu.org> Date: Fri, 10 May 2013 21:06:15 +0200 In-Reply-To: <83ehdebut7.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 May 2013 20:37:08 +0300") Message-ID: <87sj1u64ew.fsf@rosalinde.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -3.2 (---) X-Debbugs-Envelope-To: 2749 Cc: pent@aparamon.msk.ru, 2749@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.2 (---) On Fri, 10 May 2013 20:37:08 +0300 Eli Zaretskii wrote: >> From: Stephen Berman [...] >> (I wish I understood why this problem occurred and how your patch >> fixes it...) [...] > I can give you a vague idea of why the problem occurred. [...] Thanks for the explanation. >> Unless someone knows of another problem with allowing >> overflow-newline-into-fringe in Visual Line mode, I would like to >> request that both my patch and yours be committed to the trunk > > Do you use Org mode or any other modes (e.g., magit) that are heavy > users of display strings? I don't use either of those modes, but I have been developing a new version of todo-mode.el for a very long time (which I plan to submit for possible inclusion in Emacs, hopefully before the next pretest begins) and it uses before-string overlays, on the order of hundreds per buffer (though most are not in the visible window at any time), as well as word-wrap and wrap-prefix. > If not, then I'm not prepared to believe > that the above is the only problem with this change. I'd like to see > much more reports from users of those modes that this change doesn't > cause any trouble, before I'd agree to installing it. Just look how > much time it took until this problem popped up. Since I knew the only > change was in a single macro that is used in a small number of places, > fixing it was a 5-min job. But imagine that the same would happen 3 > years after committing this change, with gazillions of unrelated > changes in the display code since then. I may be misunderstanding you here, but it sounds like you think the patch to enable overflow-newline-into-fringe in Visual Line mode is already in the trunk; it isn't. This bug report was initiated more than four years ago by someone (not me) who noticed the odd display of a line whose length is window-width when Visual Line mode is enabled. Chong Yidong pointed out that this was because fringe overflow was disabled in Visual Line mode and he suspected "confusing results" if it were enabled. Then this past February, almost four years later, I posted that I had enabled it in my local branch and had not observed any problems. I've been using it since then and only today hit the problem that I reported and you quickly fixed. Nobody using the vanilla trunk can have run into the problem, because fringe overflow is still disabled in Visual Line mode there. But if it were now enabled (with my patch) and your patch were also added (to prevent the problem I reported today), then Org and magit users and others will be able to see if other problems do arise. Does this make sense, or have I completely misunderstood you? Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Fri May 10 15:32:33 2013 Received: (at 2749) by debbugs.gnu.org; 10 May 2013 19:32:33 +0000 Received: from localhost ([127.0.0.1]:35897 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uat3R-0004my-4q for submit@debbugs.gnu.org; Fri, 10 May 2013 15:32:33 -0400 Received: from mtaout23.012.net.il ([80.179.55.175]:42856) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Uat3O-0004me-HA for 2749@debbugs.gnu.org; Fri, 10 May 2013 15:32:31 -0400 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MML00900KU7OM00@a-mtaout23.012.net.il> for 2749@debbugs.gnu.org; Fri, 10 May 2013 22:32:13 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MML0093LKXLO510@a-mtaout23.012.net.il>; Fri, 10 May 2013 22:32:09 +0300 (IDT) Date: Fri, 10 May 2013 22:31:53 +0300 From: Eli Zaretskii Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case In-reply-to: <87sj1u64ew.fsf@rosalinde.fritz.box> X-012-Sender: halo1@inter.net.il To: Stephen Berman Message-id: <83d2sybphy.fsf@gnu.org> References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> <871u9f6ij1.fsf@rosalinde.fritz.box> <83ip2qc23k.fsf@gnu.org> <87wqr66dij.fsf@rosalinde.fritz.box> <83ehdebut7.fsf@gnu.org> <87sj1u64ew.fsf@rosalinde.fritz.box> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 2749 Cc: pent@aparamon.msk.ru, 2749@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > From: Stephen Berman > Cc: monnier@iro.umontreal.ca, pent@aparamon.msk.ru, 2749@debbugs.gnu.org > Date: Fri, 10 May 2013 21:06:15 +0200 > > > Do you use Org mode or any other modes (e.g., magit) that are heavy > > users of display strings? > > I don't use either of those modes, but I have been developing a new > version of todo-mode.el for a very long time (which I plan to submit for > possible inclusion in Emacs, hopefully before the next pretest begins) > and it uses before-string overlays, on the order of hundreds per buffer > (though most are not in the visible window at any time), as well as > word-wrap and wrap-prefix. Before- and after-strings are much easier on the display engine than 'display' text properties and overlays with 'display' properties. > I may be misunderstanding you here, but it sounds like you think the > patch to enable overflow-newline-into-fringe in Visual Line mode is > already in the trunk; it isn't. I know. I said "imagine" because I understand this change is not in the repository. > But if it were now enabled (with my patch) and your patch were also > added (to prevent the problem I reported today), then Org and magit > users and others will be able to see if other problems do arise. I suspect subtle issues will be triggered by this change in modes that make heavy use of display properties. But if Stefan is willing to take that risk, let's install this and see what breaks. From debbugs-submit-bounces@debbugs.gnu.org Sat May 18 16:30:36 2013 Received: (at 2749) by debbugs.gnu.org; 18 May 2013 20:30:36 +0000 Received: from localhost ([127.0.0.1]:50704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Udnlz-000691-JW for submit@debbugs.gnu.org; Sat, 18 May 2013 16:30:35 -0400 Received: from mout.gmx.net ([212.227.15.15]:60669) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Udnlx-00068j-20 for 2749@debbugs.gnu.org; Sat, 18 May 2013 16:30:34 -0400 Received: from mailout-de.gmx.net ([10.1.76.27]) by mrigmx.server.lan (mrigmx001) with ESMTP (Nemesis) id 0MK7RL-1UcQJy18Sb-001OWF for <2749@debbugs.gnu.org>; Sat, 18 May 2013 22:30:03 +0200 Received: (qmail invoked by alias); 18 May 2013 20:30:02 -0000 Received: from i59F56E2D.versanet.de (EHLO rosalinde.fritz.box) [89.245.110.45] by mail.gmx.net (mp027) with SMTP; 18 May 2013 22:30:02 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX18Peuo5sUIPmhihv6XiH4p5Nu/s+UdeT98v+SgKfX izk6Y5y/eHMfXv From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> <871u9f6ij1.fsf@rosalinde.fritz.box> <83ip2qc23k.fsf@gnu.org> <87wqr66dij.fsf@rosalinde.fritz.box> <83ehdebut7.fsf@gnu.org> <87sj1u64ew.fsf@rosalinde.fritz.box> <83d2sybphy.fsf@gnu.org> Date: Sat, 18 May 2013 22:30:00 +0200 In-Reply-To: <83d2sybphy.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 10 May 2013 22:31:53 +0300") Message-ID: <87mwrs6ng7.fsf@rosalinde.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 2749 Cc: 2749@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.5 (--) On Fri, 10 May 2013 22:31:53 +0300 Eli Zaretskii wrote: >> From: Stephen Berman [...] >> I may be misunderstanding you here, but it sounds like you think the >> patch to enable overflow-newline-into-fringe in Visual Line mode is >> already in the trunk; it isn't. > > I know. I said "imagine" because I understand this change is not in > the repository. > >> But if it were now enabled (with my patch) and your patch were also >> added (to prevent the problem I reported today), then Org and magit >> users and others will be able to see if other problems do arise. > > I suspect subtle issues will be triggered by this change in modes that > make heavy use of display properties. But if Stefan is willing to > take that risk, let's install this and see what breaks. I hope Stefan's silence till now just means he hasn't yet had time to give this issue due consideration.... In the mean time, I've encountered another problem, which has nothing to do with display properties or overlays: -1. Apply both my patch and yours (Eli's). 0. emacs -Q 1. Type `a RET C-80 x RET b' to insert three line of text, of which the second runs the width of the window, up to the right fringe. 2. M-x visual-line-mode 3. With point on `a', type `C-n': now point is on the first `x' of the second inserted line. Here's the first instance of the problem: 4. Type `C-n' again: now point is in the fringe at the end of the line of x's. Here's the next instance of the problem: 5. Type `C-p': now point is back on the first `x' of the second inserted line. (If you type `C-n' again after step 4, so point is on `b' in the third inserted line, and then type `C-p', now point is back in the fringe at the end of the line of x's. I assume this is not an instance of the problem, but point moving correctly back to the goal column.) As you've no doubt guessed by now, the problem occurs in vertical-motion, and can be reproduced by replacing `C-n' and `C-p' in the recipe by `M-: (vertical-motion 1)' and `M-: (vertical-motion -1)', respectively. I tried to debug it but my GDB skills are unfortunately too limited; if you feel like advising me, I'm all ears. Otherwise, it would be great if you could fix this as quickly as you fixed the last problem I reported! Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sun May 19 11:30:18 2013 Received: (at 2749) by debbugs.gnu.org; 19 May 2013 15:30:18 +0000 Received: from localhost ([127.0.0.1]:51532 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ue5Yw-0006cA-CU for submit@debbugs.gnu.org; Sun, 19 May 2013 11:30:18 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:43471) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ue5Ys-0006bl-Vo for 2749@debbugs.gnu.org; Sun, 19 May 2013 11:30:16 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MN100B00X00WC00@a-mtaout22.012.net.il> for 2749@debbugs.gnu.org; Sun, 19 May 2013 18:29:39 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MN100BDCXPDTK60@a-mtaout22.012.net.il>; Sun, 19 May 2013 18:29:37 +0300 (IDT) Date: Sun, 19 May 2013 18:29:26 +0300 From: Eli Zaretskii Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case In-reply-to: <87mwrs6ng7.fsf@rosalinde.fritz.box> X-012-Sender: halo1@inter.net.il To: Stephen Berman Message-id: <83sj1jvvhl.fsf@gnu.org> References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> <871u9f6ij1.fsf@rosalinde.fritz.box> <83ip2qc23k.fsf@gnu.org> <87wqr66dij.fsf@rosalinde.fritz.box> <83ehdebut7.fsf@gnu.org> <87sj1u64ew.fsf@rosalinde.fritz.box> <83d2sybphy.fsf@gnu.org> <87mwrs6ng7.fsf@rosalinde.fritz.box> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 2749 Cc: 2749@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > From: Stephen Berman > Cc: monnier@iro.umontreal.ca, 2749@debbugs.gnu.org > Date: Sat, 18 May 2013 22:30:00 +0200 > > I hope Stefan's silence till now just means he hasn't yet had time to > give this issue due consideration.... > > In the mean time, I've encountered another problem, which has nothing to > do with display properties or overlays: So let me see if I understand how this works: you discover one by one the problems about this change, those same problems I was afraid of, and I get to debug them, is that right? ;-) Is there any point in this game where we say "enough", as too many problems were discovered for too small a gain? Or does this go on forever? > -1. Apply both my patch and yours (Eli's). If you don't apply mine, does this problem still happen? From debbugs-submit-bounces@debbugs.gnu.org Sun May 19 12:29:39 2013 Received: (at 2749) by debbugs.gnu.org; 19 May 2013 16:29:39 +0000 Received: from localhost ([127.0.0.1]:51587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ue6UM-0000FS-Ro for submit@debbugs.gnu.org; Sun, 19 May 2013 12:29:39 -0400 Received: from mout.gmx.net ([212.227.17.21]:51714) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ue6UK-0000F1-E1 for 2749@debbugs.gnu.org; Sun, 19 May 2013 12:29:37 -0400 Received: from mailout-de.gmx.net ([10.1.76.28]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MJqWY-1UfCPK0rDA-001CMj for <2749@debbugs.gnu.org>; Sun, 19 May 2013 18:29:02 +0200 Received: (qmail invoked by alias); 19 May 2013 16:29:01 -0000 Received: from i59F56002.versanet.de (EHLO rosalinde.fritz.box) [89.245.96.2] by mail.gmx.net (mp028) with SMTP; 19 May 2013 18:29:01 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX1+rD2hQ0CWrHzPabBwCmnWZrBdgpvSzcSfvohowIm CNM39ImwdR7RO8 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> <871u9f6ij1.fsf@rosalinde.fritz.box> <83ip2qc23k.fsf@gnu.org> <87wqr66dij.fsf@rosalinde.fritz.box> <83ehdebut7.fsf@gnu.org> <87sj1u64ew.fsf@rosalinde.fritz.box> <83d2sybphy.fsf@gnu.org> <87mwrs6ng7.fsf@rosalinde.fritz.box> <83sj1jvvhl.fsf@gnu.org> Date: Sun, 19 May 2013 18:28:59 +0200 In-Reply-To: <83sj1jvvhl.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 19 May 2013 18:29:26 +0300") Message-ID: <87fvxjkk6s.fsf@rosalinde.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 2749 Cc: 2749@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.0 (---) On Sun, 19 May 2013 18:29:26 +0300 Eli Zaretskii wrote: >> From: Stephen Berman >> Cc: monnier@iro.umontreal.ca, 2749@debbugs.gnu.org >> Date: Sat, 18 May 2013 22:30:00 +0200 >> >> I hope Stefan's silence till now just means he hasn't yet had time to >> give this issue due consideration.... >> >> In the mean time, I've encountered another problem, which has nothing to >> do with display properties or overlays: > > So let me see if I understand how this works: you discover one by one > the problems about this change, those same problems I was afraid of, > and I get to debug them, is that right? ;-) Is this new problem one you anticipated? I thought you were worried about problems arising from heavy use of display properties, but this doesn't involve any. Anyway, I really do wish I knew how to debug this myself. I tried stepping though Fvertical_motion but that has many calls to other parts of the code and I couldn't follow it well -- didn't know what could be skipped over, or what values to test, etc. It looked like point moved into the fringe after a call to, I think, read_char but I couldn't tell if that was really the trigger (doesn't seem likely). Of course, I would be grateful if you'd give me any help or advice about how to debug it, but I suspect that wouldn't be less burdensome to you than debugging it yourself ;-) > Is there any point in this game where we say "enough", as too many > problems were discovered for too small a gain? Or does this go on > forever? Well, I hope you agree what started this is a real bug. If you, Stefan or other Emacs maintainers tell me it's not worth fixing, I can live with that. But as long as long as it's not fixed, other people may encounter it and report it again.... >> -1. Apply both my patch and yours (Eli's). > > If you don't apply mine, does this problem still happen? No, with my patch and without yours, this problem goes away. So then we're back to the previous problem.... ;-) Steve Berman From debbugs-submit-bounces@debbugs.gnu.org Sun May 19 13:39:43 2013 Received: (at 2749) by debbugs.gnu.org; 19 May 2013 17:39:43 +0000 Received: from localhost ([127.0.0.1]:51653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ue7aB-0002f9-5Q for submit@debbugs.gnu.org; Sun, 19 May 2013 13:39:43 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:47292) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Ue7a9-0002ev-4J for 2749@debbugs.gnu.org; Sun, 19 May 2013 13:39:42 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MN200D003NZFA00@a-mtaout22.012.net.il> for 2749@debbugs.gnu.org; Sun, 19 May 2013 20:38:58 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MN200DHA3OX4H90@a-mtaout22.012.net.il>; Sun, 19 May 2013 20:38:58 +0300 (IDT) Date: Sun, 19 May 2013 20:38:46 +0300 From: Eli Zaretskii Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case In-reply-to: <87fvxjkk6s.fsf@rosalinde.fritz.box> X-012-Sender: halo1@inter.net.il To: Stephen Berman Message-id: <83mwrqx42h.fsf@gnu.org> References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> <871u9f6ij1.fsf@rosalinde.fritz.box> <83ip2qc23k.fsf@gnu.org> <87wqr66dij.fsf@rosalinde.fritz.box> <83ehdebut7.fsf@gnu.org> <87sj1u64ew.fsf@rosalinde.fritz.box> <83d2sybphy.fsf@gnu.org> <87mwrs6ng7.fsf@rosalinde.fritz.box> <83sj1jvvhl.fsf@gnu.org> <87fvxjkk6s.fsf@rosalinde.fritz.box> X-Spam-Score: -1.2 (-) X-Debbugs-Envelope-To: 2749 Cc: 2749@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.2 (-) > From: Stephen Berman > Cc: monnier@iro.umontreal.ca, 2749@debbugs.gnu.org > Date: Sun, 19 May 2013 18:28:59 +0200 > > On Sun, 19 May 2013 18:29:26 +0300 Eli Zaretskii wrote: > > >> From: Stephen Berman > >> Cc: monnier@iro.umontreal.ca, 2749@debbugs.gnu.org > >> Date: Sat, 18 May 2013 22:30:00 +0200 > >> > >> I hope Stefan's silence till now just means he hasn't yet had time to > >> give this issue due consideration.... > >> > >> In the mean time, I've encountered another problem, which has nothing to > >> do with display properties or overlays: > > > > So let me see if I understand how this works: you discover one by one > > the problems about this change, those same problems I was afraid of, > > and I get to debug them, is that right? ;-) > > Is this new problem one you anticipated? I thought you were worried > about problems arising from heavy use of display properties, but this > doesn't involve any. Changes such as the one you suggested are bound to break any number of places that are all related to functions that simulate display. vertical-motion is one of them, but in no way the only one. Display properties and overlays tend to reveal such problems sooner, because they already strain the relevant code, and require all kinds of ad-hoc'ery that is easy to break. But they are not the only ones. > Of course, I would be grateful if you'd give me any help or advice about > how to debug it, but I suspect that wouldn't be less burdensome to you > than debugging it yourself ;-) > > > Is there any point in this game where we say "enough", as too many > > problems were discovered for too small a gain? Or does this go on > > forever? > > Well, I hope you agree what started this is a real bug. If you, Stefan > or other Emacs maintainers tell me it's not worth fixing, I can live > with that. But as long as long as it's not fixed, other people may > encounter it and report it again.... I don't mind trying a bit longer, I just want to know what kind of process are we involved in here. If there were a decision (by Stefan) to introduce this feature no matter what, then I'd understand that any fallout needs to be fixed. But this not being the case, I wonder what are we trying to accomplish here. I'll take a look when I have time. From debbugs-submit-bounces@debbugs.gnu.org Tue May 28 18:28:26 2013 Received: (at 2749) by debbugs.gnu.org; 28 May 2013 22:28:26 +0000 Received: from localhost ([127.0.0.1]:38154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhSNW-0000vA-5O for submit@debbugs.gnu.org; Tue, 28 May 2013 18:28:26 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.182]:2626) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1UhSNU-0000uv-2y for 2749@debbugs.gnu.org; Tue, 28 May 2013 18:28:24 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFMCpOt/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GsR+QDpEKA6R6gV6DEw X-IPAS-Result: Av4EABK/CFFMCpOt/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GsR+QDpEKA6R6gV6DEw X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="14978876" Received: from 76-10-147-173.dsl.teksavvy.com (HELO pastel.home) ([76.10.147.173]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 28 May 2013 18:26:52 -0400 Received: by pastel.home (Postfix, from userid 20848) id 597E567BCD; Tue, 28 May 2013 18:26:57 -0400 (EDT) From: Stefan Monnier To: Stephen Berman Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case Message-ID: References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> <871u9f6ij1.fsf@rosalinde.fritz.box> <83ip2qc23k.fsf@gnu.org> <87wqr66dij.fsf@rosalinde.fritz.box> <83ehdebut7.fsf@gnu.org> <87sj1u64ew.fsf@rosalinde.fritz.box> <83d2sybphy.fsf@gnu.org> <87mwrs6ng7.fsf@rosalinde.fritz.box> Date: Tue, 28 May 2013 18:26:57 -0400 In-Reply-To: <87mwrs6ng7.fsf@rosalinde.fritz.box> (Stephen Berman's message of "Sat, 18 May 2013 22:30:00 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 2749 Cc: Eli Zaretskii , 2749@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -1.9 (-) > I hope Stefan's silence till now just means he hasn't yet had time to > give this issue due consideration.... No, the thread was simply mis-filed. I'm a user of word-wrap and I like overflow-newline-into-fringe, so I'm in favor of this patch. That's assuming any serious fall-out can get fixed, obviously. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 02 11:55:07 2013 Received: (at 2749-done) by debbugs.gnu.org; 2 Jul 2013 15:55:07 +0000 Received: from localhost ([127.0.0.1]:52671 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uu2v1-0005jQ-Sr for submit@debbugs.gnu.org; Tue, 02 Jul 2013 11:55:06 -0400 Received: from mtaout22.012.net.il ([80.179.55.172]:56388) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Uu2uw-0005ik-3I for 2749-done@debbugs.gnu.org; Tue, 02 Jul 2013 11:54:59 -0400 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MPB00I00G6L0K00@a-mtaout22.012.net.il> for 2749-done@debbugs.gnu.org; Tue, 02 Jul 2013 18:54:51 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MPB00HR9G7EJ3A0@a-mtaout22.012.net.il>; Tue, 02 Jul 2013 18:54:51 +0300 (IDT) Date: Tue, 02 Jul 2013 18:54:39 +0300 From: Eli Zaretskii Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case In-reply-to: X-012-Sender: halo1@inter.net.il To: Stefan Monnier Message-id: <83obalareo.fsf@gnu.org> References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> <871u9f6ij1.fsf@rosalinde.fritz.box> <83ip2qc23k.fsf@gnu.org> <87wqr66dij.fsf@rosalinde.fritz.box> <83ehdebut7.fsf@gnu.org> <87sj1u64ew.fsf@rosalinde.fritz.box> <83d2sybphy.fsf@gnu.org> <87mwrs6ng7.fsf@rosalinde.fritz.box> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 2749-done Cc: stephen.berman@gmx.net, 2749-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > From: Stefan Monnier > Date: Tue, 28 May 2013 18:26:57 -0400 > Cc: Eli Zaretskii , 2749@debbugs.gnu.org > > > I hope Stefan's silence till now just means he hasn't yet had time to > > give this issue due consideration.... > > No, the thread was simply mis-filed. I'm a user of word-wrap and I like > overflow-newline-into-fringe, so I'm in favor of this patch. > That's assuming any serious fall-out can get fixed, obviously. I fixed the two known problems with the original proposal, and committed everything to the trunk as revision 113259. This bug is now officially closed. Any fallout should be reported as separate bugs. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 03 05:15:27 2013 Received: (at 2749-done) by debbugs.gnu.org; 3 Jul 2013 09:15:27 +0000 Received: from localhost ([127.0.0.1]:53725 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UuJ9q-0000I6-RE for submit@debbugs.gnu.org; Wed, 03 Jul 2013 05:15:26 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:41670) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UuJ9o-0000Hx-JE for 2749-done@debbugs.gnu.org; Wed, 03 Jul 2013 05:15:25 -0400 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id r639FKdk002514; Wed, 3 Jul 2013 05:15:21 -0400 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 20A7FAE15B; Wed, 3 Jul 2013 05:15:20 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case Message-ID: References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> <871u9f6ij1.fsf@rosalinde.fritz.box> <83ip2qc23k.fsf@gnu.org> <87wqr66dij.fsf@rosalinde.fritz.box> <83ehdebut7.fsf@gnu.org> <87sj1u64ew.fsf@rosalinde.fritz.box> <83d2sybphy.fsf@gnu.org> <87mwrs6ng7.fsf@rosalinde.fritz.box> <83obalareo.fsf@gnu.org> Date: Wed, 03 Jul 2013 05:15:20 -0400 In-Reply-To: <83obalareo.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 02 Jul 2013 18:54:39 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered GEN_SPAM_FEATRE=0.2, RV4627=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4627> : streams <993290> : uri <1465573> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 2749-done Cc: stephen.berman@gmx.net, 2749-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) >> No, the thread was simply mis-filed. I'm a user of word-wrap and I like >> overflow-newline-into-fringe, so I'm in favor of this patch. > I fixed the two known problems with the original proposal, and > committed everything to the trunk as revision 113259. Cool, thanks, Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 03 05:52:59 2013 Received: (at 2749-done) by debbugs.gnu.org; 3 Jul 2013 09:53:00 +0000 Received: from localhost ([127.0.0.1]:53813 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UuJkB-0002L8-Fr for submit@debbugs.gnu.org; Wed, 03 Jul 2013 05:52:59 -0400 Received: from mout.gmx.net ([212.227.17.21]:57215) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1UuJk9-0002Kp-1w for 2749-done@debbugs.gnu.org; Wed, 03 Jul 2013 05:52:57 -0400 Received: from mailout-de.gmx.net ([10.1.76.33]) by mrigmx.server.lan (mrigmx002) with ESMTP (Nemesis) id 0MSomp-1UmEhr2K8r-00RqmN for <2749-done@debbugs.gnu.org>; Wed, 03 Jul 2013 11:52:50 +0200 Received: (qmail invoked by alias); 03 Jul 2013 09:52:50 -0000 Received: from i59F5617F.versanet.de (EHLO rosalinde.fritz.box) [89.245.97.127] by mail.gmx.net (mp033) with SMTP; 03 Jul 2013 11:52:50 +0200 X-Authenticated: #20778731 X-Provags-ID: V01U2FsdGVkX18N7WNeebQNhbkkLeuNRf3GCKpXmO+XCXyIBYpKMO fPYJMGnp0ZKju2 From: Stephen Berman To: Eli Zaretskii Subject: Re: bug#2749: 23.0.91; Visual Line Mode: incorrect line wrapping in corner case References: <87d4c694r2.fsf@cyd.mit.edu> <87obfhhn9d.fsf@rosalinde.fritz.box> <871u9f6ij1.fsf@rosalinde.fritz.box> <83ip2qc23k.fsf@gnu.org> <87wqr66dij.fsf@rosalinde.fritz.box> <83ehdebut7.fsf@gnu.org> <87sj1u64ew.fsf@rosalinde.fritz.box> <83d2sybphy.fsf@gnu.org> <87mwrs6ng7.fsf@rosalinde.fritz.box> <83obalareo.fsf@gnu.org> Date: Wed, 03 Jul 2013 11:52:48 +0200 In-Reply-To: <83obalareo.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 02 Jul 2013 18:54:39 +0300") Message-ID: <87li5oq8b3.fsf@rosalinde.fritz.box> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Y-GMX-Trusted: 0 X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 2749-done Cc: Stefan Monnier , 2749-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) On Tue, 02 Jul 2013 18:54:39 +0300 Eli Zaretskii wrote: >> From: Stefan Monnier >> Date: Tue, 28 May 2013 18:26:57 -0400 >> Cc: Eli Zaretskii , 2749@debbugs.gnu.org >> >> > I hope Stefan's silence till now just means he hasn't yet had time to >> > give this issue due consideration.... >> >> No, the thread was simply mis-filed. I'm a user of word-wrap and I like >> overflow-newline-into-fringe, so I'm in favor of this patch. >> That's assuming any serious fall-out can get fixed, obviously. > > I fixed the two known problems with the original proposal Confirmed, and many thanks! Steve Berman From unknown Mon Jun 23 07:47:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 31 Jul 2013 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator