From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 25 08:40:29 2017 Received: (at submit) by debbugs.gnu.org; 25 Jun 2017 12:40:29 +0000 Received: from localhost ([127.0.0.1]:36395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dP6q4-0004Sv-Ns for submit@debbugs.gnu.org; Sun, 25 Jun 2017 08:40:28 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dP6q1-0004Sg-9T for submit@debbugs.gnu.org; Sun, 25 Jun 2017 08:40:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dP6pv-0001uw-0q for submit@debbugs.gnu.org; Sun, 25 Jun 2017 08:40:20 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=5.0 tests=BAYES_50,FREEMAIL_FROM, RCVD_IN_SORBS_SPAM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54635) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dP6pu-0001us-TJ for submit@debbugs.gnu.org; Sun, 25 Jun 2017 08:40:18 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dP6pt-0001UK-Hg for guix-patches@gnu.org; Sun, 25 Jun 2017 08:40:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dP6po-0001qj-FC for guix-patches@gnu.org; Sun, 25 Jun 2017 08:40:17 -0400 Received: from mail-wr0-f173.google.com ([209.85.128.173]:33550) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dP6po-0001oV-9p for guix-patches@gnu.org; Sun, 25 Jun 2017 08:40:12 -0400 Received: by mail-wr0-f173.google.com with SMTP id r103so119508263wrb.0 for ; Sun, 25 Jun 2017 05:40:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=Ng0/PantVdveTMO6rmyUclB3Tipq/txJDEx7GoBQuZo=; b=Shg0oYcs8CNxvlT53r7i1vH3Iv64T5ifUWWHe/Vn7gIVHr71qLu6w+p4+GFJLx/z/Y ZH7TgaOw3ji0VQwALYJn0FPcUDj/d0304BmD34rB0OsoCl6NYpcEcdmt3nGjCski/KYb TReMxYcwiM/mL/iXOAMmE9Yj4UYG2g6cm8wZus9z0c7fPdqLkpikRwGUrj+BQUhza+5h ov+thLRwPqTiMRHOFUoZiqoVg7pbwahiB0xnHLWdFncw0PG5IaUQMbqtD2RfAM0ZYyTY Owg0K6SK9WYqj42HWWd3KDyOVK3STvwHoKzgbVADKhAzl/wq4wGCpqhEJYBfzECzX0eR zGqw== X-Gm-Message-State: AKS2vOzzMZOyPDduHsr+oc9kISGHv0KRWZHDCepyii/M+c+rR/5UbwhZ DfzG6rYjx62ik3Db X-Received: by 10.80.173.235 with SMTP id b40mr13288575edd.110.1498394409159; Sun, 25 Jun 2017 05:40:09 -0700 (PDT) Received: from gerrit.coffeecompany.local ([145.131.174.10]) by smtp.gmail.com with ESMTPSA id e22sm2601487edd.26.2017.06.25.05.40.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 25 Jun 2017 05:40:08 -0700 (PDT) From: Jelle Licht To: guix-patches@gnu.org Subject: [PATCH] gnu: Add python-pass-git-helper. Date: Sun, 25 Jun 2017 14:39:47 +0200 Message-Id: <20170625123947.5031-1-jlicht@fsfe.org> X-Mailer: git-send-email 2.13.1 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.3 (---) X-Debbugs-Envelope-To: submit Cc: Jelle Licht X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/password-utils.scm (python-pass-git-helper): New variable. --- gnu/packages/password-utils.scm | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm index 9cfacdb42..55b6e2a04 100644 --- a/gnu/packages/password-utils.scm +++ b/gnu/packages/password-utils.scm @@ -37,6 +37,7 @@ #:use-module (gnu packages aidc) #:use-module (gnu packages base) #:use-module (gnu packages compression) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages glib) #:use-module (gnu packages gnupg) #:use-module (gnu packages gtk) @@ -410,3 +411,38 @@ Password Scheme\"} by Niels Provos and David Mazieres.") (define-public python2-bcrypt (package-with-python2 python-bcrypt)) + +(define-public python-pass-git-helper + (package + (name "python-pass-git-helper") + (version "0.3") + (source + (origin + (method url-fetch) + (uri (pypi-uri "pass-git-helper" version)) + (sha256 + (base32 + "1zxzwljz8zqayd6dcai6y9qkj2ingbk89z20hqqvcr62a5bjks7v")))) + (build-system python-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-before 'build 'patch-pass-path + (lambda* (#:key inputs #:allow-other-keys) + (let* ((password-store (assoc-ref inputs "password-store")) + (pass (string-append password-store + "/bin/pass"))) + (substitute* "pass-git-helper" + (("'pass'") (string-append "'" pass "'"))) + #t)))))) + (inputs + `(("python-pyxdg" ,python-pyxdg) + ("password-store" ,password-store))) + (home-page "https://github.com/languitar/pass-git-helper") + (synopsis "Git credential helper interfacing with pass") + (description + "A git credential helper implementation which allows to use pass, the +standard unix password manager, as the credential backend for your git +repositories. This is achieved by explicitly defining mappings between hosts +and entries in the password store.") + (license license:lgpl3))) -- 2.13.1 From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 25 13:23:08 2017 Received: (at 27483) by debbugs.gnu.org; 25 Jun 2017 17:23:08 +0000 Received: from localhost ([127.0.0.1]:37522 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPBFc-0002mR-10 for submit@debbugs.gnu.org; Sun, 25 Jun 2017 13:23:08 -0400 Received: from o138.p9.mailjet.com ([87.253.234.138]:46952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPBFZ-0002mI-Qa for 27483@debbugs.gnu.org; Sun, 25 Jun 2017 13:23:06 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=h5/gbt3Kht8w7DUTH/FaqozeGdg=; b=pnFVDgrl/K+7v6SIW13JygLBUVKH2mEv16lF65VfCWPjHkNyvbg44LDmj OBeUdmZSSxj/ze3pXr9tavHU2i9GnX5ROtFZrpZdNSOttpYcf7lJMWwY2mSM gRDs2So5dKd/63E6ahtTk5qwLVjp7Ot+r1cw19H8QO3vobf0FgeT/U= Message-Id: MIME-Version: 1.0 From: Arun Isaac To: Jelle Licht Subject: Re: [bug#27483] [PATCH] gnu: Add python-pass-git-helper. Date: Sun, 25 Jun 2017 22:52:44 +0530 In-reply-to: <20170625123947.5031-1-jlicht@fsfe.org> References: <20170625123947.5031-1-jlicht@fsfe.org> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEEAMX9gutgAAAAAAAAAAAPNjeEAAAACwQwAAAAAAAW9WABZT_F4ZzcofymfTeqzrTa1qammwAAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 27483 Cc: 27483@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Thanks for the patch! > +(define-public python-pass-git-helper > + (package > + (name "python-pass-git-helper") Since, this is an application, not a python library, this package should not have the "python-" prefix. It should just be called pass-git-helper. > + (version "0.3") The latest version is 0.3.1. However, this is only available on the project's github releases page. Could you try with that? https://github.com/languitar/pass-git-helper/releases > + (description > + "A git credential helper implementation which allows to use pass, t= he > +standard unix password manager, as the credential backend for your git > +repositories. This is achieved by explicitly defining mappings between = hosts > +and entries in the password store.") Descriptions should use full sentences. Could you rephrase the first sentence to comply? https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Description= s.html > + (license license:lgpl3))) The license is lgpl3+. Look at line 17 of setup.py. Everything else LGTM. Could you send an updated patch? = From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 25 16:24:15 2017 Received: (at 27483) by debbugs.gnu.org; 25 Jun 2017 20:24:15 +0000 Received: from localhost ([127.0.0.1]:37664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPE4s-000457-Aw for submit@debbugs.gnu.org; Sun, 25 Jun 2017 16:24:15 -0400 Received: from mout02.posteo.de ([185.67.36.142]:47719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPBmY-0005P9-P6 for 27483@debbugs.gnu.org; Sun, 25 Jun 2017 13:57:11 -0400 Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 3wwfyh4nBrzynk; Sun, 25 Jun 2017 19:56:58 +0200 (CEST) References: <20170625123947.5031-1-jlicht@fsfe.org> <1205d2af.AEEAMX9gutkAAAAAAAAAAAPFxFYAAAACwQwAAAAAAAW9WABZT_F4@mailjet.com> User-agent: mu4e 0.9.18; emacs 25.2.1 From: Jelle Licht To: Arun Isaac Subject: Re: [bug#27483] [PATCH] gnu: Add python-pass-git-helper. In-reply-to: <1205d2af.AEEAMX9gutkAAAAAAAAAAAPFxFYAAAACwQwAAAAAAAW9WABZT_F4@mailjet.com> Date: Sun, 25 Jun 2017 19:56:57 +0200 Message-ID: <871sq83q8m.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 27483 X-Mailman-Approved-At: Sun, 25 Jun 2017 16:24:13 -0400 Cc: Jelle Licht , 27483@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) --=-=-= Content-Type: text/plain Arun Isaac writes: > Thanks for the patch! > >> +(define-public python-pass-git-helper >> + (package >> + (name "python-pass-git-helper") > > Since, this is an application, not a python library, this package should > not have the "python-" prefix. It should just be called pass-git-helper. > >> + (version "0.3") > > The latest version is 0.3.1. However, this is only available on the > project's github releases page. Could you try with that? > > https://github.com/languitar/pass-git-helper/releases > >> + (description >> + "A git credential helper implementation which allows to use pass, the >> +standard unix password manager, as the credential backend for your git >> +repositories. This is achieved by explicitly defining mappings between hosts >> +and entries in the password store.") > > Descriptions should use full sentences. Could you rephrase the first > sentence to comply? > > https://www.gnu.org/software/guix/manual/html_node/Synopses-and-Descriptions.html > >> + (license license:lgpl3))) > > The license is lgpl3+. Look at line 17 of setup.py. > > Everything else LGTM. Could you send an updated patch? Done! --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-gnu-Add-pass-git-helper.patch >From 9b818abc4d313f42efa6f052830050b0e376a073 Mon Sep 17 00:00:00 2001 From: Jelle Licht Date: Sun, 25 Jun 2017 14:38:40 +0200 Subject: [PATCH] gnu: Add pass-git-helper. * gnu/packages/password-utils.scm (pass-git-helper): New variable. --- gnu/packages/password-utils.scm | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm index 9cfacdb42..bad52dd22 100644 --- a/gnu/packages/password-utils.scm +++ b/gnu/packages/password-utils.scm @@ -37,6 +37,7 @@ #:use-module (gnu packages aidc) #:use-module (gnu packages base) #:use-module (gnu packages compression) + #:use-module (gnu packages freedesktop) #:use-module (gnu packages glib) #:use-module (gnu packages gnupg) #:use-module (gnu packages gtk) @@ -410,3 +411,39 @@ Password Scheme\"} by Niels Provos and David Mazieres.") (define-public python2-bcrypt (package-with-python2 python-bcrypt)) + +(define-public pass-git-helper + (package + (name "pass-git-helper") + (version "0.3.1") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/languitar/pass-git-helper/" + "archive/release-" version ".tar.gz")) + (sha256 + (base32 + "0lz5ncy44pz7z1j2nnyildx8sq33zi3xvg5nkwg25n11nasqh2xn")))) + (build-system python-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-before 'build 'patch-pass-path + (lambda* (#:key inputs #:allow-other-keys) + (let* ((password-store (assoc-ref inputs "password-store")) + (pass (string-append password-store + "/bin/pass"))) + (substitute* "pass-git-helper" + (("'pass'") (string-append "'" pass "'"))) + #t)))))) + (inputs + `(("python-pyxdg" ,python-pyxdg) + ("password-store" ,password-store))) + (home-page "https://github.com/languitar/pass-git-helper") + (synopsis "Git credential helper interfacing with pass") + (description + "pass-git-helper is a git credential helper which allows to use pass, the +standard unix password manager, as the credential backend for your git +repositories. This is achieved by explicitly defining mappings between hosts +and entries in the password store.") + (license license:lgpl3+))) -- 2.13.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 25 16:45:45 2017 Received: (at 27483-done) by debbugs.gnu.org; 25 Jun 2017 20:45:45 +0000 Received: from localhost ([127.0.0.1]:37682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPEPh-0004ao-Fh for submit@debbugs.gnu.org; Sun, 25 Jun 2017 16:45:45 -0400 Received: from o176.p8.mailjet.com ([87.253.233.176]:51063) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dPEPf-0004af-Mq for 27483-done@debbugs.gnu.org; Sun, 25 Jun 2017 16:45:44 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/simple; q=dns/txt; d=bnc3.mailjet.com; i=arunisaac=3Dsystemreboot.net@bnc3.mailjet.com; s=mailjet; h=message-id:mime-version:from:to:subject:date:list-unsubscribe:cc:in-reply-to: references:x-csa-complaints:x-mj-mid:content-type:content-transfer-encoding; bh=ylxQuNaJk8JNajbKQ6FXtc/hFvw=; b=tZckeWCewV03pFT6r+j5SvYEUeRHmN7W0NrPAHAnAlzoDZD+2VYzFkskD N6sjvkZaiMLewNkoABDDvTOEFrU3iJWpRq1BtMzhtZkHlSmzB540AruKHe0T IW70HsLWO5VgotDImq1ZAnK0Awde3fdBNt581b997Ikg9aUbCCmXTQ= Message-Id: MIME-Version: 1.0 From: Arun Isaac To: Jelle Licht Subject: Re: [bug#27483] [PATCH] gnu: Add python-pass-git-helper. Date: Mon, 26 Jun 2017 02:15:31 +0530 In-reply-to: <871sq83q8m.fsf@gmail.com> References: <20170625123947.5031-1-jlicht@fsfe.org> <1205d2af.AEEAMX9gutkAAAAAAAAAAAPFxFYAAAACwQwAAAAAAAW9WABZT_F4@mailjet.com> <871sq83q8m.fsf@gmail.com> X-CSA-Complaints: whitelist-complaints@eco.de X-MJ-Mid: AEQAMJnnolIAAAAAAAAAAAPNlDgAAAACwQwAAAAAAAW9WABZUCD2Y2hO3d--Q3OmJOxo6mTFCAAFgUc Content-Type: text/plain Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 27483-done Cc: 27483-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Pushed! Thanks! I added a copyright header for you, and made a few other minor stylistic changes. = From unknown Fri Aug 22 01:33:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 24 Jul 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator