GNU bug report logs - #27477
[PATCH] gnu: acl: Enable tests.

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kei <at> openmailbox.org>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kei <at> openmailbox.org>
Subject: [PATCH] gnu: acl: Enable tests.
Date: Sat, 24 Jun 2017 14:06:06 -0400

* gnu/packages/acl.scm (acl)[arguments]: Enable tests. Add 'patch-tests' phase.
---
 gnu/packages/acl.scm | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/acl.scm b/gnu/packages/acl.scm
index ae6764993..34f8c294a 100644
--- a/gnu/packages/acl.scm
+++ b/gnu/packages/acl.scm
@@ -44,19 +44,30 @@
       (patches (search-patches "acl-hurd-path-max.patch"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:tests? #f   ; FIXME: Investigate test suite failures
-       #:test-target "tests"
+     `(#:test-target "tests"
        #:phases
         (alist-cons-after
          'build 'patch-exec-bin-sh
          (lambda _
            (substitute* "test/run"
              (("/bin/sh") (which "sh"))))
-         (alist-replace
-          'install
+         (alist-cons-before
+          'check 'patch-tests
           (lambda _
-            (zero? (system* "make" "install" "install-lib" "install-dev")))
-          %standard-phases))))
+            ;; The coreutils do not have an ACL bit to remove from their
+            ;; output, so the sed expression that removes the bit is disabled.
+            (substitute* "test/sbits-restore.test"
+              (("\\| sed.*'") ""))
+            ;; These tests require the existence of a user named "bin", but
+            ;; this user does not exist within Guix's build environment.
+            (for-each (lambda (file)
+                        (delete-file (string-append "test/" file)))
+                      '("setfacl-X.test" "cp.test" "misc.test")))
+          (alist-replace
+           'install
+           (lambda _
+             (zero? (system* "make" "install" "install-lib" "install-dev")))
+           %standard-phases)))))
     (inputs `(("attr" ,attr)))
     (native-inputs
      `(("gettext" ,gettext-minimal)
-- 
2.13.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.