GNU bug report logs - #27477
[PATCH] gnu: acl: Enable tests.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Kei Kebreau <kei <at> openmailbox.org>
Subject: bug#27477: closed (Re: [bug#27477] [PATCH] gnu: acl: Enable tests.)
Date: Sat, 04 Nov 2017 14:53:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#27477: [PATCH] gnu: acl: Enable tests.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 27477 <at> debbugs.gnu.org.

-- 
27477: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27477
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Leo Famulari <leo <at> famulari.name>
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: Ludovic Courtès <ludo <at> gnu.org>,
 27477-done <at> debbugs.gnu.org
Subject: Re: [bug#27477] [PATCH] gnu: acl: Enable tests.
Date: Sat, 4 Nov 2017 10:52:33 -0400

[Message part 3 (text/plain, inline)]

On Thu, Sep 14, 2017 at 09:46:33AM -0400, Kei Kebreau wrote:
> ludo <at> gnu.org (Ludovic Courtès) writes:
> 
> > Kei Kebreau <kei <at> openmailbox.org> skribis:
> >
> >> Leo Famulari <leo <at> famulari.name> writes:
> >>
> >>> On Sat, Jun 24, 2017 at 02:06:06PM -0400, Kei Kebreau wrote:
> >>>> * gnu/packages/acl.scm (acl)[arguments]: Enable tests. Add
> >>>> 'patch-tests' phase.
> >>>
> >>> Great!
> >>>
> >>> But we'll probably need to wait for the next core-updates cycle. I've
> >>> applied to locally to a core-updates-next branch but it would be great
> >>> if you kept it around for the next cycle :)
> >>
> >> Cool. I'll hold on to the patch!
> >
> > Now is the time to try the patch on ‘core-updates’!
> >
> > Ludo’.
> 
> Aw, I missed this becuase of my email migration. I'll catch it next time
> as long as this message makes it to kkebreau <at> posteo.net instead of
> kei <at> openmailbox.org.
> 
> Thanks in advance.

I amended this patch to apply and pushed it as
2d433b5363fecba0d63caa1844c937dec4ccc23b.

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Kei Kebreau <kei <at> openmailbox.org>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kei <at> openmailbox.org>
Subject: [PATCH] gnu: acl: Enable tests.
Date: Sat, 24 Jun 2017 14:06:06 -0400

* gnu/packages/acl.scm (acl)[arguments]: Enable tests. Add 'patch-tests' phase.
---
 gnu/packages/acl.scm | 23 +++++++++++++++++------
 1 file changed, 17 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/acl.scm b/gnu/packages/acl.scm
index ae6764993..34f8c294a 100644
--- a/gnu/packages/acl.scm
+++ b/gnu/packages/acl.scm
@@ -44,19 +44,30 @@
       (patches (search-patches "acl-hurd-path-max.patch"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:tests? #f   ; FIXME: Investigate test suite failures
-       #:test-target "tests"
+     `(#:test-target "tests"
        #:phases
         (alist-cons-after
          'build 'patch-exec-bin-sh
          (lambda _
            (substitute* "test/run"
              (("/bin/sh") (which "sh"))))
-         (alist-replace
-          'install
+         (alist-cons-before
+          'check 'patch-tests
           (lambda _
-            (zero? (system* "make" "install" "install-lib" "install-dev")))
-          %standard-phases))))
+            ;; The coreutils do not have an ACL bit to remove from their
+            ;; output, so the sed expression that removes the bit is disabled.
+            (substitute* "test/sbits-restore.test"
+              (("\\| sed.*'") ""))
+            ;; These tests require the existence of a user named "bin", but
+            ;; this user does not exist within Guix's build environment.
+            (for-each (lambda (file)
+                        (delete-file (string-append "test/" file)))
+                      '("setfacl-X.test" "cp.test" "misc.test")))
+          (alist-replace
+           'install
+           (lambda _
+             (zero? (system* "make" "install" "install-lib" "install-dev")))
+           %standard-phases)))))
     (inputs `(("attr" ,attr)))
     (native-inputs
      `(("gettext" ,gettext-minimal)
-- 
2.13.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.