From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 01:59:06 2017 Received: (at submit) by debbugs.gnu.org; 24 Jun 2017 05:59:06 +0000 Received: from localhost ([127.0.0.1]:35066 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dOe66-00016e-17 for submit@debbugs.gnu.org; Sat, 24 Jun 2017 01:59:06 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dOe63-000167-I7 for submit@debbugs.gnu.org; Sat, 24 Jun 2017 01:59:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dOe5x-000697-GG for submit@debbugs.gnu.org; Sat, 24 Jun 2017 01:58:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39275) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dOe5x-00068l-Ci for submit@debbugs.gnu.org; Sat, 24 Jun 2017 01:58:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50206) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dOe5w-0001HR-45 for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2017 01:58:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dOe5t-00065h-2V for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2017 01:58:56 -0400 Received: from mout.web.de ([212.227.15.4]:57745) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dOe5s-000644-NX for bug-gnu-emacs@gnu.org; Sat, 24 Jun 2017 01:58:52 -0400 Received: from drachen.dragon ([92.74.161.87]) by smtp.web.de (mrweb001 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MLgCx-1dOuwV1RuF-000pt5 for ; Sat, 24 Jun 2017 07:58:48 +0200 From: Michael Heerdegen To: bug-gnu-emacs@gnu.org Subject: 26.0.50; this-command-keys and interactive input Date: Sat, 24 Jun 2017 07:58:47 +0200 Message-ID: <87y3siapuw.fsf@drachen> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:D7hPiGuMTZvve/r5ezJmVMDNoPVXtDCb6L8ZI2kpgh2xRIrr6F/ KgoERlQXXYe6TfYOTG0da/sHWKaaek3svqeGNYrg33/vv7yU4s5OikZMMN2OOQNatB0maXb taVdZtK36hluCurio22GDYUP/8ILNf3RXR7ggQZ2xC6VWedhQFv4ScgtO/GJi6eFEE1ASfC ogjAyP6sJYH8Z2UK5y1mw== X-UI-Out-Filterresults: notjunk:1;V01:K0:Zervi/fEdbE=:YmBpU7LfDVwDNjugvjtMVG keXvp/hsV1fmdV/NJ52R71EQulqmpK+qbkBOWV0pD3X9YUzW1YtcmMMMI1smqt4eC01fvQtVC U3ycDxdkaLNGnLlhRgONnzm83+bFVRQGngoakIAPsHSTmZdhT8tcWBZjpBs+W6X+ked3HXTEB ZVWJZtdLyxFgTyH8618tEuf1mBBW9++QMoeVDXMisr8Tlpj/6qlHN2q01IS6hPeERMNDeKioO 604AXbtidWpH9bS6RhUiLsjbuxuPmuf/R2olq4CoUxbNCEc4JPoXmC43zvWetHc1I5SU9+9Xo oyIhvNh8mLaLgK3P+QF9ZyY6vILeQ0OH9vJhoiwTeeRvfnBef6O9rWDdXpIDbQVPQSRpujj3u QeihEPr8+ywd7OGXDDOqqUuFYD4oBhpE8D2WOXzSvIlzGLulkbVv+2LWSldQXrCI80mdrcvNe pDBGC5xYI64g/vnwmyL/V3EJDXQ47Rg2Jk5xrlFmCRo9GPRyFVN7eojvbwLp1kg2fVt1XwBhi 21QaqZ3VRMvXAU89KZ5mcLBkne8KUOinMbredGItmUACFBZclsMDQWqi4vF7UpwG8zvFD6WfH r5NPzZWuY/iDb7HPLdu3OetIMZI97MyiDkL702VKfDAsKjypZ8n0kzfBvpFG2+k6x6ufeSRuR yIlcl7ifayGS02NzlCrxqFi+utceyRsCI8JyEgsTu2PcHqhVMrPpdCTFFQ60p3iKSIl5w3P73 6jRYEmB19m8xGG/5MYXB7tWwoGOG7pwo2VbihNkD+KPYcvv2t3EsbAyF3POGuU4j5hSGKYtnP tyDcFlk X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) Hello, Evaluate this: (defun test (arg) (interactive (list (read-from-minibuffer "Input: "))) (message "%S" (cons this-command (this-command-keys))) arg) (global-set-key [f12] #'test) where f12 stands for some random key sequence. Hit f12 and give any input. I get the following message: (test . "^M") I would expect (test . f12). Obviously, `this-command-keys' returns the key confirming the input instead of the key that has invoked the command. This contradicts the descriptions in the documentation (docstring and manual). The docs only mention an exception when a command calls `read-key-sequence', but this is not the case here. FWIW, I would prefer fixing this over changing the docs. Thanks, Michael. In GNU Emacs 26.0.50 (build 3, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-06-19 built on drachen Repository revision: 1b75af59b305867c89271905be72a05d06a4eff4 Windowing system distributor 'The X.Org Foundation', version 11.0.11903000 System Description: Debian GNU/Linux 9.0 (stretch) From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 03:01:48 2017 Received: (at 27470) by debbugs.gnu.org; 24 Jun 2017 07:01:48 +0000 Received: from localhost ([127.0.0.1]:35106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dOf4m-0002b7-Cb for submit@debbugs.gnu.org; Sat, 24 Jun 2017 03:01:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37900) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dOf4k-0002av-6H for 27470@debbugs.gnu.org; Sat, 24 Jun 2017 03:01:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dOf4a-0003Au-0q for 27470@debbugs.gnu.org; Sat, 24 Jun 2017 03:01:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dOf4Z-0003Aq-Tq; Sat, 24 Jun 2017 03:01:35 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1508 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dOf4Y-0002Z0-OS; Sat, 24 Jun 2017 03:01:35 -0400 Date: Sat, 24 Jun 2017 10:01:17 +0300 Message-Id: <831sq9vphe.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-reply-to: <87y3siapuw.fsf@drachen> (message from Michael Heerdegen on Sat, 24 Jun 2017 07:58:47 +0200) Subject: Re: bug#27470: 26.0.50; this-command-keys and interactive input References: <87y3siapuw.fsf@drachen> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27470 Cc: 27470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Michael Heerdegen > Date: Sat, 24 Jun 2017 07:58:47 +0200 > > (defun test (arg) > (interactive (list (read-from-minibuffer "Input: "))) > (message "%S" (cons this-command (this-command-keys))) > arg) > > (global-set-key [f12] #'test) > > where f12 stands for some random key sequence. > > Hit f12 and give any input. I get the following message: > > (test . "^M") > > I would expect (test . f12). This happens because read-from-minibuffer enters recursive-edit, and we don't preserve this-command-keys across recursive-edit invocations. This has been Emacs behavior since forever. The patch below seems to fix this, but I have no idea what it could break, given how old this behavior is. So if we are to accept this, I'd like to have a few people step forward and run with the change for a month or so, to see there are no adverse effects. We've been burnt several times lately by changes in keyboard-input stuff that broke subtle but very useful features. Thanks. diff --git a/src/minibuf.c b/src/minibuf.c index 1bbe276..5617941 100644 --- a/src/minibuf.c +++ b/src/minibuf.c @@ -497,6 +497,8 @@ read_minibuf (Lisp_Object map, Lisp_Object initial, Lisp_Object prompt, Fcons (Vminibuffer_history_position, Fcons (Vminibuffer_history_variable, minibuf_save_list)))))); + minibuf_save_list + = Fcons (Fthis_command_keys_vector (), minibuf_save_list); record_unwind_protect_void (read_minibuf_unwind); minibuf_level++; @@ -836,6 +838,11 @@ read_minibuf_unwind (void) Fset_buffer (XWINDOW (window)->contents); /* Restore prompt, etc, from outer minibuffer level. */ + Lisp_Object key_vec = Fcar (minibuf_save_list); + eassert (VECTORP (key_vec)); + this_command_key_count = XFASTINT (Flength (key_vec)); + this_command_keys = key_vec; + minibuf_save_list = Fcdr (minibuf_save_list); minibuf_prompt = Fcar (minibuf_save_list); minibuf_save_list = Fcdr (minibuf_save_list); minibuf_prompt_width = XFASTINT (Fcar (minibuf_save_list)); From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 09:15:14 2017 Received: (at 27470) by debbugs.gnu.org; 24 Jun 2017 13:15:14 +0000 Received: from localhost ([127.0.0.1]:35308 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dOkuA-0004ZH-Jr for submit@debbugs.gnu.org; Sat, 24 Jun 2017 09:15:14 -0400 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:14577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dOku8-0004Z3-2e for 27470@debbugs.gnu.org; Sat, 24 Jun 2017 09:15:12 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DYCQCYZE5Z/48Dr7heHAEBBAEBCgEBg1iKZ4YAkRkBl18chgIEAgKDB0QUAQIBAQEBAQEBayiFGQZWIxALNBIUGA0kij+xSotTAQEBAQEFAiaDJ4hRil4BBJ5plVgYiQMzhlOTXYFENiGBCjAhCDBJhyskiiYBAQE X-IPAS-Result: A0DYCQCYZE5Z/48Dr7heHAEBBAEBCgEBg1iKZ4YAkRkBl18chgIEAgKDB0QUAQIBAQEBAQEBayiFGQZWIxALNBIUGA0kij+xSotTAQEBAQEFAiaDJ4hRil4BBJ5plVgYiQMzhlOTXYFENiGBCjAhCDBJhyskiiYBAQE X-IronPort-AV: E=Sophos;i="5.39,384,1493697600"; d="scan'208";a="318307043" Received: from 184-175-3-143.dsl.teksavvy.com (HELO pastel.home) ([184.175.3.143]) by smtp.teksavvy.com with ESMTP; 24 Jun 2017 09:15:04 -0400 Received: by pastel.home (Postfix, from userid 20848) id 8EAED6A6AA; Sat, 24 Jun 2017 09:15:04 -0400 (EDT) From: Stefan Monnier To: Michael Heerdegen Subject: Re: bug#27470: 26.0.50; this-command-keys and interactive input Message-ID: References: <87y3siapuw.fsf@drachen> Date: Sat, 24 Jun 2017 09:15:04 -0400 In-Reply-To: <87y3siapuw.fsf@drachen> (Michael Heerdegen's message of "Sat, 24 Jun 2017 07:58:47 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 27470 Cc: 27470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > (defun test (arg) > (interactive (list (read-from-minibuffer "Input: "))) > (message "%S" (cons this-command (this-command-keys))) > arg) Whether it's a bug or not is hard to say (the quirk is described in the doctring). But you can get the behavior you want with: (defun sm-test (arg &optional keys) (interactive (let ((keys (this-command-keys-vector))) (list (read-from-minibuffer "Input: ") keys))) (message "%S" (cons this-command keys)) arg) -- Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 25 01:53:53 2017 Received: (at 27470) by debbugs.gnu.org; 25 Jun 2017 05:53:53 +0000 Received: from localhost ([127.0.0.1]:36225 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dP0Ub-0001dT-Jc for submit@debbugs.gnu.org; Sun, 25 Jun 2017 01:53:53 -0400 Received: from mout.web.de ([212.227.17.11]:62285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dP0Ua-0001dH-FB for 27470@debbugs.gnu.org; Sun, 25 Jun 2017 01:53:52 -0400 Received: from drachen.dragon ([92.74.161.87]) by smtp.web.de (mrweb103 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M0QgT-1dd5KX27BN-00uVkF; Sun, 25 Jun 2017 07:53:44 +0200 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#27470: 26.0.50; this-command-keys and interactive input References: <87y3siapuw.fsf@drachen> <831sq9vphe.fsf@gnu.org> Date: Sun, 25 Jun 2017 07:53:42 +0200 In-Reply-To: <831sq9vphe.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Jun 2017 10:01:17 +0300") Message-ID: <87efu8k3yx.fsf@drachen> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:pI73jZ321SOhEhoKoSbXgj0lwT1J40yvOH9acWpQnGwrXgR18ke 8mzPIUSoEnonFbRA0AA7fqjx+KVnSPDenI2S/N5VgLsyliRQyRsp1I9a1UFCU4ZIf6jYduP nYA7v6OGj8omj1/Rwk0Ike/yJCOdi3UttMMXXvuihS11JgJKwP5rR0gFVSe6sdXsnq/Lio9 iSNQI+UJrbwRk8UShYjOg== X-UI-Out-Filterresults: notjunk:1;V01:K0:IdIa0l2zNm0=:/EcJioy1blWE4UdYedURtP UdxImynpc125JLspph4+bUxVr38cGmJkHuL5CT15CFIO2/+jZi2ab3kzC5vQgpZkHD36qtuvz 9wm7ulamO0oend7wZHK5P/BXQKSxJVgEiZg6p7UptA7OP1N3DfpP5qWAV5raae1OGAIMcId2Y doZZcxYgJ8usqIKfH9Bj6bCKo8/vJUKK/dCv9XCOOQJAvqI0TfFnpHXR6ATaIvGgJLBJ/LPZ/ nyvAL4kf3LFSwLmCcR2LgnfItfz4k2u+QcdKuqOs1PDessQu2TvEKMuslI/VRbNIoH2qYpQXL pg/r1VAG3lCUdN7kmt8g0fzGY95y4Q1u7DA9E5zWQ/iS+vKhpg2d77/hTUNEZ4ppnwHtYdLLs KN59xbSE0OYP5qkhLSXJwQNKZvgrws1dx+NtLdReI4w/93lHAEqIjNqarripw/0wAdbnYCrPs czQCGboxXQqhhByZV4mrKguvAQXzKZqbyWW3eK6U42GoJk/bZWXtvfKsuNoedmU48Le2O+rpc DNCSUou/2GucLCpyX3GFN0207yGYAKPywzIjdRZAogWf3PHPNI3aefC5mWi+VNy+ZzPNDhGHT cdeXTyXGo/1JQ4Q+Gowa7qoxbvBzgGBL9FobS6cGcdZwJ2SoLWIAUF7vdqxKi706iIj7RxLtQ BC7vrKulXW8JJQcpkURNSfYQhym2oVJcADBU9+n6c+CbH7GFgO2gMrvPkZ346WjxJD/54s8lF JDcPRPZFlzmbbU8bUORuJjShF0v8yRnWJrJqN4np/L6uRMlhnoluA97+t76wwuGF939vRWewN vH27BvG X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27470 Cc: 27470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > The patch below seems to fix this, but I have no idea what it could > break, given how old this behavior is. Thanks. Solves the issue for me. I'll keep using your patch so I'm the first tester. Michael. From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 22 04:16:48 2017 Received: (at 27470) by debbugs.gnu.org; 22 Jul 2017 08:16:48 +0000 Received: from localhost ([127.0.0.1]:51832 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYpai-0006DE-Ge for submit@debbugs.gnu.org; Sat, 22 Jul 2017 04:16:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:32847) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dYpah-0006D1-3i for 27470@debbugs.gnu.org; Sat, 22 Jul 2017 04:16:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dYpaY-0002ep-UD for 27470@debbugs.gnu.org; Sat, 22 Jul 2017 04:16:42 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42139) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dYpaY-0002eg-QW; Sat, 22 Jul 2017 04:16:38 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3334 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dYpaX-0007qG-I9; Sat, 22 Jul 2017 04:16:38 -0400 Date: Sat, 22 Jul 2017 11:16:32 +0300 Message-Id: <83a83wantr.fsf@gnu.org> From: Eli Zaretskii To: michael_heerdegen@web.de In-reply-to: <831sq9vphe.fsf@gnu.org> (message from Eli Zaretskii on Sat, 24 Jun 2017 10:01:17 +0300) Subject: Re: bug#27470: 26.0.50; this-command-keys and interactive input References: <87y3siapuw.fsf@drachen> <831sq9vphe.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -7.8 (-------) X-Debbugs-Envelope-To: 27470 Cc: 27470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -7.8 (-------) > Date: Sat, 24 Jun 2017 10:01:17 +0300 > From: Eli Zaretskii > Cc: 27470@debbugs.gnu.org > > > From: Michael Heerdegen > > Date: Sat, 24 Jun 2017 07:58:47 +0200 > > > > (defun test (arg) > > (interactive (list (read-from-minibuffer "Input: "))) > > (message "%S" (cons this-command (this-command-keys))) > > arg) > > > > (global-set-key [f12] #'test) > > > > where f12 stands for some random key sequence. > > > > Hit f12 and give any input. I get the following message: > > > > (test . "^M") > > > > I would expect (test . f12). > > This happens because read-from-minibuffer enters recursive-edit, and > we don't preserve this-command-keys across recursive-edit invocations. > > This has been Emacs behavior since forever. > > The patch below seems to fix this, but I have no idea what it could > break, given how old this behavior is. So if we are to accept this, > I'd like to have a few people step forward and run with the change for > a month or so, to see there are no adverse effects. We've been burnt > several times lately by changes in keyboard-input stuff that broke > subtle but very useful features. Michael, any findings so far? Do you recommend that we push that change? Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 23 11:44:30 2017 Received: (at 27470) by debbugs.gnu.org; 23 Jul 2017 15:44:30 +0000 Received: from localhost ([127.0.0.1]:53590 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZJ3W-0006wd-Mp for submit@debbugs.gnu.org; Sun, 23 Jul 2017 11:44:30 -0400 Received: from mout.web.de ([212.227.15.3]:54178) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZJ3V-0006wQ-RO for 27470@debbugs.gnu.org; Sun, 23 Jul 2017 11:44:30 -0400 Received: from drachen.dragon ([178.0.9.210]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LtTDo-1dgpWc31rY-010tI6; Sun, 23 Jul 2017 17:44:22 +0200 From: Michael Heerdegen To: Eli Zaretskii Subject: Re: bug#27470: 26.0.50; this-command-keys and interactive input References: <87y3siapuw.fsf@drachen> <831sq9vphe.fsf@gnu.org> <83a83wantr.fsf@gnu.org> Date: Sun, 23 Jul 2017 17:44:21 +0200 In-Reply-To: <83a83wantr.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 22 Jul 2017 11:16:32 +0300") Message-ID: <87zibvi2ei.fsf@drachen> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:nu4VJ3ruXvGnT8j9bXKJjvnRLD5XuOlQ37+aHN0bAzjFeQVFpl4 dCrHXJ2TQNXMkbFy0abc6M3hwbPhiH4SfIbjnPkL3dA1+BjQjaZfKb2Jp2wqpJXOsJ8KQ1F J+9FWO32HbxcxqVxXXI40oGxsWs56IM2KsWsWkULuSevJPpbj7WDxf7nxxE5tiXBqP4kFDq wT/Iy6Rq1eZmIad+GeSMg== X-UI-Out-Filterresults: notjunk:1;V01:K0:871jCjTsO7M=:j687jyeothkQUt9ppuXmb2 EdUuX2rIoDfksljJC6lAlnVF0ps09uhq7dgnv7sFgClBD5IT+fk23ImvnXGVqFRDYVbetXO4v NeG73EyuKSTQu8gMY7hQucyyUtSf7sFlvPCtYajLTVOd4PpGuWKh5GkwvxUG0Lk96Uypf2LE1 itG+WR+zWb2Aofr/TmnvpA8s5swGoLMGNoC5BJS7w4ivBWIIGQHtDX7j4CdDGtvrMOIYBAIlu DMKI3h2aMYs6P/shaAvMNw9h+W6XWEibaagJPXIL19SuSMAA4MOUjm0/5L/KLbzmvSgCUUgTQ yoLpJ2YmL0CMb03aO4TVjszSh5ip8IOmrmk3uUibb03vdAGKAHs6/VYd9zt2q9quTjoAlhiwk J2/Lox2FNDPzTKV6xxASNRKCCsFXhYV2A3zngtyrPdMk9f7GGBniqw7DVivkLrFV8s8zSaQcB U69g1NGG8+kf+hGO4n/bLlCEJt0NhMITv6BT7ZCeBofR6wAzUBmX3T1e6RwWnHEhtgWMPbxSV Xcx+PA7OydFKAOKBR74r2VzfsDtJQugpfne9If+qRBx77sMRGpEN1RbTYDKHwtSgREgZJdglG YvTaYxTct5aJE/nnNRJHZYbvwq+WZKjkbGvTnYF3+r7T6vbpNfDa0uHnmr+iivHoXNJz2Gqb5 X2Q7wQGaQTi5n2N8lPosBwCZEKW3gqyQ4P9TbJaqmL1M+ajyac+kK049RfHbhNYPEoHcRvgTn 6gHLPZcrs1ajIqDQtO121GIZuHEtACe1vL6xHkdlSLThdP1UKgWd9lp5opcEeT/loJB1wyuIf Wm23JVQTJn/ZF+bRZ4t2lTauBM7RPcgAWo+OL2Y54fX+6vlnLI= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27470 Cc: 27470@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: > Michael, any findings so far? No, everything seems to be fine. > Do you recommend that we push that change? It solves my problem, so - yes! But I can't judge whether it could potentially cause any trouble. Anyway, it's small and easily revertible, so I see no reason to hold it back. Thanks, Michael. From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 28 08:42:22 2017 Received: (at 27470-done) by debbugs.gnu.org; 28 Jul 2017 12:42:22 +0000 Received: from localhost ([127.0.0.1]:59318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1db4b0-00044O-Aa for submit@debbugs.gnu.org; Fri, 28 Jul 2017 08:42:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:59144) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1db4az-000448-6I for 27470-done@debbugs.gnu.org; Fri, 28 Jul 2017 08:42:21 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1db4aq-0000Ij-2o for 27470-done@debbugs.gnu.org; Fri, 28 Jul 2017 08:42:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:40475) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1db4ap-0000Id-VW; Fri, 28 Jul 2017 08:42:11 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3276 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1db4an-0007I8-Kf; Fri, 28 Jul 2017 08:42:11 -0400 Date: Fri, 28 Jul 2017 15:41:46 +0300 Message-Id: <83bmo44tth.fsf@gnu.org> From: Eli Zaretskii To: Michael Heerdegen In-reply-to: <87zibvi2ei.fsf@drachen> (message from Michael Heerdegen on Sun, 23 Jul 2017 17:44:21 +0200) Subject: Re: bug#27470: 26.0.50; this-command-keys and interactive input References: <87y3siapuw.fsf@drachen> <831sq9vphe.fsf@gnu.org> <83a83wantr.fsf@gnu.org> <87zibvi2ei.fsf@drachen> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27470-done Cc: 27470-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Michael Heerdegen > Cc: 27470@debbugs.gnu.org > Date: Sun, 23 Jul 2017 17:44:21 +0200 > > Eli Zaretskii writes: > > > Michael, any findings so far? > > No, everything seems to be fine. > > > Do you recommend that we push that change? > > It solves my problem, so - yes! But I can't judge whether it could > potentially cause any trouble. Anyway, it's small and easily > revertible, so I see no reason to hold it back. Pushed to master. Thanks for testing this. From unknown Thu Aug 14 21:55:28 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 26 Aug 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator