From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 23 18:44:45 2017 Received: (at submit) by debbugs.gnu.org; 23 Jun 2017 22:44:45 +0000 Received: from localhost ([127.0.0.1]:34863 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dOXJk-0005qf-Vj for submit@debbugs.gnu.org; Fri, 23 Jun 2017 18:44:45 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dOXJh-0005qR-7M for submit@debbugs.gnu.org; Fri, 23 Jun 2017 18:44:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dOXJb-0005oD-9e for submit@debbugs.gnu.org; Fri, 23 Jun 2017 18:44:36 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:39067) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dOXJb-0005o4-6K for submit@debbugs.gnu.org; Fri, 23 Jun 2017 18:44:35 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34153) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dOXJa-00013y-5D for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2017 18:44:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dOXJW-0005mb-75 for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2017 18:44:34 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:29516) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dOXJV-0005ls-TV for bug-gnu-emacs@gnu.org; Fri, 23 Jun 2017 18:44:30 -0400 Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v5NMiQrI019069 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 23 Jun 2017 22:44:27 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.13.8/8.14.4) with ESMTP id v5NMiQHj029193 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 23 Jun 2017 22:44:26 GMT Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id v5NMiNxA020592 for ; Fri, 23 Jun 2017 22:44:25 GMT MIME-Version: 1.0 Message-ID: Date: Fri, 23 Jun 2017 15:44:21 -0700 (PDT) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.5; `dired-mark-unmarked-files' with non-nil UNFLAG-P X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6770.5000 (x86)] Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) AFAICT this could never have worked. 1. Prior to Emacs 24, the interactive spec was just "P", which could of course not work interactively. In Emacs 24 it was changed to read the REGEXP and use the prefix arg for UNFLAG-P. That "P" was an indication that the command never worked interactively and was probably ill-conceived for that. And that "P" remained from Emacs 20 (if not before) through 23. 2. There are no occurrences in the Elisp sources that use non-nil UNFLAG-P. 3. Non-nil UNFLAG-P does nothing, AFAICT. It _cannot_ do anything. Certainly it cannot unflag, which means change a deletion flag (`D') to a space char. Why? Because the replacement is applied only to lines that already have a space char (not a `D'). Its effect in that case is indeed to post a space char. But it does so only for lines that already have a space char! This is the call: (dired-mark-if (and (looking-at-p " ") ; <=3D=3D=3D Mark (with a SPC) only if already the= re! (let ((fn (dired-get-filename localp t))) (and fn (string-match-p regexp fn)))) msg) What to do? I suggest NOT trying to have any "unflag" behavior here. If it were fixed, so that it actually replaced `D' with ` ' when there is a prefix arg, I think that behavior would be confusing. IOW, better not to fix the implementation to fix an awful design. Mark-if-unmarked should not mean unflag sometimes. But if you really want to fix this so that it does what the doc says, that's OK by me. Something should be done about it, anyway. (BTW, the comment "uninteresting" is backward wrt the comment "not already marked". The files that are checked are those that are not already marked and are interesting, i.e, match.) In GNU Emacs 24.5.1 (i686-pc-mingw32) of 2015-04-11 on LEG570 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/usr --host=3Di686-pc-mingw32' From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 21 11:41:37 2019 Received: (at 27465) by debbugs.gnu.org; 21 Jul 2019 15:41:37 +0000 Received: from localhost ([127.0.0.1]:59338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpDxx-00037b-Dh for submit@debbugs.gnu.org; Sun, 21 Jul 2019 11:41:37 -0400 Received: from quimby.gnus.org ([80.91.231.51]:59904) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpDxv-00037R-SN for 27465@debbugs.gnu.org; Sun, 21 Jul 2019 11:41:36 -0400 Received: from [80.169.244.84] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpDxs-0005JJ-AS; Sun, 21 Jul 2019 17:41:34 +0200 From: Lars Ingebrigtsen To: Drew Adams Subject: Re: bug#27465: 24.5; `dired-mark-unmarked-files' with non-nil UNFLAG-P References: Date: Sun, 21 Jul 2019 17:41:31 +0200 In-Reply-To: (Drew Adams's message of "Fri, 23 Jun 2017 15:44:21 -0700 (PDT)") Message-ID: <87r26j4cpg.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Drew Adams writes: > 3. Non-nil UNFLAG-P does nothing, AFAICT. It _cannot_ do anything. > Certainly it cannot unflag, which means change a deletion flag (`D') > to a space char. Why? Because the replacement is applied o [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 27465 Cc: 27465@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Drew Adams writes: > 3. Non-nil UNFLAG-P does nothing, AFAICT. It _cannot_ do anything. > Certainly it cannot unflag, which means change a deletion flag (`D') > to a space char. Why? Because the replacement is applied only to > lines that already have a space char (not a `D'). > > Its effect in that case is indeed to post a space char. But it does > so only for lines that already have a space char! > > This is the call: > > (dired-mark-if > (and > (looking-at-p " ") ; <=== Mark (with a SPC) only if already there! > (let ((fn (dired-get-filename localp t))) > (and fn (string-match-p regexp fn)))) > msg) I've now made unflag-p work on the Emacs trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 21 11:41:43 2019 Received: (at control) by debbugs.gnu.org; 21 Jul 2019 15:41:43 +0000 Received: from localhost ([127.0.0.1]:59341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpDy2-00037t-Md for submit@debbugs.gnu.org; Sun, 21 Jul 2019 11:41:42 -0400 Received: from quimby.gnus.org ([80.91.231.51]:59924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hpDy1-00037l-1f for control@debbugs.gnu.org; Sun, 21 Jul 2019 11:41:41 -0400 Received: from [80.169.244.84] (helo=sandy) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1hpDxy-0005Jd-Cc for control@debbugs.gnu.org; Sun, 21 Jul 2019 17:41:40 +0200 Date: Sun, 21 Jul 2019 17:41:37 +0200 Message-Id: <87pnm34cpa.fsf@mouse.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #27465 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 27465 fixed close 27465 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 27465 fixed close 27465 27.1 quit From unknown Mon Aug 18 11:25:38 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 19 Aug 2019 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator