Subject: Re: [bug#27464] [PATCH] gnu: Add ht.

From: Tobias Geerinckx-Rice <[email-masked]>
Date: Sat, 24 Jun 2017 16:16:21 +0200

On 23/06/17 18:16, Gábor Boskovits wrote:
>     * gnu/packages/hexedit.scm (ht): New variable.
> ---
>  gnu/packages/hexedit.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/gnu/packages/hexedit.scm b/gnu/packages/hexedit.scm
> index d2aaec306..7fc5a20ff 100644
> --- a/gnu/packages/hexedit.scm
> +++ b/gnu/packages/hexedit.scm
> @@ -1,5 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2016 Kei Kebreau <[email-masked]>
> +;;; Copyright © 2017 Gábor Boskovits <[email-masked]>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -44,3 +45,23 @@ file can be a device as the file is read a piece at a time.  You can modify
>  the file and search through it.")
>      (home-page "http://rigaux.org/hexedit.html")
>      (license license:gpl2+)))
> +
> +(define-public ht
> +  (package
> +    (name "ht")
> +    (version "2.1.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://sourceforge.net/projects/hte/files/ht-source/"

I'd re-format this to wrap at <= 80 characters. I'm old.

> +                                  name "-" version ".tar.bz2"))
> +              (sha256
> +                (base32
> +                  "0w2xnw3z9ws9qrdpb80q55h6ynhh3aziixcfn45x91bzrbifix9i"))))

The two lines above should be indented with a single space:

  (sha256
   (base32
    ("0foobar..."

In a properly configured™ Emacs editor, hitting C-M-q at the start of
the package expression will do the Right Thing.

> +    (build-system gnu-build-system)
> +    (inputs `(("ncurses",ncurses)))

Missing space before ,ncurses. Does this compile? If so, cool.

(It does!)

> +    (synopsis "The HT Editor: A file editor/viewer/analyzer for executables")

In the spirit of section 6.7.4 of the Guix manual, I'd shorten this to

   (synopsis "Editor, viewer, and analyzer for executable files")

> +    (description "This program is a file viewer, editor and analyzer for text, binary,
> +and (especially) executable files.")

s/This program/ht/

> +    (home-page "http://hte.sourceforge.net/")
> +    (license license:gpl2)))
> +

Spurious newline:

  $ git am ~/this
  Applying: gnu: Add ht.
  .git/rebase-apply/patch:39: new blank line at EOF.
  warning: 1 line adds whitespace errors.

All in all trivial things! I'll leave a day or so for other reviewers.
You can submit a new patch if you like, or I can make the changes myself
when I push.

Kind regards,

T G-R