GNU bug report logs - #27464
[PATCH] gnu: Add ht.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27464 in the body.
You can then email your comments to 27464 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Gábor Boskovits <boskovits <at> gmail.com>
Subject: [PATCH] gnu: Add ht.
Date: Fri, 23 Jun 2017 18:16:12 +0200

    * gnu/packages/hexedit.scm (ht): New variable.
---
 gnu/packages/hexedit.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/hexedit.scm b/gnu/packages/hexedit.scm
index d2aaec306..7fc5a20ff 100644
--- a/gnu/packages/hexedit.scm
+++ b/gnu/packages/hexedit.scm
@@ -1,5 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2016 Kei Kebreau <kei <at> openmailbox.org>
+;;; Copyright © 2017 Gábor Boskovits <boskovits <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -44,3 +45,23 @@ file can be a device as the file is read a piece at a time.  You can modify
 the file and search through it.")
     (home-page "http://rigaux.org/hexedit.html")
     (license license:gpl2+)))
+
+(define-public ht
+  (package
+    (name "ht")
+    (version "2.1.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://sourceforge.net/projects/hte/files/ht-source/"
+                                  name "-" version ".tar.bz2"))
+              (sha256
+                (base32
+                  "0w2xnw3z9ws9qrdpb80q55h6ynhh3aziixcfn45x91bzrbifix9i"))))
+    (build-system gnu-build-system)
+    (inputs `(("ncurses",ncurses)))
+    (synopsis "The HT Editor: A file editor/viewer/analyzer for executables")
+    (description "This program is a file viewer, editor and analyzer for text, binary,
+and (especially) executable files.")
+    (home-page "http://hte.sourceforge.net/")
+    (license license:gpl2)))
+
-- 
2.13.0

Message #8 received at 27464 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: 27464 <at> debbugs.gnu.org
Subject: miniLZO
Date: Sat, 24 Jun 2017 00:45:26 +0200

[Message part 1 (text/plain, inline)]

This software uses miniLZO. I guess it is ok to leave as is.

[Message part 2 (text/html, inline)]

Message #11 received at 27464 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: boskovits <at> gmail.com, 27464 <at> debbugs.gnu.org
Subject: Re: [bug#27464] miniLZO
Date: Sat, 24 Jun 2017 15:20:25 +0200

[Message part 1 (text/plain, inline)]

Hullo,

On 24/06/17 00:45, Gábor Boskovits wrote:
> This software uses miniLZO. I guess it is ok to leave as is.

miniLZO isn't a stand-alone library but a subset of LZO specifically
meant to be bundled with other software. It's also GPL2+, so it should
be fine.

...unless you had a specific objection in mind?

Kind regards,

T G-R

[signature.asc (application/pgp-signature, attachment)]

Message #14 received at 27464 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: boskovits <at> gmail.com, 27464 <at> debbugs.gnu.org
Subject: Re: [bug#27464] [PATCH] gnu: Add ht.
Date: Sat, 24 Jun 2017 16:16:21 +0200

[Message part 1 (text/plain, inline)]

On 23/06/17 18:16, Gábor Boskovits wrote:
>     * gnu/packages/hexedit.scm (ht): New variable.
> ---
>  gnu/packages/hexedit.scm | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/gnu/packages/hexedit.scm b/gnu/packages/hexedit.scm
> index d2aaec306..7fc5a20ff 100644
> --- a/gnu/packages/hexedit.scm
> +++ b/gnu/packages/hexedit.scm
> @@ -1,5 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2016 Kei Kebreau <kei <at> openmailbox.org>
> +;;; Copyright © 2017 Gábor Boskovits <boskovits <at> gmail.com>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -44,3 +45,23 @@ file can be a device as the file is read a piece at a time.  You can modify
>  the file and search through it.")
>      (home-page "http://rigaux.org/hexedit.html")
>      (license license:gpl2+)))
> +
> +(define-public ht
> +  (package
> +    (name "ht")
> +    (version "2.1.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://sourceforge.net/projects/hte/files/ht-source/"

I'd re-format this to wrap at <= 80 characters. I'm old.

> +                                  name "-" version ".tar.bz2"))
> +              (sha256
> +                (base32
> +                  "0w2xnw3z9ws9qrdpb80q55h6ynhh3aziixcfn45x91bzrbifix9i"))))

The two lines above should be indented with a single space:

  (sha256
   (base32
    ("0foobar..."

In a properly configured™ Emacs editor, hitting C-M-q at the start of
the package expression will do the Right Thing.

> +    (build-system gnu-build-system)
> +    (inputs `(("ncurses",ncurses)))

Missing space before ,ncurses. Does this compile? If so, cool.

(It does!)

> +    (synopsis "The HT Editor: A file editor/viewer/analyzer for executables")

In the spirit of section 6.7.4 of the Guix manual, I'd shorten this to

   (synopsis "Editor, viewer, and analyzer for executable files")

> +    (description "This program is a file viewer, editor and analyzer for text, binary,
> +and (especially) executable files.")

s/This program/ht/

> +    (home-page "http://hte.sourceforge.net/")
> +    (license license:gpl2)))
> +

Spurious newline:

  $ git am ~/this
  Applying: gnu: Add ht.
  .git/rebase-apply/patch:39: new blank line at EOF.
  warning: 1 line adds whitespace errors.

All in all trivial things! I'll leave a day or so for other reviewers.
You can submit a new patch if you like, or I can make the changes myself
when I push.

Kind regards,

T G-R

[signature.asc (application/pgp-signature, attachment)]

Message #17 received at 27464 <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: boskovits <at> gmail.com, 27464 <at> debbugs.gnu.org
Subject: Re: [bug#27464] miniLZO
Date: Sat, 24 Jun 2017 17:05:50 +0200

[Message part 1 (text/plain, inline)]

[Re-CCing the bug]

On 24/06/17 15:20, Gábor Boskovits wrote:
> Ok, thanks. That is also what I thought. Then this patch is fine by me.
>
> 2017. jún. 24. 15:18 ezt írta ("Tobias Geerinckx-Rice" <me <at> tobias.gr
> <mailto:me <at> tobias.gr>>):
>
>     miniLZO isn't a stand-alone library but a subset of LZO specifically
>     meant to be bundled with other software. It's also GPL2+, so it should
>     be fine.

So configure.ac also allows linking to the full library, instead of
inlining the mini version. I guess I wasn't expecting that level of
flexibility.

In that case, I think we should use our ‘lzo’ package instead. Adding it
as an input seems to suffice, no configure flags necessary. Sorry to
change my mind on you! :-)

Kind regards,

T G-R

[signature.asc (application/pgp-signature, attachment)]

Message #22 received at 27464-done <at> debbugs.gnu.org (full text, mbox):

From: Tobias Geerinckx-Rice <me <at> tobias.gr>
To: boskovits <at> gmail.com, 27464-done <at> debbugs.gnu.org
Subject: Re: [bug#27464] [PATCH] gnu: Add ht.
Date: Mon, 26 Jun 2017 16:41:38 +0200

[Message part 1 (text/plain, inline)]

On 23/06/17 18:16, Gábor Boskovits wrote:
> * gnu/packages/hexedit.scm (ht): New variable.

Pushed as 24b91ebd2e78a103aee128e5e089b6d6bf339fd9.

Thanks!

T G-R

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.